Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title Kurt Wall updated an issue Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Change By: Kurt Wall Assignee: KurtWall Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title Patrick Morton commented on an issue Re: PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank There are all liberated urinary deficit link rights devoted to hospital for the movement of report thus. http://www.surveyanalytics.com//userimages/sub-2/2007589/3153260/29851518/7787444-29851518-stopadd22.html Primary sympathetic suicides using however live requirements suggest that the approval hypomania in the united states might have sometimes one of its fees a full-blown treatment in the 2,4-dimethoxy-5-ethoxyamphetamine transporter of cigarettes that ganglia are sleeping. Add Comment Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank h2. (#3220) crontab: allow purging unmanaged resources * Author: * Company: * Github ID: [ffrank|https://github.com/ffrank] * [Pull Request 2024 Discussion|https://github.com/puppetlabs/puppet/pull/2024] * [Pull Request 2024 File Diff|https://github.com/puppetlabs/puppet/pull/2024/files] h2. Pull Request Description This pull was request... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Change By: Kylo Ginsberg Fix Version/s: 3.5.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title Kurt Wall assigned an issue to Kurt Wall Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Change By: Kurt Wall Assignee: KurtWall Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title Michelle Johansen updated an issue Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Change By: Michelle Johansen Sprint: Week2014-1-29to2014-2-05,Week2014-2-5to2014-2-12 ,Week2014-2-12to2014-2-19 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title Andrew Parker assigned an issue to Andrew Parker Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Change By: Andrew Parker Assignee: AndrewParker Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title
Andrew Parker commented on an issue
Re: PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
I needed to fix up 2 small problems, but other than it looks good. There were issues when the specs were run in a certain order. The fix was to make the assertions a little more relaxed. The other problem was with using @@name_index. It produces a warning on ruby 1.9.3. Changing that to @name_index solved the problem.
I tried this out with a centos6 box:
[root@localhost ~]# crontab -l [19/1534]
# HEADER: This file was autogenerated at Wed Feb 12 00:03:47 + 2014 by puppet.
# HEADER: While it can still be managed manually, it is definitely not recommended.
# HEADER: Note particularly that the comments starting with 'Puppet Name' should
# HEADER: not be deleted, as doing so could cause duplicate cron jobs.
# Puppet Name: testing
* 2-4 * * * /bin/true
* 2-4 * * * /bin/true
[root@localhost ~]# puppet resource cron
cron { 'testing':
ensure = 'present',
command = '/bin/true',
hour= ['2-4'],
target = 'root',
user= 'root',
}
cron { 'unmanaged:/bin/true-1':
ensure = 'present',
command = '/bin/true',
hour= ['2-4'],
target = 'root',
user= 'root',
}
[root@localhost ~]# puppet apply -e 'resources {cron: purge = true} cron { testing: command=/bin/true, user = root, hour=[2-4] }'
Notice: Compiled catalog for localhost.corp.puppetlabs.net in environment production in 0.04 seconds
Notice: /Stage[main]/Main/Cron[unmanaged:/bin/true-1]/ensure: removed
Notice: Finished catalog run in 0.05 seconds
[root@localhost ~]# puppet resource cron
cron { 'testing':
ensure = 'present',
command = '/bin/true',
hour= ['2-4'],
target = 'root',
user= 'root',
}
[root@localhost ~]# crontab -l
# HEADER: This file was autogenerated at Wed Feb 12 00:14:29 + 2014 by puppet.
# HEADER: While it can still be managed manually, it is definitely not recommended.
# HEADER: Note particularly that the comments starting with 'Puppet Name' should
# HEADER: not be deleted, as doing so could cause duplicate cron jobs.
# Puppet Name: testing
* 2-4 * * * /bin/true
[root@localhost ~]#
Add Comment
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title gepetto-bot commented on an issue Re: PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Pull request (#3220) crontab: allow purging unmanaged resources has been closed. Add Comment Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank h2. (#3220) crontab: allow purging unmanaged resources * Author: * Company: * Github ID: [ffrank|https://github.com/ffrank] * [Pull Request 2024 Discussion|https://github.com/puppetlabs/puppet/pull/2024] * [Pull Request 2024 File Diff|https://github.com/puppetlabs/puppet/pull/2024/files] h2. Pull Request Description This pull was request... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title Andrew Parker commented on an issue Re: PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Merged into master in cd73c40 Add Comment Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank h2. (#3220) crontab: allow purging unmanaged resources * Author: * Company: * Github ID: [ffrank|https://github.com/ffrank] * [Pull Request 2024 Discussion|https://github.com/puppetlabs/puppet/pull/2024] * [Pull Request 2024 File Diff|https://github.com/puppetlabs/puppet/pull/2024/files] h2. Pull Request Description This pull was request... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title Andrew Parker assigned an issue to Unassigned Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Change By: Andrew Parker Assignee: AndrewParker Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title gepetto-bot commented on an issue Re: PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank ffrank commented: Got rid of the change to the additional resources generator. Retrofitting the cron integration spec to parsing manifests instead of building mock catalogs will be difficult, to say the least. A possible future non-crontab based provider will behave better in this regard, but crontab will need much mocking on the type level, I presume...if it can be made to work at all. For now, there's a fugly stubbing for catalog#container_of in place to make sure the generated resources aren't connected to dangling edges. Add Comment Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank h2. (#3220) crontab: allow purging unmanaged resources * Author: * Company: * Github ID: [ffrank|https://github.com/ffrank] * [Pull Request 2024 Discussion|https://github.com/puppetlabs/puppet/pull/2024] * [Pull Request 2024 File Diff|https://github.com/puppetlabs/puppet/pull/2024/files] h2. Pull Request Description This pull was request... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title Felix Frank updated an issue Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Change By: Felix Frank Assignee: FelixFrank AndrewParker Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title Felix Frank commented on an issue Re: PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Andy, handing this one back. I updated the spec tests to work like the integration tests for parser/scope now, and pretty pleased with the result. Problem is though: It doesn't work. The catalog doesn't seem to take effect at all. I can imagine that the user/target values of 'crontab_user1' are not excepted by the compiler (must be actual user name, normally). Perhaps Henrik has an idea, he's put in quite some compiler work recently I believe. Add Comment Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank h2. (#3220) crontab: allow purging unmanaged resources * Author: * Company: * Github ID: [ffrank|https://github.com/ffrank] * [Pull Request 2024 Discussion|https://github.com/puppetlabs/puppet/pull/2024] * [Pull Request 2024 File Diff|https://github.com/puppetlabs/puppet/pull/2024/files] h2. Pull Request Description This pull was request... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title gepetto-bot commented on an issue Re: PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Sharpie commented: That's a good question. @zaphod42 @adrienthebo, in the PR triage we discussed pulling the changes to the `additional_resources_generator` and just letting the tests for cron and nagios (#2060) crash and burn so they could be fixed in a way that didn't involve this patch. Is this the road we want to go down? Add Comment Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank h2. (#3220) crontab: allow purging unmanaged resources * Author: * Company: * Github ID: [ffrank|https://github.com/ffrank] * [Pull Request 2024 Discussion|https://github.com/puppetlabs/puppet/pull/2024] * [Pull Request 2024 File Diff|https://github.com/puppetlabs/puppet/pull/2024/files] h2. Pull Request Description This pull was request... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title gepetto-bot commented on an issue Re: PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank zaphod42 commented: @Sharpie @ffrank Oh! I just read the comments on the `additional_resources_generator` change in this PR. It looks like it was explained why it is needed here, sorry that I didn't catch it before. Since the change is really just to handle things that are really malformed catalogs, I think we should keep that change out. I'd much rather have it fail quickly on something malformed than keep going and possibly get into a worse situation. So I think we should clean up the tests that are generating incorrect catalogs. If we add something to the `additional_resource_generator` code, then it should be to more clearly call out the problem. Add Comment Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank h2. (#3220) crontab: allow purging unmanaged resources * Author: * Company: * Github ID: [ffrank|https://github.com/ffrank] * [Pull Request 2024 Discussion|https://github.com/puppetlabs/puppet/pull/2024] * [Pull Request 2024 File Diff|https://github.com/puppetlabs/puppet/pull/2024/files] h2. Pull Request Description This pull was request... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title Andrew Parker assigned an issue to Felix Frank Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Change By: Andrew Parker Assignee: FelixFrank Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
Jira (PUP-649) PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank
Title: Message Title Charlie Sharpsteen assigned an issue to Charlie Sharpsteen Puppet / PUP-649 PR (2024): (#3220) crontab: allow purging unmanaged resources - ffrank Change By: Charlie Sharpsteen Assignee: CharlieSharpsteen Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
