Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2015-12-08 Thread Eric Thompson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Thompson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-659 
 
 
 
  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 

Change By:
 
 Eric Thompson 
 
 
 

QA Status:
 
 Reviewed 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-22 Thread Kurt Wall (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kurt Wall assigned an issue to Kurt Wall 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-659 
 
 
 
  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 

Change By:
 
 Kurt Wall 
 
 
 

Assignee:
 
 KurtWall 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-22 Thread Kurt Wall (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kurt Wall commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
Verified in master at SHA=71d2c55. Using the attached demo module, I saw no significant difference between compilation times using qualified and unqualified variables. 
 
 
 
 
 
 
# time puppet master --compile goodnode 21 | grep 'Compiled catalog for' 
 
 
 
 
Notice: Compiled catalog for goodnode in environment production in 0.35 seconds 
 
 
 
 
 
 
 
 
 
real	0m1.121s 
 
 
 
 
user	0m1.004s 
 
 
 
 
sys	0m0.087s 
 
 
 
 
# time puppet master --compile badnode 21 | grep 'Compiled catalog for' 
 
 
 
 
Notice: Compiled catalog for badnode in environment production in 0.35 seconds 
 
 
 
 
 
 
 
 
 
real	0m1.149s 
 

Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-22 Thread Kurt Wall (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kurt Wall assigned an issue to Unassigned 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-659 
 
 
 
  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 

Change By:
 
 Kurt Wall 
 
 
 

Assignee:
 
 KurtWall 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-19 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
Commit ed3bbd487 passed CI moving to FR 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-19 Thread Eric Sorenson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Sorenson updated an issue 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-659 
 
 
 
  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 

Change By:
 
 Eric Sorenson 
 
 
 

Summary:
 
 s QualifiedvariablelookupsareveryslowunderPuppet2.7+unlessprefixedwith:: 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-15 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney assigned an issue to Hailee Kenney 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-659 
 
 
 
  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 

Change By:
 
 Hailee Kenney 
 
 
 

Assignee:
 
 HaileeKenney 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-15 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
I've opened a pull request to revert the revert: https://github.com/puppetlabs/puppet/pull/3414 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-15 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
Merged to master https://github.com/puppetlabs/puppet/commit/9129051acb1b069233cda6f6ee1ef6d315660691 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-13 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
The test ticket_4293_define_and_use_a_define_in_a_class is wrong - we no longer search the local name space. 
 
 
 
 
 
 
class foo { 
 
 
 
 
  define do_notify($msg) { 
 
 
 
 
notify { Message for $name: $msg: } 
 
 
 
 
  } 
 
 
 
 
  do_notify { test_one: msg = a_message_for_you } 
 
 
 
 
} 
 
 
 
 
include foo
 
 
 
 
 
 
 
Should be written: 
 
 
 
 
 
 
class foo { 
 
 
 
 
  define do_notify($msg) { 
 
 
  

Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-13 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
The other failing test has exactly the same problem (lines 66-74): 
 
 
 
 
 
 
class ntp { 
 
 
 
 
  $ntpservers = hiera_array(ntpservers) 
 
 
 
 
 
 
 
 
 
  define print { 
 
 
 
 
$server = $name 
 
 
 
 
notify { ntpserver ${server}: } 
 
 
 
 
  } 
 
 
 
 
 
 
 
 
 
  print { $ntpservers: }
 
 
 
 
 
 
 
And should be written like this: 
 
 
 
 
 
  

Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-13 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
Please reapply the PR, and fix the tests. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-12 Thread Kylo Ginsberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kylo Ginsberg commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
I believe this merge is failing two acceptance tests: https://jenkins.puppetlabs.com/view/Puppet/view/Master/job/Puppet-Package-Acceptance-master/296/ 
 

tests.ticket_4293_define_and_use_a_define_within_a_class.rb
 

tests/parser_functions/hiera_array.lookup_data.rb
 
 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-12 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
So I've been investigating the acceptance failures. The manifest in the first acceptance test failure (ticket_4293_define...) is failing with this error: 
 
 
 
 
 
 
Error: Evaluation Error: Error while evaluating a Resource Statement, Invalid resource type do_notify at /Users/HAIL9000/Projects/puppet/test.pp:5:3 on node hailees-macbook-pro.local 
 
 
 
 
Error: Evaluation Error: Error while evaluating a Resource Statement, Invalid resource type do_notify at /Users/HAIL9000/Projects/puppet/test.pp:5:3 on node hailees-macbook-pro.local 
 
 
 
 
 
 
The error is coming from this portion of the initialized in `lib/puppet/resource.rb`: 
 
 
 
 
 
 
 if self.class? 
 
 
 
 
raise ArgumentError, Could not find declared class #{title} 
 
 
 
 
  else 
 
 
 
 
raise ArgumentError, Invalid resource type #{type} 
 
 
 
 
  end  
 
 
 
 
 
 
  

Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-12 Thread Brian Cain (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Brian Cain commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
Reverted in https://github.com/puppetlabs/puppet/commit/db0cfa48a477d5f6a54847b565912dc5561852f1 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-12 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
After talking to Kylo Ginsberg I'm going to go ahead and revert this until Henrik Lindberg can take a look at it. It's not immediately clear if the issue mentioned in the above comment is actually the intended behavior (and the acceptance tests need to be fix) or if it is a bug (and the implementation needs to be fixed). Either way, it's not clear to me what needs to change so we'll revert it for now so that we can get CI green again. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-08 Thread Brian Cain (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Brian Cain assigned an issue to Brian Cain 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-659 
 
 
 
  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 

Change By:
 
 Brian Cain 
 
 
 

Assignee:
 
 BrianCain 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-08 Thread Brian Cain (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Brian Cain commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
Merged to master at 87fad92f18966ea62544df16d251885794c5ec92 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-12-01 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-659 
 
 
 
  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Sprint:
 
 PlatformServer2014-12-24 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-11-30 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg assigned an issue to Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-659 
 
 
 
  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Assignee:
 
 HenrikLindberg 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-11-30 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
When doing the real implementation, I ended up with aprox 8.5s for both the good and the bad scenarios. After tweaking code on this path (removing other junk, and optimizing calls to Puppet.debug) I got down to 8.10 s. 
I think that serves the purpose of this ticket; to make references to '::name::foo::bar' and 'name::foo::bar' have the same (and better performance). 
To tweak this more, the exampel should be rewriten as a benchmark, and changed to a small size to allow it to be profiled with a profiler (in reasonable time). This is left for the future, mainly because the involved code (loaders, and scope) will be rewritten and the tests above are easy enough to run manually for the time being. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-11-30 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-659 
 
 
 
  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
Changing story points to 2 as this was easier than expected (if the results achieved so far are good enough - if not, add a bunch of story points because then it starts to get difficult). 
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Story Points:
 
 5 2 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-11-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
And the implementation is ... interesting - at the core of the dynamic scope mess, then all other functionality now works around. Going to attempt a spike to clean this up. Scope supports having multiple namespaces (we dropped the function that puts the nuclear weapon in the hands of users, but puppet itself still deals with this). Since we supported dynamic namespaces any non qualified name can be resolved to a fairly large number of namespaces - now that we stopped doing that (we prepend '::' in many operation to ensure that a name is always an absolute reference) - then it is no only wasteful, but really stupid to construct a long list of names, which is a copy of an array with a name in it, that we on each lookup process with `downcase`, `flatten`, `unique`, `avra kadavra` and few other spells... 
I could go on and on. This page describes the implementation pretty well: http://www.thesaurus.com/browse/nonsense 
I did a brutal removal of all the 'prattle' and then goodclass and badclass took the same time, around 8 seconds on my machine. Now going through that in more detail - looks like it is an echo chamber where a lot of functionality is only there to make tests happy. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-11-24 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-659 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::  
 
 
 
 
 
 
 
 
 
 
Since we have changed dynamic lookups to lexical for all variables, the search space is a lot smaller in 4.0. We have not measured the difference, and we have dropped support for Ruby 1.8.7. We should do a new measure at least. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-06-11 Thread Andy Parker (JIRA)
Title: Message Title










 

 Andy Parker commented on an issue


















  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with :: 










I'm tying this to PUP-494 so that we take a look at it and see if we can, if not eliminate this, at least reduce the problem.












   

 Add Comment

























 Puppet /  PUP-659



  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with :: 







 This ticket concerns a performance regression that occurs when variable lookups are qualified as suggested by the [language documentation|http://docs.puppetlabs.com/puppet/3/reference/lang_variables.html#naming]:   {quote}  Qualified variable names are prefixed with the name of their scope and the `::` (double colon) namespace separator. (For example, th...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, 

Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-06-10 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper updated an issue


















 Puppet /  PUP-659



  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with :: 










Change By:

 Josh Cooper




Component/s:

 Server












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-06-10 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper updated an issue


















 Puppet /  PUP-659



  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with :: 










Change By:

 Josh Cooper




Component/s:

 DSL












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2014-02-16 Thread Ashley Penney (JIRA)
Title: Message Title










 

 Ashley Penney commented on an issue


















  Re: Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with :: 










We think the qualified variable path is responsible for the puppetlabs-apache unit tests taking over 50 minutes on Ruby 1.8.7. Andy and I did some digging into the tests and it seems like it relates back to this. Just as a datapoint, this is actively damaging our ability to test one of the supported modules, apache, properly.












   

 Add Comment

























 Puppet /  PUP-659



  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with :: 







 This ticket concerns a performance regression that occurs when variable lookups are qualified as suggested by the [language documentation|http://docs.puppetlabs.com/puppet/3/reference/lang_variables.html#naming]:   {quote}  Qualified variable names are prefixed with the name of their scope and the `::` (double colon) namespace separator. (For example, th...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an 

Jira (PUP-659) Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with ::

2013-12-17 Thread Kenn Hussey (JIRA)
Title: Message Title










 

 Kenn Hussey updated an issue


















 Puppet /  PUP-659



  Qualified variable lookups are very slow under Puppet 2.7+ unless prefixed with :: 










Change By:

 Kenn Hussey




Labels:

 qe qa -reviewedredmine












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.