Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-6608 variable scoping change in Puppet 4.6.0 Change By: Kenn Hussey Labels: regression Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6608 variable scoping change in Puppet 4.6.0 Change By: Henrik Lindberg Release Notes Summary: A regression in evaluation of resource like class inclusion caused evaluation of the class to be lazy as opposed to the correct immediate evaluation. This in turn led to problems with missing variables which in turn could lead to other problems. The order of evaluation is now restored. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title John Duarte commented on PUP-6608 Re: variable scoping change in Puppet 4.6.0 Henrik Lindberg can we get a release note on this one? Thanks. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Sofer Athlan-Guyot commented on PUP-6608 Re: variable scoping change in Puppet 4.6.0 Thanks for the update Henrik. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Henrik Lindberg commented on PUP-6608 Re: variable scoping change in Puppet 4.6.0 Sofer Athlan-Guyot this is targeted at 4.6.1 which will be released as soon as possible (there are some other issues that are major/critical as well, and they all need to go through QA - which is being done now). Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Emilien Macchi commented on PUP-6608 Re: variable scoping change in Puppet 4.6.0 Big +1 with Sofer, Puppet 4.6.0 release is currently breaking Puppet OpenStack upstream CI (unit and functional testing jobs). Thanks. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Sofer Athlan-Guyot commented on PUP-6608 Re: variable scoping change in Puppet 4.6.0 Hi, could a release be done quickly for this one. It's really break a lot of things. Regards, Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Phong Ly commented on PUP-6608 Re: variable scoping change in Puppet 4.6.0 Bug fixed, tested with puppet-agent at SHA 092d3dc7 Tested with --strict_variables root@nkwd9ocoq7a3lh8:~# puppet apply --strict_variables test_with-strict_variables.pp Warning: Could not retrieve fact ipaddress Notice: Compiled catalog for nkwd9ocoq7a3lh8.delivery.puppetlabs.net in environment production in 0.08 seconds Notice: goodbye Notice: /Stage[main]/Main/Notify[goodbye]/message: defined 'message' as 'goodbye' Notice: Applied catalog in 0.03 seconds root@nkwd9ocoq7a3lh8:~# root@nkwd9ocoq7a3lh8:~# cat test_with-strict_variables.pp
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Phong Ly updated an issue Puppet / PUP-6608 variable scoping change in Puppet 4.6.0 Change By: Phong Ly QA Risk Assessment: High QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Phong Ly assigned an issue to Phong Ly Puppet / PUP-6608 variable scoping change in Puppet 4.6.0 Change By: Phong Ly Assignee: qa Phong Ly Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title John Duarte assigned an issue to qa Puppet / PUP-6608 variable scoping change in Puppet 4.6.0 Change By: John Duarte Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Henrik Lindberg commented on PUP-6608 Re: variable scoping change in Puppet 4.6.0 and merged to master Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Henrik Lindberg commented on PUP-6608 Re: variable scoping change in Puppet 4.6.0 merged to stable: 05a7ced Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Puppet / PUP-6608 variable scoping change in Puppet 4.6.0 Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6608 variable scoping change in Puppet 4.6.0 Ping Kylo Ginsberg David Kramer Change By: Henrik Lindberg Priority: Normal Critical Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title
Craig Dunn commented on PUP-6608
Re: variable scoping change in Puppet 4.6.0
+1 on this being critical
I also see the same behaviour without using strict_variables, it works with include, but a class declaration fails.
Craigs-MacBook-Pro:modules craigdunn$ puppet config print strict_variables
false
include testmodule
notify { "value ${testmodule::somevar}": }
Notice: /Stage[main]/Main/Notify[value bar]/message: defined 'message' as 'value bar'
class { 'testmodule': }
notify { "value ${testmodule::somevar}": }
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title R.I.Pienaar commented on PUP-6608 Re: variable scoping change in Puppet 4.6.0 This seems to be a critical bug to me, the priority doesn't seem right. We've had a few people on irc/slack bitten by this. Perhaps some mail must go out to announce list warning people off upgrading or something like that? Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Henrik Lindberg commented on PUP-6608 Re: variable scoping change in Puppet 4.6.0 I suspect that an evaluation of the class is missing - and that the include enforces that evaluation with the given parameters. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6608 variable scoping change in Puppet 4.6.0 Change By: Henrik Lindberg Story Points: 1 Sprint: Language 2016-08-24 Scrum Team: Language Fix Version/s: PUP 4.6.1 Component/s: Puppet Server Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, sen
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-6608
variable scoping change in Puppet 4.6.0
Change By:
Henrik Lindberg
Variables defined in a class are not in scope after resource-like declaration of that class: {code} $ cat test.pp class a($myvar = 'hello') {}class { 'a': myvar => 'goodbye' }notify { $a::myvar: }$ puppet --version4.5.3$ puppet apply --strict_variables test.pp Notice: Compiled catalog for kvm-01.node.vagrant.consul in environment production in 0.03 secondsNotice: goodbyeNotice: /Stage[main]/Main/Notify[goodbye]/message: defined 'message' as 'goodbye'Notice: Applied catalog in 0.02 seconds$ puppet --version4.6.0$ puppet apply --strict_variables test.pp Error: Evaluation Error: Unknown variable: 'a::myvar'. at /home/vagrant/test.pp:3:10 on node kvm-01.node.vagrant.consul {code} Without strict_variables it could be very dangerous. Note that if you add an include, it works: {code} $ cat test.pp class a($myvar = 'hello') {}class { 'a': myvar => 'goodbye' }include anotify { $a::myvar: } $ puppet --version4.6.0$ puppet apply --strict_variables test.pp Notice: Compiled catalog for kvm-01.node.vagrant.consul in environment production in 0.09 secondsNotice: goodbyeNotice: /Stage[main]/Main/Notify[goodbye]/message: defined 'message' as 'goodbye'Notice: Applied catalog in 0.02 seconds {code}
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email
Jira (PUP-6608) variable scoping change in Puppet 4.6.0
Title: Message Title
Mark Mickan created an issue
Puppet / PUP-6608
variable scoping change in Puppet 4.6.0
Issue Type:
Bug
Affects Versions:
PUP 4.6.0
Assignee:
Unassigned
Components:
Puppet Server
Created:
2016/08/11 3:30 PM
Priority:
Normal
Reporter:
Mark Mickan
Variables defined in a class are not in scope after resource-like declaration of that class:
$ cat test.pp class a($myvar = 'hello') {} class { 'a': myvar => 'goodbye' }
notify { $a::myvar: }
$ puppet --version 4.5.3 $ puppet apply --strict_variables test.pp Notice: Compiled catalog for kvm-01.node.vagrant.consul in environment production in 0.03 seconds Notice: goodbye Notice: /Stage[main]/Main/Notify[goodbye]/message: defined 'message' as 'goodbye' Notice: Applied catalog in 0.02 seconds
$ puppet --version 4.6.0 $ puppet apply --strict_variables test.pp Error: Evaluation Error: Unknown variable: 'a::myvar'. at /home/vagrant/test.pp:3:10 on node kvm-01.node.vagrant.consul
Without strict_variables it could be very dangerous. Note that if you add an include, it works:
$ cat test.pp class a($myvar = 'hello') {
