Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-24 Thread Kenn Hussey (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kenn Hussey updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6622 
 
 
 
  Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 

Change By:
 
 Kenn Hussey 
 
 
 

Labels:
 
 regression 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-19 Thread John Duarte (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 John Duarte assigned an issue to Unassigned 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6622 
 
 
 
  Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 

Change By:
 
 John Duarte 
 
 
 

Assignee:
 
 Ethan Brown 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-19 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6622 
 
 
 
  Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Release Notes Summary:
 
 Function loading and calling was hit by a performance regression that caused a 300% degradation in performance as observed by benchmarks. This is now fixed. 
 
 
 

Release Notes:
 
 Bug Fix 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-19 Thread John Duarte (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 John Duarte assigned an issue to Ethan Brown 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6622 
 
 
 
  Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 

Change By:
 
 John Duarte 
 
 
 

Assignee:
 
 Ethan Brown 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-19 Thread John Duarte (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 John Duarte commented on  PUP-6622 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 
 
Ethan Brown or Henrik Lindberg do we want a release note for this fix? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-19 Thread John Duarte (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 John Duarte assigned an issue to qa 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6622 
 
 
 
  Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 

Change By:
 
 John Duarte 
 
 
 

Status:
 
 Ready for  CI  Test 
 
 
 

Assignee:
 
 Henrik Lindberg qa 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-17 Thread Phong Ly (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Phong Ly updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6622 
 
 
 
  Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 

Change By:
 
 Phong Ly 
 
 
 

QA Risk Assessment:
 
 Low 
 
 
 

QA Status:
 
 Reviewed 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-17 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-6622 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 
 
Merged to stable at: 27c4201 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-17 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-6622 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 
 
Ethan Brown's test showed a change from 100 to over 300 (300%). With the work Thomas Hallgren did on this ticket, the corresponding diff is from 55 to 65 (20%). It is inevitable that some performance is lost as there is additional functionality involved in 4.6.0 that the tests brutally hammer. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-17 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg assigned an issue to Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6622 
 
 
 
  Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Assignee:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-17 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6622 
 
 
 
  Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 

Change By:
 
 Thomas Hallgren 
 
 
 

Story Points:
 
 1 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-17 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6622 
 
 
 
  Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 

Change By:
 
 Thomas Hallgren 
 
 
 

Sprint:
 
 Language 2016-08-24 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-17 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren assigned an issue to Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6622 
 
 
 
  Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 

Change By:
 
 Thomas Hallgren 
 
 
 

Assignee:
 
 Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-16 Thread Ethan Brown (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ethan Brown updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6622 
 
 
 
  Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 

Change By:
 
 Ethan Brown 
 
 
 

Scrum Team:
 
 Language 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-16 Thread Ethan Brown (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ethan Brown updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6622 
 
 
 
  Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 

Change By:
 
 Ethan Brown 
 
 
 
 
 
 
 
 
 
 On Windows 2008R2 / Ruby 2.1, commit https://github.com/puppetlabs/puppet/commit/01db61e24178a3baebbeaa1c58250fcbf447d8bc introduced a 10x performance degredation for the {{benchmark:function_loading}} micro-benchmark in the Puppet suite.  I used git bisect to identify that particular commit.h3. For {{2211c64}} (parent of {{01db61e}}){code}C:\source\puppet [(2211c64...) +68 ~0 -0 !]> bundle exec rake benchmark:function_loadingDocument generation not available without yard. cannot load such file -- yardmkdir -p C:/Users/ADMINI~1/AppData/Local/Temp/function_loading20160816-3900-13bswjgDL is deprecated, please use Fiddle user system  totalrealRun 1   10.296000   2.125000  12.421000 ( 13.608853)Run 26.766000   1.031000   7.797000 (  8.749664)Run 38.078000   0.797000   8.875000 (  9.692987)Run 48.578000   0.891000   9.469000 ( 10.468348)Run 59.094000   0.844000   9.938000 ( 10.937080)Run 69.984000   0.844000  10.828000 ( 12.093286)Run 7   10.61   0.844000  11.454000 ( 12.629397)Run 8   12.109000   0.843000  12.952000 ( 13.953529)Run 9   12.25   1.032000  13.282000 ( 14.311859)Run 10  13.438000   0.828000  14.266000 ( 15.218068)> total:   101.203000  10.079000 111.282000 (121.663071)> avg:  10.120300   1.007900  11.128200 ( 12.166307){code}h3. For {{01db61e}}{code}C:\source\puppet [(01db61e...) +68 ~0 -0 !]> bundle exec rake benchmark:function_loadingDocument generation not available without yard. cannot load such file -- yardmkdir -p C:/Users/ADMINI~1/AppData/Local/Temp/function_loading20160816-49440-1miin4uDL is deprecated, please use Fiddle user system  totalrealRun 1  114.015000  14.797000 128.812000 (142.752140)Run 2  156.344000  14.547000 170.891000 (184.167353)Run 3  201.969000  13.188000 215.157000 (228.894914)Run 4  245.016000  12.828000 257.844000 (271.543842)Run 5  288.734000  13.312000 302.046000 (315.255168){code}NOTE: The above was terminated prematurely given the obvious trend of a further decrease of performance on each run.h3. Current stable HEAD ({{13d208b2e935151c6b8cf77e8bf4ad1b45fc72c5}}) as of 8/16/2016Some corrective efforts appear to have already been taken to address this performance problem (and it's compounding effect), but the current performance of latest code is still 3x slower than it was on versions of Puppet prior to {{4.6.0}}.{code}C:\source\puppet [stable...origin/stable +68 ~0 -0 !]> bundle exec rake benchmark:function_loadingDocument generation not available without yard. cannot load such file -- yardmkdir -p C:/Users/ADMINI~1/AppData/Local/Temp/function_loading20160816-10824-x58pt6DL is deprecated, please use Fiddle user system  totalrealRun 1   29.266000   5.266000  34.532000 ( 35.654881)Run 2   24.453000   3.969000  28.422000 ( 29.694252)Run 3   25.563000   3.89  29.453000 ( 30.420901)Run 4   26.453000   3.797000  30.25 ( 31.485412)Run 5   27.219000   3.563000  30.782000 ( 31.846841)Run 6   30.39   3.328000  33.718000 ( 34.311228)Run 7   

Jira (PUP-6622) Puppet function_loading benchmark performance degredation

2016-08-16 Thread Ethan Brown (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ethan Brown created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6622 
 
 
 
  Puppet function_loading benchmark performance degredation  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Affects Versions:
 

 PUP 4.6.0 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2016/08/16 1:44 PM 
 
 
 

Fix Versions:
 

 PUP 4.6.1 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Ethan Brown 
 
 
 
 
 
 
 
 
 
 
On Windows 2008R2 / Ruby 2.1, commit https://github.com/puppetlabs/puppet/commit/01db61e24178a3baebbeaa1c58250fcbf447d8bc introduced a 10x performance degredation for the benchmark:function_loading micro-benchmark in the Puppet suite. I used git bisect to identify that particular commit. 
For 2211c64 (parent of 01db61e) 
 
 
 
 
 
 
C:\source\puppet [(2211c64...) +68 ~0 -0 !]> bundle exec rake benchmark:function_loading