Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title Geoff Nichols commented on PUP-6628 Re: Corrective change should use property values directly, bypassing any munging Apologies, John Duarte, my update was completely unintentional. I'll (re)close this. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title John Duarte commented on PUP-6628 Re: Corrective change should use property values directly, bypassing any munging Geoff Nichols, you moved this ticket from 'closed' to 'needs information' yesterday. Can you comment on what the information or course of action you need? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title John Duarte updated an issue Puppet / PUP-6628 Corrective change should use property values directly, bypassing any munging Change By: John Duarte QA Risk Assessment: Medium Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title John Duarte updated an issue Puppet / PUP-6628 Corrective change should use property values directly, bypassing any munging Change By: John Duarte QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title John Duarte commented on PUP-6628 Re: Corrective change should use property values directly, bypassing any munging Validated using pre-release version of puppet-agent at SHA cd3af7c containing puppet at SHA 738a8d7 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title John Duarte assigned an issue to John Duarte Puppet / PUP-6628 Corrective change should use property values directly, bypassing any munging Change By: John Duarte Assignee: qa John Duarte Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title
Branan Riley updated an issue
Puppet / PUP-6628
Corrective change should use property values directly, bypassing any munging
Change By:
Branan Riley
Acceptance Criteria:
It should be possible to apply the two following manifests in sequence without Puppet apply failing with an error , and the report should indicate that it was NOT a corrective change, since the manifest has changed : {noformat}group { 'bar': ensure => present}user { 'foo': ensure => present, membership => inclusive, groups => ['bar']}{noformat}{noformat}group { 'bar': ensure => present}group { 'baz': ensure => present}user { 'foo': ensure => present, membership => inclusive, groups => ['bar', 'baz']}{noformat} {noformat} User[foo]: !ruby/object:Puppet::Resource::Statustitle: foofile: "/home/branan/proj/pl/puppet/test.pp"line: 9resource: User[foo]resource_type: Usercontainment_path:- Stage[main]- Main- User[foo]evaluation_time: 0.033121403tags:- user- foo- classtime: '2016-08-19T12:41:22.752345544-07:00'failed: falsechanged: trueout_of_sync: trueskipped: falsechange_count: 1out_of_sync_count: 1events:- !ruby/object:Puppet::Transaction::Event audited: false property: groups previous_value: - baz desired_value: bar,baz historical_value: message: groups changed 'baz' to ['bar', 'baz'] name: :groups_changed status: success time: 2016-08-19 12:41:22.752746299 -07:00 redacted: corrective_change: falsecorrective_change: false{noformat}
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title Branan Riley commented on PUP-6628 Re: Corrective change should use property values directly, bypassing any munging John Duarte Acceptance criteria added. It is essentially borrowed from the user report in PUP-6632 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title
Branan Riley updated an issue
Puppet / PUP-6628
Corrective change should use property values directly, bypassing any munging
Change By:
Branan Riley
Acceptance Criteria:
It should be possible to apply the two following manifests in sequence without Puppet apply failing with an error:{noformat}group { 'bar': ensure => present}user { 'foo': ensure => present, membership => inclusive, groups => ['bar']}{noformat}{noformat}group { 'bar': ensure => present}group { 'baz': ensure => present}user { 'foo': ensure => present, membership => inclusive, groups => ['bar', 'baz']}{noformat}
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title John Duarte commented on PUP-6628 Re: Corrective change should use property values directly, bypassing any munging Branan Riley, can you provide an acceptance criteria example for this? Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title John Duarte assigned an issue to qa Puppet / PUP-6628 Corrective change should use property values directly, bypassing any munging Change By: John Duarte Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title Branan Riley updated an issue Puppet / PUP-6628 Corrective change should use property values directly, bypassing any munging Change By: Branan Riley Release Notes Summary: Corrective change calculation is now more robust when properties have complex munge and validate methods Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title Branan Riley updated an issue Puppet / PUP-6628 Corrective change should use property values directly, bypassing any munging Change By: Branan Riley Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6628) Corrective change should use property values directly, bypassing any munging
Title: Message Title Branan Riley created an issue Puppet / PUP-6628 Corrective change should use property values directly, bypassing any munging Issue Type: Bug Affects Versions: PUP 4.6.0 Assignee: Branan Riley Created: 2016/08/17 11:23 AM Fix Versions: PUP 4.6.1 Priority: Normal Reporter: Branan Riley Currently, corrective change uses the "correct" should readers/writers for property values. Unfortunately, properties may have munge and unmunge implementations that are not symmetrical, and in some cases this can cause both should= and validate to fail for those types. If we update corrective_change to be a bit more aggressive when inspecting property values, we can avoid the entire munge/unmunge/validate dance, and simply inject data directly into the property in exactly the same form that we pull it out. This may causes issues if internal representations of data change between versions of properties, but corrective change reporting is already likely to be flaky in those cases.
