Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Moses Mendoza Release Notes Summary: Prior to Puppet 4.9.0, if a resource had a subscribing relationship with a recursive file resource, and puppet was run with --tags such that these resources were evaluated, the subscribing resource would not be triggered. This has been resolved in Puppet 4.9.0. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Moses Mendoza Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Kenn Hussey commented on PUP-6741 Re: When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Moses Mendoza or Ethan Brown please provide release notes for this issue. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Kurt Wall updated an issue Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Kurt Wall QA Risk Assessment Reason: Covered by spec tests Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Kurt Wall updated an issue Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Kurt Wall QA Risk Assessment: No Action Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Ethan Brown commented on PUP-6741 Re: When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Merged to master in https://github.com/puppetlabs/puppet/commit/7ba780bfa787197eba48e64236a3d3b9987870fd Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Geoff Nichols Sprint: AP 2016-11-30 , AP 2016-12-14 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Geoff Nichols Story Points: 2 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Geoff Nichols assigned an issue to Ethan Brown Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Geoff Nichols Assignee: Geoff Nichols Ethan Brown Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Geoff Nichols Sprint: AP Grooming 2016-11-30 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Geoff Nichols assigned an issue to Geoff Nichols Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Geoff Nichols Assignee: Moses Mendoza Geoff Nichols Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Geoff Nichols Sprint: AP Grooming Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Kenn Hussey Priority: Blocker Critical Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Kenn Hussey Fix Version/s: PUP 4.9.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Moses Mendoza commented on PUP-6741 Re: When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Thanks Christian Hoffmann for this tip! After investigating too I came to the same conclusion that the cause here is effectively missing tags on the whit "sentinel" resources. Charlie Sharpsteen I believe suggested a similar thing in PUP-5777 (linked). A PR is now up against puppet Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Moses Mendoza assigned an issue to Moses Mendoza Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Moses Mendoza Assignee: Moses Mendoza Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title
Christian Hoffmann commented on PUP-6741
Re: When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
TLDR: I have started an attempt at analyzing this issue and think I understand the root cause. I have created a simple patch which fixes the issue for me.
Details
Preparation steps
First, let me add an even shorter reproducer which works using only puppet apply:
/tmp/test.pp
file { '/tmp/target':
ensure => 'directory',
source => '/tmp/source',
recurse => true,
tag => 'foo',
} ~>
exec { '/bin/echo "changed"':
refreshonly => true,
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title Stefan Pijnappels updated an issue Puppet / PUP-6741 When `recurse => true` is used in a file resource, tags are not applied to all recursive objects. Change By: Stefan Pijnappels Priority: Normal Blocker Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title
Eric Sorenson updated an issue
Puppet / PUP-6741
When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Change By:
Eric Sorenson
In the case where `recurse => true' is added to a file resource which is actually a directory with a whole bunch of files in it, it appears that not all these files get tagged with either the default tags for the class/resource or with custom tags specified in the resource declaration.If these tags are then used later in a puppet run using --tags, the resource is not included.As an example, the following code will create a number of files in a directory, where the directory is marked as ` {{ recurse => true ` }} and the resource is tagged with a tag ` {{ sometag ` }} : ``` {code} class abc::component::ao { tag 'sometag' file { '/tmp/somefiles': tag => 'sometag', ensure => directory, source => "puppet:///static/somefiles", recurse => true, purge => true, owner => 'root', group => 'root', } exec { 'do something': tag => 'sometag', command => '/bin/echo do something', # 20 lines script refreshonly => true, subscribe => [ File['/tmp/somefiles'], ], } } ``` {code} However, when ` {{ puppet agent -t --tags sometag ` }} is run, the following is noted in the output: ``` {code} Notice: /Stage[main]/Abc::Component::Ao/File[/ao/basescripts/su_stop.ksh]/ensure: defined content as '{md5}1fd97a2fc03e639946d960ebd13bebd8'Debug: /Stage[main]/Abc::Component::Ao/File[/ao/basescripts/su_stop.ksh]: The container /ao/basescripts will propagate my refresh eventDebug: /ao/basescripts: Not tagged with sometagDebug: /ao/basescripts: Resource is being skipped, unscheduling all eventsInfo: /ao/basescripts: Unscheduling all events on /ao/basescripts ``` {code} This suggests that the tag was not set correctly on all files when the recurse was set and so the Exec is not refreshed.The exact same code without the `recurse => true` works exactly as expected.Is this a bug, and is there a workaround for this issue?Stefan
Add Comment
Jira (PUP-6741) When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Title: Message Title
Stefan Pijnappels created an issue
Puppet / PUP-6741
When `recurse => true` is used in a file resource, tags are not applied to all recursive objects.
Issue Type:
Bug
Assignee:
Unassigned
Created:
2016/09/26 7:39 AM
Priority:
Normal
Reporter:
Stefan Pijnappels
In the case where `recurse => true' is added to a file resource which is actually a directory with a whole bunch of files in it, it appears that not all these files get tagged with either the default tags for the class/resource or with custom tags specified in the resource declaration.
If these tags are then used later in a puppet run using --tags, the resource is not included.
As an example, the following code will create a number of files in a directory, where the directory is marked as `recurse => true` and the resource is tagged with a tag `sometag`:
``` class abc::component::ao { tag 'sometag' file { '/tmp/somefiles': tag => 'sometag', ensure => directory, source => "puppet:///static/somefiles", recurse => true, purge => true, owner => 'root', group => 'root', }
exec { 'do something': tag => 'sometag', command => '/bin/echo do something', # 20 lines script refreshonly => true, subscribe => [ File['/tmp/somefiles'], ], }
} ```
However, when `puppet agent -t --tags sometag` is run, the following is noted in the output:
``` Notice: /Stage[main]/Abc::Component::Ao/File[/ao/basescripts/su_stop.ksh]/ensure: defined content as ' {md5}
1fd97a2fc03e639946d960ebd13bebd8' Debug: /Stage[main]/Abc::Component::Ao/File[/ao/basescripts/su_stop.ksh]: The container /ao/basescripts will propagate my refresh event Debug: /ao/basescripts: Not tagged with sometag
