Jira (PUP-6767) Interpolation within Data Provider should respect strict variables setting
Title: Message Title Lindsey Smith updated an issue Puppet / PUP-6767 Interpolation within Data Provider should respect strict variables setting Change By: Lindsey Smith Team: Puppet Developer Experience Platform Core Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6767) Interpolation within Data Provider should respect strict variables setting
Title: Message Title Maggie Dreyer updated an issue Puppet / PUP-6767 Interpolation within Data Provider should respect strict variables setting Change By: Maggie Dreyer Labels: triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6767) Interpolation within Data Provider should respect strict variables setting
Title: Message Title Eric Thompson updated an issue Puppet / PUP-6767 Interpolation within Data Provider should respect strict variables setting Change By: Eric Thompson Team: Puppet Developer Support Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6767) Interpolation within Data Provider should respect strict variables setting
Title: Message Title Maksym Melnychok commented on PUP-6767 Re: Interpolation within Data Provider should respect strict variables setting I think the case is quite clear - it's actually the same case for which `strict_variables` setting itself was introduced. Single typo in variable name interpolated within data provider path can completely change the dataset catalog is working with when doing hiera lookups. Referring to inexistent puppet variables or facts yields an error. So do `hiera` and `lookup` functions when asked for a key that can't be looked-up and no explicit default value is provided. I don't see why should exception be made about interpolation. While backward compatibility is valid issue, introducing a breaking change that reliably generates an error in ambiguous situation is (in my opinion) one of the best ways to introduce such changes, and if this error points out previously unknown problematic code - that is a pure win without any drawbacks. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6767) Interpolation within Data Provider should respect strict variables setting
Title: Message Title Henrik Lindberg commented on PUP-6767 Re: Interpolation within Data Provider should respect strict variables setting It would help if the case for this was written up. The code this points to is in the middle of interpolation. Note that "strict variables" means that puppet variables are strict, not lookups/interpolations in general. And indeed, if you have strict variables on, and try to get a puppet variable that does not exist you will get an error. (If that is not working, then that is a bug). I can see it being difficult to do this. It would not be backwards compatible as the current behavior is expected (not found interpolates empty string), so can only be introduced at a major version boundary. I also suspect that users may need the flexibility to accept missing which means there needs to be some other mechanism - perhaps different interpolation functions - but that adds to the pile of special cases. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6767) Interpolation within Data Provider should respect strict variables setting
Title: Message Title Maksym Melnychok created an issue Puppet / PUP-6767 Interpolation within Data Provider should respect strict variables setting Issue Type: Bug Affects Versions: PUP 4.5.3 Assignee: Unassigned Components: Breaking Change Created: 2016/09/30 11:48 PM Priority: Normal Reporter: Maksym Melnychok followup to this comment thread: https://github.com/Yelp/puppet/commit/087312f99e1e45733bec09f5a61f9fa7f1b70874#commitcomment-19242530 Add Comment
