Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Henrik Lindberg commented on PUP-6781 Re: support 'verbatim' lookup option We decided to not include this feature. Description updated. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Henrik Lindberg commented on PUP-6781 Re: support 'verbatim' lookup option Removed the puppet release, and change the status of this ticket to 'won't do'. PUP-7004 is about removing what was merged here, and earlier for this feature. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6781 support 'verbatim' lookup option Change By: Henrik Lindberg Fix Version/s: PUP 4.9.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-6781
support 'verbatim' lookup option
Change By:
Henrik Lindberg
A data_hash data provider function returns a hash of values. When those values are strings they are automatically subject to interpolation using the existing hiera style. This will continue to work for the data returned by the data_hash function.There is the need to turn off interpolation for certain keys because it is very painful to escape strings that need to have hiera interpolation look alike content (this is not uncommon). To support this without requiring the user to switch to {{key_lookup}} style (where interpolation is done by the function) there should be a lookup_option controlling if a value should be used verbatim.Note that it is the data provider function kind / and its configuration that determines hw values are interpolation (the syntax for interpolation etc.) and the lookup option can override that such interpolation takes place. The verbatim option cannot be used to turn off any interpolation performed by the function itself.UPDATE Note that {{verbatim: true}} is only available as an option After additional discussion this feature did not turn out to be so great after all as it just introduces complexity and it doing it the way we now implemented it we may block having a different interpolation format in the future. For that reason, we should remove the 'verbatim' feature. Thus, the {{data_hash}} type of data provider. It cannot be set per key in {{lookup_options}}. It is function always for all key/ interpolates the values at the point in that provider time when the value is produced . The lookup_key and data_dig kinds of other functions are responsible for performing does not provide automatic interpolation , and they may if so chooses accept a verbatim option, but it has no meaning . A new ticket will be added to remove the framework and must be handled by the implementor 'verbatim' feature as it was merged as part of the function something bigger that cannot just be reverted .
Add Comment
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-6781
support 'verbatim' lookup option
Change By:
Henrik Lindberg
A data_hash data provider function returns a hash of values. When those values are strings they are automatically subject to interpolation using the existing hiera style. This will continue to work for the data returned by the data_hash function.There is the need to turn off interpolation for certain keys because it is very painful to escape strings that need to have hiera interpolation look alike content (this is not uncommon). To support this without requiring the user to switch to {{key_lookup}} style (where interpolation is done by the function) there should be a lookup_option controlling if a value should be used verbatim.Note that it is the data provider function kind / and its configuration that determines hw values are interpolation (the syntax for interpolation etc.) and the lookup option can override that such interpolation takes place. The verbatim option cannot be used to turn off any interpolation performed by the function itself. UPDATENote that {{verbatim: true}} is only available as an option to a {{data_hash}} type of data provider. It cannot be set per key in {{lookup_options}}. It is always for all key/values in that provider. The lookup_key and data_dig kinds of functions are responsible for performing interpolation, and they may if so chooses accept a verbatim option, but it has no meaning to the framework and must be handled by the implementor of the function.
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Henrik Lindberg commented on PUP-6781 Re: support 'verbatim' lookup option Right - we forgot to update the ticket after having resolved the issues in favor of how it is now implemented. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Thomas Hallgren commented on PUP-6781 Re: support 'verbatim' lookup option Henrik Lindberg, I read this ticket again and I realize that I didn't read it properly the first time and that I must remember our discussions incorrectly. As I recall it, we decided the following: A lookup_key or data_dig function is always treated as verbatim by the lookup framework. This is regardless of options. If such functions need interpolation, they are themselves responsible for making that happen. A data_hash function will either always interpolate its values (the default) or not interpolate at all. This is controlled by the boolean data provider option verbatim. We concluded that there was no need to control the verbatimness of individual keys. Consequently, the verbatim data provider option is currently implemented to affect the data_hash function only and there is no such thing as a lookup_option controlling explicit verbatim values. I see several issues with what is now being discussed: 1. If verbatim is to be passed down to lookup_key and data_dig functions, does that also apply to a verbatim found in the lookup_options ? If so, that's something completely new. We currently do not pass lookup_options down to the function (the only option available at present is merge). 2. If we don't pass the lookup_option to the functions but still want it to be in effect (for data_hash) do we still pass the data provider option? 3. Given that the lookup_options are subject to interpolation (they are), how do we control the verbatimness of the options themselves? 4. How do we resolve the ambiguity is introduced between the lookup_option and multiple (but different) data provider options. 4a. It sounds rather dangerous that a lookup_option pattern, defined somewhere in a module, should be allowed to override the data_provider setting (speaks for the suggested prio in Henrik's comment) 4b. The lookup_option for a specific key says verbatim, but depending on what data provider that finds it, it might not be since the its setting isn't verbatim, and vice versa (speaks against the suggested prio) I'm still much in favor of introducing verbatim as a data provider option only and not a lookup_option. Add Comment
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Henrik Lindberg commented on PUP-6781 Re: support 'verbatim' lookup option To not go crazy, think we should use the terms "lookup options" for what is in data and "data provider options" for the options per level in hiera.yaml. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Henrik Lindberg commented on PUP-6781 Re: support 'verbatim' lookup option Yes, you are right - I forgot. IIRC (ping Thomas Hallgren), the lookup function arguments wins over lookup_options (in data) which in turn wins over the level option. Not sure if there is a difference between the three functions - I think the default is "verbatim false" for data_hash, but "true" for the other two kinds of functions. Thomas Hallgren please correct me if I am wrong here. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Eric Thompson commented on PUP-6781 Re: support 'verbatim' lookup option Henrik Lindberg thanks for the context. in this case verbatim is set per level (in hiera.yaml): https://github.com/puppetlabs/puppet/pull/5421/files#diff-2c12cbb4931cfd2102db8d688e73049eR1073 can that be set per-key as you imply above using lookup_options? if so, what happens when they conflict? do we have or need testing around what happens with merged lookups across values and environments with different options? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Henrik Lindberg commented on PUP-6781 Re: support 'verbatim' lookup option The lookup_options are set in data sources and its name is unchanged. The 'options:' in a hiera.yaml level entry is not the same as the lookup_options. The 'options:' in a level entry is for options to the function being called to produce data (things like a path, a URL, etc. depending on the type of function being used). The 'lookup_options' is for options per key in the data (for example if the value for a key is a deep merge, to be taken verbatim etc). Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Eric Thompson updated an issue Puppet / PUP-6781 support 'verbatim' lookup option this is covered well by unit tests. Henrik Lindberg, Thomas Hallgren we don't have great (any) coverage of the various places one can set lookup_options this can be set in the hiera.yaml file, covered by the unit tests here. can we still set this as a key in a data source? is the key still called lookup_options? what happens if we use options: in hiera.yaml and the same options in lookup_options key in a data source? Change By: Eric Thompson QA Risk Assessment Reason: covered well by unit tests QA Risk Assessment: No Action QA Contact: Eric Thompson Add Comment
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Henrik Lindberg commented on PUP-6781 Re: support 'verbatim' lookup option merged to master at: f026e9e Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Thomas Hallgren commented on PUP-6781 Re: support 'verbatim' lookup option There was no unit test for this new behavior so I added one. That, of course, revealed a bug so I fixed it and created a PR. I reverted the status of this ticket back to "Ready for merge" Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-6781 support 'verbatim' lookup option Change By: Thomas Hallgren Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-6781
support 'verbatim' lookup option
Change By:
Henrik Lindberg
Release Notes Summary:
The hiera meta data {{lookup_options}} now supports that a key can be set to {{verbatim : true}} in order to prevent interpolation from taking place. This is helpful when a data value should contain %\{\} values as it avoids having to escape each such occurrence in the value.
Release Notes:
New Feature
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6781 support 'verbatim' lookup option Change By: Henrik Lindberg Component/s: DOCS Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Josh Cooper updated an issue Puppet / PUP-6781 support 'verbatim' lookup option Change By: Josh Cooper Fix Version/s: PUP 4.9.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Josh Cooper assigned an issue to qa Puppet / PUP-6781 support 'verbatim' lookup option Change By: Josh Cooper Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Thomas Hallgren commented on PUP-6781 Re: support 'verbatim' lookup option The described functionality was added as part of PUP-6780 . For details, see data_hash_function_provider.rb lines 18 and 75. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6781 support 'verbatim' lookup option Change By: Henrik Lindberg Sprint: PDS Triage 2016-12-14 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6781) support 'verbatim' lookup option
Title: Message Title Henrik Lindberg created an issue Puppet / PUP-6781 support 'verbatim' lookup option Issue Type: New Feature Assignee: Unassigned Created: 2016/10/04 4:52 PM Priority: Normal Reporter: Henrik Lindberg A data_hash data provider function returns a hash of values. When those values are strings they are automatically subject to interpolation using the existing hiera style. This will continue to work for the data returned by the data_hash function. There is the need to turn off interpolation for certain keys because it is very painful to escape strings that need to have hiera interpolation look alike content (this is not uncommon). To support this without requiring the user to switch to key_lookup style (where interpolation is done by the function) there should be a lookup_option controlling if a value should be used verbatim. Note that it is the data provider function kind / and its configuration that determines hw values are interpolation (the syntax for interpolation etc.) and the lookup option can override that such interpolation takes place. The verbatim option cannot be used to turn off any interpolation performed by the function itself. Add Comment
