Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Michelle Fredette commented on PUP-6919 Re: Puppet::Util::Windows::Process.execute should accept a working directory added release note for 6.0.1 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Kris Bosland commented on PUP-6919 Re: Puppet::Util::Windows::Process.execute should accept a working directory Passed CI in e2f7ccfb7 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Enis Inan updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Enis Inan Release Notes Summary: Puppet::Util::Execution.execute now supports a `cwd` option to specify the current working directory that the command will run in. This option is only available on the agent. It cannot be used on the master, meaning it cannot be used in, for example, regular functions, hiera backends, or report processors. Release Notes: New Feature Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Enis Inan updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Enis Inan Fix Version/s: PUP 5.y Fix Version/s: PUP 6.0.1 Fix Version/s: PUP 5.5.7 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Enis Inan assigned an issue to Enis Inan Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Enis Inan updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Enis Inan Sprint: Platform OS Kanban Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-6919
Puppet::Util::Windows::Process.execute should accept a working directory
Change By:
Enis Inan
The Windows API supports setting a working directory when starting a process. However, Puppet does not currently allow setting this value programatically.The win32-process gem can pass {{ cwd}} supplied through it's argument hash - see code at https://github.com/djberg96/win32-process/blob/win32-process-0.7.5/lib/win32/process.rb#L681 Puppet currently uses {{Dir.chdir}} to set a working directory before creating a process - however, this might not always work properly on Windows. The {{cwd}} has {{File.directory?(dir)}} used to validate it, which could fail on UNC or other path types (like reparse points - i.e. symlinks) on Windows - meaning that {{Dir.chdir}} at https : //github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/exec.rb#L29 never gets called as expected.{{cwd}} should be passed in to {{Puppet : : Util::Execution.execute}} at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/exec.rb#L59 / and should take in a `cwd` option that lets the call to {{Process.create}} at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/ user specify the new process ' working directory . rb#L12 should pass the {{arguments}} value through.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Enis Inan assigned an issue to Unassigned Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Enis Inan updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Enis Inan Sprint: Platform OS Kanban Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Enis Inan commented on PUP-6919 Re: Puppet::Util::Windows::Process.execute should accept a working directory Ended up reverting this change – see https://github.com/puppetlabs/puppet/pull/7045. Note that the POSIX issue with cd'ing to the cwd when the user does not have permissions to access it would have been resolved in https://github.com/puppetlabs/puppet/pull/7034; however, that was not merged due to some other issues with the existing implementation. These were: Puppet::Util::Execution.execute still runs the command in the cwd even if the cwd cannot be accessed. There are some design questions around whether we can move the directory existence check to the top-level execute method so that both execute_posix + execute_windows can use it. Right now, we only do this in execute_posix while in execute_windows, we wrap the system call error. For reference, the original implementation of this ticket was merged here: https://github.com/puppetlabs/puppet/pull/7016 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title
Ethan Brown updated an issue
Puppet / PUP-6919
Puppet::Util::Windows::Process.execute should accept a working directory
Change By:
Ethan Brown
The Windows API supports setting a working directory when starting a process. However, Puppet does not currently allow setting this value programatically.The win32-process gem can pass {{cwd}} supplied through it's argument hash - see code at https://github.com/djberg96/win32-process/blob/win32-process-0.7.5/lib/win32/process.rb#L681Puppet currently uses {{Dir.chdir}} to set a working directory before creating a process - however, this might not always work properly on Windows. The {{cwd}} has {{File.directory?(dir)}} used to validate it, which could fail on UNC or other path types (like reparse points - i.e. symlinks) on Windows - meaning that {{Dir.chdir}} at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/exec.rb#L29 never gets called as expected.{{cwd}} should be passed in to {{Puppet::Util::Execution.execute}} at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/exec.rb#L59 / and the call to {{Process.create}} at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/process.rb#L12 should pass the {{arguments}} value through.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Enis Inan updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Enis Inan Sprint: Platform OS Kanban Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Enis Inan assigned an issue to Enis Inan Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Branan Riley updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Branan Riley Labels: package type_and_provider windows Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Larissa Lane updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Larissa Lane Team: Coremunity Platform OS Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Josh Cooper updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Josh Cooper Fix Version/s: PUP 4.10.z Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Geoff Nichols Team: Platform OS Core Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Geoff Nichols Sprint: Agent N+1 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Ethan Brown updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Ethan Brown Sprint: Agent Ready for Engineering N+1 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Maggie Dreyer updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Maggie Dreyer Labels: package triaged windows Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Ethan Brown updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Ethan Brown Fix Version/s: PUP 5.y Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Kenn Hussey Fix Version/s: PUP 4.9.z Fix Version/s: PUP 4.10.z Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Geoff Nichols Sprint: Agent Ready for Engineering 1 0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Geoff Nichols Fix Version/s: PUP 4.10.0 Fix Version/s: PUP 4.9.z Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Geoff Nichols Story Points: 3 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Geoff Nichols Sprint: Agent Grooming Ready for Engineering Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Geoff Nichols Fix Version/s: PUP 5.0.0 Fix Version/s: PUP 4.10.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Geoff Nichols Sprint: Agent Accepted Grooming Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Ethan Brown commented on PUP-6919 Re: Puppet::Util::Windows::Process.execute should accept a working directory I've temporarily added PUP 5.0.0 as a fixVersion, though I'd like to see this fixed for the Glisan agent if possible. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Ethan Brown updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Ethan Brown Fix Version/s: PUP 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Geoff Nichols Sprint: AP Holding Grooming Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Geoff Nichols Sprint: AP Grooming Holding Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Geoff Nichols Sprint: AP Holding Grooming Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Geoff Nichols Sprint: AP Grooming Holding Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Geoff Nichols Sprint: AP Triage Grooming Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Ethan Brown updated an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Change By: Ethan Brown Team: Agent & Platform Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6919) Puppet::Util::Windows::Process.execute should accept a working directory
Title: Message Title Ethan Brown created an issue Puppet / PUP-6919 Puppet::Util::Windows::Process.execute should accept a working directory Issue Type: Bug Assignee: Unassigned Created: 2016/11/15 10:51 PM Labels: windows package Priority: Normal Reporter: Ethan Brown The Windows API supports setting a working directory when starting a process. However, Puppet does not currently allow setting this value programatically. The win32-process gem can pass cwd supplied through it's argument hash - see code at https://github.com/djberg96/win32-process/blob/win32-process-0.7.5/lib/win32/process.rb#L681 Puppet currently uses Dir.chdir to set a working directory before creating a process - however, this might not always work properly on Windows. The cwd has File.directory?(dir) used to validate it, which could fail on UNC or other path types on Windows - meaning that Dir.chdir at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/exec.rb#L29 never gets called as expected. cwd should be passed in to Puppet::Util::Execution.execute at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/provider/exec.rb#L59 / and the call to Process.create at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/process.rb#L12 should pass the arguments value through.
