Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Ethan Brown commented on PUP-6925 Re: Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Based on 1.9 shipping timelines, the other PR at https://github.com/puppetlabs/puppet/pull/5384 that includes SSL files has been re-ticketed as PUP-7134 with a new target of Puppet 5.0.0. Those changes were less critical than some of the ones incorporated into this PR. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Moses Mendoza commented on PUP-6925 Re: Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding merged to master at https://github.com/puppetlabs/puppet/commit/ce5500dd660019b2be6d132b14f70baff4c553fa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Jorie Tappa updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Jorie Tappa Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Geoff Nichols Sprint: AP 2016-11-30, AP 2016-12-14, AP 2017-01-11, AP 2017-01-25 , AP 2017-02-08 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Geoff Nichols Sprint: AP 2016-11-30, AP 2016-12-14, AP 2017-01-11, AP 2017- 02 01 - 08 25 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Geoff Nichols Sprint: AP 2016-11-30, AP 2016-12-14, AP 2017-01-11, AP 2017- 01 02 - 25 08 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Geoff Nichols Sprint: AP 2016-11-30, AP 2016-12-14, AP 2017-01-11 , AP 2017-01-25 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Geoff Nichols Sprint: AP 2016-11-30, AP 2016-12-14, AP 2016 2017 - 12 01 - 28 11 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Geoff Nichols Sprint: AP 2016-11-30, AP 2016-12-14 , AP 2016-12-28 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Kurt Wall updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Kurt Wall QA Risk Assessment Reason: [Bulk update] Testing, infrastructure, research tickets do not require risk assessment QA Risk Assessment: No Action Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Geoff Nichols Sprint: AP 2016-11-30 , AP 2016-12-14 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Ethan Brown assigned an issue to Ethan Brown Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Ethan Brown Assignee: Ethan Brown Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Geoff Nichols Story Points: 3 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Geoff Nichols Acceptance Criteria: - All tests pass in places where encoding needed to change.- New tests demonstrate behavior is correct.- New acceptance tests may be needed. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Geoff Nichols Sprint: AP 2016- 12 11 - 14 30 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Change By: Geoff Nichols Sprint: AP 2016- 11 12 - 30 14 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6925) Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding
Title: Message Title Ethan Brown created an issue Puppet / PUP-6925 Convert Ruby ::File calls for open to Puppet::FileSystem and explicitly specify encoding Issue Type: Improvement Affects Versions: PUP 4.8.0 Assignee: Unassigned Created: 2016/11/16 8:08 AM Labels: utf-8 i18n Priority: Normal Reporter: Ethan Brown There are still a smattering of calls to File.open or similar in the Puppet code that should use Puppet::FileSystem and that should explicitly specify an encoding. Make sure UTF-8 is used where possible, but be careful to leave some calls as the default Encoding.default_external in the case they are operating system managed files or expect different encodings. This is an extension of work started in PUP-6188 which was about how to use FileSystem.open or FileSystem.exclusive_open with an encoding.
