Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Thomas Hallgren assigned an issue to qa Puppet / PUP-6992 Fix inconsistent autoload of environment functions and pcore types. Change By: Thomas Hallgren Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6992 Fix inconsistent autoload of environment functions and pcore types. Change By: Henrik Lindberg Release Notes Summary: The feature that allows functions to defined in an environment in the "environment::" name space has been modified because the implementation was inconsistent between ruby and puppet based functions in this respect. Now, a file containing the definition of a function in an environment is always under a directory reflecting the name space. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Henrik Lindberg commented on PUP-6992 Re: Fix inconsistent autoload of environment functions and pcore types. merged to master at: f02ebf3 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Henrik Lindberg commented on PUP-6992 Re: Fix inconsistent autoload of environment functions and pcore types. Specification updated to reflect the wanted (changed) behavior. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6992 Fix inconsistent autoload of environment functions and pcore types. Change By: Henrik Lindberg Sprint: Modules PDE 2017-01-11 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Thomas Hallgren updated an issue Puppet / PUP-6992 Fix inconsistent autoload of environment functions and pcore types. Change By: Thomas Hallgren Sprint: Modules 2017-01-11 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-6992 Fix inconsistent autoload of environment functions and pcore types. Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Puppet / PUP-6992 Fix inconsistent autoload of environment functions and pcore types. Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Henrik Lindberg commented on PUP-6992 Re: Fix inconsistent autoload of environment functions and pcore types. Ping Thomas Hallgren unsure if you looked into this - may not make it into 4.9.0. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Kenn Hussey commented on PUP-6992 Re: Fix inconsistent autoload of environment functions and pcore types. Henrik Lindberg this needs to be in the current sprint in order to make the cutoff for Puppet 4.9.0 (and puppet-agent 1.9.0); otherwise, it should be assigned a different fix version. /cc Craig Gomes Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Henrik Lindberg commented on PUP-6992 Re: Fix inconsistent autoload of environment functions and pcore types. Eric Thompson Yes '::' in name, and '/' in path, are equivalent. For modules where definitions are not allowed in top scope we took of the modulename:: part. We divide into directories based on '::' because we want a 1:1 mapping between name and file, as well as having the ability to have modulename::foo, modulename::bar::foo etc. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Eric Thompson commented on PUP-6992 Re: Fix inconsistent autoload of environment functions and pcore types. okay. and the assumption is more or less that the loader replaces the / on filesystem, with :: in function name when finding/loading functions? so they can't all just be in $environment/functions or $environment/lib/puppet/functions? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Henrik Lindberg commented on PUP-6992 Re: Fix inconsistent autoload of environment functions and pcore types. You want to have the ability to name the functions environment::blah() in order to prevent the function you are writing to not clash with functions that are in no namespace (global) for example blah(). You don't want to name the function after the name of the environment as it changes depending on where it is checked out, so production::blah() does not make sense. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Eric Thompson commented on PUP-6992 Re: Fix inconsistent autoload of environment functions and pcore types. thanks, that makes sense Henrik Lindberg. Thomas Hallgren if that's the case. why would we need functions named environment::blah and why would they be isolated into: /lib/puppet/functions/environment # ruby /functions/environment # puppet i'm assuming here means "current environment's root" Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Henrik Lindberg commented on PUP-6992 Re: Fix inconsistent autoload of environment functions and pcore types. "global name" can only mean "top scoped name" here as there is no leakage between environments wrt. functions. A ::foo function in env A is different from a ::foo function in module B, and A and B cannot see into each-other. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Eric Thompson commented on PUP-6992 Re: Fix inconsistent autoload of environment functions and pcore types. For the sake of consistency, functions using global names should reside under: /lib/puppet/functions # ruby /functions # puppet does "global" imply that if i put a function as above, in one environment, it should be usable in another environment? what happens if there are two functions named the same thing in each environment? which one wins? what happens if there are two incompatible functions named the same thing, should the one in my environment be loaded if the other one was previously loaded? (environment isolation) Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Eric Thompson updated an issue Puppet / PUP-6992 Fix inconsistent autoload of environment functions and pcore types. Change By: Eric Thompson When a *ruby* function is declared in a _func_name.rb_ file under the directory _/lib/puppet/functions_, the auto-loader makes it accessible using the global name "func_name". Declaring a *puppet* function in _func_name.pp_ under _/functions_ does , however , not work. The function is not found unless the name of the function is prefixed with "environment::". In contrast, if the *ruby* function is prefixed the same way, the function is no longer found unless it is also moved to _/lib/puppet/functions/environment_.For the sake of consistency, functions using global names should reside under:_/lib/puppet/functions_ # ruby_/functions_ # puppetand functions prefixed with "environment::" should reside under:_/lib/puppet/functions/environment_ # ruby_/functions/environment_ # puppetThe same scheme should be used for auto-loading pcore types that are declared in the environment (but beneath the _types_ directory instead of _functions_). Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Eric Thompson updated an issue Puppet / PUP-6992 Fix inconsistent autoload of environment functions and pcore types. adding acceptance sub-task Change By: Eric Thompson QA Risk Assessment Reason: high risk, pp functions not loading in some cases QA Contact: Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Eric Thompson updated an issue Puppet / PUP-6992 Fix inconsistent autoload of environment functions and pcore types. Change By: Eric Thompson QA Risk Assessment: Needs Assessment Automate Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6992) Fix inconsistent autoload of environment functions and pcore types.
Title: Message Title Thomas Hallgren created an issue Puppet / PUP-6992 Fix inconsistent autoload of environment functions and pcore types. Issue Type: Bug Affects Versions: PUP 4.8.1 Assignee: Unassigned Created: 2016/12/09 3:12 AM Fix Versions: PUP 4.9.0 Priority: Normal Reporter: Thomas Hallgren When a ruby function is declared in a func_name.rb file under the directory /lib/puppet/functions, the auto-loader makes it accessible using the global name "func_name". Declaring a puppet function in func_name.pp under /functions does however not work. The function is not found unless the name of the function is prefixed with "environment::". In contrast, if the ruby function is prefixed the same way, the function is no longer found unless it is also moved to /lib/puppet/functions/environment. For the sake of consistency, functions using global names should reside under: /lib/puppet/functions # ruby /functions # puppet and functions prefixed with "environment::" should reside under: /lib/puppet/functions/environment # ruby /functions/environment # puppet The same scheme should be used for auto-loading pcore types that are declared in the environment (but beneath the types directory instead of functions).
