Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Kurt Wall updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Kurt Wall QA Risk Assessment: Needs Assessment No Action Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Moses Mendoza commented on PUP-7077 Re: Puppet::Util::Windows::File.replace_file fails on UNC paths merged to master at 1b04becadb89aca317de14cdfb9181e3b084c8f6 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Moses Mendoza commented on PUP-7077 Re: Puppet::Util::Windows::File.replace_file fails on UNC paths passed CI on stable (intended release vehicle) here: https://jenkins-master-prod-1.delivery.puppetlabs.net/view/puppet-agent/view/stable/view/puppet-agent/job/platform_puppet-agent_intn-van-sys_suite-daily-puppet-stable/35/ Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Moses Mendoza commented on PUP-7077 Re: Puppet::Util::Windows::File.replace_file fails on UNC paths Merged to stable at f6e57a259ce9ef7fb86a1205d87d71e263aea301 via 4.10.x merge to stable. merged originally to 4.10.x via b97c5928f218445d098529bf3ab931fb60b25f64. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Kenn Hussey assigned an issue to Moses Mendoza Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Kenn Hussey Assignee: Josh Cooper Moses Mendoza Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Josh Cooper commented on PUP-7077 Re: Puppet::Util::Windows::File.replace_file fails on UNC paths This needs to be merged up to stable/4.10.x and master. Will do that after branch changes. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Josh Cooper updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Josh Cooper Release Notes Summary: Puppet can now manage files on UNC shares when the user has permission to create/modify the file, but the share permissions are not Full Control. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Ethan Brown assigned an issue to Josh Cooper Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Ethan Brown Assignee: Josh Cooper Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Geoff Nichols Sprint: Agent Ready for Engineering 2017-04-05 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Kenn Hussey Fix Version/s: PUP 4.9.z Fix Version/s: PUP 4.7.z Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Kenn Hussey Fix Version/s: PUP 4.10.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Geoff Nichols Sprint: Agent Ready for Engineering 1 0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Geoff Nichols Sprint: Agent 2017-03-22 Ready for Engineering Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title
Ethan Brown commented on PUP-7077
Re: Puppet::Util::Windows::File.replace_file fails on UNC paths
Thanks to some assistance from Glenn Sarti I was able to reproduce this. When share permissions for the UNC path include Read and Change but not Full Control, this error can occur. With Full Control set, this problem does not show up.
The issue report is correct. If dwReplaceFlags is a different value passed to ReplaceFileW set, it will allow new files to be created. I tried REPLACEFILE_IGNORE_MERGE_ERRORS and REPLACEFILE_IGNORE_ACL_ERRORS and both were able to created a new file OR modify an existing file. I also validated that using cmd /c echo 'foo' > file.txt also worked for a UNC volume with said permissions.
What's left now is to choose an implementation path. Options include:
Set REPLACEFILE_IGNORE_MERGE_ERRORS all the time.
Set REPLACEFILE_IGNORE_MERGE_ERRORS only when the volume is UNC (or the path starts with {{}})
I'm leaning toward the first as it's simpler, as long as there are no unintended consequences on ACLs - this will require some more debugging to validate.
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Geoff Nichols Sprint: AP 2017-03- 08 22 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Geoff Nichols Sprint: AP 2017- 02 03 - 22 08 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Geoff Nichols Sprint: AP 2017-02- 08 22 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Geoff Nichols Sprint: AP Grooming 2017- 01 02 - 18 08 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Geoff Nichols Acceptance Criteria: * Files on UNC paths non-NTFS volumes without ACL support can be managed with Puppet* Spec tests are added if necessary Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Geoff Nichols Story Points: 2 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Geoff Nichols Sprint: AP Grooming 2017-01-18 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Geoff Nichols Fix Version/s: PUP 3.8.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Geoff Nichols commented on PUP-7077 Re: Puppet::Util::Windows::File.replace_file fails on UNC paths Added a PUP 4.9.z fix version. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Geoff Nichols Fix Version/s: PUP 4.9.0 Fix Version/s: PUP 4.9.z Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Ethan Brown updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Ethan Brown Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title
Ethan Brown updated an issue
Puppet / PUP-7077
Puppet::Util::Windows::File.replace_file fails on UNC paths
Change By:
Ethan Brown
A user report was received that {{Puppet::Util::Windows::File.replace_file}} was traced as a problem in file writes to UNC paths. The original code lives at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/file.rb#L51-L69Note that the current code calls [ReplaceFile|https://msdn.microsoft.com/en-us/library/windows/desktop/aa365512(v=vs.85).aspx] and specifies {{REPLACEFILE_WRITE_THROUGH}} (0x01) as the {{dwReplaceFlags}} despite MSDN documentation listing that value as unsupported.The original code dates back to 2012 and probably wasn't sufficiently tested in UNC path scenarios - https://github.com/puppetlabs/puppet/commit/73e302bbf5ab4a6c5513a39070e2c907542775ae#diff-a91b066f285a8fe7ccfa4162399d458fR11From the user report, given a manifest:{code} file { 'puppettestfile':path=> 'server\path\Puppet_Test_File.txt',ensure => 'file',content => 'This is a puppet test file with content loaded from manifest',}{code}Different errors propagated depending on different circumstances:h4. When the file does not exist{code}Error: ReplaceFile(//server/path/Puppet_Test_File.txt, //server/path/Puppet_Test_File.txt20170106-6416-1fqt5cr): Access is denied.Error: /Stage[main]/Acurityconfig/File[puppettestfile]/ensure: change from absent to file failed: ReplaceFile(//sacuts16/TS16/TS16/Puppet_Test_File.txt, //sacuts16/TS16/TS16/Puppet_Test_File.txt20170106-6416-1fqt5cr): Access is denied.{code}*NOTE*: This results in a 0 byte file being createdh4. When the content of the file does not match{code}Error: ReplaceFile(//server/path/Puppet_Test_File.txt, //server/path/Puppet_Test_File.txt20170106-11576-wsevbb): Access is denied.Notice: /Stage[main]/ModuleName/File[puppettestfile]/content: Error: /Stage[main]/ModuleName/File[puppettestfile]/content: change from {md5}058755754b4ac17664d7a8eba995a8d1 to {md5}3568af3a5598f2998d60a5e92af55fd6 failed: ReplaceFile(//server/path/Puppet_Test_File.txt, //server/path/Puppet_Test_File.txt20170106-11576-wsevbb): Access is denied{code}The user was able to use an {{exec}} coupled with {{cmd.exe /c echo}} to successfully write files to the destination UNC path - so clearly the account Puppet running under has appropriate permission to do so.The user ultimately was able to work around the issue by passing {{REPLACEFILE_IGNORE_MERGE_ERRORS}} (0x02) as the value for {{dwReplaceFlags}}. It's possible the Puppet code can have that change made right away given the current value being passed is allegedly unsupported. Some additional tests may need to be written.The only concern here is whether or not the ACL can be set as desired. It may be necessary to add some documentation that managing files on UNC paths may not result in the expected {{mode}} being set.Callers of {{replace_file}} should also be audited to understand its current use in the Puppet codebase - https://github . com/puppetlabs/puppet/search?p=1=replace_file=%E2%9C%93
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Ethan Brown commented on PUP-7077 Re: Puppet::Util::Windows::File.replace_file fails on UNC paths Thanks Kenn Hussey - looking at next PUP 4.7.z... and I believe the 4.9.z would be the non-LTS to target (but there's no 4.9.z version yet). Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Ethan Brown updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Ethan Brown Fix Version/s: PUP 4.7.1 Fix Version/s: PUP 4.7.z Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Kenn Hussey commented on PUP-7077 Re: Puppet::Util::Windows::File.replace_file fails on UNC paths Ethan Brown the fix needs to land by tomorrow in order to make the cut for PUP 4.7.1 (and 4.8.2) Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Ethan Brown commented on PUP-7077 Re: Puppet::Util::Windows::File.replace_file fails on UNC paths I have tentatively targeted this at the LTS agent / Puppet 4.7 series, and all future versions. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Ethan Brown updated an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Change By: Ethan Brown Fix Version/s: PUP 4.9.0 Fix Version/s: PUP 4.8.z Fix Version/s: PUP 4.7.1 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7077) Puppet::Util::Windows::File.replace_file fails on UNC paths
Title: Message Title Ethan Brown created an issue Puppet / PUP-7077 Puppet::Util::Windows::File.replace_file fails on UNC paths Issue Type: Bug Affects Versions: PUP 4.8.1, PUP 4.7.0 Assignee: Unassigned Components: Windows Created: 2017/01/09 2:06 PM Labels: windows acl Priority: Normal Reporter: Ethan Brown A user report was received that Puppet::Util::Windows::File.replace_file was traced as a problem in file writes to UNC paths. The original code lives at https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/file.rb#L51-L69 Note that the current code calls ReplaceFile and specifies REPLACEFILE_WRITE_THROUGH (0x01) as the dwReplaceFlags despite MSDN documentation listing that value as unsupported. The original code dates back to 2012 and probably wasn't sufficiently tested in UNC path scenarios -
