Jira (PUP-7175) acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-7175 acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding Change By: Moses Mendoza Fix Version/s: PUP 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7175) acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding
Title: Message Title Sean McDonald commented on PUP-7175 Re: acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding Moses Mendoza should this ticket have a 5.0.0 fix version? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7175) acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding
Title: Message Title Moses Mendoza commented on PUP-7175 Re: acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding merged to master at https://github.com/puppetlabs/puppet/commit/79c68bde5962cf326da8f0de628b74a59d38e9be Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7175) acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding
Title: Message Title Eric Thompson assigned an issue to Unassigned Puppet / PUP-7175 acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding Change By: Eric Thompson Assignee: Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7175) acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding
Title: Message Title Eric Thompson commented on PUP-7175 Re: acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding The concept of "binding" the data provider functions is removed in 5.0 (would be surprised if anyone outside of Puppet have ever used that). ah. ok. i had forgotten that was removed. that's the part that stopped working. i'll fix the test. specifying the function in metadata.json still works, as expected. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7175) acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding
Title: Message Title Thomas Hallgren commented on PUP-7175 Re: acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding It's a bit unclear to me what it is that stopped working. Does it work in 5.0 when you declare the data_provider "function" in metadata.json (it should)? If so, did you have a special Ruby binding (under lib/puppet/bindings) that stopped working? It's expected and OK in that case. The concept of "binding" the data provider functions is removed in 5.0 (would be surprised if anyone outside of Puppet have ever used that). We kept the ability to declare the data provider function in environment.conf/metadata.json though (with deprecation warnings). Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7175) acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding
Title: Message Title
Eric Thompson commented on PUP-7175
Re: acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding
Thomas Hallgren thanks! yeah, i should have just left the env conf out of the above. the test tests that data providers can be found in the environment, globally and in a module. so in some ways they are "mixed"
this test works as-is against puppet 4.x, is it a concern that i now have to declare the function in metadata.json and i didn't before?
ah, it looks like the second half of the test is using a metadata.json to specify the data binding.
with vi line nums:
102 {
103 "name": "tester-#{module_name}",
104 "version": "0.1.0",
105 "author": "tester",
106 "summary": null,
107 "license": "Apache-2.0",
108 "source": "",
109 "project_page": null,
110 "issues_url": null,
Jira (PUP-7175) acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding
Title: Message Title Thomas Hallgren commented on PUP-7175 Re: acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding Looks like you're mixing an environment data provider and a module data provider. Declaring a "function" in the environment.conf should still work (we retain backward compatibility with Hiera v4) but the function must then be declared in the environment, not in the module. In order to have a v4 "function" in a module, it must be declared in the metadata.json. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7175) acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding
Title: Message Title Eric Thompson updated an issue Puppet / PUP-7175 acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding Change By: Eric Thompson Summary: acceptance: tests/lookup/lookup.rb failing automatic parameter lookup with module data binding Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
