Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Jorie Tappa updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Jorie Tappa Labels: resolved-issue-added Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Thomas Hallgren updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Thomas Hallgren Release Notes Summary: Values in reports that were earlier serialized using Ruby specific YAML tags are now serialized as hashes with a special key stating the data type - thus making them valid general YAML. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Geoff Nichols commented on PUP-7382 Re: Ensure current values are YAML serializable Thomas Hallgren, when you have a chance, could you please populate the release notes for this issue? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Maggie Dreyer commented on PUP-7382 Re: Ensure current values are YAML serializable Deferring to Josh Cooper Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Kenn Hussey commented on PUP-7382 Re: Ensure current values are YAML serializable Maggie Dreyer please provide release notes for this issue, if applicable. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Maggie Dreyer commented on PUP-7382 Re: Ensure current values are YAML serializable Second PR merged at https://github.com/puppetlabs/puppet/commit/f5a69b48e1ad9abeadd28e60bfae59dc9687acf5 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Henrik Lindberg Assignee: Josh Cooper Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Thomas Hallgren assigned an issue to Josh Cooper Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Thomas Hallgren Assignee: Thomas Hallgren Josh Cooper Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Josh Cooper commented on PUP-7382 Re: Ensure current values are YAML serializable Reopening this, see https://github.com/puppetlabs/puppet/pull/5925#pullrequestreview-42465686 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Josh Cooper assigned an issue to Thomas Hallgren Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Josh Cooper Assignee: John Duarte Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title John Duarte assigned an issue to John Duarte Puppet / PUP-7382 Ensure current values are YAML serializable Change By: John Duarte Assignee: qa John Duarte Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title John Duarte assigned an issue to qa Puppet / PUP-7382 Ensure current values are YAML serializable Change By: John Duarte Status: Ready for CI Test Assignee: Thomas Hallgren qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Kenn Hussey Sprint: Puppet 5 Race to the Finish! Agent 2017-06-14 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Henrik Lindberg Sprint: PDE 2017-05-31 , PDE Rollover Beethoven Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Henrik Lindberg Component/s: Type System Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Geoff Nichols Sub-team: Language Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Thomas Hallgren commented on PUP-7382 Re: Ensure current values are YAML serializable I'm planning to implement this using the `ToDataConverter` class that is being added in PUP-5912 so I'm setting this as blocked by that ticket. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Geoff Nichols Team: Agent Puppet Developer Experience Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Eric Delaney updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Eric Delaney QA Risk Assessment Reason: Does this cause test changes? QA Risk Assessment: Needs Assessment Automate QA Contact: Eric Delaney Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Ethan Brown updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Ethan Brown Labels: triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Ethan Brown updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Ethan Brown Team: Puppet Developer Experience Agent Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Thomas Hallgren commented on PUP-7382 Re: Ensure current values are YAML serializable The "whitelist of the types" that Branan mentions is he list of all types that are assignable to Data, i.e. type Data = "" which means that it is very easy to distinguish such values by doing: if Puppet::Pops::Types::TypeFactory.data.assignable?(value) # value is Data else # value goes beyond what can be represented as YAML end One way to present types that go beyond Data (we call them RichData types) could be to use the StringConverter and describe the various implementations using the Object type. All types that are described that way are capable of presenting themselves in string form as a Puppet new function call with a hash parameter. If there's a need for it, that string can be parsed back and evaluated using the Puppet evaluator. The result is equivalent to the original object. If the string must be YAML, then we need to decide on how to represent the type information in YAML. Perhaps the way we decided to do it for catalog rich data
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Geoff Nichols Team: Agent Puppet Developer Experience Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Geoff Nichols Sprint: Agent N+1 PDE 2017-05-17 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Geoff Nichols Sprint: Agent Ready for Engineering N+1 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Geoff Nichols Sprint: Agent Grooming Ready for Engineering Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Geoff Nichols Acceptance Criteria: * puppetlabs-acl module v 1.1.2 passes CI when using a puppet-agent build with embedded Ruby 2.3* New unit tests added to Puppet to validate behavior Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Geoff Nichols Story Points: 5 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Geoff Nichols Story Points: 3 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Geoff Nichols Priority: Blocker Major Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7382 Ensure current values are YAML serializable Change By: Geoff Nichols Priority: Normal Blocker Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Ethan Brown commented on PUP-7382 Re: Ensure current values are YAML serializable Do we want to consider Puppet warnings for users custom types that might cause problems? One place worth investigating is the vmware modules - they all share the source at https://github.com/vmware/vmware-vmware_lib/tree/master/lib/puppet/property which includes a number of custom types (though none are based on the Ruby Hash or Array). These are used by the modules: https://github.com/vmware/vmware-vcenter https://github.com/vmware/vmware-vcd https://github.com/vmware/vmware-nsx There are some other modules that do some interesting things, but I don't believe they are impacted because use of Hash is outside of type and provider code: https://github.com/simp/pupmod-simp-compliance_markup/blob/master/lib/puppetx/simp/compliance_map_ordered_hash.rb https://github.com/ptomulik/puppet-vash https://github.com/ptomulik/puppet-portsutil/blob/master/lib/puppet/util/ptomulik/package/ports/options.rb consumes the Vash mixins above https://github.com/ptomulik/puppet-portsng/blob/master/lib/puppet/provider/package/portsng.rb seems to consume above as well https://github.com/aimonb/puppet_aviator/blob/master/lib/puppet/feature/faraday/utils.rb#L107 https://github.com/xaque208/puppet-permute/blob/master/lib/puppet/parser/functions/resource_permute.rb#L34 https://github.com/puppetlabs/puppetlabs-catalog_preview/blob/master/lib/puppet_x/puppetlabs/migration/overview_model/query.rb#L152 https://github.com/willdurand/puppet-nodejs/blob/master/lib/puppet/parser/functions/evaluate_version.rb#L8-L9 returns a NodeVersion which is a subclass of Ruby Array at https://github.com/willdurand/puppet-nodejs/blob/master/lib/puppet/parser/functions/util/nodejs_functions.rb#L3 I couldn't find any uses of the "Oval" types, but I did uncover them in my search
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title
Ethan Brown updated an issue
Puppet / PUP-7382
Ensure current values are YAML serializable
Change By:
Ethan Brown
As described in MODULES-4275, a provider may return arbitrary objects as the {{current}} value. This value is written (as YAML) in the corrective change file and in the report (if there is a change). The assumption has always been that the {{current}} value is primitive (string, integer, etc), but the ACL module returns Hash subclasses. Since we rely on {{to_yaml_properties}} for report serialization (see PUP-7381), Ruby 2.3 will serialize instance variables of our subclasses, which causes puppet to try to serialize the provider instance. This wasn't a problem previously, because Ruby 2.2 and below just serialize the hash key/value pairs. (The commit changing the Ruby behavior is https://github.com/ruby/ruby/commit/fe0414b5473b5332706126d2a017a9bf235c8146#diff-aed2624c7e8f254dd7356f2a32d8358fR471) Puppet needs to be more defensive about how {{current}} values are handled. Presumably this could be done by always writing out the {{to_s}} version of the object./cc [~geoff.nichols], [~ethan], [~henrik.lindberg]
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Ethan Brown commented on PUP-7382 Re: Ensure current values are YAML serializable https://github.com/puppetlabs/puppet/pull/5726 showed one approach of bolting on encode_with on the fly during serialization that works for stripping the provider property, but isn't a really good holistic solution I don't think. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Henrik Lindberg commented on PUP-7382 Re: Ensure current values are YAML serializable We can have a value transformer (we have a few already) that filters and/or transforms "funky values" - it could compare and say they are different but it cannot show the value(s) / diff etc. This would work as a whitelist, but work recursively if "funky values" are nested inside of arrays/hashes. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Branan Riley commented on PUP-7382 Re: Ensure current values are YAML serializable To be clear, we consider "primitive" in this case to also include Array and Hash, correct? I believe that to_s won't work for corrective change reporting, unfortunately. In order to avoid false positives where a property being in sync isn't a simple value equality, we call out to a property's insyc? implementation. Passing in a stringified value from a serialized blob could cause that custom code to misbehave in exciting ways. An option we might be able to go with is having a simple whitelist of the types we want - simple scalars, arrays, hashes - and just not report on corrective change at all for properties with weirder internal representations. There's some potential complexity here about whether we should try to make the associated log messages associated with the resource in the report, but it's not too bad. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Henrik Lindberg commented on PUP-7382 Re: Ensure current values are YAML serializable There is a problem with "to_s" on the returned value if this happens too early in the pipeline for serialization (at least if we assume that one day the report can contain rich data) - maybe we deal with this then, but if it can be avoided it would be good. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Josh Cooper commented on PUP-7382 Re: Ensure current values are YAML serializable Also note this problem could have happened in Ruby 2.1 if the ACL module had return Array subclasses instead of Hash subclasses. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7382) Ensure current values are YAML serializable
Title: Message Title Josh Cooper created an issue Puppet / PUP-7382 Ensure current values are YAML serializable Issue Type: Bug Assignee: Unassigned Created: 2017/03/21 10:30 PM Priority: Normal Reporter: Josh Cooper As described in MODULES-4275, a provider may return arbitrary objects as the current value. This value is written (as YAML) in the corrective change file and in the report (if there is a change). The assumption has always been that the current value is primitive (string, integer, etc), but the ACL module returns Hash subclasses. Since we rely on to_yaml_properties for report serialization (see PUP-7381), Ruby 2.3 will serialize instance variables of our subclasses, which causes puppet to try to serialize the provider instance. This wasn't a problem previously, because Ruby 2.2 and below just serialize the hash key/value pairs. Puppet needs to be more defensive about how current values are handled. Presumably this could be done by always writing out the to_s version of the object. /cc Geoff Nichols, Ethan Brown, Henrik Lindberg Add Comment
