Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-7473 remove dead code in Puppet::Type::instances Change By: Henrik Lindberg Release Notes Summary: refactoring of code / pruning dead code Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Kenn Hussey commented on PUP-7473 Re: remove dead code in Puppet::Type::instances Moses Mendoza please provide release notes for this issue, if applicable. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Moses Mendoza assigned an issue to Unassigned Puppet / PUP-7473 remove dead code in Puppet::Type::instances Change By: Moses Mendoza Assignee: Moses Mendoza Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Moses Mendoza commented on PUP-7473 Re: remove dead code in Puppet::Type::instances this passed CI through builds up to https://jenkins-master-prod-1.delivery.puppetlabs.net/view/puppet-agent/view/master/view/Suite/job/platform_puppet-agent_intn-van-sys_suite-daily-puppet-master/70/parameters/ Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Moses Mendoza assigned an issue to Moses Mendoza Puppet / PUP-7473 remove dead code in Puppet::Type::instances Change By: Moses Mendoza Assignee: Josh Cooper Moses Mendoza Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7473 remove dead code in Puppet::Type::instances Change By: Geoff Nichols Sprint: Agent 2017-05-03, Agent N+1 2017-05-31 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-7473 remove dead code in Puppet::Type::instances Change By: Geoff Nichols Sprint: Agent 2017-05-03 , Agent N+1 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Ethan Brown commented on PUP-7473 Re: remove dead code in Puppet::Type::instances Merged to master in https://github.com/puppetlabs/puppet/commit/6c5b7043896977e51587df815bd8c9dbb071ace3 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Kurt Wall updated an issue Puppet / PUP-7473 remove dead code in Puppet::Type::instances Change By: Kurt Wall QA Risk Assessment Reason: Refactor Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Kurt Wall updated an issue Puppet / PUP-7473 remove dead code in Puppet::Type::instances Change By: Kurt Wall QA Risk Assessment: Needs Assessment No Action Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-7473 remove dead code in Puppet::Type::instances Change By: Moses Mendoza Sprint: Agent 2017-05-03 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Moses Mendoza assigned an issue to Josh Cooper Puppet / PUP-7473 remove dead code in Puppet::Type::instances Change By: Moses Mendoza Assignee: Josh Cooper Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-7473 remove dead code in Puppet::Type::instances Change By: Moses Mendoza Story Points: 1 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Moses Mendoza updated an issue Puppet / PUP-7473 remove dead code in Puppet::Type::instances Change By: Moses Mendoza Fix Version/s: PUP 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Moses Mendoza commented on PUP-7473 Re: remove dead code in Puppet::Type::instances found while working on review for PUP-7021 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7473) remove dead code in Puppet::Type::instances
Title: Message Title Moses Mendoza created an issue Puppet / PUP-7473 remove dead code in Puppet::Type::instances Issue Type: Bug Assignee: Unassigned Created: 2017/04/26 8:51 AM Priority: Normal Reporter: Moses Mendoza This block in Puppet::Type: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/type.rb#L1163-L1168 iterates over all of the properties of the type, checks if the given provider supports the property, and returns an array of all the supported property names. Except we don't do anything with the result. Before commit http://github.com/puppetlabs/puppet/commit/53241a91, which was a maint commit to remove superfluous variables we never used, the result of this block was assigned to the variable `all_properties` - which was never used. The commit removed the variable, but not the associated block. I believe the intention was to filter out properties that weren't supported by the provider before we called `newattr` on them, except `newattr` https://github.com/puppetlabs/puppet/blob/master/lib/puppet/type.rb#L769-L773 already does this filtering, and provides helpful debug output that a provider doesn't support a property so we're not managing it. The block can be removed. Add Comment