Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-11-10 Thread Claire Cadman (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Claire Cadman updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7582  
 
 
  Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
Change By: 
 Claire Cadman  
 
 
Labels: 
 doc_reviewed platform_7  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.19.1495458026000.75585.1605004920249%40Atlassian.JIRA.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-10-08 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 Passed CI in e89aa76eb2  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.19.1495458026000.52263.1602194820143%40Atlassian.JIRA.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-10-06 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7582  
 
 
  Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Release Notes: 
 Bug Fix  
 
 
Release Notes Summary: 
 Previously puppet would warn or error if it encountered a virtualclass (indicated by @class) or an exported class (indicated by @@class)based on the Puppet[:strict] setting. By default, puppet would warn, yetinclude resources from the virtual class in the catalog. This commit makes puppet always error on virtual and exported classes.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.19.1495458026000.49679.1601998500108%40Atlassian.JIRA.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-10-06 Thread Gabriel Nagy (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gabriel Nagy commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 Merged to main in https://github.com/puppetlabs/puppet/commit/cb9319fb40774fb9e432839ff85f14b352fefbee  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.19.1495458026000.49623.1601991360029%40Atlassian.JIRA.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-09-29 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper assigned an issue to Josh Cooper  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7582  
 
 
  Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Assignee: 
 Josh Cooper  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.19.1495458026000.45532.1601405280211%40Atlassian.JIRA.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-09-29 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7582  
 
 
  Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Sprint: 
 Platform Core KANBAN  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.19.1495458026000.45531.1601405280169%40Atlassian.JIRA.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-09-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 Puppet currently warns on all instances of virtual classes with file and line numbers, so I think it's fairly easy to correct this problem in manifests prior to upgrading:  
 
 
 
 
 $ bx puppet apply iclass.pp  
 
 
 Warning: Classes are not virtualizable (file: /Users/josh/work/puppet/iclass.pp, line: 14, column: 3)  
 
 
 Warning: Classes are not virtualizable (file: /Users/josh/work/puppet/iclass.pp, line: 15, column: 3)  
 
 
 Notice: Compiled catalog for localhost in environment production in 0.09 seconds  
 
 
 Notice: I've been realized  
 
 
 Notice: /Notify[vclass]/message: defined 'message' as 'I\'ve been realized'  
 
 
 Notice: I've been realized  
 
 
 Notice: /Notify[vclass2]/message: defined 'message' as 'I\'ve been realized'  
 
 
 Notice: Applied catalog in 0.01 seconds  
 
 
 $ bx puppet parser validate iclass.pp  
 
 
 Warning: Classes are not virtualizable (file: /Users/josh/work/puppet/iclass.pp, line: 14, column: 3)  
 
 
 Warning: 

Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-09-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 Check to see if puppet parser validate can warn on all cases where this occurs, not just the first one.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.19.1495458026000.44699.1601318220035%40Atlassian.JIRA.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-09-24 Thread Ben Ford (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ben Ford commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 I said this in slack some time ago, but I should record it on the ticket. Kill it dead. The more hidden "actually, it's not doing what you think you're doing" gotchas we can eliminate, the better.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.19.1495458026000.42092.1600964520086%40Atlassian.JIRA.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-09-23 Thread Reid Vandewiele (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Reid Vandewiele commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 I think we should make it a hard error. The point of the ticket is that when you put a "@" in front of class today, it silently doesn't do what you probably thought it was doing, and that's confusing. If we make it a hard error there could be some code, somewhere, that a user would then need to remove an "@" sign from. I've never seen a user try to do this intentionally. Removing the "@" sign would have no functional change on what their code does anyway, and at first blush I believe it's safe to fix non-clever code with something close to as simple as find . -name '*.pp' | xargs sed -i 's/@class {/class {/'. An error is better than not actually doing what the syntax lets you think you're doing.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.19.1495458026000.41483.1600883880080%40Atlassian.JIRA.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-09-22 Thread Charlie Sharpsteen (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Charlie Sharpsteen commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 I've never seen this done in the wild, but also haven't been specifically looking for things like it. Sounds like there has been a deprecation warning since 4.10, so I'd say go ahead and change the behavior in 7 if this is something we want to clean up.   We could always flip it back in 7.0.1 if it turns out to break $really_important_use_case that noone has mentioned in 3 years.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.19.1495458026000.40341.1600787700172%40Atlassian.JIRA.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-07-21 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7582  
 
 
  Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Epic Link: 
 PUP- 9120 10591  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.19.1495458026000.112623.1595350140100%40Atlassian.JIRA.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-04-29 Thread Melissa Stone (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Melissa Stone updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7582  
 
 
  Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
Change By: 
 Melissa Stone  
 
 
Sub-team: 
 Language  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.19.1495458026000.50948.1588193040053%40Atlassian.JIRA.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-04-29 Thread Melissa Stone (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Melissa Stone updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7582  
 
 
  Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
Change By: 
 Melissa Stone  
 
 
Team: 
 Froyo Coremunity  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.19.1495458026000.50949.1588193040096%40Atlassian.JIRA.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-04-29 Thread Melissa Stone (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Melissa Stone commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 Hey Ben Ford! Question for you on this one. It looks like we do support virtualized classes in a sense in puppet. Josh Cooper and I are trying to figure out the best path forward on this. Currently, following the example in the description of PUP-1606, I can get the virtual class to notify successfully. It only errors out when I include `--strict=error`. ``` ➜ puppet git:(master) ✗ cat iclass.pp class vclass { notify  {"vclass": message => "I've been realized" } } class iclass { @class  {"vclass": } } class  {"iclass":} ➜ puppet git:(master) ✗ be ./bin/puppet apply --debug iclass.pp Debug: Runtime environment: puppet_version=6.16.0, ruby_version=2.3.8, run_mode=user, default_encoding=UTF-8 Debug: Loading external facts from /Users/melissa/.puppetlabs/opt/puppet/cache/facts.d Debug: Facter: Found no suitable resolves of 1 for ec2_metadata . . . Debug: Facter: value for filesystems is still nil Debug: Facter: value for ipaddress6 is still nil Debug: Reset text domain to :production Warning: Classes are not virtualizable (file: /Users/melissa/workdir/puppet/iclass.pp, line: 8, column: 3) Notice: Compiled catalog for pyewacket.vpn.puppet.net in environment production in 0.04 seconds Debug: Creating default schedules Debug: Loaded state in 0.00 seconds Debug: Loaded state in 0.00 seconds Info: Applying configuration version '1588192102' Notice: I've been realized Notice: /Notify[vclass]/message: defined 'message' as 'I\'ve been realized' Debug: Finishing transaction 70323370342720 Debug: Storing state Debug: Pruned old state cache entries in 0.00 seconds Debug: Stored state in 0.00 seconds Notice: Applied catalog in 0.01 seconds Debug: Applying settings catalog for sections reporting, metrics Debug: Finishing transaction 70323644029760 Debug: Received report to process from pyewacket.vpn.puppet.net Debug: Processing report from pyewacket.vpn.puppet.net with processor Puppet::Reports::Store ➜ puppet git:(master) ✗ be ./bin/puppet apply --debug iclass.pp --strict error Debug: Runtime environment: puppet_version=6.16.0, ruby_version=2.3.8, run_mode=user, default_encoding=UTF-8 Debug: Loading external facts from /Users/melissa/.puppetlabs/opt/puppet/cache/facts.d . . . Debug: Facter: value for ipaddress6 is still nil Debug: Reset text domain to :production Error: Could not parse for environment production: Classes are not virtualizable (file: /Users/melissa/workdir/puppet/iclass.pp, line: 8, column: 3) on node pyewacket.vpn.puppet.net ``` Circling back to Eric's question, what's the benefit of removing this? How many people might this break? The warning was introduced in 4.10.2, so that's good if we do decide to make puppet fail if the user is trying to use a virtualized class.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 
 

Jira (PUP-7582) Make attempt to export or virtualize a class an error

2020-01-27 Thread Jorie Tappa (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jorie Tappa updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7582  
 
 
  Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
Change By: 
 Jorie Tappa  
 

  
 
 
 
 

 
 Currently (under to control of --strict), it is a warning or an error to attempt to use {{@class}} or {{@@class}} in a resource _expression_ or a {{create_resources}} call. Now in In  Puppet  6  7 .0.0 this should always be an error.Note the configuration for this is done twice, once for the static validation, and once for the runtime. The checker4_0 has the static validation logic, and the runtime check is in the `create_resources`. See PUP-1606 where the warnings were added.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit 

Jira (PUP-7582) Make attempt to export or virtualize a class an error

2018-09-09 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 Moved this to 7.0.0 removals (it is still wrong and should be fixed).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2018-09-09 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7582  
 
 
  Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Fix Version/s: 
 PUP 6.0.0  
 
 
Fix Version/s: 
 PUP 7.0.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2018-08-29 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 Eric Sorenson If you wanted this, but thought it would be complicated... it is a very simple change. (A "won't fix" is fine too, just wanted to let you know it is not hard to change since it is already configurable).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2018-08-29 Thread Eric Sorenson (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Eric Sorenson commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 I think we're out of time on this one and it seems very low risk to leave it. I'm just gonna close/wontfix.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2018-08-15 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 Josh Cooper There was no decision. I think we should make it a hard non configurable error.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2018-08-03 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 ping Henrik Lindberg, Thomas Hallgren  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2018-07-19 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 What's the final decision for 6?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2018-03-20 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 Eric Sorenson See PUP-1606 for why people try to use this. The current behaviour is that the @ or @@ is ignored when combined with class declaration via resource _expression_ - it has been ignored since puppet 2.7.0. In PUP-1606 we made it a warning/error under the control of --strict to make it clear that it simply does not work. The impact if this is now always an error is that users that have @ or @@ in combination with class would need to remove the at-chars as they would always get an error for such a construct. There is not a big downside to keeping this under control of --strict, if someone publishes code that contains this and someone else runs with --strict=error they would see the issue and could prompt to get it fixed. At the same time, I don't think this is really used in the wild simply because it has had no effect since puppet 2.6.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2018-03-19 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7582  
 
 
  Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Sub-team: 
 Language  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2018-03-19 Thread Eric Sorenson (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Eric Sorenson commented on  PUP-7582  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
 What is the downside of continuing the behavior as it is? Do people do this in the world right now, and if so, what problem are they trying to solve?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2018-03-19 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7582  
 
 
  Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Sub-team: 
 Language  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2018-03-19 Thread Craig Gomes (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Craig Gomes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7582  
 
 
  Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
Change By: 
 Craig Gomes  
 
 
Sub-team: 
 Coremunity  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2018-03-19 Thread Craig Gomes (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Craig Gomes updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-7582  
 
 
  Make attempt to export or virtualize a class an error   
 

  
 
 
 
 

 
Change By: 
 Craig Gomes  
 
 
Sub-team: 
 Language Coremunity  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2017-05-25 Thread Geoff Nichols (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Geoff Nichols updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7582 
 
 
 
  Make attempt to export or virtualize a class an error  
 
 
 
 
 
 
 
 
 

Change By:
 
 Geoff Nichols 
 
 
 

Team:
 
 Agent 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2017-05-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7582 
 
 
 
  Make attempt to export or virtualize a class an error  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Fix Version/s:
 
 PUP 6.0.0 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7582) Make attempt to export or virtualize a class an error

2017-05-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7582 
 
 
 
  Make attempt to export or virtualize a class an error  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2017/05/22 6:00 AM 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
Currently (under to control of --strict), it is a warning or an error to attempt to use @class or @@class in a resource _expression_ or a create_resources call. 
Now in Puppet 6.0.0 this should always be an error. 
Note the configuration for this is done twice, once for the static validation, and once for the runtime. The checker4_0 has the static validation logic, and the runtime check is in the `create_resources`. See PUP-1606 where the warnings were added. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment