Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8476 Incorrect handling of white space surrounding comments in EPP Change By: Josh Cooper Component/s: Epp Component/s: Language Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title Thomas Hallgren commented on PUP-8476 Re: Incorrect handling of white space surrounding comments in EPP Merged to master at bf26912. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-8476 Incorrect handling of white space surrounding comments in EPP Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title Henrik Lindberg commented on PUP-8476 Re: Incorrect handling of white space surrounding comments in EPP DOCS - see the corresponding PR to the specifications repo. Note the "notes" which also have details about comments in EPP in general; examples include what happens when using puppet language comments # and /* */ inside of EPP tags. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-8476 Incorrect handling of white space surrounding comments in EPP Change By: Henrik Lindberg Assignee: Henrik Lindberg Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-8476
Incorrect handling of white space surrounding comments in EPP
Change By:
Henrik Lindberg
Release Notes Summary:
EPP comments {{<%# Like this %>}} always trimmed preceding whitespace. This is different from ERB making it more difficult to migrate ERB templates to EPP. There was also no way of making EPP preserve those spaces. Now, EPP comment does not trim preceding whitespace by default, and a new left trimming tag {{<%#-}} has been added.This is a backwards incompatibility in that code like this:{code}Before <%# comment %>after{code}resulted in the string {{"Beforeafter"}}, whereas now it will be "Before after".
Release Notes:
Bug Fix
Component/s:
Language Specification
Component/s:
Epp
Component/s:
DOCS
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title Henrik Lindberg commented on PUP-8476 Re: Incorrect handling of white space surrounding comments in EPP The solution is to make EPP comment not trim on the left and instead add a new tag <%#- that specifies that left space should be trimmed. This was considered a lesser evil than keeping the behavior and trying to add syntax to keep spaces because that would be inconsistent with the other tags. Removing trimming also means that EPP works the same way as ERB. (ERB does not have a left-trim for comments). Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title Henrik Lindberg commented on PUP-8476 Re: Incorrect handling of white space surrounding comments in EPP Moved this to Puppet 6.0.0 since it is a breaking change. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title Henrik Lindberg assigned an issue to Henrik Lindberg Puppet / PUP-8476 Incorrect handling of white space surrounding comments in EPP Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-8476 Incorrect handling of white space surrounding comments in EPP Change By: Henrik Lindberg Fix Version/s: PUP 6.0.0 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title Henrik Lindberg commented on PUP-8476 Re: Incorrect handling of white space surrounding comments in EPP ERB does not trim left at all, and does not support trimming on the right either using a closing -%>. It simply removes the comment as if it did not exist at all, and trimming only works if there is an adjacent newline. I think that since EPP trims whitespace on a -, it should not really trim anything for a comment unless - is specified. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8476 Incorrect handling of white space surrounding comments in EPP Change By: Josh Cooper Sub-team: Language Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8476 Incorrect handling of white space surrounding comments in EPP Change By: Josh Cooper Team: Platform Core Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8476) Incorrect handling of white space surrounding comments in EPP
Title: Message Title
Thomas Hallgren created an issue
Puppet / PUP-8476
Incorrect handling of white space surrounding comments in EPP
Issue Type:
Bug
Assignee:
Unassigned
Created:
2018/02/20 7:49 AM
Priority:
Normal
Reporter:
Thomas Hallgren
An EPP comment preceded by any number of spaces or tabs will not produce those spaces or tabs on output:
inline_epp("some \t\t <%#%>text")) # returns 'sometext'
inline_epp("some<%#%> text")) # returns 'some text'
I can't find anything in the documentation that supports this. The code contains this comment and a regexp. It would make sense if the regexp was anchored at the beginning of line (and if the behavior was documented) but it isn't.
