Jira (PUP-8776) Extract the code & verify the module

2018-07-09 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-8776  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Extract the code & verify the module   
 

  
 
 
 
 

 
 passed CI in puppet#f0ef0a2409  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8776) Extract the code & verify the module

2018-07-02 Thread Melissa Stone (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Melissa Stone commented on  PUP-8776  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Extract the code & verify the module   
 

  
 
 
 
 

 
 merged into master with https://github.com/puppetlabs/puppetlabs-sshkeys_core/commit/c42bbe6471b9f1813d7b40b9f67d988b994a8e5a  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8776) Extract the code & verify the module

2018-06-20 Thread Melissa Stone (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Melissa Stone assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8776  
 
 
  Extract the code & verify the module   
 

  
 
 
 
 

 
Change By: 
 Melissa Stone  
 
 
Assignee: 
 Melissa Stone  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8776) Extract the code & verify the module

2018-06-20 Thread Melissa Stone (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Melissa Stone assigned an issue to Melissa Stone  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8776  
 
 
  Extract the code & verify the module   
 

  
 
 
 
 

 
Change By: 
 Melissa Stone  
 
 
Assignee: 
 Melissa Stone  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8776) Extract the code & verify the module

2018-05-23 Thread Austin Boyd (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Melissa Stone created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8776  
 
 
  Extract the code & verify the module   
 

  
 
 
 
 

 
Issue Type: 
  Sub-task  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/05/23 3:42 PM  
 
 
Labels: 
 csv-import  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Melissa Stone  
 

  
 
 
 
 

 
 Extract the code from puppet and into your module. You'll be copying the existing file structure into your module, but you will need to keep an eye out for any implicit dependencies that only really manifest in the code.   * Generate a new module skeleton using PDK  * Copy existing files from puppet to the new module, preserving the existing file layout * Ensure the unit tests pass successfully using `pdk test unit` * Ensure rubocop violations are fixed using `pdk validate` * Circle back and make sure the unit tests still pass after fixing any rubocop violations * Migrate the acceptance tests to use beaker-rspec, you'll need to add a system_test group to .sync.yml, create a default nodeset, move the location of the tests, and change them to use an rspec like syntax. * Once acceptance, spec, and rubocop tests all pass successfully, you'll want to build and verify your module to make sure the code is picked up and runs succesfully when installed as an independent module. * Make sure the readme is filled out fully with details on your module.   For details, see https://docs.google.com/document/d/1v00xgnfnowAqedKZm-GzSjLYD5rRhToQicrk9Y1MK2E/edit?usp=sharing