Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Austin Boyd updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Austin Boyd Zendesk Ticket IDs: 33723 Zendesk Ticket Count: 1 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.262757.1530029175000.6352.1576158061364%40Atlassian.JIRA.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Jean Bond updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Jean Bond Labels: resolved-issue-added Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Josh Cooper Fix Version/s: PUP 5.5.z Fix Version/s: PUP 6.2.0 Fix Version/s: PUP 6.0.6 Fix Version/s: PUP 5.5.10 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Josh Cooper commented on PUP-8962 Re: Type and provider info should be logged when prefetch fails Follow up merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/0afbf4d44b557224a74a47e484138e274460d20a Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Josh Cooper commented on PUP-8962 Re: Type and provider info should be logged when prefetch fails Merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/049430128a583f56e55b643420956934a2a2ce55 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Kris Bosland updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Kris Bosland Release Notes Summary: Puppet will now log exceptions that happen during prefetch. Also exception handling in prefetch was fixed to the correct set of exceptions. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Kris Bosland updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Kris Bosland Sprint: Coremunity Hopper Platform Core KANBAN Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Kris Bosland assigned an issue to Kris Bosland Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Kris Bosland Assignee: Kris Bosland Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title
Josh Cooper commented on PUP-8962
Re: Type and provider info should be logged when prefetch fails
Yeah, looks like we missed it for 6.0. That said we should be able to log the exception before raising, which was the behavior for load errors and missing commands before PUP-7630 was implemented:
rescue => detail
#TRANSLATORS `prefetch` is a function name and should not be translated
Puppet.log_exception(detail, _("Could not prefetch %{type_name} provider '%{name}': %{detail}") % { type_name: type_name, name: provider_class.name, detail: detail })
message = _("Could not prefetch %{type_name} provider '%{name}': %{detail}") % { type_name: type_name, name: provider_class.name, detail: detail }
Puppet.log_exception(detail, message)
if !detail.is_a?(LoadError) && !detail.is_a?(Puppet::MissingCommand)
raise unless Puppet.settings[:future_features]
@prefetch_failed_providers[type_name][provider_class.name] = true
end
end
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Charlie Sharpsteen commented on PUP-8962 Re: Type and provider info should be logged when prefetch fails The crontab example still fails mysteriously with Puppet 6.0.3 in the latest PE 2019.0 nightly: [root@pe-20190nightly-master ~]# puppet --version 6.0.3 [root@pe-20190nightly-master ~]# puppet agent -t Info: Using configured environment 'production' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Retrieving locales Info: Loading facts Info: Caching catalog for pe-20190nightly-master.puppetdebug.vlan Info: Applying configuration version '1540246020' Error: Failed to apply catalog: Could not parse line "\u\u\u\uodelay" (file: root, line: 2) The error message is much better if
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Jorie Tappa updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Jorie Tappa Sprint: Coremunity Grooming Hopper Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Jorie Tappa commented on PUP-8962 Re: Type and provider info should be logged when prefetch fails Grooming session: Looks like we forgot to un-gate some things attached to the future_features flag that should've been on by default in pup 6. ping Charlie Sharpsteen Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Jacob Helwig commented on PUP-8962 Re: Type and provider info should be logged when prefetch fails Charlie Sharpsteen, it looks like the error message should get translated into something a bit more useful if you turn on future_features in the puppet.conf (prefetch in transaction.rb). I'm not sure what the plan was for when to move the new (actually old) prefetch behavior from PUP-7630 to being the default behavior, though. Might have been something that was missed for 6.0? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Josh Cooper Fix Version/s: PUP 5.5.z Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Josh Cooper Sprint: Coremunity Hopper Grooming Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Josh Cooper Sprint: Coremunity Grooming Hopper Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Josh Cooper Sprint: Coremunity Grooming Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Neil Binney updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Neil Binney CS Priority: Needs Priority Reviewed Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Josh Cooper Team: Platform Core Coremunity Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title
Charlie Sharpsteen updated an issue
Puppet / PUP-8962
Type and provider info should be logged when prefetch fails
Change By:
Charlie Sharpsteen
While the puppet agent is applying a catalog, it will pre-fetch resource instances that share a common source. Such as packages from the same provider or cron jobs from the same crontab. Catalog application will abort with an error message if this prefetch operation fails. Often, these errors are terse, cryptic, and give no insight into which sort of resource type failed to fetch (cron job? package? SSH key?). In the case of types based on the ParsedFile provider, the prefetch code is shared among all types which means that the stack trace produced by {{--trace}} doesn't even help distinguish what type encountered the error.Error messages should be clear about which type and provider failed so that users can proceed directly to debugging instead of puzzling out what happened.h2. Reproduction Case - Install PE 2018.1.2 on CentOS 7. - Configure {{site.pp}} in the production environment with a cron resource:{code:bash}cat < /etc/puppetlabs/code/environments/production/manifests/master_node.ppnode '$(hostname -f)' { cron {'cron job to trigger prefetch':command => '/bin/true',user => 'root',hour => 1, }}EOF{code} - Write garbage to root's crontab to trigger a parse failure:{code:bash}printf '\0\0\0\0odelay' > /var/spool/cron/root{code} - Run {{puppet agent -t}}h3. OutcomeThe catalog fails to apply with a very terse, cryptic error message:{noformat}# puppet agent -tInfo: Using configured environment 'production'Info: Retrieving pluginfactsInfo: Retrieving pluginInfo: Retrieving localesInfo: Loading factsInfo: Caching catalog for pe-201812-master.puppetdebug.vlanInfo: Applying configuration version '1530028114'Error: Failed to apply catalog: Could not parse line "\u\u\u\uodelay" (file: root, line: 2){noformat}h3. Expected OutcomeError message should include the type and provider name as is done when prefect prefetch fails due to a LoadError or Puppet::MissingCommand error:{noformat}# puppet agent -tInfo: Using configured environment 'production'Info: Retrieving pluginfactsInfo: Retrieving pluginInfo: Retrieving localesInfo: Loading factsInfo: Caching catalog for pe-201812-master.puppetdebug.vlanInfo: Applying configuration version '1530028653'Error: Failed to apply catalog: Could not prefetch cron provider 'crontab': Could not parse line "\u\u\u\uodelay" (file: root, line: 2){noformat}
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Charlie Sharpsteen updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Charlie Sharpsteen CS Priority: Needs Priority Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8962) Type and provider info should be logged when prefetch fails
Title: Message Title Charlie Sharpsteen updated an issue Puppet / PUP-8962 Type and provider info should be logged when prefetch fails Change By: Charlie Sharpsteen Summary: Type and provider info should always be logged when prefetch fails Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
