Jira (PUP-8988) Don't pluginsync vendored modules
Title: Message Title Josh Cooper commented on PUP-8988 Re: Don't pluginsync vendored modules Passed puppet-agent#master CI in 1b388f978 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8988) Don't pluginsync vendored modules
Title: Message Title Josh Cooper commented on PUP-8988 Re: Don't pluginsync vendored modules Merged to master in https://github.com/puppetlabs/puppet/commit/bb505442c37aa8a06f8883b573173f6ae11fe914 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8988) Don't pluginsync vendored modules
Title: Message Title Josh Cooper commented on PUP-8988 Re: Don't pluginsync vendored modules Additional PR so that puppet doesn't try to create /opt/puppetlabs/puppet/vendor_modules if it doesn't exist: https://github.com/puppetlabs/puppet/pull/6939 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8988) Don't pluginsync vendored modules
Title: Message Title Josh Cooper commented on PUP-8988 Re: Don't pluginsync vendored modules Merged to master in https://github.com/puppetlabs/puppet/commit/3e946fd175d417f73536bdd76a968bf1100cef1a Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8988) Don't pluginsync vendored modules
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8988 Don't pluginsync vendored modules Change By: Josh Cooper Release Notes Summary: This is a behavior change to code that hasn't been released yet, so there won't be any user-facing changes. Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8988) Don't pluginsync vendored modules
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8988 Don't pluginsync vendored modules Change By: Josh Cooper Team: Coremunity Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8988) Don't pluginsync vendored modules
Title: Message Title
Josh Cooper updated an issue
Puppet / PUP-8988
Don't pluginsync vendored modules
Change By:
Josh Cooper
Currently in puppet#master, we treat vendored modules just like any another module in the environment-specific modulepath, just that they have the least preference.This is desirable to ensure that the version of the type we're compiling for, is the same version that the agent uses during catalog application. This is important to ensure the code in the type (title patterns, munge, validate, auto relations) is consistent to prevent subtle and difficult to reproduce bugs. It would also prevent problems like PUP-2746.However, it causes a few problems: * it will cause additional pluginsync'ing of types and providers * we have to be careful about introducing changes to types that are not compatible with older agents. For example, the yumrepo type now marks the {{password}} and {{proxy_password}} properties as sensitive, but the {{Puppet::Parameter#sensitive}} method is not available in older puppet versions. * it is a departure from how puppet currently worksThis ticket proposes we: * remove the vendored modules from the module path so that they are not pluginsync'ed automatically * add a puppet setting for vendored modulepath * add the path to the autoloader search path with least precedenceThis way vendored types can be autoloaded locally, but we never pluginsync (types/providers/facts/files/etc) from them./cc [~ericsorenson], [~jacob.helwig], [~melissa], [~branan]
Add Comment
This message was
Jira (PUP-8988) Don't pluginsync vendored modules
Title: Message Title
Josh Cooper updated an issue
Puppet / PUP-8988
Don't pluginsync vendored modules
Change By:
Josh Cooper
Currently in puppet#master, we treat vendored modules just like any another module in the environment-specific modulepath, just that they have the least preference.This is desirable to ensure that the version of the type we're compiling for, is the same version that the agent uses during catalog application. This is important to ensure the code in the type (title patterns, munge, validate, auto relations) is consistent to prevent subtle and difficult to reproduce bugs. It would also prevent problems like PUP-2746.However, it causes a few problems: * it will cause additional pluginsync'ing of types and providers * we have to be careful about introducing changes to types that are not compatible with older agents. For example, the yumrepo type now marks the {{password}} and {{proxy_password}} properties as sensitive, but the {{Puppet::Parameter#sensitive}} method is not available in older puppet versions. * it is a departure from how puppet currently worksThis ticket proposes we: * remove the vendored modules from the module path so that they are not pluginsync'ed automatically * add a puppet setting for vendored modulepath * add the path to the autoloader search path with least precedenceThis way vendored types can be autoloaded locally, but we never pluginsync (types/providers/facts/files/etc) from them./cc [~ericsorenson], [~jacob.helwig], [~melissa], [~branan]
Add Comment
This message was
Jira (PUP-8988) Don't pluginsync vendored modules
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8988 Don't pluginsync vendored modules Change By: Josh Cooper Sprint: Platform Core KANBAN Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8988) Don't pluginsync vendored modules
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-8988 Don't pluginsync vendored modules Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8988) Don't pluginsync vendored modules
Title: Message Title Branan Riley commented on PUP-8988 Re: Don't pluginsync vendored modules This matches my understanding of the issues with automatic pluginsyncing, and I agree with the plan to not sync vendored modules. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8988) Don't pluginsync vendored modules
Title: Message Title Josh Cooper created an issue Puppet / PUP-8988 Don't pluginsync vendored modules Issue Type: Bug Assignee: Unassigned Created: 2018/07/06 4:31 PM Fix Versions: PUP 6.0.0 Priority: Normal Reporter: Josh Cooper Currently in puppet#master, we treat vendored modules just like any another module in the environment-specific modulepath, just that they have the least preference. This is desirable to ensure that the version of the type we're compiling for, is the same version that the agent uses during catalog application. This is important to ensure the code in the type (title patterns, munge, validate, auto relations) is consistent to prevent subtle and difficult to reproduce bugs. It would also prevent problems like PUP-2746. However, it causes a few problems: it will cause additional pluginsync'ing of types and providers we have to be careful about introducing changes to types that are not compatible with older agents. For example, the yumrepo type now marks the password and proxy_password properties as sensitive, but the Puppet::Parameter#sensitive method is not available in older puppet versions. it is a departure from how puppet currently works This ticket proposes we: remove the vendored modules from the module path so that they are not pluginsync'ed automatically add a puppet setting for vendored modulepath add the path to the autoloader search path with least precedence
