Jira (PUP-9151) Schedule resource weekly behavior inconsistent with other periods
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9151 Schedule resource weekly behavior inconsistent with other periods Change By: Josh Cooper Sprint: Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.276167.1537288473000.98526.1628028840297%40Atlassian.JIRA.
Jira (PUP-9151) Schedule resource weekly behavior inconsistent with other periods
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9151 Schedule resource weekly behavior inconsistent with other periods Change By: Josh Cooper Sprint: Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.276167.1537288473000.98513.1628028780753%40Atlassian.JIRA.
Jira (PUP-9151) Schedule resource weekly behavior inconsistent with other periods
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9151 Schedule resource weekly behavior inconsistent with other periods Change By: Josh Cooper Sprint: Community PRs Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.276167.1537288473000.98516.1628028780848%40Atlassian.JIRA.
Jira (PUP-9151) Schedule resource weekly behavior inconsistent with other periods
Title: Message Title Jo Rhett commented on PUP-9151 Re: Schedule resource weekly behavior inconsistent with other periods I feel like one of the complications with touching this type is that it's used the most by (A) people who don't understand the other declarative approaches and (B) Enterprises who have very specific time bucket constraints... which are the two markets least prepared for a change in behavior Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9151) Schedule resource weekly behavior inconsistent with other periods
Title: Message Title
Jo Rhett commented on PUP-9151
Re: Schedule resource weekly behavior inconsistent with other periods
As it happens, I have run into this I agree completely with his analysis of the problem. Weekly doesn't properly implement number only distance. I think I recall hacking up a patch for this and then realizing that the current spec is a bit unclear to start with. I believe that Henrik Lindberg looked at it and gave a similar concern: it's kind of hard to fix the type without breaking a lot of working (if idiomatic) implementations. I believe that the following schedule will meet his needs. Use a daily schedule with a weekday limiter, and he'll get the effect he wants.
schedule { 'friday_night':
period => 'daily',
range => '18:00 - 23:59',
weekday => 'Friday',
repeat => 1,
}
This isn't the first periodmatch => number bug we've seen and I think there's too much cruft in existence to just change the delivery outright. Eric Sorenson for your purposes this is a general backlog thing you need to tackle eventually. I think a clear, testable spec needs to be written. I think it should use a different specification formation so that people can migrate to the new spec without breaking many old catalogs. This specification should be deprecated and eventually removed.
Jira (PUP-9151) Schedule resource weekly behavior inconsistent with other periods
Title: Message Title Eric Sorenson commented on PUP-9151 Re: Schedule resource weekly behavior inconsistent with other periods I think we'd take a patch that addresses this, it's not widely used but I understand the logic. Jo Rhett - you've probably used 'schedule' more than any human on this blue globe - have you run into this before? What do you think about the proposed solution? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9151) Schedule resource weekly behavior inconsistent with other periods
Title: Message Title Rob Braden updated an issue Puppet / PUP-9151 Schedule resource weekly behavior inconsistent with other periods Change By: Rob Braden Sprint: Platform Core Coremunity Grooming Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9151) Schedule resource weekly behavior inconsistent with other periods
Title: Message Title
Jarret Lavallee created an issue
Puppet / PUP-9151
Schedule resource weekly behavior inconsistent with other periods
Issue Type:
Bug
Affects Versions:
PUP 5.5.6
Assignee:
Unassigned
Created:
2018/09/18 9:34 AM
Priority:
Normal
Reporter:
Jarret Lavallee
The schedule type does not behave correctly with `period => weekly` and `"periodmatch => number`. This results in a gap where the resource should be applied, but cannot due to the underlying logic of the weekly period. The other periods check to ensure that the period is different. For example, the daily period checks to see if the day is not the same as the previous run 09/07 != 09/08. The weekly period, on the other hand, checks to see if the day of the week is less than the previous or 604800 seconds have elapsed. Currently, when using the weekly schedule, resources will not be applied any time on the same day of the week until after 604800 from the previous run. So if the previous run was at 2018-09-07 18:00, the weekly schedule would include the resource any time from 09/10 to 09/13, and after 9/15+ any time. On 09/14, 7 days from the previous run, it could only run after 18:00, so it cannot be run from 00:00-18:00 on 09/14. The deviation comes from https://github.com/puppetlabs/puppet/blob/master/lib/puppet/type/schedule.rb#L226-L235 where the weekly has a proc instead of comparing the week.
ScheduleMethods = {
:hourly => :hour,
