Jira (PUP-9298) Update directory? check on cwd in Execution.execute
Title: Message Title Josh Cooper commented on PUP-9298 Re: Update directory? check on cwd in Execution.execute This ticket hasn't been updated in several years, so I'm going to close. Please reopen if the issue persists. Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.283362.1541092475000.56363.1623712260038%40Atlassian.JIRA.
Jira (PUP-9298) Update directory? check on cwd in Execution.execute
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-9298 Update directory? check on cwd in Execution.execute Change By: Geoff Nichols Sprint: Platform OS Kanban Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9298) Update directory? check on cwd in Execution.execute
Title: Message Title Sean McDonald updated an issue Puppet / PUP-9298 Update directory? check on cwd in Execution.execute Change By: Sean McDonald Team: Platform OS Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9298) Update directory? check on cwd in Execution.execute
Title: Message Title Sean McDonald updated an issue Puppet / PUP-9298 Update directory? check on cwd in Execution.execute Change By: Sean McDonald Sprint: Platform OS Kanban Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9298) Update directory? check on cwd in Execution.execute
Title: Message Title Sean McDonald created an issue Puppet / PUP-9298 Update directory? check on cwd in Execution.execute Issue Type: Task Assignee: Unassigned Created: 2018/11/01 10:14 AM Priority: Normal Reporter: Sean McDonald Puppet::Util::Execution.execute checks for the existence of the cwd specified when the :cwd option is given using Puppet::FileSystem.directory? However, Puppet::FileSystem.directory? currently can return a false negative with reparse points (symlinks) in windows. We should refactor that function so it works with reparse points. A change to refactor Puppet::FileSystem.dirctory? is likely too risky to introduce in a Z release, so we'll need to introduce two fixes: one that's safer for Z releases and one to actually fix Puppet::FileSystem.directory? Note that Puppet::Util::Windows::File.exist? works for directories as well (the underlying windows API used in that function is for files or directories), so that's likely the solution here: For the Z release streams we can simply have the check cwd use Puppet::Util::Windows::File.exist? on windows and directory? everywhere else. Then the change to the master branch should be to actually leverage Puppet::Util::Windows::File.exist? inside the windows specific Puppet::FileSystem.dirctory? Add Comment
