Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Eric Thompson updated an issue Puppet / PUP-978 multiple literal default entries in case should raise error Change By: Eric Thompson QA Risk Assessment Reason: covered by unit tests; error message QA Risk Assessment: No Action QA Contact: Kurt Wall Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Thomas Hallgren assigned an issue to qa Puppet / PUP-978 multiple literal default entries in case should raise error Change By: Thomas Hallgren Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Thomas Hallgren commented on PUP-978 Re: multiple literal default entries in case should raise error Merged to master at e49a882. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-978 multiple literal default entries in case should raise error Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Puppet / PUP-978 multiple literal default entries in case should raise error Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-978 multiple literal default entries in case should raise error Change By: Henrik Lindberg Acceptance Criteria: That a duplicate literal default in a case or selector _expression_ leads to no action, warning or error as controlled by the --strict option. The message should point to the first duplicated entry. Release Notes Summary: Duplicate literal default entries in case and selector expressions are now validated under the control of the --strict flag (defaults to warning). Sprint: PDE 2017-01-11 Release Notes: New Feature Fix Version/s: PUP 5.0.0 Fix Version/s: PUP 4.9.0 Add Comment
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Henrik Lindberg commented on PUP-978 Re: multiple literal default entries in case should raise error Repurposing this ticket for the 4.9.0 implementation (under the control of strict). Adding a new ticket for the 5.0.0 implementation where this check will always result in an error. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-978
multiple literal default entries in case should raise error
Change By:
Henrik Lindberg
Multiple 'default' entries should result in a parse error. It creates an ambiguity. Consider the following examples:{code}case 10 { default : { notice 'nbr1' } default : { notice 'nbr2' }}# => notices nbr 2case default { default : { notice 'nbr1 } default : { notice 'nbr2' }}# => notices nbr1{code}The solution is to validate that only one option among all propositions is a literal default.UPDATEThe check for this can only detect literal (i.e. static) duplication. This because it is possible to use any _expression_ as a case option and we cannot evaluate all options as the language is specified to evaluate them sequentially until there is a match. Here is an illustration:{code:puppet}$a = defaultcase 10 { $a : { notice yay } default : { notice nay }}{code}This will notice {{yay}}.It is not only duplication of literal {{default}} that can cause problems - a check could check for any static duplication since the option with a second identical value would never be reached. Such a check is however more expensive than only checking duplication of literal {{default}} since option values can be arbitrarily complex.
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-978
multiple literal default entries in case should raise error
Change By:
Henrik Lindberg
Multiple 'default' entries should result in a parse error. It creates an ambiguity. Consider the following examples:{code}case 10 { default : { notice 'nbr1' } default : { notice 'nbr2' }}# => notices nbr 2case default { default : { notice 'nbr1 } default : { notice 'nbr2' }}# => notices nbr1{code}The solution is to validate that only one option among all propositions is a literal default. UPDATEThe check for this can only detect literal (i.e. static) duplication. This because it is possible to use any _expression_ as a case option and we cannot evaluate all options as the language is specified to evaluate them sequentially until there is a match. Here is an illustration:{code:puppet}$a = defaultcase 10 { $a : { notice yay } default : { notice nay }}{code}This will notice {{yay}}.It is not only duplication of literal {{default}} that can cause problems - a check could check for any static duplication since the option with a second identical value would never be reached.
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Henrik Lindberg commented on PUP-978 Re: multiple literal default entries in case should raise error The check could be added to 4.9.0 under control of the strict flag. Then in 5.0, it could be the default. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Moses Mendoza commented on PUP-978 Re: multiple literal default entries in case should raise error Henrik Lindberg does this need deprecation? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-978 multiple literal default entries in case should raise error Change By: Henrik Lindberg Team: Puppet Developer Support Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-978 multiple literal default entries in case should raise error Change By: Henrik Lindberg Fix Version/s: PUP 4.x Fix Version/s: PUP 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Henrik Lindberg commented on PUP-978 Re: multiple literal default entries in case should raise error Unfortunately this is a breaking change and cannot be introduced until 5.0.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-978 multiple literal default entries in case should raise error Change By: Henrik Lindberg Scrum Team: Language Add Comment This message was sent by Atlassian JIRA (v6.3.10#6340-sha1:7ea293a) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title
Henrik Lindberg commented on an issue
Re: multiple literal default entries in case should raise error
the same validation should be applied to selector expressions
Add Comment
Puppet / PUP-978
multiple literal default entries in case should raise error
Multiple 'default' entries should result in a parse error. It creates an ambiguity. Consider the following examples: {code} case 10 { default : { notice 'nbr1' } default : { notice 'nbr2' } } # = notices nbr 2 case default { default : { notice 'nbr1 } default : { notice 'nbr2' } } # = notices nbr1 {code} The solution is to val...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Andy Parker updated an issue Puppet / PUP-978 multiple literal default entries in case should raise error Change By: Andy Parker Fix Version/s: 3.7.0 Fix Version/s: 4.0.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-978) multiple literal default entries in case should raise error
Title: Message Title Andy Parker updated an issue Puppet / PUP-978 multiple literal default entries in case should raise error Change By: Andy Parker Fix Version/s: 4.0.0 Fix Version/s: 4.x Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
