Re: [pve-devel] [PATCH docs v6 15/16] notifications: describe new notification metadata fields
Am 22.04.24 um 11:15 schrieb Lukas Wagner: > > > On 2024-04-22 11:10, Fiona Ebner wrote: >>> +| Cluster node fenced |`fencing` | `error` | >>> `hostname` >>> +| Storage replication job failed |`replication` | `error` | >>> `hostname`, `job-id` >>> +| Backup succeeded |`vzdump` | `info` | >>> `hostname`, `job-id` (only for backup jobs) >>> +| Backup failed|`vzdump` | `error` | >>> `hostname`, `job-id` (only for backup jobs) >> >> I think the "(only for backup jobs)" should not be there, or? >> > > No, that should be there. The `job-id` field is set if the backup is started > as a scheduled job and if that job is started by hand, but *not* if > e.g. a single VM is backed up manually. Would not make sense for the latter, > since that one has no associated job. > Oh, sorry. I had misinterpreted this and didn't think about manual invocation vs. job. ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH docs v6 15/16] notifications: describe new notification metadata fields
On 2024-04-22 11:10, Fiona Ebner wrote: >> +| Cluster node fenced |`fencing` | `error` | >> `hostname` >> +| Storage replication job failed |`replication` | `error` | >> `hostname`, `job-id` >> +| Backup succeeded |`vzdump` | `info` | >> `hostname`, `job-id` (only for backup jobs) >> +| Backup failed|`vzdump` | `error` | >> `hostname`, `job-id` (only for backup jobs) > > I think the "(only for backup jobs)" should not be there, or? > No, that should be there. The `job-id` field is set if the backup is started as a scheduled job and if that job is started by hand, but *not* if e.g. a single VM is backed up manually. Would not make sense for the latter, since that one has no associated job. -- - Lukas ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] [PATCH docs v6 15/16] notifications: describe new notification metadata fields
Am 22.04.24 um 10:31 schrieb Lukas Wagner: > Signed-off-by: Lukas Wagner > --- > notifications.adoc | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/notifications.adoc b/notifications.adoc > index 57053c8..dec878a 100644 > --- a/notifications.adoc > +++ b/notifications.adoc > @@ -289,19 +289,21 @@ Notification Events > > [width="100%",options="header"] > |=== > -| Event| `type`| Severity | Metadata > fields (in addition to `type`) > -| System updates available |`package-updates` | `info` | `hostname` > -| Cluster node fenced |`fencing` | `error` | `hostname` > -| Storage replication failed |`replication` | `error` | - > -| Backup finished |`vzdump` | `info` (`error` on > failure) | `hostname` > -| Mail for root|`system-mail` | `unknown`| - > +| Event| `type`| Severity | Metadata > fields (in addition to `type`) > +| System updates available |`package-updates` | `info` | > `hostname` > +| Cluster node fenced |`fencing` | `error` | > `hostname` > +| Storage replication job failed |`replication` | `error` | > `hostname`, `job-id` > +| Backup succeeded |`vzdump` | `info` | > `hostname`, `job-id` (only for backup jobs) > +| Backup failed|`vzdump` | `error` | > `hostname`, `job-id` (only for backup jobs) I think the "(only for backup jobs)" should not be there, or? > +| Mail for root|`system-mail` | `unknown`| > `hostname` > |=== > > [width="100%",options="header"] > |=== > -| Field name | Description > -| `type` | Type of the notifcation > -| `hostname` | Hostname, without domain (e.g. `pve1`) > +| Field name| Description > +| `type`| Type of the notifcation Pre-existing typo: s/notfcation/notification > +| `hostname`| Hostname, without domain (e.g. `pve1`) > +| `job-id` | Job ID > |=== > > System Mail Forwarding ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
[pve-devel] [PATCH docs v6 15/16] notifications: describe new notification metadata fields
Signed-off-by: Lukas Wagner --- notifications.adoc | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/notifications.adoc b/notifications.adoc index 57053c8..dec878a 100644 --- a/notifications.adoc +++ b/notifications.adoc @@ -289,19 +289,21 @@ Notification Events [width="100%",options="header"] |=== -| Event| `type`| Severity | Metadata fields (in addition to `type`) -| System updates available |`package-updates` | `info` | `hostname` -| Cluster node fenced |`fencing` | `error` | `hostname` -| Storage replication failed |`replication` | `error` | - -| Backup finished |`vzdump` | `info` (`error` on failure) | `hostname` -| Mail for root|`system-mail` | `unknown`| - +| Event| `type`| Severity | Metadata fields (in addition to `type`) +| System updates available |`package-updates` | `info` | `hostname` +| Cluster node fenced |`fencing` | `error` | `hostname` +| Storage replication job failed |`replication` | `error` | `hostname`, `job-id` +| Backup succeeded |`vzdump` | `info` | `hostname`, `job-id` (only for backup jobs) +| Backup failed|`vzdump` | `error` | `hostname`, `job-id` (only for backup jobs) +| Mail for root|`system-mail` | `unknown`| `hostname` |=== [width="100%",options="header"] |=== -| Field name | Description -| `type` | Type of the notifcation -| `hostname` | Hostname, without domain (e.g. `pve1`) +| Field name| Description +| `type`| Type of the notifcation +| `hostname`| Hostname, without domain (e.g. `pve1`) +| `job-id` | Job ID |=== System Mail Forwarding -- 2.39.2 ___ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
