Re: [pve-devel] Creating of a 2nd blacklist with many blocked IPs

2014-11-02 Thread Dietmar Maurer
 When in the cluster.fw an auto-blacklist with ip-entries written, you ignore 
 this -
 must been every time empty!
 
 So the admin must fill the ipset and this is resistent! Without warranty!
 
 In documentation must been the information, dont fill directly in ipset work 
 with
 an ipset swap and then with a move when you are finished - thats only a short
 change, I mean you must doe! ... and I mean you make thousends administrators
 happy!

I will keep that in mind, but I currently do not have time to implement that.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


[pve-devel] run_command and shellquote

2014-11-02 Thread Michael Rasmussen
Hi Dietmar,

A command needs to be run like this:
/usr/bin/ssh -o 'BatchMode=yes'
-i /etc/pve/priv/zfs/192.168.3.145_id_rsa root@192.168.3.145 zfs set
refreservation=4g tank/vm-100-disk-1

but due to run_command applies shellquote which will apply quotes to
the param refreservation=4g because of '=' to the command the command
ends up like this:
/usr/bin/ssh -o 'BatchMode=yes'
-i /etc/pve/priv/zfs/192.168.3.145_id_rsa root@192.168.3.145 zfs set
'refreservation=4g' tank/vm-100-disk-1

which causes it to fail.

Any way to prevent shellquote to apply qoutes to refreservation=4g ?

-- 
Hilsen/Regards
Michael Rasmussen

Get my public GnuPG keys:
michael at rasmussen dot cc
http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xD3C9A00E
mir at datanom dot net
http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE501F51C
mir at miras dot org
http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE3E80917
--
/usr/games/fortune -es says:
What is a magician but a practising theorist?
-- Obi-Wan Kenobi


pgpJElRTXWNfT.pgp
Description: OpenPGP digital signature
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] run_command and shellquote

2014-11-02 Thread Dietmar Maurer
 but due to run_command applies shellquote which will apply quotes to the
 param refreservation=4g because of '=' to the command the command ends up
 like this:
 /usr/bin/ssh -o 'BatchMode=yes'
 -i /etc/pve/priv/zfs/192.168.3.145_id_rsa root@192.168.3.145 zfs set
 'refreservation=4g' tank/vm-100-disk-1
 
 which causes it to fail.
 
 Any way to prevent shellquote to apply qoutes to refreservation=4g ?

Why does shell quoting make the command fail? I thought shell quoting should 
not have any effect on
how the command receives parameters?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel