Re: [pve-devel] iproute2 package for kernel 4.15 ?

[Rene Jochum]

Yes, I reported that bug (not the patch ).

As said in the next PVE, there will be something like:

/bin/ss -Hlt 'sport = :5900'

Kind regards,

René

On 2018-04-20 10:33, Alexandre DERUMIER wrote:
>>> iproute2 4.15 contains a bug in /bin/ss which is in use in the next PVE. 
> 
> Just curious, where proxmox is using /bin/ss ?
> 
> man said:
> "ss is used to dump socket statistics. It allows showing information similar 
> to netstat.  It can display more TCP and state informations than other tools."
> 
> 
> Seem to be fixed here:
> https://www.spinics.net/lists/netdev/msg486801.html
> 
> - Mail original -
> De: "Rene Jochum" <r...@jochums.at>
> À: "pve-devel" <pve-devel@pve.proxmox.com>
> Envoyé: Vendredi 20 Avril 2018 09:35:53
> Objet: Re: [pve-devel] iproute2 package for kernel 4.15 ?
> 
> Hi, 
> 
> iproute2 4.15 contains a bug in /bin/ss which is in use in the next PVE. 
> 
> See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895719 
> 
> LG, 
> René 
> 
> 
> On 2018-04-20 08:41, Alexandre DERUMIER wrote: 
>> Hi, 
>>
>> could it be possible to add iproute2 4.15 to proxmox repository ? 
>>
>> I'm currently testing a new feature with vxlan + vlan aware bridge, 
>> to map vlan->vxlan with only 1 vtep device. 
>>
>>
>> #bridge link set dev vxlan0 vlan_tunnel on 
>> #bridge vlan add dev vxlan0 vid 1000-1001 tunnel_info id 2000-2001 
>>
>>
>> BTW, here a good presentation of least netdev conf about bridge, vxlan, 
>> ebgp-vpn,... 
>>
>> https://www.netdevconf.org/2.2/session.html?prabhu-linuxbridge-tutorial 
>> https://www.netdevconf.org/2.2/slides/prabhu-linuxbridge-tutorial.pdf 
>>
>>
>> I'll try to implement missing options for vxlan in ifupdown soon (already 
>> present in ifupdown2), 
>> and a GUI support for vxlan 
>>
>> Alexandre 
>> ___ 
>> pve-devel mailing list 
>> pve-devel@pve.proxmox.com 
>> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel 
>>
> 
> 
> 
-- 
René Jochum
Mail: r...@jochums.at
Tel: +43 664 750 77 653
Web: https://rene.jochums.at
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH librados2-perl] Convert to dpkg-buildpackage

[Rene Jochum]

Thanks again, comments inline.

On 2018-04-19 10:16, Fabian Grünbichler wrote:
>> @@ -52,23 +54,27 @@ install: PVE/RADOS.pm RADOS.so
>>  .PHONY: deb ${DEB}
>>  deb: ${DEB}
>>  ${DEB}:
>> -rm -rf debian
>> -mkdir debian
>> -make DESTDIR=${CURDIR}/debian install
>> -install -d -m 0755 debian/DEBIAN
>> -sed -e s/@@VERSION@@/${VERSION}/ -e s/@@PKGRELEASE@@/${PKGREL}/ -e 
>> s/@@ARCH@@/${ARCH}/ -e "s|@PERLAPI@|perlapi-$(PERL_APIVER)|g" > >debian/DEBIAN/control
>> -install -D -m 0644 copyright debian/${DOCDIR}/copyright
>> -install -m 0644 changelog.Debian debian/${DOCDIR}/
>> -gzip -9 -n debian/${DOCDIR}/changelog.Debian
>> -echo "git clone git://git.proxmox.com/git/librados2-perl.git\\ngit 
>> checkout ${GITVERSION}" > debian/${DOCDIR}/SOURCE
>> -fakeroot dpkg-deb --build debian
>> -mv debian.deb ${DEB}
>> -rm -rf debian
>> +rm -rf ${BUILDDIR}
>> +rsync -a * ${BUILDDIR}
>> +
>> +cp -fpr debian ${BUILDDIR}
> why rsync + cp? one should be enough ;)

Hihi, ofc.

> 
>> +cp changelog.Debian ${BUILDDIR}/debian/changelog
>> +cp copyright ${BUILDDIR}/debian/copyright
> see above, those two could go into the checked-in debian/
> 
>> +sed -e s/@@VERSION@@/${VERSION}/ -e s/@@PKGRELEASE@@/${PKGREL}/ -e 
>> s/@@ARCH@@/${ARCH}/ -e "s|@PERLAPI@|perlapi-$(PERL_APIVER)|g" 
>> ${BUILDDIR}/debian/control
> except for the PERLAPI one, all of these should be dropped / replaced:
> VERSION and PKGRELEASE come from debian/changelog
> ARCH comes via control and dpkg-architecture
> 
> whether the PERLAPI is really needed should probably be investigated.

It is needed, as "RADOS.so" only works with that perl Version - on of
the main reasons I have to recompile on Buster.

> 
>> +make DESTDIR=${BUILDDIR} install
>> +install -D -m 0644 copyright ${BUILDDIR}/${DOCDIR}/copyright
>> +install -m 0644 changelog.Debian ${BUILDDIR}/${DOCDIR}/
>> +gzip -9 -n ${BUILDDIR}/${DOCDIR}/changelog.Debian
> these four should not be needed (dpkg-buildpackage will call the
> Makefile to compile/build anyway, and sets DESTDIR correctly)
> 
> copyright and changelog are handled by the appropriate debhelpers
> 
>> +echo "git clone git://git.proxmox.com/git/librados2-perl.git\\ngit 
>> checkout ${GITVERSION}" > ${BUILDDIR}/${DOCDIR}/SOURCE
> this does not work as intended (debdiff says the SOURCE file is not
> contained after applying the patch)

Fixed, in V2




-- 
René Jochum
Mail: r...@jochums.at
Tel: +43 664 750 77 653
Web: https://rene.jochums.at
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH librados2-perl] Convert to dpkg-buildpackage

[Rene Jochum]

On 2018-04-19 10:16, Fabian Grünbichler wrote:
> some comments inline (your patch also only applies when ignoring
> whitespace changes!)


Hi Fabian,

thank you for looking into it! Can you give me a tip on making patches
that apply without ignoring white space changes?

Will implement all the given recommendations now.

Thanks,
René


___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH vncterm] Improve the .gitignore

[Rene Jochum]

This should be spiceterm.

On 2018-04-18 22:25, René Jochum wrote:
> Signed-off-by: René Jochum 
> ---
>  .gitignore | 5 -
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/.gitignore b/.gitignore
> index ca37680..bcae525 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,2 +1,5 @@
> -spiceterm
> +build/
> +*.deb
> +*.buildinfo
> +*.changes
> 
> --
> 2.17.0
> 
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Sending patches

[Rene Jochum]

> yes, but please send each patch as separate mail (in reply to the cover
> letter). 'git send-email' does the right thing, so I'd recommend just
> collecting all the patches ('git format-patch' with subjectprefix set
> correctly in each repository) into one directory, and then running
> 
> $ git send-email --annotate --to pve-devel@pve.proxmox.com 
> directory/with/patches
> 
> please make sure to include your "Signed-Off-By" lines, etc. pp.
> 
> see [1] for a similar patch series from me
> 
> 1: https://pve.proxmox.com/pipermail/pve-devel/2017-September/028860.html

Thanks for your reply Fabian,

I found a fix:

$ cd vncterm
$ git format-patch -o ../patches/ --subject-prefix="PATCH vncterm"
master..gitignore --cover-letter
$ cd ..
$ git format-patch --start-number=2 -o ../patches/
--subject-prefix="PATCH spiceterm" master..gitignore

^ see the "--start-number" parameter.

Thanks,
Rene
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] Sending patches

[Rene Jochum]

Hi,

I've read https://pve.proxmox.com/wiki/Developer_Documentation.

I would like to send ONE patch series for lots of packages where
i add/extend the .gitignore.

Is that possible?

Thanks,
René
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] pve-edk2-firmware and mirror_edk2

[Rene Jochum]

Hi,

while building my packages for Buster i found that both repos in the
Subject aren't exported.

I see those are pretty new, do they miss a "git-daemon-export-ok" or is
that indented?

Thanks,
René
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] Gitlab-ci

[Rene Jochum]

On 2018-04-17 10:27, Dietmar Maurer wrote:
> I personally think this adds much overhead and does not really help
> developing software. 
> 

Ok.
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] Gitlab-ci

[Rene Jochum]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Hi!

I've been working on Gitlab CI for Proxmox. In a dockerized environment
I'm now able to build the current 4.15 pve-kernel for Debian Buster and
Stretch.

The Stretch build: https://git.lxch.eu/git/pve-kernel/-/jobs/43
   https://git.lxch.eu/git/pve-kernel/-/jobs/43/artifacts/browse
The Buster build: https://git.lxch.eu/git/pve-kernel/-/jobs/41
  https://git.lxch.eu/git/pve-kernel/-/jobs/41/artifacts/browse

- From the current point it will be easy to add Support for all pve
packages, it will be a single ".gitlab-ci.yml" per repo:

https://git.lxch.eu/git/pve-kernel/blob/pve-kernel-4.15-ci/.gitlab-ci.ym
l


I've made some Dockerfiles for PVE (easy to add more for PMG). These
don't require the Docker HUB - so it will be able to build them
even when the hub goes down.

https://git.lxch.eu/git/pve-dockerfiles

Is that something Proxmox is interested in? If yes, I'll continue my
work on it.

At last i want to say that "Debian" moves to Gitlab and "Gnome" already
moved. ( https://salsa.debian.org/public ).

Kind regards,

René Jochum



-BEGIN PGP SIGNATURE-

iQIzBAEBCgAdFiEEGw01YDxPNy3/D8pOnoscMvXzGKkFAlrU/mgACgkQnoscMvXz
GKljNQ//eSPKowgnk/M6ipYD/3/lEjzqevXkoJO1N0EHiApSkWPWVniOBdxUJBl9
E9dGK4lwGcT/uarhMqcR/63HOWYeQMJxb60USyFDXB5AWy5/gOsmoqGdatW3wNnR
xOOgSDCh6haFUXTGg/+3l0xC3sq7kVYfNFz7Lw3epwQdUF0FR3bHl2mq16oqeiiu
fsVoSCKKWyHbjn77o6hiK9Zf3dOdnE8Dk96nBrSIJUKy3mBB87J4eTxukdxyMqJE
nn+5358ixFJvS9SW/k4i0ukxIs7X/Mn86IuGYrYWEKtTTiSFXuGpDObdmH0AdJMJ
q0bwsxtUGr57/+UgzZWkPI51j/4VxXD7DEZuuZIae5It335WD7cUqW1YBnLFMYKe
DJ3Amz9kHxVM8bLSAdsc3D2XZq/yn73rn1HapVuOWwVw668vbn5G9GL/8cWCALee
d3A9qiw2p0Np96neXKEoQbajjb2s4mVA9MgGf9AzUzA3IGShkfqoAXLkRIo0p3vU
YO+1eTE7jNy7wh9ovc1TrvGXlwBrsfsfpCzA4BkSm/6peIYZdAwkaR8spgwJGkDA
SZEZ0DR2dsWeAzgqlHRNICKCb4UyOdVZylrT+fxma0Px2lCGIIQnTvKsXpmHZn0S
LfnT5OV85iYKHuPopt7UpWjGLWOTVBIKRkLryol0hVFO2GfOlXY=
=yJHb
-END PGP SIGNATURE-
___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel