Re: [pve-devel] [PATCH] bug 597: hotplug fix

2015-02-10 Thread Dietmar Maurer 

applied, thanks!

On 02/10/2015 12:59 PM, Wolfgang Link wrote:

wrap params in dopple quotes, so spaces will accept.

Signed-off-by: Wolfgang Link 
---
  PVE/QemuServer.pm |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 556bbb7..59441e1 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3384,7 +3384,7 @@ sub qemu_driveadd {
  my ($storecfg, $vmid, $device) = @_;
  
  my $drive = print_drive_full($storecfg, $vmid, $device);

-my $ret = vm_human_monitor_command($vmid, "drive_add auto $drive");
+my $ret = vm_human_monitor_command($vmid, "drive_add auto \"$drive\"");
  
  # If the command succeeds qemu prints: "OK"

  return 1 if $ret =~ m/OK/s;



___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH] bug 597: hotplug fix

2015-02-10 Thread Wolfgang Link 
wrap params in dopple quotes, so spaces will accept.

Signed-off-by: Wolfgang Link 
---
 PVE/QemuServer.pm |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 556bbb7..59441e1 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3384,7 +3384,7 @@ sub qemu_driveadd {
 my ($storecfg, $vmid, $device) = @_;
 
 my $drive = print_drive_full($storecfg, $vmid, $device);
-my $ret = vm_human_monitor_command($vmid, "drive_add auto $drive");
+my $ret = vm_human_monitor_command($vmid, "drive_add auto \"$drive\"");
 
 # If the command succeeds qemu prints: "OK"
 return 1 if $ret =~ m/OK/s;
-- 
1.7.10.4


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH] bug 597: hotplug fix

2015-02-10 Thread Wolfgang Link 
wrap params in dopple quotes, so spaces will accept.

Signed-off-by: Wolfgang Link 
---
 PVE/QemuServer.pm |4 
 1 file changed, 4 insertions(+)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 7045c14..9b4e137 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4248,6 +4248,10 @@ sub vm_qmp_command {
 sub vm_human_monitor_command {
 my ($vmid, $cmdline) = @_;
 
+#This is necessary, so Human-Monitor accept spaces. 
+$cmdline =~ s/(file=rbd:)/\"$1/g;
+$cmdline .="\"";
+
 my $res;
 
 my $cmd = {
-- 
1.7.10.4


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel