Re: [pve-devel] [PATCH 1/3] remove dependcy to libpve-access-control

[Dietmar Maurer]

I think PVE::RESTEnvironment is (should be) an Abstract class, so I am
not sure if we can use it that way.

> On December 11, 2017 at 10:58 AM Dominik Csapak  wrote:
> 
> 
> and use PVE::RESTEnvironment instead of
> PVE::RPCEnvironment for setup_default_cli_env
> 
> Signed-off-by: Dominik Csapak 
> ---
>  src/PVE/CLI/termproxy.pm | 4 ++--
>  src/bin/termproxy| 2 --
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/src/PVE/CLI/termproxy.pm b/src/PVE/CLI/termproxy.pm
> index 3932f55..fc98976 100644
> --- a/src/PVE/CLI/termproxy.pm
> +++ b/src/PVE/CLI/termproxy.pm
> @@ -3,7 +3,7 @@ package PVE::CLI::termproxy;
>  use strict;
>  use warnings;
>  
> -use PVE::RPCEnvironment;
> +use PVE::RESTEnvironment;
>  use PVE::CLIHandler;
>  use PVE::JSONSchema qw(get_standard_option);
>  use PVE::PTY;
> @@ -18,7 +18,7 @@ use constant DEFAULT_PATH => '/';
>  use constant DEFAULT_PERM => 'Sys.Console';
>  
>  sub setup_environment {
> -PVE::RPCEnvironment->setup_default_cli_env();
> +PVE::RESTEnvironment->setup_default_cli_env();
>  }
>  
>  sub verify_ticket {
> diff --git a/src/bin/termproxy b/src/bin/termproxy
> index 6af56c6..a28bcd9 100755
> --- a/src/bin/termproxy
> +++ b/src/bin/termproxy
> @@ -3,8 +3,6 @@
>  use strict;
>  use warnings;
>  
> -use PVE::AccessControl;
> -
>  use PVE::CLI::termproxy;
>  
>  PVE::CLI::termproxy->run_cli_handler();
> -- 
> 2.11.0
> 
> 
> ___
> pve-devel mailing list
> pve-devel@pve.proxmox.com
> https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH 1/3] remove dependcy to libpve-access-control

[Dominik Csapak]

and use PVE::RESTEnvironment instead of
PVE::RPCEnvironment for setup_default_cli_env

Signed-off-by: Dominik Csapak 
---
 src/PVE/CLI/termproxy.pm | 4 ++--
 src/bin/termproxy| 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/PVE/CLI/termproxy.pm b/src/PVE/CLI/termproxy.pm
index 3932f55..fc98976 100644
--- a/src/PVE/CLI/termproxy.pm
+++ b/src/PVE/CLI/termproxy.pm
@@ -3,7 +3,7 @@ package PVE::CLI::termproxy;
 use strict;
 use warnings;
 
-use PVE::RPCEnvironment;
+use PVE::RESTEnvironment;
 use PVE::CLIHandler;
 use PVE::JSONSchema qw(get_standard_option);
 use PVE::PTY;
@@ -18,7 +18,7 @@ use constant DEFAULT_PATH => '/';
 use constant DEFAULT_PERM => 'Sys.Console';
 
 sub setup_environment {
-PVE::RPCEnvironment->setup_default_cli_env();
+PVE::RESTEnvironment->setup_default_cli_env();
 }
 
 sub verify_ticket {
diff --git a/src/bin/termproxy b/src/bin/termproxy
index 6af56c6..a28bcd9 100755
--- a/src/bin/termproxy
+++ b/src/bin/termproxy
@@ -3,8 +3,6 @@
 use strict;
 use warnings;
 
-use PVE::AccessControl;
-
 use PVE::CLI::termproxy;
 
 PVE::CLI::termproxy->run_cli_handler();
-- 
2.11.0


___
pve-devel mailing list
pve-devel@pve.proxmox.com
https://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel