[pve-devel] [PATCH pve-manager 1/3] Correct whitespaces and comment non obvious class properties

2015-11-17 Thread Emmanuel Kasper
---
 www/manager6/form/RealmComboBox.js | 8 +++-
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/www/manager6/form/RealmComboBox.js 
b/www/manager6/form/RealmComboBox.js
index 7e6700f..ce59422 100644
--- a/www/manager6/form/RealmComboBox.js
+++ b/www/manager6/form/RealmComboBox.js
@@ -20,15 +20,13 @@ Ext.define('PVE.form.RealmComboBox', {
}
 },
 stateEvents: [ 'select' ],
-stateful: true,
-id: 'pveloginrealm', // fixme: remove (Stateful does not work without)
+stateful: true, // last chosen auth realm is saved between page reloads
+id: 'pveloginrealm', // We need stable ids when using stateful, not 
autogenerated
 stateID: 'pveloginrealm',
 
 needOTP: function(realm) {
var me = this;
-
var rec = me.store.findRecord('realm', realm);
-
return rec && rec.data && rec.data.tfa ? rec.data.tfa : undefined;
 },
 
@@ -39,7 +37,7 @@ Ext.define('PVE.form.RealmComboBox', {
model: 'pve-domains',
});
 
-me.callParent();
+   me.callParent();
 
me.store.load({
callback: function(r, o, success) {
-- 
2.1.4


___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


Re: [pve-devel] [PATCH pve-manager 1/3] Correct whitespaces and comment non obvious class properties

2015-11-17 Thread Dietmar Maurer
applied

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel