Re: [pve-devel] zfs plugin improvements
After considerations I have come to the conclusion that this is intentional since the lock is controlled higher up in the chain of commands (QemuServer.pm). This is therefore no bug. I consider the waiting patches ready for inclusion. Please can you send me the exactly list of patches (what exactly is ready for inclusion)? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] zfs plugin improvements
On Sat, 17 May 2014 07:31:16 + Dietmar Maurer diet...@proxmox.com wrote: Please can you send me the exactly list of patches (what exactly is ready for inclusion)? This are the patches ready for inclusion: commit b3a716fa613391dc54244f7a894088de36b6a303 commit b006779d458cd48a2eca94313689aab29fd96cc7 commit 85783ec48967e2fbf2c027b3af5da104a70f commit e9dcc3be6896c6673c3d8733f4f7ea1e5091d7a7 commit 5da23bad9844adfb61d3c093d08bf89eef86aadc commit 082e79f35b2f7b75862dc3014fb7de8e65fa76c6 All patches courtesy of Chris Allen. -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael at rasmussen dot cc http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xD3C9A00E mir at datanom dot net http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE501F51C mir at miras dot org http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE3E80917 -- /usr/games/fortune -es says: All things are possible, except for skiing through a revolving door. signature.asc Description: PGP signature ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] zfs plugin improvements
On Mon, 12 May 2014 01:09:38 +0200 Michael Rasmussen m...@datanom.net wrote: commit b3a716fa613391dc54244f7a894088de36b6a303: snapshot recent-both I have tested this patch and have discovered a bug. If the user makes a rollback which trigger the patch's test to not allow to make a rollback if a more recent snapshot exists the vm will be left in a locked state effectively blocking all further interaction with vm until running qm unlock from cli. I will provide a patch later this evening. -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael at rasmussen dot cc http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xD3C9A00E mir at datanom dot net http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE501F51C mir at miras dot org http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE3E80917 -- /usr/games/fortune -es says: NOWPRINT. NOWPRINT. Clemclone, back to the shadows again. -- The Firesign Theater signature.asc Description: PGP signature ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] zfs plugin improvements
On Fri, 16 May 2014 20:25:41 +0200 Michael Rasmussen m...@datanom.net wrote: On Mon, 12 May 2014 01:09:38 +0200 Michael Rasmussen m...@datanom.net wrote: commit b3a716fa613391dc54244f7a894088de36b6a303: snapshot recent-both I have tested this patch and have discovered a bug. If the user makes a rollback which trigger the patch's test to not allow to make a rollback if a more recent snapshot exists the vm will be left in a locked state effectively blocking all further interaction with vm until running qm unlock from cli. I will provide a patch later this evening. After considerations I have come to the conclusion that this is intentional since the lock is controlled higher up in the chain of commands (QemuServer.pm). This is therefore no bug. I consider the waiting patches ready for inclusion. -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael at rasmussen dot cc http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xD3C9A00E mir at datanom dot net http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE501F51C mir at miras dot org http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE3E80917 -- /usr/games/fortune -es says: I can't decide whether to commit suicide or go bowling. -- Florence Henderson signature.asc Description: PGP signature ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] zfs plugin improvements
On Fri, 9 May 2014 02:16:18 +0200 Michael Rasmussen m...@datanom.net wrote: The following remains to be tested: commit 5da23bad9844adfb61d3c093d08bf89eef86aadc: nowritecache-comstar commit 082e79f35b2f7b75862dc3014fb7de8e65fa76c6: sparse volumes-comstar,iet Above tested and no errors found. commit b006779d458cd48a2eca94313689aab29fd96cc7: tg and hg-comstar Above tested and found working provided a patch is added to the kvm command. See other mail. commit b3a716fa613391dc54244f7a894088de36b6a303: snapshot recent-both Remains to be tested. Sparse volume, nowritecache and th/hg options needs to be added to the Panel (GUI). When testing is done I will do this. One question: Can an option be enabled/disabled in the Panel depending on the value of a text box? If yes, how to implement? provider = comstar = sparse, nowritecache, target group, and host group enabled provider = istgt = sparse and nowritecache enabled. target group, and host group disabled provider = iet = sparse enabled. nowritecache, target group, and host group disabled I still would like help on the above. -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael at rasmussen dot cc http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xD3C9A00E mir at datanom dot net http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE501F51C mir at miras dot org http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE3E80917 -- /usr/games/fortune -es says: I'd love to go out with you, but I'm attending the opening of my garage door. signature.asc Description: PGP signature ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] zfs plugin improvements
One question: Can an option be enabled/disabled in the Panel depending on the value of a text box? If yes, how to implement? provider = comstar = sparse, nowritecache, target group, and host group enabled provider = istgt = sparse and nowritecache enabled. target group, and host group disabled provider = iet = sparse enabled. nowritecache, target group, and host group disabled I still would like help on the above. if .. then ;-) But I guess that needs some ExtJS knowledge. I can work on that as soon as the code is available in the CLI. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] zfs plugin improvements
Hi, it could be great to add option for compression enable|disable by volume :) (can be done live) - Mail original - De: Dietmar Maurer diet...@proxmox.com À: Michael Rasmussen m...@datanom.net, pve-devel@pve.proxmox.com Envoyé: Lundi 12 Mai 2014 05:52:03 Objet: Re: [pve-devel] zfs plugin improvements One question: Can an option be enabled/disabled in the Panel depending on the value of a text box? If yes, how to implement? provider = comstar = sparse, nowritecache, target group, and host group enabled provider = istgt = sparse and nowritecache enabled. target group, and host group disabled provider = iet = sparse enabled. nowritecache, target group, and host group disabled I still would like help on the above. if .. then ;-) But I guess that needs some ExtJS knowledge. I can work on that as soon as the code is available in the CLI. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] zfs plugin improvements
On Tue, 6 May 2014 05:54:43 + Dietmar Maurer diet...@proxmox.com wrote: Thanks, that would be great. I don't really want to commit things to the ZFS plugin without prior acknowledge from you or Alexandre. I have tested the following commits on FreeBSD (Istgt): commit 082e79f35b2f7b75862dc3014fb7de8e65fa76c6: sparse volumes. commit 5da23bad9844adfb61d3c093d08bf89eef86aadc: nowritecache. commit e9dcc3be6896c6673c3d8733f4f7ea1e5091d7a7: csh changes. commit 85783ec48967e2fbf2c027b3af5da104a70f: LUN Options. No errors found. The following remains to be tested: commit 5da23bad9844adfb61d3c093d08bf89eef86aadc: nowritecache-comstar commit 082e79f35b2f7b75862dc3014fb7de8e65fa76c6: sparse volumes-comstar,iet commit b006779d458cd48a2eca94313689aab29fd96cc7: tg and hg-comstar commit b3a716fa613391dc54244f7a894088de36b6a303: snapshot recent-both Sparse volume, nowritecache and th/hg options needs to be added to the Panel (GUI). When testing is done I will do this. One question: Can an option be enabled/disabled in the Panel depending on the value of a text box? If yes, how to implement? provider = comstar = sparse, nowritecache, target group, and host group enabled provider = istgt = sparse and nowritecache enabled. target group, and host group disabled provider = iet = sparse enabled. nowritecache, target group, and host group disabled -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael at rasmussen dot cc http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xD3C9A00E mir at datanom dot net http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE501F51C mir at miras dot org http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE3E80917 -- /usr/games/fortune -es says: [Sir Stafford Cripps] has all the virtues I dislike and none of the vices I admire. -- Winston Churchill signature.asc Description: PGP signature ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
[pve-devel] zfs plugin improvements
Hi, I would like to make the following improvements to the zfs plugin. I would appreciate any comments: 1. add a parameter to storage.cfg called sparse which would create sparse zvols if set to true. This can default to false for compatibility with the current version 2. add SRP support. I was thinking SRP could be added as a separate iscsiprovider even though the protocol is not actually iSCSI. SRP is SCSI RDMA Protocol which is supported by Infiniband hardware (and some 10G Ethernet adapters). We're currently running an Infiniband network for storage and using iSCSI over IP over Infiniband which degrades performance. I've tested SRP on our network and it has at least 100% improvement over the current solution. Best regards, Adrian Costin ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] zfs plugin improvements
On Mon, 5 May 2014 20:56:32 +0300 Adrian Costin adrian.cos...@gmail.com wrote: 1. add a parameter to storage.cfg called sparse which would create sparse zvols if set to true. This can default to false for compatibility with the current version Already in git: commit 082e79f35b2f7b75862dc3014fb7de8e65fa76c6 Author: Chris Allen ca.al...@gmail.com Date: Fri Feb 28 23:56:02 2014 -0800 Added sparse zvol support to ZFS. To enable, add sparse to the ZFS storage section, you wish to use it on, in /etc/pve/storage. Signed-off-by: Chris Allen Chris Allen 2. add SRP support. I don't have such hardware so others must step in here. -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael at rasmussen dot cc http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xD3C9A00E mir at datanom dot net http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE501F51C mir at miras dot org http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE3E80917 -- /usr/games/fortune -es says: The optimum committee has no members. -- Norman Augustine signature.asc Description: PGP signature ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] zfs plugin improvements
Already in git: commit 082e79f35b2f7b75862dc3014fb7de8e65fa76c6 Sorry, I didn't see if. It's not visible here: https://git.proxmox.com/?p=pve-storage.git;a=summary Best regards, Adrian Costin ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] zfs plugin improvements
On Mon, 5 May 2014 21:26:41 +0300 Adrian Costin adrian.cos...@gmail.com wrote: Sorry, I didn't see if. It's not visible here: https://git.proxmox.com/?p=pve-storage.git;a=summary Strange. Seems al these are missing? git log commit b3a716fa613391dc54244f7a894088de36b6a303 Author: Chris Allen Chris Allen Date: Tue Mar 11 17:32:17 2014 -0700 Added code to abort a snapshot rollback in ZFS if the snapshot selected is not the most recent. This is to avoid lu deletion when trying to rollback to a snapshot that isn't the newest. Signed-off-by: Chris Allen Chris Allen commit b006779d458cd48a2eca94313689aab29fd96cc7 Author: Chris Allen Chris Allen Date: Tue Mar 11 15:07:53 2014 -0700 Added target-group and host-group options for ZFS comstar views. Use comstar_tg and comstar_hg in /etc/pve/storage.pm. Signed-off-by: Chris Allen Chris Allen commit 85783ec48967e2fbf2c027b3af5da104a70f Author: Chris Allen Chris Allen Date: Tue Mar 11 10:46:24 2014 -0700 Fixed Istgt LUN Options handling. Signed-off-by: Chris Allen Chris Allen commit e9dcc3be6896c6673c3d8733f4f7ea1e5091d7a7 Author: Chris Allen Chris Allen Date: Mon Mar 10 13:06:09 2014 -0700 Fixed command substitution and output redirection in Istgt module to work in csh - the default shell in FreeBSD. Changed Istgt restart to onerestart. This way a running istgt daemon will always restart whether or not it is enabled Signed-off-by: Chris Allen Chris Allen commit 5da23bad9844adfb61d3c093d08bf89eef86aadc Author: Chris Allen Chris Allen Date: Mon Mar 10 12:07:35 2014 -0700 Added nowritecache option to ZFS storage plugin. Turns off write caching on Comstar and Istgt LUNs created by the plugin. Has no effect on IET, as IET always uses write-through caching for blockio volumes not in read-only mode. Signed-off-by: Chris Allen Chris Allen commit 082e79f35b2f7b75862dc3014fb7de8e65fa76c6 Author: Chris Allen ca.al...@gmail.com Date: Fri Feb 28 23:56:02 2014 -0800 Added sparse zvol support to ZFS. To enable, add sparse to the ZFS storage section, you wish to use it on, in /etc/pve/storage.pm Signed-off-by: Chris Allen Chris Allen -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael at rasmussen dot cc http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xD3C9A00E mir at datanom dot net http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE501F51C mir at miras dot org http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE3E80917 -- /usr/games/fortune -es says: Ok, I'm just uploading the new version of the kernel, v1.3.33, also known as the buggiest kernel ever. -- Linus Torvalds signature.asc Description: PGP signature ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] zfs plugin improvements
On Tue, 6 May 2014 04:25:11 + Dietmar Maurer diet...@proxmox.com wrote: Did you already test those patches? No (I might have forgotten about there existents;-). I intend to do it the coming days. -- Hilsen/Regards Michael Rasmussen Get my public GnuPG keys: michael at rasmussen dot cc http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xD3C9A00E mir at datanom dot net http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE501F51C mir at miras dot org http://pgp.mit.edu:11371/pks/lookup?op=getsearch=0xE3E80917 -- /usr/games/fortune -es says: The only intuitive interface is the nipple. After that, it's all learned. (Bruce Ediger, bedi...@teal.csn.org, in comp.os.linux.misc, on X interfaces.) signature.asc Description: PGP signature ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] zfs plugin improvements
Did you already test those patches? No (I might have forgotten about there existents;-). I intend to do it the coming days. Thanks, that would be great. I don't really want to commit things to the ZFS plugin without prior acknowledge from you or Alexandre. ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
