Re: [pve-devel] [PATCH] zfs: auto import after reboot

2015-02-09 Thread Dietmar Maurer 

On 02/03/2015 12:59 PM, Wolfgang Link wrote:

@@ -419,6 +419,14 @@ sub volume_snapshot_rollback {
  
  sub activate_storage {

  my ($class, $storeid, $scfg, $cache) = @_;
+
+my @param = ('-o', 'name', '-H');
+
+my $text = zfs_request($class, $scfg, undef, 'zpool_list', @param);
+
+if ($text !~ $scfg-{pool}) {
+   run_command(zpool import -d /dev/disk/by-id/ -a);
+}
  return 1;
  }
  


activate_storage is inherted by ZFSPlugin, so we cannot do that! So please
overwrite it inside ZFSPlugin.pm.
 




___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH] zfs: auto import after reboot

2015-02-09 Thread Dietmar Maurer 

On 02/09/2015 12:24 PM, Wolfgang Link wrote:

ctivate_storage is inherted by ZFSPlugin, so we cannot do that! So please

overwrite it inside ZFSPlugin.pm.



ahead in this patch I override it in ZFSPlugin.pm


Sorry, you are correct! I just applied your patch.

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH] zfs: auto import after reboot

2015-02-09 Thread Wolfgang Link 


On 02/09/2015 12:07 PM, Dietmar Maurer wrote:

On 02/03/2015 12:59 PM, Wolfgang Link wrote:

@@ -419,6 +419,14 @@ sub volume_snapshot_rollback {
sub activate_storage {
  my ($class, $storeid, $scfg, $cache) = @_;
+
+my @param = ('-o', 'name', '-H');
+
+my $text = zfs_request($class, $scfg, undef, 'zpool_list', @param);
+
+if ($text !~ $scfg-{pool}) {
+run_command(zpool import -d /dev/disk/by-id/ -a);
+}
  return 1;
  }


activate_storage is inherted by ZFSPlugin, so we cannot do that! So 
please

overwrite it inside ZFSPlugin.pm.



ahead in this patch I override it in ZFSPlugin.pm

Is this wrong?

___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel