Re: [pve-devel] move iothread option from global to disk
I would like also to keep iothread option to drive, to enable or not
iothread,
even if we choose scsihw: virtio-scsi-(multi|single).
multiqueue option will be added also to this scsihw:
virtio-scsi-(multi|single).
we could allow iothread,multiqueue for scsihw: virtio-scsi-pci or
virtio-scsi-(multi|single),
the only difference is that virtio-scsi-(multi|single) give us a maxdev=1 ,
instead 256.
Like this it can be really clean.
- Mail original -
De: aderumier aderum...@odiso.com
À: dietmar diet...@proxmox.com
Cc: pve-devel pve-devel@pve.proxmox.com
Envoyé: Mercredi 25 Mars 2015 08:12:54
Objet: Re: [pve-devel] move iothread option from global to disk
We slowly run out of free PCI slots ...
So if we add this patch, we need a way to add another pci bus - any idea?
I don't known if we can add a new bridge on top of another bridge (instead on
top of root bridge).
Another possibility, if scsihw: virtio-scsi-multi , we don't need
scsihw0 = { bus = 0, addr = 5 },
scsihw1 = { bus = 0, addr = 6 },
So, we can reuse them to plug a dedicated bridge with only virtio-scsi-multi
controllers
And I think it is maybe better to have different scsihw types:
scsihw: virtio-scsi-pci # what we have now
scsihw: virtio-scsi-multi # one io-thread per drive
I guess that would make hotplug code simpler?
yes, it'll make the code a lot more clean.
But maybe virtio-scsi-multi name is confusing ? because we have only 1 disk
by controller.
maybe virtio-scsi-single
I would like also to keep iothread option to drive, to enable or not iothread,
even if we choose scsihw: virtio-scsi-(multi|single).
multiqueue option will be added also to this scsihw:
virtio-scsi-(multi|single).
- Mail original -
De: dietmar diet...@proxmox.com
À: aderumier aderum...@odiso.com
Cc: pve-devel pve-devel@pve.proxmox.com
Envoyé: Mercredi 25 Mars 2015 07:18:56
Objet: Re: [pve-devel] move iothread option from global to disk
(You can plug 256 drives on 1 controller,
so with 1disk by controller, I only manage 14 drives (which is the limit of
gui currently))
We slowly run out of free PCI slots ...
So if we add this patch, we need a way to add another pci bus - any idea?
And I think it is maybe better to have different scsihw types:
scsihw: virtio-scsi-pci # what we have now
scsihw: virtio-scsi-multi # one io-thread per drive
I guess that would make hotplug code simpler?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] move iothread option from global to disk
(You can plug 256 drives on 1 controller, so with 1disk by controller, I only manage 14 drives (which is the limit of gui currently)) We slowly run out of free PCI slots ... So if we add this patch, we need a way to add another pci bus - any idea? And I think it is maybe better to have different scsihw types: scsihw: virtio-scsi-pci # what we have now scsihw: virtio-scsi-multi # one io-thread per drive I guess that would make hotplug code simpler? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] move iothread option from global to disk
And I think it is maybe better to have different scsihw types: Maybe better to always have thread by contoller and ability to manually add controllers. And selection to which controller to connect each drive. Like: scsihw0: virtio-scsi-pci scsihw1: megaraid scsi0: X,controller=0 scsi1: X,controller=0 scsi3: X,controller=1 # What for? Why would someone want slow megaraid if virtio-scsi works? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] move iothread option from global to disk
Another possibility, if scsihw: virtio-scsi-multi , we don't need
scsihw0 = { bus = 0, addr = 5 },
scsihw1 = { bus = 0, addr = 6 },
So, we can reuse them to plug a dedicated bridge with only virtio-scsi-multi
controllers
Ah yes - that is what I am looking for ;-) Please can you adopt the patch?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] move iothread option from global to disk
25.03.2015 09:18, Dietmar Maurer пишет: (You can plug 256 drives on 1 controller, so with 1disk by controller, I only manage 14 drives (which is the limit of gui currently)) We slowly run out of free PCI slots ... So if we add this patch, we need a way to add another pci bus - any idea? And I think it is maybe better to have different scsihw types: Maybe better to always have thread by contoller and ability to manually add controllers. And selection to which controller to connect each drive. Like: scsihw0: virtio-scsi-pci scsihw1: megaraid scsi0: X,controller=0 scsi1: X,controller=0 scsi3: X,controller=1 ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] move iothread option from global to disk
yes, it'll make the code a lot more clean. But maybe virtio-scsi-multi name is confusing ? because we have only 1 disk by controller. maybe virtio-scsi-single I would like also to keep iothread option to drive, to enable or not iothread, even if we choose scsihw: virtio-scsi-(multi|single). multiqueue option will be added also to this scsihw: virtio-scsi-(multi|single). OK ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] move iothread option from global to disk
25.03.2015 11:09, Dietmar Maurer пишет: And I think it is maybe better to have different scsihw types: Maybe better to always have thread by contoller and ability to manually add controllers. And selection to which controller to connect each drive. Like: scsihw0: virtio-scsi-pci scsihw1: megaraid scsi0: X,controller=0 scsi1: X,controller=0 scsi3: X,controller=1 # What for? Why would someone want slow megaraid if virtio-scsi works? It's just an example. Maybe something like this (all controllers are same): scsihw: virtio-scsi-pci scsinum: 2 scsi0: X,controller=0 scsi1: X,controller=0 scsi3: X,controller=1 ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] move iothread option from global to disk
Ah yes - that is what I am looking for ;-) Please can you adopt the patch?
I'll try to send a patch tomorrow
- Mail original -
De: dietmar diet...@proxmox.com
À: aderumier aderum...@odiso.com
Cc: pve-devel pve-devel@pve.proxmox.com
Envoyé: Mercredi 25 Mars 2015 08:28:01
Objet: Re: [pve-devel] move iothread option from global to disk
Another possibility, if scsihw: virtio-scsi-multi , we don't need
scsihw0 = { bus = 0, addr = 5 },
scsihw1 = { bus = 0, addr = 6 },
So, we can reuse them to plug a dedicated bridge with only virtio-scsi-multi
controllers
Ah yes - that is what I am looking for ;-) Please can you adopt the patch?
___
pve-devel mailing list
pve-devel@pve.proxmox.com
http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] move iothread option from global to disk
Hi, I this really a good idea? do you think it's a bad idea ? ;) Have 1 iothread by disk is really needed. Now, keeping the iothread option globally can work too. (with pending section, it's not a problem) Maybe user want to enable or disable it specificaly for a drive. - Mail original - De: dietmar diet...@proxmox.com À: aderumier aderum...@odiso.com, pve-devel pve-devel@pve.proxmox.com Envoyé: Mardi 24 Mars 2015 06:40:30 Objet: Re: [pve-devel] move iothread option from global to disk I this really a good idea? On March 19, 2015 at 11:06 AM Alexandre Derumier aderum...@odiso.com wrote: This patches serie move the iothread global option, to disk option. Currently on virtio-blk (virtio-scsi will come in a next patch series). Now, we have 1 iothread by disk, which improve performance. (I was able to reach 3x4iops with 3 virtio disks with rbd) ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] move iothread option from global to disk
What are the disadvantages of having multiple virtio-scsi controller? I think it's only the number limit of pci slots. (You can plug 256 drives on 1 controller, so with 1disk by controller, I only manage 14 drives (which is the limit of gui currently)) - Mail original - De: dietmar diet...@proxmox.com À: aderumier aderum...@odiso.com Cc: pve-devel pve-devel@pve.proxmox.com Envoyé: Mardi 24 Mars 2015 12:42:19 Objet: Re: [pve-devel] move iothread option from global to disk Do you mean about 1 virtio-scsi controller by disk ? yes, that one. I don't see any roadmap on qemu mailing about having iothread by disk. (same for multiqueue) This is the same for virtio-blk, but we have only 1disk by virtio-blk controller. What are the disadvantages of having multiple virtio-scsi controller? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] move iothread option from global to disk
I this really a good idea? do you think it's a bad idea ? ;) Have 1 iothread by disk is really needed. Now, keeping the iothread option globally can work too. (with pending section, it's not a problem) Maybe user want to enable or disable it specificaly for a drive. sorry -yes, this patch is OK for me! I meant the other patch: qemu-server : virtio-scsi iothreads looks like a hack to me? ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] move iothread option from global to disk
I this really a good idea? On March 19, 2015 at 11:06 AM Alexandre Derumier aderum...@odiso.com wrote: This patches serie move the iothread global option, to disk option. Currently on virtio-blk (virtio-scsi will come in a next patch series). Now, we have 1 iothread by disk, which improve performance. (I was able to reach 3x4iops with 3 virtio disks with rbd) ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Re: [pve-devel] move iothread option from global to disk
applied, thanks! ___ pve-devel mailing list pve-devel@pve.proxmox.com http://pve.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
