Re: [PyGreSQL] [PATCH] PQresultMemorySize
On Sat, Mar 28, 2020 at 07:14:23PM +0100, Christoph Zwerschke wrote: > Am 28.03.2020 um 18:56 schrieb Justin Pryzby: > > Maybe that should be --with-ssl-info ? I found this: > > Not sure about that. In the context of setup.py and negative_opt, I only see > the 'no-' pattern being followed. Also, this is backward compatible. Okay. Better to be backwards compatible with itself than compatible with something else. -- Justin ___ PyGreSQL mailing list PyGreSQL@Vex.Net https://mail.vex.net/mailman/listinfo/pygresql
Re: [PyGreSQL] [PATCH] PQresultMemorySize
Am 28.03.2020 um 18:56 schrieb Justin Pryzby: > Maybe that should be --with-ssl-info ? I found this: Not sure about that. In the context of setup.py and negative_opt, I only see the 'no-' pattern being followed. Also, this is backward compatible. -- Christoph ___ PyGreSQL mailing list PyGreSQL@Vex.Net https://mail.vex.net/mailman/listinfo/pygresql
Re: [PyGreSQL] [PATCH] PQresultMemorySize
On Sat, Mar 28, 2020 at 06:24:12PM +0100, Christoph Zwerschke wrote: > Am 28.03.2020 um 16:21 schrieb Justin Pryzby: > > Also, you have every option defaulting to try, with the only consequence of > > an > > unsupported PG version being a warning. I mentioned that packages (at > > least in > > the past for Debian) were encouraged to compile with --enable-foo > > --enable-bar.. > > ..such that a packages that was *expected* to compile again libfoo would > > fail > > loudly at the compile stage if it wasn't there or was somehow broken. > > Thanks for the quick feedback, Justin. > > I have addressed both of your points in > https://github.com/PyGreSQL/PyGreSQL/commit/03858234c9077ea7e492a4bbd0664b9fad74b70d python setup.py build_ext --ssl-info Maybe that should be --with-ssl-info ? I found this: https://sourceware.org/autobook/autobook/autobook_14.html |Using ‘--with-package=no’ is synonymous with ‘--without-package’ which is described below. -- Justin ___ PyGreSQL mailing list PyGreSQL@Vex.Net https://mail.vex.net/mailman/listinfo/pygresql
Re: [PyGreSQL] [PATCH] PQresultMemorySize
Am 28.03.2020 um 16:21 schrieb Justin Pryzby: Also, you have every option defaulting to try, with the only consequence of an unsupported PG version being a warning. I mentioned that packages (at least in the past for Debian) were encouraged to compile with --enable-foo --enable-bar.. ..such that a packages that was *expected* to compile again libfoo would fail loudly at the compile stage if it wasn't there or was somehow broken. Thanks for the quick feedback, Justin. I have addressed both of your points in https://github.com/PyGreSQL/PyGreSQL/commit/03858234c9077ea7e492a4bbd0664b9fad74b70d Better? -- Christoph ___ PyGreSQL mailing list PyGreSQL@Vex.Net https://mail.vex.net/mailman/listinfo/pygresql
Re: [PyGreSQL] [PATCH] PQresultMemorySize
On Sat, Mar 28, 2020 at 03:50:57PM +0100, Christoph Zwerschke wrote: > Ok, I found that distutils even has a way to define "negative" options and > used it in setup.py now: > > Please have a look at: > https://github.com/PyGreSQL/PyGreSQL/commit/4b88231afd6bdfb40dca20780cdf006fe2346ea8 +self.escaping_funcs = True +self.ssl_info = True + If the installed PostgreSQL version does not support some features, you will + see a warning during installation, and these feature will not be enabled, so ... => I would change "during installation" to "during setup.py build phase" or something. To me, "installation" reads as "installing a binary package". Also, you have every option defaulting to try, with the only consequence of an unsupported PG version being a warning. I mentioned that packages (at least in the past for Debian) were encouraged to compile with --enable-foo --enable-bar.. ..such that a packages that was *expected* to compile again libfoo would fail loudly at the compile stage if it wasn't there or was somehow broken. -- Justin ___ PyGreSQL mailing list PyGreSQL@Vex.Net https://mail.vex.net/mailman/listinfo/pygresql
Re: [PyGreSQL] [PATCH] PQresultMemorySize
Ok, I found that distutils even has a way to define "negative" options and used it in setup.py now: Please have a look at: https://github.com/PyGreSQL/PyGreSQL/commit/4b88231afd6bdfb40dca20780cdf006fe2346ea8 Let me know what you think about this change. -- Christoph ___ PyGreSQL mailing list PyGreSQL@Vex.Net https://mail.vex.net/mailman/listinfo/pygresql
