On Thu, 10 Nov 2022, Benjamin Trent wrote:
Hey y'all,
I am new to this type of workflow, I am used to github and Pull-requests.
What is the process for adding a new extension point? With a recent foray
into getting Lucene KNN into the ann-benchmarks repository, I found the
need to adjust the current codec (Lucene94Codec) to allow us to adjust some
values.
I think the extension will only need to allow us to optionally override the
`getFormat...ForField` parameters.
Technically:
- see how it's done by looking at the code tree in PyLucene's extensions
directory tree where the native extension points are defined and add
yours there - then see how they're used in PyLucene's Python unit tests
where the actual extension points are implemented in Python
Procedurally (assuming you want your change maintained in the PyLucene code
base):
- explain the benefits for it to be part of the PyLucene codebase and
how it'll be maintained as Lucene's codebase evolves
- open an issue on Jira [1] and attach a patch or send the code changes as
a patch file to the list directly
Andi..
[1]
https://issues.apache.org/jira/projects/PYLUCENE/issues/PYLUCENE-28?filter=allopenissues
