[issue3492] Zlib compress/decompress functions returning bytearray

[Anand B Pillai]

Anand B Pillai <[EMAIL PROTECTED]> added the comment:

On Thu, Sep 4, 2008 at 4:59 PM, Amaury Forgeot d'Arc
<[EMAIL PROTECTED]> wrote:
>
> Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:
>
> Two remarks:
> 1. Some functions in Modules/zipimport.c (get_data) will now receive
> PyBytes, but zipimporter_get_source handle them as PyByteArray. Does
> zipimport still work at all with this patch?
>
> 2. There are other places where PyString_FromString was (incorrectly
> IMO) replaced with PyByteArray_FromString:
> - Modules/_dbmmodule.c
> - Modules/mmapmodule.c
> - Modules/ossaudiodev.c
> - Modules/zipimport.c (as noted above)
> - PC/winreg.c
> - Python/marshal.c

Hmmm...but AFAIK zlib changes only affect zipimport directly. I wonder
whether these other instances have bugs reported and are being tracked
for the release.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3492] Zlib compress/decompress functions returning bytearray

[Anand B Pillai]

Anand B Pillai <[EMAIL PROTECTED]> added the comment:

Does py3k list/barry have this bug in their radar for rc2 ?

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3783] dbm.sqlite proof of concept

[Skip Montanaro]

Changes by Skip Montanaro <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file11385/sqlite.py

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3783] dbm.sqlite proof of concept

[Skip Montanaro]

Changes by Skip Montanaro <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file11384/test_dbm_sqlite.py

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3783] dbm.sqlite proof of concept

[Skip Montanaro]

Skip Montanaro <[EMAIL PROTECTED]> added the comment:

Updated test cases

Added file: http://bugs.python.org/file11388/test_dbm_sqlite.py

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3783] dbm.sqlite proof of concept

[Skip Montanaro]

Skip Montanaro <[EMAIL PROTECTED]> added the comment:

Another tweak - add values()

Added file: http://bugs.python.org/file11387/sqlite.py

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3783] dbm.sqlite proof of concept

[Skip Montanaro]

Skip Montanaro <[EMAIL PROTECTED]> added the comment:

Trivial doc diffs against 3.0b3 doc.

Added file: http://bugs.python.org/file11386/dbm.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3783] dbm.sqlite proof of concept

[Skip Montanaro]

Changes by Skip Montanaro <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file11383/sqlite.py

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3783] dbm.sqlite proof of concept

[Skip Montanaro]

Skip Montanaro <[EMAIL PROTECTED]> added the comment:

Another slight revision to the module.

Added file: http://bugs.python.org/file11385/sqlite.py

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3783] dbm.sqlite proof of concept

[Skip Montanaro]

Skip Montanaro <[EMAIL PROTECTED]> added the comment:

Attaching test cases based on dumbdbm tests.

Added file: http://bugs.python.org/file11384/test_dbm_sqlite.py

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3783] dbm.sqlite proof of concept

[Skip Montanaro]

Changes by Skip Montanaro <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file11380/sqlite.py

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3783] dbm.sqlite proof of concept

[Skip Montanaro]

Skip Montanaro <[EMAIL PROTECTED]> added the comment:

Attaching corrected module.

Added file: http://bugs.python.org/file11383/sqlite.py

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3781] warnings.catch_warnings fails gracelessly when recording warnings but no warnings are emitted

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

The attached patch has WarningsRecorder raise AttributeError when there
is no recorded attribute and yet one tries to access warnings attributes.

And just so you know, JP, make sure to use keyword arguments when
calling catch_warnings() (in case you didn't notice the note in the
docs). In Py3K they are keyword-only.

--
assignee: brett.cannon -> 
keywords: +needs review, patch
Added file: http://bugs.python.org/file11382/catch_warnings_atts.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3781] warnings.catch_warnings fails gracelessly when recording warnings but no warnings are emitted

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

There is no specific reason why it would be, although that is an option
as well. Part of the problem with None is that it is a legitimate
default value for some arguments to showwarning() so it doesn't
necessarily reflect that no exception was raised if you don't look at
key attributes.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3780] No way to write unit tests for warnings

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

On Thu, Sep 4, 2008 at 4:18 PM, Glyph Lefkowitz <[EMAIL PROTECTED]> wrote:
>
> Glyph Lefkowitz <[EMAIL PROTECTED]> added the comment:
>
> The use of the term "filter" is pretty confusing.  I would normally say
> it was just me, but a bunch of other Twisted hackers seemed to interpret
> it the same way: a "filter" is something that has an opportunity to
> remove something else.  For example, the python builtin function
> "filter".  Experimentation with the filters list seems to confirm this
> impression, since later filters do not have an opportunity to access the
> warnings that earlier filters have removed.  The intuitive leap there is
> to assume that inserting a filter at the head of the list won't do
> anything different than inserting it at the tail, since a later filter
> will remove it.
>

OK, so you were thinking of the filter list in a functional sense
where exceptions are passed down the chain to each filter rule instead
of a bunch of tests that stop checking once one of the rules applies.

> I can't think of an obvious recommendation to improve the text for the
> filter system itself, because upon reading it in more depth, it's fairly
> clear.  Maybe the heading could be changed to something more like
> "intercepting warnings" or "controlling the way that warnings are
> emitted"?  Something attention-grabbing that describes its purpose and
> doesn't use the word "filter".  Even a sub-heading which simply
> described how to use 'always'   filter to cause every warning to be
> emitted would be helpful.
>

OK.

> The biggest improvement to the documentation for "catch_warnings" would
> be to put it in a section of its own, "How To Test Your Code Which Uses
> Warnings", not as a footnote in "Available Classes".
>

Fair enough.

> (Also, as a minor note to be taken at your discretion: should
> catch_warnings be named PEP 8 style as a class, since it is one?  I
> don't really want to open that can of worms after reading the
> interminable threading.Event thread, but it seemed worth saying as long
> as was talking about this...)

It's partially historical since test.test_support.catch_warning() is a
context manager created from a generator. But it's also because I want
to have the option to change the context manager in the future if the
bootstrapping reasons that led to it being a class can go away. I
should probably change the section title to "Available Context
Managers" so people don't start making assumptions.

-Brett

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3660] reference leaks in 3.0

[Neal Norwitz]

Neal Norwitz <[EMAIL PROTECTED]> added the comment:

The only one that is probably an issue based on Antoine's info is:

test_unicode leaked [1, 1] references, sum=2

I've seen test_urllib2_localnet leak 3 before.  I don't know that it's
a real leak.  I'm pretty sure it is not a regression though.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3660] reference leaks in 3.0

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

Numbers for the current py3k branch (without encode-leak2.patch):

test_distutils leaked [141, 142] references, sum=283
test_docxmlrpc leaked [-7, -85] references, sum=-92
test_logging leaked [0, 219] references, sum=219
test_poplib leaked [0, 84] references, sum=84
test_sys leaked [0, 34] references, sum=34
test_unicode leaked [1, 1] references, sum=2
test_urllib2_localnet leaked [3, 3] references, sum=6
test_xmlrpc leaked [192, -190] references, sum=2

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3492] Zlib compress/decompress functions returning bytearray

[Gregory P. Smith]

Gregory P. Smith <[EMAIL PROTECTED]> added the comment:

Correct, zipimport required fixing in order for this to work.  The newly
attached zlib-and-zipimport-gps01 patch.

review at http://codereview.appspot.com/4454

I haven't had a chance to look at the other modules Amaury mentioned but
on general principal I agree, they should return bytes.

Added file: 
http://bugs.python.org/file11381/zlib-and-zipimport-bytes-gps01.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3660] reference leaks in 3.0

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

The patch for _pickle has been committed in r66227.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3769] Deprecate bsddb for removal in 3.0

[Skip Montanaro]

Skip Montanaro <[EMAIL PROTECTED]> added the comment:

me> If not, could a dbm.sqlite module be written for 2.7 and 3.1 which
me> can fill that role?

http://bugs.python.org/issue3783

S

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3783] dbm.sqlite proof of concept

[Skip Montanaro]

New submission from Skip Montanaro <[EMAIL PROTECTED]>:

Based on recent discussions about ridding Python of bsddb I decided to
see how hard it would be to implement a barebones dbm.sqlite module.
Turns out, not very hard.

No docs.  No test cases.  Caveat emptor.  But I think it can serve as
at least a proof of concept, maybe as the basis for a new module in
3.1.

--
components: Library (Lib)
files: sqlite.py
keywords: patch
messages: 72556
nosy: skip.montanaro
severity: normal
status: open
title: dbm.sqlite proof of concept
type: feature request
versions: Python 3.1
Added file: http://bugs.python.org/file11380/sqlite.py

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3781] warnings.catch_warnings fails gracelessly when recording warnings but no warnings are emitted

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

Why wouldn't w.message simply be None?

--
nosy: +pitrou

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

committed r66224 + r66225.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3780] No way to write unit tests for warnings

[Glyph Lefkowitz]

Glyph Lefkowitz <[EMAIL PROTECTED]> added the comment:

The use of the term "filter" is pretty confusing.  I would normally say
it was just me, but a bunch of other Twisted hackers seemed to interpret
it the same way: a "filter" is something that has an opportunity to
remove something else.  For example, the python builtin function
"filter".  Experimentation with the filters list seems to confirm this
impression, since later filters do not have an opportunity to access the
warnings that earlier filters have removed.  The intuitive leap there is
to assume that inserting a filter at the head of the list won't do
anything different than inserting it at the tail, since a later filter
will remove it.

I can't think of an obvious recommendation to improve the text for the
filter system itself, because upon reading it in more depth, it's fairly
clear.  Maybe the heading could be changed to something more like
"intercepting warnings" or "controlling the way that warnings are
emitted"?  Something attention-grabbing that describes its purpose and
doesn't use the word "filter".  Even a sub-heading which simply
described how to use 'always'   filter to cause every warning to be
emitted would be helpful.

The biggest improvement to the documentation for "catch_warnings" would
be to put it in a section of its own, "How To Test Your Code Which Uses
Warnings", not as a footnote in "Available Classes".

(Also, as a minor note to be taken at your discretion: should
catch_warnings be named PEP 8 style as a class, since it is one?  I
don't really want to open that can of worms after reading the
interminable threading.Event thread, but it seemed worth saying as long
as was talking about this...)

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue874900] threading module can deadlock after fork

[Antoine Pitrou]

Changes by Antoine Pitrou <[EMAIL PROTECTED]>:


Added file: http://bugs.python.org/file11379/forkthread2.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue874900] threading module can deadlock after fork

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

Instead of os.write(), it is actually sufficient to sys.stdout.flush()
at the end of the subprocess. Patch attached.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue874900] threading module can deadlock after fork

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

On Thu, Sep 4, 2008 at 6:08 PM, Antoine Pitrou <[EMAIL PROTECTED]> wrote:
>
> Antoine Pitrou <[EMAIL PROTECTED]> added the comment:
>
> Benjamin, if you don't change the test, the deadlock problem is still
> solved, it's just that the third test fails because the subprocess
> stdout is empty instead of containing the desired value. It is *not*
> because the subprocess doesn't print anything (if you launch an
> equivalent program on the command line, everything is printed), rather
> it seems that subprocess doesn't get what is printed from the child
> process of the subprocess.

Ah! My apologies for the giant misunderstanding.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue874900] threading module can deadlock after fork

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

Benjamin, if you don't change the test, the deadlock problem is still
solved, it's just that the third test fails because the subprocess
stdout is empty instead of containing the desired value. It is *not*
because the subprocess doesn't print anything (if you launch an
equivalent program on the command line, everything is printed), rather
it seems that subprocess doesn't get what is printed from the child
process of the subprocess.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue874900] threading module can deadlock after fork

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

I feel like that patch sort of avoids the problem by changing the test.
The test is hanging for some reason, so we should try to fix that, not
the test. :) I wonder if it has something to do with the various
deadlocks we are discovering in the io library.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3780] No way to write unit tests for warnings

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

On Thu, Sep 4, 2008 at 3:48 PM, Glyph Lefkowitz <[EMAIL PROTECTED]> wrote:
>
> Glyph Lefkowitz <[EMAIL PROTECTED]> added the comment:
>
> Looks like we just misunderstood the way the warnings filter works, and
> catch_warnings' interaction with it.  Thanks for the priority bump,
> guido, and sorry for the false alarm!
>

If there is a doc problem, please suggest some better wording! I
tossed the text together the best I could but if it needs improvement
I welcome suggestions.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3781] warnings.catch_warnings fails gracelessly when recording warnings but no warnings are emitted

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

I won't be able to get to this until tonight, but assuming no one
objects, I will make it be an AttributeError and a release blocker so
that the API can be considered stable in rc1.

--
priority:  -> release blocker

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue874900] threading module can deadlock after fork

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

Ok, with this patch the test passes under py3k.

Apart from the trivial typo (_Thread__stopped -> _stopped), I had to
change print("...") to os.write(1, b"...\n") in the tests as otherwise
subprocess wouldn't receive any output from the third test (buffering
problem? I don't know really).

I also added the ident fix I had already suggested in _after_fork(). If
you put a print statement at this point you'll see the old and the new
value are not the same.

--
keywords: +needs review
Added file: http://bugs.python.org/file11378/forkthread.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

You could also surround the PyErr_NoMemory with #ifndef PGEN.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3781] warnings.catch_warnings fails gracelessly when recording warnings but no warnings are emitted

[Jean-Paul Calderone]

Jean-Paul Calderone <[EMAIL PROTECTED]> added the comment:

The specific exception type isn't that important to me, as long as I can
rely on it being something in particular.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

On Thu, Sep 4, 2008 at 5:48 PM, Amaury Forgeot d'Arc
<[EMAIL PROTECTED]> wrote:
>
> Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:
>
> pgen does not exist on Windows...
>
> What if I simply remove the call to PyErr_NoMemory?
> It is not strictly necessary: the function already returns NULL without
> an exception set, for example when the file cannot be opened.

That sounds ok. I can't remember what the rest of the parse does when
there's no memory, though.

>
> ___
> Python tracker <[EMAIL PROTECTED]>
> 
> ___
>

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3780] No way to write unit tests for warnings

[Glyph Lefkowitz]

Changes by Glyph Lefkowitz <[EMAIL PROTECTED]>:


--
resolution:  -> invalid

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

pgen does not exist on Windows...

What if I simply remove the call to PyErr_NoMemory?
It is not strictly necessary: the function already returns NULL without
an exception set, for example when the file cannot be opened.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3780] No way to write unit tests for warnings

[Glyph Lefkowitz]

Glyph Lefkowitz <[EMAIL PROTECTED]> added the comment:

Looks like we just misunderstood the way the warnings filter works, and
catch_warnings' interaction with it.  Thanks for the priority bump,
guido, and sorry for the false alarm!

--
nosy: +glyph
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3780] No way to write unit tests for warnings

[Jean-Paul Calderone]

Jean-Paul Calderone <[EMAIL PROTECTED]> added the comment:

I was aware of it, but I didn't realize adding an "always" filter would
make sure all warnings always got noticed.  I haven't tried changing
Twisted's use of the warnings module yet, but it looks like
`catch_warnings` will work here.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

I think this patch should be reverted. It causes a linking error because
pgen isn't linked to libpython; it doesn't find the _PyErr_NoMemory symbol.

--
nosy: +benjamin.peterson

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3645] readline module Crashs on OpenBSD/amd64

[Roumen Petrov]

Roumen Petrov <[EMAIL PROTECTED]> added the comment:

may issue 1204 is more general

--
nosy: +rpetrov

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3782] os.write accepts unicode strings

[Antoine Pitrou]

New submission from Antoine Pitrou <[EMAIL PROTECTED]>:

I'm a bit puzzled that both str and bytes are accepted by os.write() in
py3k:

>>> os.write(1, "foo\n")
foo
4
>>> os.write(1, b"foo\n")
foo
4

--
components: Interpreter Core
messages: 72537
nosy: pitrou
priority: high
severity: normal
status: open
title: os.write accepts unicode strings
type: behavior
versions: Python 3.0

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3780] No way to write unit tests for warnings

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

It sounds like you are trying to get around "once"/"default" rules to
see all warnings raised. Why can't you use catch_warnings() and do
``simplefilter("always")`` or use "error"? Otherwise you can force the
importing and use of the pure Python implementation of warnings if you
really want to continue to use your hacked version of warn_explicit (see
test_warnings on how to control whether the C implementation gets used
or not).

--
nosy: +brett.cannon

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1638033] Add httponly to Cookie module

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

Well, if it's to be added then the patch should be updated to use reST.

--
nosy: +benjamin.peterson
versions: +Python 2.6, Python 3.0

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3781] warnings.catch_warnings fails gracelessly when recording warnings but no warnings are emitted

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

On Thu, Sep 4, 2008 at 3:10 PM, Jean-Paul Calderone
<[EMAIL PROTECTED]> wrote:
>
> New submission from Jean-Paul Calderone <[EMAIL PROTECTED]>:
>
> This example shows the behavior:
>
>from warnings import catch_warnings
>
>def test():
>with catch_warnings(True) as w:
>assert str(w.message) == "foo", "%r != %r" % (w.message, "foo")
>
>test()
>
> This fails with an IndexError from the `w.message`.  That's a bit
> surprising, and since this is mostly an API useful for testing, it'd be
> much better if it had a well-defined, documented (ie, stable and likely
> to continue working in the next release of Python) error mode.
>

The question is what exception to raise when no warning has been
recorded. AttributeError goes with the idea that the attributes are
just not set since no warnings are there to set the attributes.
LookupError doesn't seem quite right. TypeError is definitely wrong
since it has nothing to do with the type of anything.

So unless someone comes up with a better suggestion I will change
__getattr__ on catch_warnings to raise AttributeError when IndexError
is raised because no warning is currently recorded.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3780] No way to write unit tests for warnings

[Guido van Rossum]

Changes by Guido van Rossum <[EMAIL PROTECTED]>:


--
priority:  -> release blocker

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3781] warnings.catch_warnings fails gracelessly when recording warnings but no warnings are emitted

[Benjamin Peterson]

Changes by Benjamin Peterson <[EMAIL PROTECTED]>:


--
assignee:  -> brett.cannon
nosy: +brett.cannon

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3781] warnings.catch_warnings fails gracelessly when recording warnings but no warnings are emitted

[Jean-Paul Calderone]

New submission from Jean-Paul Calderone <[EMAIL PROTECTED]>:

This example shows the behavior:

from warnings import catch_warnings

def test():
with catch_warnings(True) as w:
assert str(w.message) == "foo", "%r != %r" % (w.message, "foo")

test()

This fails with an IndexError from the `w.message`.  That's a bit
surprising, and since this is mostly an API useful for testing, it'd be
much better if it had a well-defined, documented (ie, stable and likely
to continue working in the next release of Python) error mode.

--
components: Library (Lib)
messages: 72533
nosy: exarkun
severity: normal
status: open
title: warnings.catch_warnings fails gracelessly when recording warnings but no 
warnings are emitted
type: behavior
versions: Python 2.6

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3780] No way to write unit tests for warnings

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

Would the new catch_warnings [1] context manager help in this regard?

[1] http://docs.python.org/dev/library/warnings.html#warnings.catch_warnings

--
nosy: +benjamin.peterson

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1638033] Add httponly to Cookie module

[Guido van Rossum]

Guido van Rossum <[EMAIL PROTECTED]> added the comment:

To be honest, I don't see any harm in adding this now, especially since
rc1 hasn't been released yet.

--
nosy: +gvanrossum

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3780] No way to write unit tests for warnings

[Jean-Paul Calderone]

New submission from Jean-Paul Calderone <[EMAIL PROTECTED]>:

In Python 2.5 and earlier, the `warnings.warn_explicit` function could
be replaced in order to test what warnings were emitted by some code. 
This allowed unit tests for warnings to be written.  Since much of the
warnings module was re-implemented in C, replacing
`warnings.warn_explicit` no longer has any effect.  This, together with
the fact that there are no other public APIs for hooking into the
warning system with duplication suppression disabled means that there is
no reliable way to write unit tests for warnings.

This was previously discussed on python-dev, but no conclusion was
reached.  See
http://mail.python.org/pipermail/python-dev/2008-June/080635.html and
the follow-ups.

For Twisted, the consequence of this is roughly 79 failing unit tests in
Python 2.6b3 and no clear way to fix them, except to stop using the
standard library warnings module.

--
components: Library (Lib)
messages: 72530
nosy: exarkun
severity: normal
status: open
title: No way to write unit tests for warnings
type: behavior
versions: Python 2.6

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3777] PyNumber_Long fails from Float

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

Note to others: PySvn uses the PyCXX classes. The call in question is
something similar to
   Py::Long( Py::Float( double( someValue ) ) )

Barry, what is the exact error message that you get?
What do you mean by "res does not contain the value that nb_long(o)
calculated" ?
And what is the exact content of the "o" variable at the time of the
failure? (you could look for example at o->ob_type->tp_name)

--
nosy: +amaury.forgeotdarc

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3758] "make check" suggest a testing target under GNU coding standards

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

OK, I am going to go with ``make patchcheck`` since that is the script's
name and the command does nothing but execute the script.

I will wait until after rc1 to deal with this.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3776] deprecate bsddb/dbhash in 2.6 for removal in 3.0

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

Sorry if that impression was given about 2.6 deprecation. The plan was
always just for 3.0 removal since removing in 2.6 really would not be
enough time to warn users.

I have assigned to myself to apply the patch when I have time (some time
tonight).

Thanks for the review, Nick!

--
assignee:  -> brett.cannon

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3160] Building a Win32 binary installer crashes

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

Fixed in r66223.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3779] log into bugs.python.org requires cookies

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

On Thu, Sep 4, 2008 at 4:29 PM, donovaly <[EMAIL PROTECTED]> wrote:
>
> donovaly <[EMAIL PROTECTED]> added the comment:
>
> Closing the bug report is not correct. When my installation failed, I
> need an info that cookies could cause the problem. This info has to be
> given on your webpage, so it's your turn!

Please trust our knowledge of how to use the tracker! Your bug report
is about the tracker not Python, so it should be brought to the URL I
gave above.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3779] log into bugs.python.org requires cookies

[donovaly]

donovaly <[EMAIL PROTECTED]> added the comment:

Closing the bug report is not correct. When my installation failed, I
need an info that cookies could cause the problem. This info has to be
given on your webpage, so it's your turn!

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3779] log into bugs.python.org requires cookies

[Benjamin Peterson]

Benjamin Peterson <[EMAIL PROTECTED]> added the comment:

This should be reported to the meta tracker:
http://psf.upfronthosting.co.za/roundup/meta/.

--
nosy: +benjamin.peterson
resolution:  -> invalid
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3776] deprecate bsddb/dbhash in 2.6 for removal in 3.0

[Nick Coghlan]

Nick Coghlan <[EMAIL PROTECTED]> added the comment:

Attached patch raises Py3k warnings rather than plain deprecation
warnings, so it looks good to me (some of the discussions on python-dev
gave the impression that may have been getting full deprecation
warnings, implying its potential removal in 2.7 as well).

--
nosy: +ncoghlan

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3779] log into bugs.python.org requires cookies

[donovaly]

New submission from donovaly <[EMAIL PROTECTED]>:

I tried to log into this issue tracker several times without success.
Now I found out by chance that I need to allow to set browser cookies to
be able to log in.
So please display a message that one needs to allows cookies to log in.

--
messages: 72521
nosy: donovaly
severity: normal
status: open
title: log into bugs.python.org requires cookies

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3778] python uninstaller leave registry entries

[donovaly]

New submission from donovaly <[EMAIL PROTECTED]>:

- install Python 2.5.2 using the Windows installer
- now uninstall Python

Result: The uninstaller doesn't remove the registry folder
HKLM\SOFTWARE\Python
and all its subfolders.

--
components: Installation
messages: 72520
nosy: donovaly
severity: normal
status: open
title: python uninstaller leave registry entries
versions: Python 2.5

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3777] PyNumber_Long fails from Float

[Barry Alan Scott]

New submission from Barry Alan Scott <[EMAIL PROTECTED]>:

I am testing PySVN against python2.6b3.

I see a failure when PyNumber_Long is called with a Float.
It raises TypeError.

The same code works on 2.3, 2.4 and 2.5.

Looking with GDB I see:

(gdb) bt
#0  PyNumber_Long (o=0x1809384) at Objects/abstract.c:1735
#1  0x020f8e70 in Py::Long::Long (this=0xbfffefc8, [EMAIL PROTECTED]) at
pysvn_client_cmd_list.cpp:739

1681m = o->ob_type->tp_as_number;
1682if (m && m->nb_long) { /* This should include subclasses
of long */
1683/* Classic classes always take this branch. */
1684PyObject *res = m->nb_long(o);
1685if (res && (!PyInt_Check(res) &&
!PyLong_Check(res))) {

res does not contain the value that nb_long(o) calculated.
and the if on 1685 is false so you get a type error.

I have compiled on Mac OS X 10.4 powerpc and fedora 8 x86.
Both fail in the exact same way.

If you need to reproduce you will need to build pysvn and
run a command that triggers the problem. I don't have a
smaller example.

--
components: None
messages: 72519
nosy: barry-scott
severity: normal
status: open
title: PyNumber_Long fails from Float
type: behavior
versions: Python 2.6

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1291446] SSLObject breaks read semantics

[Jonathan Ellis]

Jonathan Ellis <[EMAIL PROTECTED]> added the comment:

Here is the exact SSLObject.read documentation from 2.5 (although the 
bug was filed against 2.4, and 2.6 will be out soon, the docs are the 
same):

-

read([n])

If n is provided, read n bytes from the SSL connection, otherwise read 
until EOF. The return value is a string of the bytes read.

-

This is not ambiguous.  Similarly, help(file.read) is not ambiguous.  
(The "at most" part in the first line of file.read is later explained 
to apply to non-blocking reads.)

If you want to claim "well, it's not a file-like object" then (a) it 
shouldn't have file-like methods (socket-like send and recv are the 
obvious choices instead of write and read), (b) you need to fix your 
docs.  But since god knows how many programs are out there expecting 
the semantics explained by the existing docs, I think just fixing the 
bug in the code is better than defining away the problem.

(Obviously socket.makefile won't work on an object that doesn't 
implement a socket-like interface, so that's a non-option.)

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3776] deprecate bsddb/dbhash in 2.6 for removal in 3.0

[Brett Cannon]

New submission from Brett Cannon <[EMAIL PROTECTED]>:

This patch deprecates bsddb and dbhash for removal in Python 3.0.

--
components: Library (Lib)
files: deprecate_bsddb.diff
keywords: needs review, patch, patch
messages: 72517
nosy: brett.cannon
priority: release blocker
severity: normal
status: open
title: deprecate bsddb/dbhash in 2.6 for removal in 3.0
type: behavior
versions: Python 2.6
Added file: http://bugs.python.org/file11377/deprecate_bsddb.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1291446] SSLObject breaks read semantics

[Bill Janssen]

Bill Janssen <[EMAIL PROTECTED]> added the comment:

The way I read the documentation, file.read() (and that's what we're
talking about) is still not guaranteed to read all the bytes of the
file.  But, you're right, that is the accepted semantics.  So the
documentation should change, too.

However, the "read" method on an SSLSocket, which is not a file()
subclass, is *not* guaranteed to return N bytes, it's guaranteed to
return at most N bytes.  Call "makefile" on SSLSocket if you need a
file-like object.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

Your patch looks fine, Amaury.

--
assignee:  -> amaury.forgeotdarc

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

[Amaury Forgeot d'Arc]

Changes by Amaury Forgeot d'Arc <[EMAIL PROTECTED]>:


Removed file: http://bugs.python.org/file11372/check_findencoding_malloc.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

Right, here is an updated patch

Added file: http://bugs.python.org/file11376/check_findencoding_malloc.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

[Brett Cannon]

Brett Cannon <[EMAIL PROTECTED]> added the comment:

If PyMem_MALLOC() returns NULL, shouldn't MemoryError be set?

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3671] What's New in 2.6 - corrections

[Kent Johnson]

Kent Johnson <[EMAIL PROTECTED]> added the comment:

For the itertools examples, perhaps you could remove the [ ] from the
result text so it doesn't look like a list. For example:
itertools.izip_longest([1,2,3], [1,2,3,4,5]) ->
 (1, 1), (2, 2), (3, 3), (None, 4), (None, 5)

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3769] Deprecate bsddb for removal in 3.0

[Jesús Cea Avión]

Jesús Cea Avión <[EMAIL PROTECTED]> added the comment:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Nick Coghlan wrote:
> While that will still be visible to some degree due to the presence of
> the 2.x version of the bsddb code in Python 2.6, I don't think it will
> be quite the same as it would have been with the 3.x version also being
> readily available as part of the standard 3.0 install.

Since 2.6 intention seems to mark this module as deprecated, I guess 2.x
bsddb presence in stock python will finish in 2.7. Moreover, I'm working
just now improving 2.x/3.x conversion code in pybsddb. I think this code
will be available in bsddb 4.7.4, and it will not be integrated in
Python 2.6 (that will include 4.7.3.minor releases, if we keep the
criteria of "only stability and security fixes in 2.6.x").

If the idea is to keep bsddb alive in 2.x, I don't see the point of not
keeping the 3.0 version, because the issues used to justify the removal
persist: I'm the only maintainer, little code review, buildbot issues, etc.

(I would like a comprehensive list, to be able to improve those
deficiencies).

In fact, if we keep bsddb in 2.x, the pressure to keep it in 3.x will be
higher.

> Regardless, given that the removal of bsddb from the 3.0 branch is now a
> done deal in svn, I suggest that all we can do is monitor how much

Any version control system can revert that with a single command :).

All I can say is that current bsddb code (in my personal repository)
passes all tests in current compiled python3.0 binary, called with the
"-bb" parameter flag (the "-bb" flag was something I learned yesterday).

> but in the meantime there *are* real benefits to
> decoupling the maintenance cycles (those wanting to get the most out of
> Jesus's ongoing work in exposing more of the bsddb API are probably
> going to want to be using the external pybsddb releases anyway rather
> than waiting however many months it ends up being until we get to 2.7/3.1).

The cycles are actually decoupled since I toke over the bsddb
maintenance (I've released a new version per month). So the release
cycles are not an issue.

The main issue here is 3.0 support, that I worked over the last couple
of months. It is done now. It couldn't be done faster because I was
learning 3.0 internals on-the-fly (there are NO docs about C module
migration; my experience there could be valuable) and 3.0 was a moving
target (still is). For example, when I left to summer holiday bsddb
worked flawless in Python 3.0b2. It failed in 3.0b3 because threading
renames done in python 3.0.

So, Python 3.0 is not waiting for bsddb to be ready, because it already
is (since yesterday). And future Python releases won't suffer because we
won't have any other major architectural reengineering of Python in a
long long time (I hope!).

That is, future Python releases would take whatever bsddb is available
at that time. No wait. No dependent release cycles. With my current
release schema of "a release per month", I can track python evolution
with little effort. For example, Python 2.5 to 2.6 was pretty painless,
even with the "PyBytes_*" ugliness.

> As far as the corporate scenarios go: if a corporate environment is *so*
> screwed up as to simultaneously permit a migration from Python 2.x to
> 3.0 of an internal project that relies on bsddb, while at the same time
> banning those performing the migration from installing the 3.0
> compatible version of pybsddb, then they have much bigger problems than
> which modules and packages we are choosing to include in the standard
> library.

Agreed. I was thinking about bsddb removal in 2.7.

- --
Jesus Cea Avion _/_/  _/_/_/_/_/_/
[EMAIL PROTECTED] - http://www.jcea.es/ _/_/_/_/  _/_/_/_/  _/_/
jabber / xmpp:[EMAIL PROTECTED] _/_/_/_/  _/_/_/_/_/
.  _/_/  _/_/_/_/  _/_/  _/_/
"Things are not so easy"  _/_/  _/_/_/_/  _/_/_/_/  _/_/
"My name is Dump, Core Dump"   _/_/_/_/_/_/  _/_/  _/_/
"El amor es poner tu felicidad en la felicidad de otro" - Leibniz
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.8 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQCVAwUBSMAEnplgi5GaxT1NAQIrKgP/YAp45HUSG8Q+M355LTVqlcLMLkycpooc
fflW0MlQ3zZV307VBUbGo9urkS6h1pYhYByivApylhVqj8D4x8OEmMZk0lX8cegG
LYSBzs/sBeyxWWva6r5D9/4DsgJe9ZHqaBLMpy6ipPNVtUbMS61VTNovb3wP+f72
EnSIf9k/glM=
=QxRo
-END PGP SIGNATURE-

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3696] Error parsing arguments on OpenBSD <= 4.4

[Antoine Pitrou]

Changes by Antoine Pitrou <[EMAIL PROTECTED]>:


--
resolution: accepted -> fixed
status: pending -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3618] possible deadlock in IO library (Lib/io.py)

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

(I have to add that the patch makes small reads about 60-80% slower)

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3756] re.escape() does not work with bytes()

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

I don't think there are cases where re.escape is performance critical -
are there any?
By the way, it seems to me the simplest way to write re.escape() would
be to use a regexp to do the replacement. It might or might not be the
fastest.

--
nosy: +pitrou

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3774] tkinter Menu.delete bug

[Hirokazu Yamamoto]

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment:

I've not tested this so heavily, but patch could be simple.
self._tclCommands could be None, so should check it.

--
keywords: +easy, needs review, patch
Added file: http://bugs.python.org/file11375/menu_bag.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3618] possible deadlock in IO library (Lib/io.py)

[Antoine Pitrou]

Changes by Antoine Pitrou <[EMAIL PROTECTED]>:


--
keywords: +needs review

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3618] possible deadlock in IO library (Lib/io.py)

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

Here is a patch. The RLock implementation is naive and as simple as
possible. It doesn't solve Haypo's case, probably because the tracing
func kicks in in the RLock code itself.

I don't want to make a decision on this alone, so someone please advise.

Added file: http://bugs.python.org/file11374/rlockio.patch

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3769] Deprecate bsddb for removal in 3.0

[Nick Coghlan]

Nick Coghlan <[EMAIL PROTECTED]> added the comment:

Raymond Hettinger wrote:
> I think this should be deferred to Py3.1.
> This decision was not widely discussed and I think it likely that some
> users will
> be surprised and dismayed.  The release
> candidate seems to be the wrong time to
> yank this out (in part because of the surprise
> factor) and in part because I think the change
> silently affects shelve performance so that the
> impact may be significantly negative but not
> readily apparent.

I don't use Python for database work myself, but something I am somewhat
disappointed to lose is the presence of a moderately complicated package
within the Python distribution itself which is making use of the various
2-to-3 migration tools to support both Python 2.x and 3.x with a single
mixed Python-and-C code base (along with automatic conversion via 2to3).

While that will still be visible to some degree due to the presence of
the 2.x version of the bsddb code in Python 2.6, I don't think it will
be quite the same as it would have been with the 3.x version also being
readily available as part of the standard 3.0 install.

Regardless, given that the removal of bsddb from the 3.0 branch is now a
done deal in svn, I suggest that all we can do is monitor how much
feedback we get indicating that the need to download bsddb as a separate
install is a significant hindrance to Py3k migrations. If the feedback
indicates it is necessary, restoring the module for 3.1 certainly isn't
an impossibility, but in the meantime there *are* real benefits to
decoupling the maintenance cycles (those wanting to get the most out of
Jesus's ongoing work in exposing more of the bsddb API are probably
going to want to be using the external pybsddb releases anyway rather
than waiting however many months it ends up being until we get to 2.7/3.1).

There's also a bit of a second shot at this for bsddb supporters, in
that some of the "omnibus" Python distribution providers like
ActiveState and Enthought may choose to include pybsddb once they start
releasing bundles for Python 3.0.

As far as the corporate scenarios go: if a corporate environment is *so*
screwed up as to simultaneously permit a migration from Python 2.x to
3.0 of an internal project that relies on bsddb, while at the same time
banning those performing the migration from installing the 3.0
compatible version of pybsddb, then they have much bigger problems than
which modules and packages we are choosing to include in the standard
library. In my experience, restrictive corporate environments are far
more likely to just disallow migrations to 3.0 altogether (and in many
cases, the decision makers disallowing such migrations probably won't be
wrong - the case for migrating an existing internal app to 3.0 is far,
far weaker than that for using 3.0 for new development).

Cheers,
Nick.

--
nosy: +ncoghlan

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3775] Update RELNOTES file

[Barry A. Warsaw]

New submission from Barry A. Warsaw <[EMAIL PROTECTED]>:

The RELNOTES file should contain all, but only, the issues relevant for
the 3.0 final release.

--
assignee: barry
messages: 72505
nosy: barry
priority: deferred blocker
severity: normal
status: open
title: Update RELNOTES file
versions: Python 3.0

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3671] What's New in 2.6 - corrections

[A.M. Kuchling]

A.M. Kuchling <[EMAIL PROTECTED]> added the comment:

Many of the items are fixed in rev66217; thanks!  A few of them were
fixed in the revisions I did this past weekend.

Not fixed: 

* the links for apply() and map() in the PEP 371 section.  Georg, is
there a way to override where the methods link to, or at least prevent
them from being turned into links?

* the itertools section uses the -> to indicate the resulting stream of
values; this is why those examples aren't written in the
interpreter-prompt style.  So I'm not going to change the examples by
adding list().

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3769] Deprecate bsddb for removal in 3.0

[Jesús Cea Avión]

Jesús Cea Avión <[EMAIL PROTECTED]> added the comment:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Brett Cannon wrote:
>> Also, the reason for removal may yet disappear
>> if jcrea steps in an continues to make updates.
> 
> OK, but none of his changes have received a code review, so if we are
> going to go down the whole "disciplined" route about it being an rc
> then we should back out all of Jesus' changes for both 2.6 and 3.0,
> which puts us back to the same instability issues.

I was wondering if somebody could write a "TO DO" list of things need to
keep bsddb in the stdlib. Then I could work to trying to comply :).

Yes, we are all very busy guys, but still...

- --
Jesus Cea Avion _/_/  _/_/_/_/_/_/
[EMAIL PROTECTED] - http://www.jcea.es/ _/_/_/_/  _/_/_/_/  _/_/
jabber / xmpp:[EMAIL PROTECTED] _/_/_/_/  _/_/_/_/_/
.  _/_/  _/_/_/_/  _/_/  _/_/
"Things are not so easy"  _/_/  _/_/_/_/  _/_/_/_/  _/_/
"My name is Dump, Core Dump"   _/_/_/_/_/_/  _/_/  _/_/
"El amor es poner tu felicidad en la felicidad de otro" - Leibniz
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.8 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQCVAwUBSL/kPZlgi5GaxT1NAQLu4AP/VSHPYOCQgQYFJsdi2MWXBpyY7TyC5XgT
Ks2uilXru/hsKQcegn8G6z/53Bt0Uu+oXZSQaZ51V8VnwDXEqaZ+GnKK+S2ky9m0
yomgMlKIZZJsOVd6X4HbLtrVYVKX8wQ224X/yCkw27OLzLIE9IDbUzEjC3+/A7mD
9IJu3B6IaLA=
=ZA8p
-END PGP SIGNATURE-

--
nosy: +jcea

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3774] tkinter Menu.delete bug

[Hirokazu Yamamoto]

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment:

I tried, and I confirmed released python2.5.2 runs fine. and
py3k, trunk, release25-maint fails. Probably something changed after
2.5.2 release.

--
nosy: +ocean-city
versions: +Python 2.5, Python 2.6

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3774] tkinter Menu.delete bug

[skomoroh]

New submission from skomoroh <[EMAIL PROTECTED]>:

When I create a menu item without command and them remove it, I have a
error:
  File "/usr/local/lib/python3.0/tkinter/__init__.py", line 2661, in delete
if c in self._tclCommands:
TypeError: argument of type 'NoneType' is not iterable

--
components: Tkinter
files: menu_bug.py
messages: 72501
nosy: skomoroh
severity: normal
status: open
title: tkinter Menu.delete bug
versions: Python 3.0
Added file: http://bugs.python.org/file11373/menu_bug.py

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2305] Update What's new in 2.6

[Facundo Batista]

Facundo Batista <[EMAIL PROTECTED]> added the comment:

The parse_qs() and parse_qsl() relocation from module cgi to urlparse
needs an entry in the "What's new..." (alerting you through here,
because I commited this last night).

See issue 600362 for further info, or ask me directly, :)

--
nosy: +facundobatista

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2305] Update What's new in 2.6

[A.M. Kuchling]

A.M. Kuchling <[EMAIL PROTECTED]> added the comment:

Closing this item; the 2.6 "What's New" is done, except for any small
fixes that get reported.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3756] re.escape() does not work with bytes()

[Andrew McNamara]

Andrew McNamara <[EMAIL PROTECTED]> added the comment:

On further testing, sometimes the str version is faster, sometimes the 
bytes version is faster. Never more than about 50% one way or the 
other, so probably not worth worrying about, although I still don't 
really like the implementation. Maybe it deserves a C implementation?

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue877121] configure detects incorrect compiler optimization

[Michael Schmarck]

Changes by Michael Schmarck <[EMAIL PROTECTED]>:


--
versions: +Python 2.4, Python 2.6, Python 3.0

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue877121] configure detects incorrect compiler optimization

[Michael Schmarck]

Michael Schmarck <[EMAIL PROTECTED]> added the comment:

This still happens with Python 2.6b3, 3.0b3 and 2.5.2 and Sun Studio 12
on Solaris Sparc.

Like mentioned in Issue1162001, the problem seems to be, that cc returns
0 if -OPT:Olimit=0 is used:

--($ ~)-- cc  -OPT:Olimit=0 test1.c; echo $?
cc: Warning: illegal option -OPT:Olimit=0
0

--($ ~)-- gcc  -OPT:Olimit=0 test1.c; echo $?
cc1: error: invalid option argument `-OPT:Olimit=0'
1

I ran this configure:

CXX=/opt/SUNWspro/bin/CC CC=/opt/SUNWspro/bin/cc ./configure
--prefix=$HOME/.software/python-2.6b3 --disable-ipv6 --enable-shared
--without-gcc --with-threads --with-doc-strings

The prefix was always different, of course :)

--($ ~)-- gcc --version
gcc (GCC) 3.4.3 (csl-sol210-3_4-branch+sol_rpath)
Copyright (C) 2004 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

--($ ~)-- version # for cc
Machine hardware:   sun4u
OS version: 5.10
Processor type: sparc
Hardware:   SUNW,Sun-Fire-480R

The following components are installed on your system:


Sun Studio 12
Sun Studio 12 C Compiler
Sun Studio 12 C++ Compiler
Sun Studio 12 Tools.h++ 7.1
Sun Studio 12 C++ Standard 64-bit Class Library
Sun Studio 12 Garbage Collector 
Sun Studio 12 Fortran 95 
Sun Studio 12 Debugging Tools (including dbx)
Sun Studio 12 IDE
Sun Studio 12 Debugger GUI
Sun Studio 12 Performance Analyzer (including collect, ...)
Sun Studio 12 X-Designer 
Sun Studio 12 VIM editor
Sun Studio 12 XEmacs editor
Sun Studio 12 Performance Library 
Sun Studio 12 LockLint
Sun Studio 12 Building Software (including dmake)
Sun Studio 12 Documentation Set

version of "/opt/SUNWspro/bin/../prod/bin/../../bin/cc": Sun C 5.9
SunOS_sparc Patch 124867-01 2007/07/12
version of "/opt/SUNWspro/bin/../prod/bin/../../bin/CC": Sun C++ 5.9
SunOS_sparc Patch 124863-01 2007/07/25
version of "/opt/SUNWspro/bin/../prod/bin/../../bin/f90": Sun Fortran 95
8.3 SunOS_sparc Patch 127000-01 2007/07/18
version of "/opt/SUNWspro/bin/../prod/bin/../../bin/dbx": Sun Dbx
Debugger 7.6 SunOS_sparc Patch 124872-01 2007/07/12
version of "/opt/SUNWspro/bin/../prod/bin/../../bin/analyzer": Sun
Analyzer 7.6 SunOS_sparc Patch 126995-01 2007/07/17
version of "/opt/SUNWspro/bin/../prod/bin/../../bin/dmake": Sun
Distributed Make 7.8 SunOS_sparc Patch 126503-01 2007/07/19

--
nosy: +mschmarck
versions: +Python 2.5 -Python 2.4

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3618] possible deadlock in IO library (Lib/io.py)

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

We might as well bite the bullet and include a short, minimalist RLock
implementation in io.py (so as not to pull threading and all its
dependencies at startup). The C version of RLock will wait for 3.1.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3187] os.listdir can return byte strings

[Baptiste Carvello]

Baptiste Carvello <[EMAIL PROTECTED]> added the comment:

If, as I understand, it is the application's job to call listdir with
bytes or unicode depending on the platform, it might be useful to have a
function in the os module telling whether the filesystem is bytes of
unicode-native. 

That way, the idiom for doing something to all files in a given
directory would read:

>>> directory="my_direcory"
... if not os.is_filesystem_unicode():
... directory=directory.encode(sys.stdin.encoding)
... for name in os.listdir(directory):
... f=open(name)
... # do something
... f.close()

and it would work on all platforms, even if one of the filenames is not
in the locale's normal encoding.

If this idiom is correct, it could also be useful to include it in the
module documentation so that application authors know what they are
supposed to do.

--
nosy: +zegreek

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3492] Zlib compress/decompress functions returning bytearray

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

Two remarks:
1. Some functions in Modules/zipimport.c (get_data) will now receive
PyBytes, but zipimporter_get_source handle them as PyByteArray. Does
zipimport still work at all with this patch?

2. There are other places where PyString_FromString was (incorrectly
IMO) replaced with PyByteArray_FromString:
- Modules/_dbmmodule.c
- Modules/mmapmodule.c
- Modules/ossaudiodev.c
- Modules/zipimport.c (as noted above)
- PC/winreg.c
- Python/marshal.c

--
nosy: +amaury.forgeotdarc

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3759] test_asyncore.py leaks handle

[Hirokazu Yamamoto]

Changes by Hirokazu Yamamoto <[EMAIL PROTECTED]>:


--
resolution: accepted -> fixed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3762] platform.architecture() fails if python is lanched via its symbolic link (cygwin)

[Hirokazu Yamamoto]

Hirokazu Yamamoto <[EMAIL PROTECTED]> added the comment:

Thanks, fixed in r66213(trunk), r66214(release-maint25), r66216(py3k).

--
resolution: accepted -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1658] "RuntimeError: dictionary changed size during iteration" in Tkinter

[Guilherme Polo]

Guilherme Polo <[EMAIL PROTECTED]> added the comment:

Committed r66215

I've applied this only in py3k since it doesn't affect python 2.6

--
resolution: accepted -> fixed
status: open -> closed
versions:  -Python 2.6

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3492] Zlib compress/decompress functions returning bytearray

[Antoine Pitrou]

Antoine Pitrou <[EMAIL PROTECTED]> added the comment:

+1 for committing.

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3722] print followed by exception eats print with doctest

[Chris Withers]

Chris Withers <[EMAIL PROTECTED]> added the comment:

Out of interest, where are the doctest docs you quoted? I missed that
bit and that disturbs me :-S

I'm not sure documenting a bug and trying to explain it away makes it
any less of a bug, nonetheless, lets leave this one open as a feature
request then ;-)

--
type:  -> feature request

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3773] Check for errors when using PyTokenizer_FindEncoding()

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

In PyTokenizer_FindEncoding(), PyMem_MALLOC may return NULL.
Another patch attached.

--
nosy: +amaury.forgeotdarc
Added file: http://bugs.python.org/file11372/check_findencoding_malloc.diff

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3762] platform.architecture() fails if python is lanched via its symbolic link (cygwin)

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

The problem shows up on other platforms as well.
The following comes from a standard Debian 64bit:

$ /usr/bin/python -c "import platform; print platform.architecture()"
('64bit', '')
$ /usr/bin/python2.4 -c "import platform; print platform.architecture()"
('64bit', 'ELF')

And the patch corrects this.

--
keywords:  -needs review
nosy: +amaury.forgeotdarc
resolution:  -> accepted

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue1658] "RuntimeError: dictionary changed size during iteration" in Tkinter

[Amaury Forgeot d'Arc]

Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

The patch is indeed simple.

A minor stylistic remark: instead of 
for c in classes:
del cnf[c[0]]
it would be clearer to write
for k, v in classes:
del cnf[v]
like the other loop does, 3 lines after.

Please apply.

--
keywords:  -needs review
nosy: +amaury.forgeotdarc

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue3772] logging module fails with non-ascii data

[Vinay Sajip]

Vinay Sajip <[EMAIL PROTECTED]> added the comment:

Changes checked into trunk.

--
resolution:  -> fixed
status: open -> closed

___
Python tracker <[EMAIL PROTECTED]>

___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com