[issue5341] A selection of spelling errors and typos throughout source
Mark Dickinson dicki...@gmail.com added the comment: Thanks, Georg. And yes, I was indeed wondering why I found so few wayward apostrophes! Applied in r69846, r69847. I'm not sure whether it's worth backporting these to 2.6 and 3.0. Please do not change builtin to built-in. In a python context, it reads fine as one word. built-in seems to be the more common spelling within the documentation. Personally, in the context of Python I find builtin acceptable as a noun (don't shadow builtins), but it still looks wrong when used as an adjective (the builtin function open). Anyway, I'll refrain from making any more of these changes. -- resolution: accepted - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5341 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1533164] Installed but not listed *.pyo break bdist_rpm
Mads Kiilerich m...@kiilerich.com added the comment: The command rpm is (now, and in rpm.org version) for runtime and installation only. Rpm building is done by /usr/bin/rpm-build (from the package with the same name, run yum install rpm-build). /usr/lib/python2.5/distutils/command/bdist_rpm.py will select rpm-build if it is available. Yes, the fallback is confusing. That is a consequence of the rpm fork and probably out of scope for this issue ;-) ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1533164 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4258] Use 30-bit digits instead of 15-bit digits for Python integers.
Mark Dickinson dicki...@gmail.com added the comment: It finally occurred to me that what might be killing 32-bit performance is the divisions, rather than the multiplications. To test this, here's a version of 30bit_longdigit17.patch that replaces just *two* of the divisions in Objects/longsobject.c by the appropriate x86 divl assembler instruction. The result for pydigits is an astonishing 10% speedup! Results of running python pydigits_bestof.py 2000 on 32-bit OS X 10.5.6/Core 2 Duo: upatched py3k - Best Time; 2212.6 ms 30bit_longdigit17.patch --- Best Time; 2283.9 ms (-3.1% relative to py3k) 30bit_longdigit17+asm.patch --- Best Time; 2085.7 ms (+6.1% relative to py3k) The problem is that (e.g., in the main loop of x_divrem) we're doing a 64-bit by 32-bit division, expecting a 32-bit quotient and a 32-bit remainder. From the analysis of the algorithm, *we* know that the quotient will always fit into 32 bits, so that e.g., on x86, a divl instruction is appropriate. But unless the compiler is extraordinarily clever it doesn't know this, so it produces an expensive library call to a function that probably involves multiple divisions and/or some branches, that produces the full 64-bit quotient. On 32-bit PowerPC things are even worse, since there there isn't even a 64-by-32 bit divide instruction; only a 32-bit by 32-bit division. So I could still be persuaded that 30-bit digits should only be enabled by default on 64-bit machines... Added file: http://bugs.python.org/file13149/30bit_longdigit17+asm.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4258 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5345] cStringIO class name typo
Virgil Dupras hs...@hardcoded.net added the comment: The documentation says: Another difference from the StringIO module is that calling StringIO() with a string parameter creates a read-only object. Unlike an object created without a string parameter, it does not have write methods. These objects are not generally visible. They turn up in tracebacks as StringI and StringO. And there seem to have been some activity about this around r33834. -- nosy: +vdupras ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5345 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1533164] Installed but not listed *.pyo break bdist_rpm
Tarek Ziadé ziade.ta...@gmail.com added the comment: Ok, looks good now, thanks a lot. But I am unable to reproduce the problem. The rpm is built fine using my test and the provided example, with or without the -O1 option... I have tried with Python trunk and Fedora's Python 2.5 Would you mind trying with the current Distutils trunk on your side ? ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1533164 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2519] Typing 'modules' in the interactive help system fails when imports fail
Dennis Kaarsemaker den...@kaarsemaker.net added the comment: I don't see this bug in python 3.0, so feel free to close this issue. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2519 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1533164] Installed but not listed *.pyo break bdist_rpm
Antoine Pitrou pit...@free.fr added the comment: But I am unable to reproduce the problem. The rpm is built fine using my test and the provided example, with or without the -O1 option... IIUC, the problem occurs not on building the RPM, but on trying to install it. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1533164 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5328] Crash when doing some list iteration
Changes by Benjamin Peterson benja...@python.org: -- resolution: - invalid status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5328 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1533164] Installed but not listed *.pyo break bdist_rpm
Changes by Tarek Ziadé ziade.ta...@gmail.com: Added file: http://bugs.python.org/file13150/test_bdist_rpm.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1533164 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1533164] Installed but not listed *.pyo break bdist_rpm
Changes by Tarek Ziadé ziade.ta...@gmail.com: Removed file: http://bugs.python.org/file13097/rpm.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1533164 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5346] mailbox._singlefileMailbox.flush doesn't preserve file rights
New submission from Andrey Rahmatullin w...@altlinux.org: Mbox file is recreated during flush(), so the new file has access rights according to umask, which is not necessarily the same as of the old file. -- components: Library (Lib) messages: 82604 nosy: wRAR severity: normal status: open title: mailbox._singlefileMailbox.flush doesn't preserve file rights type: behavior versions: Python 2.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5346 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1533164] Installed but not listed *.pyo break bdist_rpm
Tarek Ziadé ziade.ta...@gmail.com added the comment: I am now able to reproduce it, thanks to Mads help for the record, on a fresh Fedora 10, you need to do: $ yum groupinstall Development Tools $ yum install rpmdevtools Then the problem will occur like described. Moving to the next stage : fixing Distutils for that problem ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1533164 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5316] Buildbot failures in test_site
Antoine Pitrou pit...@free.fr added the comment: I manage to reproduce it by running test_site just after test_distutils: ./python -E -tt -m test.regrtest -uall -l -w test_distutils test_site It could be related to test_distutils modifying an environment variable without restoring it at the end. -- assignee: - tarek nosy: +tarek ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5316 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5316] Buildbot failures in test_site
Eric Smith e...@trueblade.com added the comment: Trial and error shows it's test_sdist.py. -- nosy: +eric.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5316 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4565] Rewrite the IO stack in C
Antoine Pitrou pit...@free.fr added the comment: What should we do about test_fileio, test_file and test_bufio? ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4565 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5347] SocketIO redefines RawIOBase.__del__
New submission from Antoine Pitrou pit...@free.fr: SocketIO defines its own __del__ while it could simply rely on IOBase.__del__ to do the right thing. I'm saying this because in the C version of the io lib, there is no __del__ anymore, so that SocketIO objects caught in a ref cycle wouldn't block the GC from collecting the objects. -- components: Library (Lib) messages: 82609 nosy: pitrou priority: normal severity: normal status: open title: SocketIO redefines RawIOBase.__del__ type: behavior versions: Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5347 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1533164] Installed but not listed *.pyo break bdist_rpm
Tarek Ziadé ziade.ta...@gmail.com added the comment: The patch is ready. I'll ask at Distutils-SIG what people think about the force-optimize option name, then I'll commit it for 2.7 and 3.1 -- versions: -Python 2.6, Python 3.0 Added file: http://bugs.python.org/file13151/rpm.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1533164 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1533164] Installed but not listed *.pyo break bdist_rpm
Changes by Tarek Ziadé ziade.ta...@gmail.com: Removed file: http://bugs.python.org/file13150/test_bdist_rpm.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1533164 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4565] Rewrite the IO stack in C
Benjamin Peterson benja...@python.org added the comment: On Sun, Feb 22, 2009 at 1:50 PM, Antoine Pitrou rep...@bugs.python.org wrote: Antoine Pitrou pit...@free.fr added the comment: What should we do about test_fileio, test_file and test_bufio? I changed test_file and test_bufio to test the open() implementations of each library. test_fileio should be fine because the implementation is the same for _pyio and io. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4565 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2054] add ftp-tls support to ftplib - RFC 4217
Jeff Oyama j...@oyama.org added the comment: Just wondering, has anyone done a patch since Bill made the necessary changes to ssl.py in order to implement FTP TLS? If so, where can I find it? I would love to test it out. -- nosy: +jeffo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2054 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4136] merge json library with latest simplejson 2.0.x
Bob Ippolito b...@redivi.com added the comment: New patch implementing cyclic GC, new-style relative imports, no lines 80 characters in non-test Python code Added file: http://bugs.python.org/file13152/json_issue4136_r69885.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4136 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1533164] Installed but not listed *.pyo break bdist_rpm
Changes by Tarek Ziadé ziade.ta...@gmail.com: Added file: http://bugs.python.org/file13153/rpm.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1533164 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1533164] Installed but not listed *.pyo break bdist_rpm
Changes by Tarek Ziadé ziade.ta...@gmail.com: Removed file: http://bugs.python.org/file13151/rpm.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1533164 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4565] Rewrite the IO stack in C
Antoine Pitrou pit...@free.fr added the comment: There's also test_univnewlines, I think. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4565 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4626] compile() doesn't ignore the source encoding when a string is passed in
Benjamin Peterson benja...@python.org added the comment: On Tue, Feb 17, 2009 at 6:22 PM, STINNER Victor rep...@bugs.python.org wrote: I don't understand the change in source_as_string(). Except of that, it looks correct. Py_CFFLAGS_SOURCE_IS_UTF8 is already set in compile(). The one problem is that it causes test_coding to fail because coding cookies are ignored and not checked to see if they are the same as the encoding of the file. The test have to fail, but the error is not the the compile() patch, but in the test. Input file is opened as unicode instead of bytes. A propose this patch to fix the test: That fix is correct, but I think it avoids what the test is meant to test. The test is supposed to check that compile() complains if the encoding of the unicode string is wrong compared to the coding cookie, but I think that feature is ok to not support. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4626 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5348] Documentation of format implies only strings and numbers are acceptable arguments
New submission from Mitchell Model m...@acm.org: The documentation of format on the builtin functions page should be changed from Convert a string or a number to Convert a value. The documentation begins Convert a string or a number. This is misleading in that format can be called on any value, since there is an Object.__format__ and classes can define their own __format__ method. PEP 3101 is explicit about all of this and the documentation of __format__ ends by noting that format(value, format_spec) merely calls value.__format__(format_spec). typeobject.c implements Object.__format__ with a note about PEP 3101. Given all of that I don't see why format should be explained as taking a string or a number as its first argument. -- assignee: georg.brandl components: Documentation messages: 82616 nosy: MLModel, georg.brandl severity: normal status: open title: Documentation of format implies only strings and numbers are acceptable arguments versions: Python 2.6, Python 2.7, Python 3.0, Python 3.1 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5348 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5348] Documentation of format implies only strings and numbers are acceptable arguments
Changes by Benjamin Peterson benja...@python.org: -- nosy: +eric.smith ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5348 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3788] test_cookie isn't comprehensive
Noufal nou...@nibrahim.net.in added the comment: This patch contains some simple tests for Morsel. I will update it again to increase coverage. The changes to the Cookie tests assume that the patch in issue4860 has been applied. -- keywords: +patch nosy: +noufal Added file: http://bugs.python.org/file13154/test_cookie.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3788 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5349] abstractmethod vs C++ pure virtual
New submission from Jared Grubb pyt...@jaredgrubb.com:
On page library/abc.html documenting abc.abstractmethod, the following
text about C++ is placed in a note:
Note: Unlike C++’s pure virtual functions, or Java abstract methods,
these abstract methods may have an implementation. This implementation
can be called via the super() mechanism from the class that overrides
it. This could be useful as an end-point for a super-call in a framework
that uses cooperative multiple-inheritance.
This is not an accurate description of C++'s pure virtual functions.
Pure virtual functions CAN have an implementation, which can be called
from derived classes; this makes them behave just like Python's
abstractmethod.
Example:
struct Abstract {
virtual void foo() = 0;
};
void Abstract::foo() {
std::cout pure virtual function called;
}
struct Derived : public Abstract {
virtual void foo() {
Abstract::foo(); // call the abstract impl
}
};
--
assignee: georg.brandl
components: Documentation
messages: 82618
nosy: georg.brandl, jaredgrubb
severity: normal
status: open
title: abstractmethod vs C++ pure virtual
versions: Python 2.6
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5349
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5311] bdist_msi generates version number for pure Python packages
Changes by Tarek Ziadé ziade.ta...@gmail.com: -- versions: +Python 2.7, Python 3.1 -Python 2.5, Python 2.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5311 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4204] Cannot build _multiprocessing, math, mmap and readline of Python 2.6 on FreeBSD 4.11 w/ gcc 2.95.4
Zvezdan Petkovic zvez...@zope.com added the comment: Part of this patch committed in -r 67098 breaks Mac OS X 10.5, because the completion_matches() function is already declared in /usr/include/readline/readline.h and the new declaration conflicts with it. If the lack of this declaration is a problem for FreeBSD, then it will have to be conditionally declared for FreeBSD platform, and perhaps specific version of FreeBSD 4.x. Something along the lines of: #ifdef __FreeBSD__ /* perhaps a specific FreeBSD version condition here 4.x? */ extern char **completion_matches(char *, CPFunction *); #endif I have a patch of an off-by-one out-of-bounds error in readline.c, that enables building Python with Mac OS X native readline/editline emulation. There's no need for an external GNU readline port installation (unless one wants some features that editline perhaps doesn't have). That patch worked fine with Python 2.4 ad 2.5, but when I tried it with Python 2.6.1 the build failed because of the conflicting declaration introduced with this tracker issue. When the line extern char **completion_matches(char *, CPFunction *); is commented out, the readline module compiles and works OK. (Well, line 558 in setup.py needs to be uncommented to look like this: if platform == 'darwin' and os.uname()[2] '9.': to allow the use of Mac OS X readline/editline library) I can submit the readline.c patch for Mac OS X in a separate tracker issue, but the changes done in this issue should be fixed separately in my opinion. Please advise how to proceed. -- nosy: +zvezdan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4204 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue4111] Add DTrace probes
Changes by Chris Miles miles.ch...@gmail.com: -- nosy: +chrismiles ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4111 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
