[issue10292] tarinfo should use relative symlinks

2010-11-02 Thread Martin v . Löwis

Changes by Martin v. Löwis mar...@v.loewis.de:


--
assignee:  - lars.gustaebel
nosy: +lars.gustaebel

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10292
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1926] NNTPS support in nntplib

2010-11-02 Thread Andrew Vant

Andrew Vant ajv...@gmail.com added the comment:

At Antoine's suggestion I've written a new patch for this for 3.2, adding 
support for both SSL on 563 and STARTTLS on a normal connection. A NNTP_SSL 
class supports the former and a NNTP.starttls() method supports the latter. As 
a side effect of getting starttls working I had to add a NNTP.login() method as 
well. (see below)

The patch updates nntplib.py, test_nntplib.py, nntplib.rst, and Misc/NEWS. 

Some implementation notes: 

By default, NNTP objects attempt to log in during initialization,and there 
didn't seem to be any support for logging in later. This was a problem as 
STARTTLS has to be issued before logging in. In order to get around this and 
handle a STARTTLS nuance involving CAPABILITIES, I moved the authentication 
part of _NNTPBase.__init__ into a method of its own, NNTP.login(), and another 
piece of it into NNTP.getcapabilities(). This doesn't affect the observable 
behavior of NNTP() or the existing methods.

As a side note, IMHO NNTP shouldn't attempt to log in at initialization at all. 
The user, password, and usenetrc args should not be part of the constructors 
and the program using the library should be able to choose when or if to log in 
after connecting. I couldn't think of any way to do this without breaking 
existing programs, though. At the very least I think usenetrc should default to 
False, but that would break programs that rely on the default behavior too, I 
think. 

I updated the test cases, with a caveat. They use gmane to perform the tests. 
Gmane doesn't support starttls. Therefor the tests currently only check for 
correct failure rather than correct success. There's test code for the 
starttls() method but it never runs. I checked the functionality against 
eternal-september to be sure it does, in fact, correctly succeed as well, but 
I'm not about to put my login details in the automatic test script. ;-) 

The NNTPS-on-563 test, OTOH, works exactly like the existing NNTP test and 
seems to work fine. It was a hell of a lot easier to implement that part too.

Hope I didn't miss anything. First time doing this for a public project. 
Apparently the personal-itch theory is correct.

click

--
nosy: +ajvant
Added file: http://bugs.python.org/file19463/python_nntp_ssl_patch1.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1926
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1926] NNTPS support in nntplib

2010-11-02 Thread Andrew Vant

Andrew Vant ajv...@gmail.com added the comment:

Also, Julien: Thanks for mentioning the 563-discouraged thing. I added a note 
about it to the new documentation before submitting.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1926
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10293] PyMemoryView object has obsolete members

2010-11-02 Thread Kristján Valur Jónsson

New submission from Kristján Valur Jónsson krist...@ccpgames.com:

The PyMemoryObject has a base member which appears to be obsolete.  
Furthermore, the function do_release() attempt to perform some obsolete-looking 
woodo with base if it happens to be a tuple.  Looks dangerous.

--
components: Interpreter Core
messages: 120211
nosy: krisvale
priority: normal
severity: normal
status: open
title: PyMemoryView object has obsolete members
type: behavior
versions: Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10293
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10288] Remove

2010-11-02 Thread Marc-Andre Lemburg

Marc-Andre Lemburg m...@egenix.com added the comment:

Dave Malcolm wrote:
 
 New submission from Dave Malcolm dmalc...@redhat.com:
 
 Issue 5793 rationalized all usage of C character handling to use 
 Py_-prefixed locale-unaware macros, at the char level.
 
 In particular, this comment was added in two places to 
 Include/bytes_methods.h in r72044:
 http://svn.python.org/view/python/branches/py3k/Include/bytes_methods.h?view=diffr1=72043r2=72044
 
   /* These are left in for backward compatibility and will be removed
   in 2.8/3.2 */
 
 Given that 3.2 is coming soon, is it time to remove these?  (also, the 
 reference to 2.8 caught my eye)

+1

 Attached is a patch to py3k which removes them, and fixes up various users 
 that were still in the source tree.
 
 Am I right in thinking that the undef and redefinition of the various 
 lower-case macros from ctype.h was already intended to be removed? (given 
 that this messes about with a standard C library)

Please remove those as well. I suppose those were mainly used to find
instances of islower() et al. in the source code.

--
nosy: +lemburg
title: Remove deprecated C character handling macros ISUPPER() etc - Remove

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10288
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10086] test_sysconfig failure with site-packages

2010-11-02 Thread Hallvard B Furuseth

Hallvard B Furuseth h.b.furus...@usit.uio.no added the comment:

,AC�ric Araujo writes:
 Attaching a patch with your two suggestions.
 Added file: http://bugs.python.org/file19264/fix10086.diff

Not quite, since I suggested
   global_path.startswith(os.path.join(base, ))
instead of
   global_path.startswith(base)

I should have mentioned, the join appends a directory terminator
to base.  Not sure if that's the correct way to do it.  Anyway,
your patch does not catch a similar failure (if this can happen):

   base= /site
   global_path = /site-nonsense/...

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10086
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10288] Remove deprecated C character handling macros ISUPPER() etc

2010-11-02 Thread Marc-Andre Lemburg

Changes by Marc-Andre Lemburg m...@egenix.com:


--
title: Remove - Remove deprecated C character handling macros ISUPPER() etc

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10288
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10260] Add a threading.Condition.wait_for() method

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

 I spent some time thinking of a name.  I tried wait_predicate and
 predicate_wait, but wait_for seemed natural.  Any other ideas?
 How about wait_until_true?

wait_for is ok IMO.

 My original method had this as a free function, but I moved it into
 the Condition because I could see no other kind of primitive that
 would use it.  I agree that it is unfortunate to pull what is
 essentially a utility function into the Condition variable, so I am
 leaning towards keeping it a module function.

I'm not sure I see the point. It's an operation on a Condition variable,
so it's natural to have it as a Condition method. A module function
would feel rather weird.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10260
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2636] Regexp 2.7 (modifications to current re 2.2.2)

2010-11-02 Thread Vlastimil Brom

Vlastimil Brom vlastimil.b...@gmail.com added the comment:

There seems to be a bug in the handling of numbered backreferences in sub() in
issue2636-20101102.zip
I believe, it would be a fairly new regression, as it would be noticed rather 
soon.
(tested on Python 2.7; winXP)

 re.sub(([xy]), -\\1-, abxc)
'ab-x-c'
 regex.sub(([xy]), -\\1-, abxc)
Traceback (most recent call last):
  File stdin, line 1, in module
  File C:\Python27\lib\regex.py, line 176, in sub
return _compile(pattern, flags).sub(repl, string, count, pos, endpos)
  File C:\Python27\lib\regex.py, line 375, in _compile_replacement
compiled.extend(items)
TypeError: 'int' object is not iterable


vbr

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2636
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2636] Regexp 2.7 (modifications to current re 2.2.2)

2010-11-02 Thread Vlastimil Brom

Vlastimil Brom vlastimil.b...@gmail.com added the comment:

Sorry for the noise, please, forgot my previous msg120215;
I somehow managed to keep an older version of _regex_core.py along with the new 
regex.py in the Lib directory, which are obviously incompatible.
After updating the files correctly, the mentioned examples work correctly.

vbr

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2636
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue4510] ValueError for list.remove() not very helpful

2010-11-02 Thread Benjamin Peterson

Benjamin Peterson benja...@python.org added the comment:

This has already been implemented.

--
nosy: +benjamin.peterson
resolution:  - out of date
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue4510
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7266] test_lib2to3 failure under Windows

2010-11-02 Thread Benjamin Peterson

Changes by Benjamin Peterson benja...@python.org:


--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7266
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9796] Add summary tables for unittest API

2010-11-02 Thread Ezio Melotti

Ezio Melotti ezio.melo...@gmail.com added the comment:

issue9796-3.diff improves the rendering of the HTML tables. (Note: the patch 
just adds the tables, short paragraphs before them and moves a few methods 
around to match the division and the order of the tables, without changing 
their content.)

--
components: +Tests
Added file: http://bugs.python.org/file19464/issue9796-3.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9796
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9340] argparse parse_known_args does not work with subparsers

2010-11-02 Thread Steven Bethard

Steven Bethard steven.beth...@gmail.com added the comment:

Fixed with a variant of Catherine's patch (following R. David Murray's 
suggestion of inlining the two methods) in r86111 (3.X) and r86112 (2.7). Also 
added one more test to make sure that the order of the extra arguments is 
consistent (extra arguments from main parser before extra arguments from 
subparser).

--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed
versions:  -Python 3.1

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9340
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10273] Clean-up Unittest API

2010-11-02 Thread Ezio Melotti

Ezio Melotti ezio.melo...@gmail.com added the comment:

FWIW in addition to assertRegexpMatches and assertNotRegexpMatches there are 2 
more methods that use Regexp: assertRaisesRegexp and the newly introduced 
assertWarnsRegexp.

--
components: +Tests

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10273
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10273] Clean-up Unittest API

2010-11-02 Thread Michael Foord

Michael Foord mich...@voidspace.org.uk added the comment:

@Ezio

Good catch. Even though several of us (including myself) prefer assertRegex 
over assertRegexp it is probably better to have consistent APIs otherwise 
people will never remember which methods have the 'p' and which don't.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10273
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7826] support caching for 2to3

2010-11-02 Thread Benjamin Peterson

Benjamin Peterson benja...@python.org added the comment:

I'm going to reject this for now.

--
resolution:  - rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7826
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10288] Remove deprecated C character handling macros ISUPPER() etc

2010-11-02 Thread Eric Smith

Eric Smith e...@trueblade.com added the comment:

+1

I agree on removing the lowercase versions. It's sort of handy having them 
around to prevent accidental uses. But the same could be said for other similar 
macros/functions. Plus they wouldn't work if the isXXX symbols were really 
functions, not macros (not that I know if that's even allowed by the standard).

The patch looks okay to me, although I didn't actually compile and run the 
tests. You'll find out soon enough! The issue number in the NEWS entry needs to 
be fixed, of course.

Thanks for doing this, Dave.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10288
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10292] tarinfo should use relative symlinks

2010-11-02 Thread Lars Gustäbel

Lars Gustäbel l...@gustaebel.de added the comment:

Apparently you were in quite a hurry when you filed this bug report.

- What is the exact problem and how does it manifest itself?
- Any helpful details (tracebacks, output)?
- Is there a testcase or example code you can provide?
- Which other tools are you talking about?
- Your patch is faulty (upperdir is undefined).
- The patch does not apply to neither r27 tag nor release27-maint branch 
although you claim that 2.7 is affected.
- Which exact Python version are you using on what platform?
- Oh, and a little more politeness wouldn't hurt.

Okay, so please ask again. I am curious to see what you've found.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10292
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7292] Multiprocessing Joinable race condition?

2010-11-02 Thread Ask Solem

Changes by Ask Solem a...@opera.com:


--
nosy: +asksol

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7292
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5930] Transient error in multiprocessing (test_number_of_objects)

2010-11-02 Thread Ask Solem

Changes by Ask Solem a...@opera.com:


--
nosy: +asksol

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5930
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10267] test_ttk_guionly leaks many references

2010-11-02 Thread Hirokazu Yamamoto

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment:

It seems this issue can be fixed by attached patch.

--
keywords: +patch
nosy: +ocean-city
Added file: 
http://bugs.python.org/file19465/py3k_fix_test_ttk_guionly_refleak.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10267
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9733] Can't iterate over multiprocessing.managers.DictProxy

2010-11-02 Thread Ask Solem

Changes by Ask Solem a...@opera.com:


--
resolution:  - invalid
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9733
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue3876] multiprocessing does not compile on systems which do not define sem_timedwait

2010-11-02 Thread Ask Solem

Ask Solem a...@opera.com added the comment:

What is the status of this issue?  There are several platform listed here, 
which I unfortunately don't have access to.

--
nosy: +asksol

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3876
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9955] multiprocessing.Pipe segmentation fault when recv of unpicklable object

2010-11-02 Thread Ask Solem

Ask Solem a...@opera.com added the comment:

Can't reproduce on Python 2.7, but can indeed reproduce on 2.6.  Issue fixed?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9955
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10133] multiprocessing: conn_recv_string() broken error handling

2010-11-02 Thread Ask Solem

Changes by Ask Solem a...@opera.com:


--
nosy: +asksol

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10133
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10292] tarinfo should use relative symlinks

2010-11-02 Thread Jasper St. Pierre

Jasper St. Pierre jstpie...@mecheye.net added the comment:

Oh man, attaching the wrong diff and getting the diff wrong.

The issue I found with Python 2.7:

when creating a simple link in tar:

$ mkdir tar_test
$ cd tar_test
$ touch one
$ ln -s one two
$ cd ..
$ tar czf tar_test.tgz tar_test

It seems obvious that there would be a relative link in the tar file:

-rwxrwxrwx jstpierre/me 2010-11-02 10:57:15 tar_test/two - one

Unfortunately, as far as I can tell, tarfile treats this as an absolute path, 
and fails when extracting:

 tf.extractfile(tar_test/two)
Traceback (most recent call last):
  File stdin, line 1, in module
  File /usr/lib/python2.6/tarfile.py, line 2122, in extractfile
tarinfo))
  File /usr/lib/python2.6/tarfile.py, line 2105, in extractfile
if tarinfo.isreg():
AttributeError: 'NoneType' object has no attribute 'isreg'

I was trying to fix that.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10292
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8028] self.terminate() from a multiprocessing.Process raises AttributeError exception

2010-11-02 Thread Ask Solem

Ask Solem a...@opera.com added the comment:

It seems that Process.terminate is not meant to be used by the child, but only 
the parent.

From the documentation:

  Note that the start(), join(), is_alive() and exit_code methods
  should only be called by the process that created the process object.

Either terminate() should be added to this list,
or terminate should be patch to call sys.exit in a child process.

I vote for the former, so I attached a doc patch.

--
keywords: +patch
Added file: http://bugs.python.org/file19466/i8028.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8028
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10292] tarinfo should use relative symlinks

2010-11-02 Thread Jasper St. Pierre

Jasper St. Pierre jstpie...@mecheye.net added the comment:

Uh, I just noticed the python2.6 in the traceback.

Looks like I *was* using 2.6 because Cygwin decided
to downgrade for some reason.

Uh, sorry about that.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10292
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10038] json.loads() on str should return unicode, not str

2010-11-02 Thread Nik Tautenhahn

Nik Tautenhahn n...@livinglogic.de added the comment:

There is even more inconsistency here.

As already mentioned, we have this:


 import json
 json.loads(json.dumps(abc))

'abc'

If, however, I am evil and hide _json.so (which is the C-part of the json 
module for speedup), the JSON code falls back to its python implementation and 
voila:

 import json
 json.loads(json.dumps(abc))

u'abc'

Not so neat, if your fallback is not a fallback but shows such different 
behaviour.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10038
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5573] multiprocessing Pipe poll() and recv() semantics.

2010-11-02 Thread Ask Solem

Changes by Ask Solem a...@opera.com:


--
resolution:  - invalid
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5573
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8037] multiprocessing.Queue's put() not atomic thread wise

2010-11-02 Thread Ask Solem

Ask Solem a...@opera.com added the comment:

Pickling on put makes sense to me.  I can't think of cases where this could 
break existing code either.  I think this may also resolve issue 8323

--
stage:  - unit test needed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8037
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10038] json.loads() on str should return unicode, not str

2010-11-02 Thread Fred L. Drake, Jr.

Fred L. Drake, Jr. fdr...@acm.org added the comment:

Alternately, the Python implementation may be thought of as definitive
and the optimizations are broken.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10038
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9919] gdbinit lineno result is one line in excess

2010-11-02 Thread qpatata

qpatata qpat...@gmail.com added the comment:

I'm sorry, I've not explained correctly.

I'm wondering if the addition of the \n is ok or not, taken into account that 
it breaks the format of the pyframe macro output. It could be better to keep 
the older version (without the \n).

Kind regards.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9919
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9796] Add summary tables for unittest API

2010-11-02 Thread Ezio Melotti

Ezio Melotti ezio.melo...@gmail.com added the comment:

Updated patch after the changes made in r86118.

--
Added file: http://bugs.python.org/file19467/issue9796-4.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9796
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10294] Lib/test/test_unicode_file.py contains dead code

2010-11-02 Thread Stefan Behnel

New submission from Stefan Behnel sco...@users.sourceforge.net:

Lib/test/test_unicode_file.py contains dead code:

def _test_equivalent(self, filename1, filename2):
remove_if_exists(filename1)
self.assertTrue(not os.path.exists(filename2))
f = file(filename1, w)
f.close()
try:
self._do_equivalent(filename1, filename2)
finally:
os.unlink(filename1)

Note how this refers to the now-gone file(). The method is never used in the 
test code. Similarly, the _do_equivalent() method that it calls appears 
otherwise unused.

--
components: Tests
messages: 120236
nosy: scoder
priority: normal
severity: normal
status: open
title: Lib/test/test_unicode_file.py contains dead code
versions: Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10294
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10038] json.loads() on str should return unicode, not str

2010-11-02 Thread Walter Dörwald

Walter Dörwald wal...@livinglogic.de added the comment:

The following patch (against the release27-maint branch) seems to fix the 
problem.

--
keywords: +patch
nosy: +doerwalter
Added file: http://bugs.python.org/file19468/json.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10038
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2001] Pydoc interactive browsing enhancement

2010-11-02 Thread Ron Adam

Ron Adam ron_a...@users.sourceforge.net added the comment:

Nick, I can update the patch and move the server back into pydoc.py if that 
will help you get this into 3.2 beta.

I can also changed the docstrings of the new parts to # comments.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2001
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1926] NNTPS support in nntplib

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Andrew, thank you for posting a patch.
I have a couple of comments:

* the command-line option for the SSLContext won't work, since a context is a 
custom object, not a string; I would rework this part anyway, since I don't 
think separate options for the SSL host are useful (I'd rather add a 
SSL-enabling flag; also, STARTTLS can be queried from the capabilities)

* on a stylistic note, there are a couple of places where you use tabs for 
indentation; also, comments should have a space after the '#' ('# xxx' and not 
'#xxx')

* not moving methods around (such as getwelcome) would make it easier to review 
the real changes

* in test_starttls, I would clearly report that the server doesn't support 
STARTTLS, e.g.:

except nntplib.NNTPPermanentError:
self.skip(STARTTLS not supported by server)

* starttls() should probably test the `tls_on` attribute first and raise a 
ValueError if True (as you point out, a client mustn't attempt to start a new 
TLS session if one is already active).


All in all, it looks good though.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1926
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10267] test_ttk_guionly leaks many references

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Hirokazu's patch works for me.

--
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10267
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10294] Lib/test/test_unicode_file.py contains dead code

2010-11-02 Thread Antoine Pitrou

Changes by Antoine Pitrou pit...@free.fr:


--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10294
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9635] Add Py_BREAKPOINT and sys._breakpoint hooks

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

I would rename Py_BREAKPOINT to _Py_BREAKPOINT since we don't really want to 
support this. Also, why do you allow any arguments to sys._breakpoint()?

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9635
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1926] NNTPS support in nntplib

2010-11-02 Thread Julien ÉLIE

Julien ÉLIE jul...@trigofacile.com added the comment:

Thanks a lot for having implemented STARTTLS, Andrew!
That's great news!



+Since the order in which certain operations need to be done varies
+between normal, SSL, and STARTTLS connections varies, some
+initialization must be done in the subclasses. 

One varies is enough.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1926
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10240] dict.update.__doc__ is misleading

2010-11-02 Thread Éric Araujo

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +eric.araujo
versions:  -Python 2.5, Python 2.6, Python 3.3

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10240
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2636] Regexp 2.7 (modifications to current re 2.2.2)

2010-11-02 Thread Matthew Barnett

Matthew Barnett pyt...@mrabarnett.plus.com added the comment:

issue2636-20101102a.zip is a new version of the regex module.

msg120204 relates to issue #1519638 Unmatched group in replacement. In 
'regex' an unmatched group is treated as an empty string in a replacement 
template. This behaviour is more in keeping with regex implementations in other 
languages.

msg120206 was caused by not all group references being made case-insensitive 
when they should be.

--
Added file: http://bugs.python.org/file19469/issue2636-20101102a.zip

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2636
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10038] json.loads() on str should return unicode, not str

2010-11-02 Thread Barry A. Warsaw

Barry A. Warsaw ba...@python.org added the comment:

The fact that the C and Python versions are not fully tested (afaict) is not 
good.  I'm not sure that's worth fixing for 2.7 and it's probably worth a 
separate bug report for Python 3.2 on that.

In the meantime, I'll test Walter's patch and add a unit test for this case.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10038
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1500504] Alternate RFC 3986 compliant URI parsing module

2010-11-02 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

Is this still relevant?  Can’t the improvements make it into urllib.parse?

--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1500504
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10171] Ugly buttons in some Tkinter objects in Windows

2010-11-02 Thread Rafe Kettler

Rafe Kettler rafe.kett...@gmail.com added the comment:

I've tested how these dialogs display in regular Tcl/Tk, and it appears the 
problem resides in the Tcl implementation, not the Python binding. You can see 
for yourself by running this Tcl script:

package require Tk
tk_messageBox
tk_chooseColor

Since this is not a Tkinter or Python issue, I think the issue should be closed 
and a bug (if it doesn't exist already) should be filed with the Tcl/Tk 
developers.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10171
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10038] json.loads() on str should return unicode, not str

2010-11-02 Thread Fred L. Drake, Jr.

Fred L. Drake, Jr. fdr...@acm.org added the comment:

The incomplete testing and C/Python implementation mismatch are covered by 
issue 5723 and issue 9233.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10038
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10294] Lib/test/test_unicode_file.py contains dead code

2010-11-02 Thread Brett Cannon

Brett Cannon br...@python.org added the comment:

Committed in r86125

--
assignee:  - brett.cannon
nosy: +brett.cannon
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10294
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10252] Fix resource warnings in distutils

2010-11-02 Thread Brian Brazil

Brian Brazil brian.bra...@gmail.com added the comment:

I don't see your patch on the other bug, so I've updated mine not to use with.

--
Added file: http://bugs.python.org/file19470/distutils_fd_leak_v2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10252
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue5843] Normalization error in urlunparse

2010-11-02 Thread Éric Araujo

Changes by Éric Araujo mer...@netwok.org:


--
components: +Library (Lib)
title: Possible normalization error in urlparse.urlunparse - Normalization 
error in urlunparse
versions: +Python 2.7, Python 3.1, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue5843
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10215] Mac Python 3.1 installer does less than earlier installers

2010-11-02 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

Does 3.2 install into a Python3.framework?  In other words, is the conception 
that 2.x and 3.x are two different languages ported over to Mac?

--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10215
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10215] Mac Python 3.1 installer does less than earlier installers

2010-11-02 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

Without typos: Does 3.1 install into a Python3.framework directory?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10215
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10206] python program starting with unmatched quote spews spaces to stdout

2010-11-02 Thread Éric Araujo

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +benjamin.peterson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10206
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8994] pydoc does not support non-ascii docstrings

2010-11-02 Thread Torsten Landschoff

Torsten Landschoff t.landsch...@gmx.net added the comment:

You are right, this is a duplicate of #6625. And in fact I should have known 
since I commented on that bug...

--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8994
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10198] wave module writes corrupt wav file for zero-length writeframes

2010-11-02 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

That revision is actually an edit to re.rst.

Is the patch irrelevant for other branches?

--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10198
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8488] Docstrings of non-data descriptors ignored

2010-11-02 Thread Torsten Landschoff

Torsten Landschoff t.landsch...@gmx.net added the comment:

FYI, this still applies to r86094 of py3k.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8488
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10038] json.loads() on str should return unicode, not str

2010-11-02 Thread Raymond Hettinger

Raymond Hettinger rhettin...@users.sourceforge.net added the comment:

To mitigate possible negative impacts from changing the return type, consider 
adding a parse_string hook that lets users control the return type:

   json.loads(f, parse_int=decimal.Decimal, parse_string=repr)

--
nosy: +rhettinger

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10038
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue6625] UnicodeEncodeError on pydoc's CLI

2010-11-02 Thread STINNER Victor

Changes by STINNER Victor victor.stin...@haypocalc.com:


--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue6625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10038] json.loads() on str should return unicode, not str

2010-11-02 Thread Barry A. Warsaw

Barry A. Warsaw ba...@python.org added the comment:

Adding that argument to Python 2.7 seems like new feature territory.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10038
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8488] Docstrings of non-data descriptors ignored

2010-11-02 Thread Raymond Hettinger

Changes by Raymond Hettinger rhettin...@users.sourceforge.net:


--
priority: normal - low

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8488
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10038] json.loads() on str should return unicode, not str

2010-11-02 Thread Barry A. Warsaw

Barry A. Warsaw ba...@python.org added the comment:

@doerwalter: patch looks good.  I've added a test and will commit momentarily.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10038
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10038] json.loads() on str should return unicode, not str

2010-11-02 Thread Barry A. Warsaw

Barry A. Warsaw ba...@python.org added the comment:

r86126

--
assignee: bob.ippolito - barry
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10038
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9999] test_shutil cross-file-system tests are fragile (may not test what they purport to test)

2010-11-02 Thread Éric Araujo

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +eric.araujo
title: test_shutil cross-file-system tests are fragile (may not test what they 
pruport to test) - test_shutil cross-file-system tests are fragile (may not 
test what they purport to test)

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8488] Docstrings of non-data descriptors ignored

2010-11-02 Thread Benjamin Peterson

Benjamin Peterson benja...@python.org added the comment:

pydoc should probably be adapted to look at a type for descrs.

--
nosy: +benjamin.peterson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8488
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10181] get_shape0 in memoryobject.c not checked for error return

2010-11-02 Thread Éric Araujo

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10181
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9849] Argparse needs better error handling for nargs

2010-11-02 Thread Éric Araujo

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +eric.araujo
stage:  - needs patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9849
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9846] ZipExtFile provides no mechanism for closing the underlying file object

2010-11-02 Thread Éric Araujo

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9846
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9736] doctest.DocTestSuite doesn't handle test globs correctly

2010-11-02 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

Would you like to work on a patch?

(Setting the versions field to versions that are open for bug fixes.)

--
nosy: +eric.araujo
stage:  - needs patch
type:  - behavior
versions: +Python 3.2 -Python 2.5, Python 2.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9736
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10263] python -m site does not print path details

2010-11-02 Thread Nick Coghlan

Nick Coghlan ncogh...@gmail.com added the comment:

Yeah, because the internal import system isn't fully exposed, runpy and a 
couple of other tools in the standard library rely on the emulation in pkgutil 
instead. I know there are some differences between the emulation and the 
builtin mechanism on Windows in terms of search order, but I thought they were 
the same on OS X.

Manipulating sys.path and the various caches in sys should affect both import 
mechanisms though - just what are setuptools/distribute doing?

I'm also curious as to which version of the module importlib finds (import 
importlib; print(importlib.import_module(site).__file__) will tell you that 
for both 2.7 and 3.x)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10263
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9625] argparse: Problem with defaults for variable nargs

2010-11-02 Thread Éric Araujo

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9625
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2001] Pydoc interactive browsing enhancement

2010-11-02 Thread Nick Coghlan

Nick Coghlan ncogh...@gmail.com added the comment:

On Wed, Nov 3, 2010 at 2:17 AM, Ron Adam rep...@bugs.python.org wrote:

 Ron Adam ron_a...@users.sourceforge.net added the comment:

 Nick, I can update the patch and move the server back into pydoc.py if that 
 will help you get this into 3.2 beta.

Yep, probably the best option 3.2 - then make a new issue about making
those public in the standard library (since they aren't really
pydoc-specific).

 I can also changed the docstrings of the new parts to # comments.

Just mark the various names with an underscore so people know the
current names aren't final. There's no harm in leaving the docstrings
in place if you do that.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2001
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10284] Exception raised when decoding NNTP newsgroup descriptions

2010-11-02 Thread Julien ÉLIE

Julien ÉLIE jul...@trigofacile.com added the comment:

David, the headers are not at all supposed to be utf-8 encoded.
For instance, have a look at the cn.bbs.comp.lang.python newsgroup:

http://groups.google.fr/group/cn.bbs.comp.lang.python

If you look at the source of the articles, you will for instance see that the 
Subject: header field is not MIME-encoded.  It is directly written in gb2312.

That's how news works in the wild.  Please do not break nntplib in Python 3.2!


Regarding AUTHINFO, the specification is not broken at all.  Bytes are 
expected, not strings in a particular encoding.  Well, most people are in fact 
confused when they speak about encodings -- me included :-)
The specification is pretty clear:  NNTP expects bytes.  And my text string is 
\xC9ric, that's all.  Please also do not break nntplib when providing such 
strings on class instantiation.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10284
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9587] unittest.assertRaises() return the raised exception

2010-11-02 Thread Éric Araujo

Changes by Éric Araujo mer...@netwok.org:


--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9587
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1500504] Alternate RFC 3986 compliant URI parsing module

2010-11-02 Thread Nick Coghlan

Nick Coghlan ncogh...@gmail.com added the comment:

I still like the higher level API concept, although I might not do it exactly 
as presented here any more.

Independently of introducing a new parsing API, it would be worthwhile 
extracting the parsing tests from the attached module to make sure the 
*existing* parser can handle them all correctly.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1500504
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue670664] HTMLParser.py - more robust SCRIPT tag parsing

2010-11-02 Thread Éric Araujo

Éric Araujo mer...@netwok.org added the comment:

Would it be reasonable to add knowledge to html.parser to make it recognize 
script elements as CDATA and handle it correctly (that is let “” pass)?

--
nosy: +eric.araujo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue670664
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10284] Exception raised when decoding NNTP newsgroup descriptions

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

 And my text string is \xC9ric, that's all.

You mean b\xC9ric, right?

 If you look at the source of the articles, you will for instance see
 that the Subject: header field is not MIME-encoded.  It is directly
 written in gb2312.

How is an NNTP client supposed to guess the encoding? Either a header is 
MIME-encoded, or it follows the RFC 3977 recommendation of UTF-8 (“The content 
of a header SHOULD be in UTF-8”), or it's unreadable.

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10284
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10181] get_shape0 in memoryobject.c not checked for error return

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Yes, there are probably many holes like this. I've done what I could to make 
the simple cases (builtin types) to work, but the spec is rotten from the 
start. Blame the numpy people, sorry.

--
nosy: +ncoghlan

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10181
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10181] get_shape0 in memoryobject.c not checked for error return

2010-11-02 Thread Nick Coghlan

Nick Coghlan ncogh...@gmail.com added the comment:

As far as I know, PEP 3118 serves its purpose of allowing extension modules 
like numpy and PIL to share data without needing to copy it around all the 
time. It's just that memoryview wasn't really part of that purpose (since all 
the affected third party libraries have their own objects for looking at 
memory), and it shows :P

Our near term goal should be to get memoryview in a good place for handling 1D 
contiguous data and throw exceptions (rather than crashing) for everything 
else. I think Antoine has achieved the former, but it sounds like there is 
still some work to do on the latter.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10181
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2927] expose html.parser.unescape

2010-11-02 Thread Tom Pinckney

Tom Pinckney thomaspinckn...@gmail.com added the comment:

I don't think Django includes an HTML unescape. I'm not familiar with other 
frameworks. So I'd still find this useful to include in the stdlib.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2927
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10181] get_shape0 in memoryobject.c not checked for error return

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

 As far as I know, PEP 3118 serves its purpose of allowing extension
 modules like numpy and PIL to share data without needing to copy it
 around all the time. It's just that memoryview wasn't really part of
 that purpose (since all the affected third party libraries have their
 own objects for looking at memory), and it shows :P

The deeper issue is that there are no ownership or lifetime rules for
dynamically allocated fields in Py_buffer (such as strides and shape),
which itself isn't a PyObject. For very simple objects (such as bytes or
bytearray) it isn't really a problem, but it is in more complicated
situations; and there's no possible solution without a clear spec..

(and I'm not even talking of the issue of making slices of memoryviews,
since the buffer API itself doesn't handle slicing, which means the
memoryview object has to modify its inner Py_buffer...)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10181
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10280] nntp_version set to the most recent advertised version

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

I've fixed it according to your suggestion (take the max of the advertised 
version) in r86129. Thank you!

--
resolution:  - fixed
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10280
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10281] Exception raised when an NNTP overview field is absent

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

I am wondering how to return the corresponding information. Should the field be 
totally absent from the returned dictionary, should it map to the empty string, 
or should it map to None?
I'm leaning towards the latter (map to None), but perhaps the empty string is 
better?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10281
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10284] Exception raised when decoding NNTP newsgroup descriptions

2010-11-02 Thread Julien ÉLIE

Julien ÉLIE jul...@trigofacile.com added the comment:

Antoine, a news client could guess it because of the Content-Type: header field 
(in this example, it mentions charset=gb2312).
Yet, articles without a Content-Type: header field exist in the wild...
There is no way to always make the right guess, unfortunately.
News clients try to do their best :-)


Yes, I mean b\xC9ric.  4 bytes.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10284
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10215] Mac Python 3.1 installer does less than earlier installers

2010-11-02 Thread Bruce Sherwood

Bruce Sherwood bruce.sherw...@gmail.com added the comment:

Yes. After installation, you'll see that Python 3.1 is in
/Library/Frameworks/Python.framework/Versions/3.1

Bruce Sherwood

On Tue, Nov 2, 2010 at 1:45 PM, Éric Araujo rep...@bugs.python.org wrote:

 Éric Araujo mer...@netwok.org added the comment:

 Without typos: Does 3.1 install into a Python3.framework directory?

 --

 ___
 Python tracker rep...@bugs.python.org
 http://bugs.python.org/issue10215
 ___


--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10215
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10281] Exception raised when an NNTP overview field is absent

2010-11-02 Thread Julien ÉLIE

Julien ÉLIE jul...@trigofacile.com added the comment:

The empty string would mean the header exists, and is empty (though not 
RFC-compliant).
For instance:

User-Agent: \r\n

I believe None is better.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10281
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10284] Exception raised when decoding NNTP newsgroup descriptions

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

 Antoine, a news client could guess it because of the Content-Type:
 header field (in this example, it mentions charset=gb2312).
 Yet, articles without a Content-Type: header field exist in the
 wild...

Unless I'm mistaken, Content-Type should only apply to the body, not the
headers. Either the headers use UTF-8 (RFC 3977), or they should be
MIME-encoded. Everything else is undecodable.

 There is no way to always make the right guess, unfortunately.
 News clients try to do their best :-)

Well, a news client built on nntplib could also try to do its best :)

 Yes, I mean b\xC9ric.  4 bytes.

Ok, perhaps we should allow bytes username and password.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10284
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9736] doctest.DocTestSuite doesn't handle test globs correctly

2010-11-02 Thread Jim Fulton

Jim Fulton j...@zope.com added the comment:

On Tue, Nov 2, 2010 at 5:55 PM, Éric Araujo rep...@bugs.python.org wrote:

 Éric Araujo mer...@netwok.org added the comment:

 Would you like to work on a patch?

Sure.

Jim

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9736
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10281] Exception raised when an NNTP overview field is absent

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Here is a patch for returning None on absent fields.
(works with trigofacile.com)

--
keywords: +patch
Added file: http://bugs.python.org/file19471/nntpover.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10281
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10284] Exception raised when decoding NNTP newsgroup descriptions

2010-11-02 Thread Julien ÉLIE

Julien ÉLIE jul...@trigofacile.com added the comment:

 Unless I'm mistaken, Content-Type should only apply to the body, not the
 headers.  Either the headers use UTF-8 (RFC 3977), or they should be
 MIME-encoded.  Everything else is undecodable.

Yes, of course.  Such articles are not RFC-compliant.  You're not mistaken when 
you mention that the Content-Type: header field applies to the body.
I was just answering about how the encoding could be guessed.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10284
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10181] get_shape0 in memoryobject.c not checked for error return

2010-11-02 Thread Nick Coghlan

Nick Coghlan ncogh...@gmail.com added the comment:

Read the Releasing the buffer section in PEP 3118 again. Unless I'm 
misunderstanding you completely, the rules you're asking for are already in 
place: those fields are entirely the responsibility of the exporting object, 
and it needs to ensure they remain valid until the buffer is released.

Now, it may be that we haven't *implemented* this correctly or consistently in 
the builtin objects, in which case we should do something about it. But the 
rules are there.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10181
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10181] get_shape0 in memoryobject.c not checked for error return

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

 Read the Releasing the buffer section in PEP 3118 again. Unless I'm
 misunderstanding you completely, the rules you're asking for are
 already in place: those fields are entirely the responsibility of the
 exporting object, and it needs to ensure they remain valid until the
 buffer is released.

In practice, though, we copy Py_buffer structs around and there's no way
for the original object to know about that. That's the fundamental
difference with a PyObject where you would only increase a refcount
instead of copying the structure's contents.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10181
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10281] Exception raised when an NNTP overview field is absent

2010-11-02 Thread Julien ÉLIE

Julien ÉLIE jul...@trigofacile.com added the comment:

OK, thanks.
By the way, why is the token stripped?
  token = token[len(h):].lstrip( )

X-Header:   test  \r\n in an header is kept in the overview as-is.
I do not see why   test   should not be the value returned.

Also, with:
  token = token or None

X-Header: \r\n becomes None if I understand how the source code works...  
Yet, it is a real '', not None.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10281
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10281] Exception raised when an NNTP overview field is absent

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

 OK, thanks.
 By the way, why is the token stripped?
   token = token[len(h):].lstrip( )
 
 X-Header:   test  \r\n in an header is kept in the overview as-is.
 I do not see why   test   should not be the value returned.

It's a simple way of handling Xref: foo and returning foo rather
than  foo. If spaces are supposed to be significant I can just strip
the first one, though.

 Also, with:
   token = token or None
 
 X-Header: \r\n becomes None if I understand how the source code
 works...  Yet, it is a real '', not None.

Er, so you're disagreeing with your previous message? Or am I missing
something? :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10281
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8037] multiprocessing.Queue's put() not atomic thread wise

2010-11-02 Thread Vilnis Termanis

Vilnis Termanis vilnis.terma...@googlemail.com added the comment:

Please find attached an updated patch (including unit test) for the 
release27-maint branch. I've run the test_multiprocessing suite against svn 
revision 86129 of said branch.

--
Added file: http://bugs.python.org/file19472/patch_27maint.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8037
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1926] NNTPS support in nntplib

2010-11-02 Thread Andrew Vant

Andrew Vant ajv...@gmail.com added the comment:

On 2 Nov 2010 at 17:05, Antoine Pitrou wrote:

 * the command-line option for the SSLContext won't work, since a
 context is a custom object, not a string; I would rework this part
 anyway, since I don't think separate options for the SSL host are
 useful (I'd rather add a SSL-enabling flag; also, STARTTLS can be
 queried from the capabilities)

I'm not sure I understand which part you're talking about herethe 
tests don't take a context for anything that I can see, and the 
mechanism I use in nntplib (a context as a named argument) is the 
same one used in smtplib and poplib for prot_SSL. 

(if you can suggest a method-of-use that breaks it, that may enlighten
me better) 

 * on a stylistic note, there are a couple of places where you use tabs
 for indentation; also, comments should have a space after the '#' ('#
 xxx' and not '#xxx')

Meh. My editor wasn't set up properly when I started. I thought I'd 
eliminated all the tabs. Guess not. There's probably a way to grep 
for lines that have tabs in them, I'll fix it.

 * not moving methods around (such as getwelcome) would make it easier
 to review the real changes

I'll see what I can do. Some amount of that was necessary to fit 
STARTTLS in. (because init assumed you wanted to log in right away 
and never again) 

 * in test_starttls, I would clearly report that the server doesn't
 support STARTTLS, e.g.:

Can do. I didn't know about self.skip; I don't really understand the 
testing framework, I was just working by comparison to the other 
tests.

 * starttls() should probably test the `tls_on` attribute first and
 raise a ValueError if True (as you point out, a client mustn't attempt
 to start a new TLS session if one is already active).

...I actually meant to do exactly that, but forgot to put the check 
in. Thank you. 

--

Andrew.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1926
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10281] Exception raised when an NNTP overview field is absent

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Here is a patch trying to better handle whitespace. Would it be ok for you?

--
Added file: http://bugs.python.org/file19473/nntpover2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10281
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10281] Exception raised when an NNTP overview field is absent

2010-11-02 Thread Antoine Pitrou

Changes by Antoine Pitrou pit...@free.fr:


Removed file: http://bugs.python.org/file19473/nntpover2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10281
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue10281] Exception raised when an NNTP overview field is absent

2010-11-02 Thread Antoine Pitrou

Antoine Pitrou pit...@free.fr added the comment:

Oops, sorry.

--
Added file: http://bugs.python.org/file19474/nntpover2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue10281
___
___
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >