[issue18521] [cppcheck] Full report

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Shouldn't converttuple() in getargs.c set levels[1] = 0; after second 
levels[0] = i+1;?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18521
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18521] [cppcheck] Full report

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Agree that all other looks false positive or unimportant.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18521
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19256] Optimize marshal format and add version token.

2013-10-14 Thread Raymond Hettinger

Raymond Hettinger added the comment:

Unlike pickle, the marshal module makes no promises about keeping the format 
consistent between Python versions.

--
nosy: +rhettinger

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19257] Sub-optimal error message when importing a non-package

2013-10-14 Thread Alex Gaynor

New submission from Alex Gaynor:

Use case:

Alexanders-MacBook-Pro:pypy alex_gaynor$ python3.3
Python 3.3.2 (default, May 29 2013, 14:03:57)
[GCC 4.2.1 Compatible Apple LLVM 4.2 (clang-425.0.28)] on darwin
Type help, copyright, credits or license for more information.
 import datetime.datetime
Traceback (most recent call last):
  File frozen importlib._bootstrap, line 1521, in _find_and_load_unlocked
AttributeError: 'module' object has no attribute '__path__'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File stdin, line 1, in module
ImportError: No module named 'datetime.datetime'; datetime is not a package




Showing the user the original module has no attribute __path__ error is just 
confusing, we should hide it.

--
messages: 199847
nosy: alex
priority: normal
severity: normal
status: open
title: Sub-optimal error message when importing a non-package

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19257
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19189] Improve cross-references in pickle documentation.

2013-10-14 Thread Roundup Robot

Roundup Robot added the comment:

New changeset c99a3566be83 by Serhiy Storchaka in branch '2.7':
Issue #19189: Improved cross-references in the pickle module documentation.
http://hg.python.org/cpython/rev/c99a3566be83

New changeset f2c725fb4b2f by Serhiy Storchaka in branch '3.3':
Issue #19189: Improved cross-references in the pickle module documentation.
http://hg.python.org/cpython/rev/f2c725fb4b2f

New changeset 37c06d20dda5 by Serhiy Storchaka in branch 'default':
Issue #19189: Improved cross-references in the pickle module documentation.
http://hg.python.org/cpython/rev/37c06d20dda5

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19189
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19189] Improve cross-references in pickle documentation.

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Thank you Georg for your review and for your suggestion.

--
resolution:  - fixed
stage: patch review - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19189
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18758] Fix internal references in the documentation

2013-10-14 Thread Serhiy Storchaka

Changes by Serhiy Storchaka storch...@gmail.com:


--
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18758
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19256] Optimize marshal format and add version token.

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

The version token needed only when we want break backward compatibility (change 
the meaning of existing opcodes).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18919] Unify audio modules tests

2013-10-14 Thread koobs

koobs added the comment:

Tests fail for 2.7 on the koobs-freebsd9 and koobs-freebsd10 buildbots since 
a9f967c8d002db364021a5fb1c9926a27029e849

Taking a snapshot of the output here for reference:

test_aifc
test test_aifc produced unexpected output:
**
Warning: bad COMM chunk size
Warning: bad COMM chunk size
Warning: MARK chunk contains only 0 markers instead of 1

**

snip

363 tests OK.
1 test failed:
test_aifc

snip

Re-running failed tests in verbose mode
Re-running test 'test_aifc' in verbose mode

snip

test_read_comm_kludge_compname_even (test.test_aifc.AIFCLowLevelTest) ... 
Warning: bad COMM chunk size
ok
test_read_comm_kludge_compname_odd (test.test_aifc.AIFCLowLevelTest) ... 
Warning: bad COMM chunk size
ok
test_read_wrong_marks (test.test_aifc.AIFCLowLevelTest) ... Warning: MARK chunk 
contains only 0 markers instead of 1
ok

--
Ran 80 tests in 0.102s

OK

--
nosy: +koobs

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18919
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18606] Add statistics module to standard library

2013-10-14 Thread Nick Coghlan

Nick Coghlan added the comment:

+0 for starting with _sum as private and +1 for getting this initial
version checked in for alpha 4.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18606
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19252] Enum.py : Enum.__new__() : Test Coverage

2013-10-14 Thread CliffM

CliffM added the comment:

Sorry -- I could have been clearer :

The conditional:

 if member.value == value:

Is redundant as the tests stand.  If you comment it out -- everything works. So 
therefore we are missing a test.

The current test works, as red is the first value to pop out of the value() 
list.  

This makes the if-clause fragile for future maintenance.  So we need another 
test to ensure the loop is covered.

It's a coverage issue -- where although the code is executed by the test, and 
the code is correct, the test is not complete enough for the code.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19252
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18919] Unify audio modules tests

2013-10-14 Thread Serhiy Storchaka

Changes by Serhiy Storchaka storch...@gmail.com:


--
stage: committed/rejected - patch review
status: closed - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18919
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18919] Unify audio modules tests

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Is unexpected output considered as test failing? The aifc module uses bare 
print to output these warnings to stdout. Here is a patch which uses 
captured_stdout().

--
Added file: http://bugs.python.org/file32109/test_aifc_capture_warnings.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18919
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19257] Sub-optimal error message when importing a non-package

2013-10-14 Thread Berker Peksag

Changes by Berker Peksag berker.pek...@gmail.com:


--
nosy: +brett.cannon, eric.snow
versions: +Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19257
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19217] Calling assertEquals for moderately long list takes too long

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Perhaps a combination of len(pprint.pformat(seq1).splitlines()) and 
len(pprint.pformat(seq2).splitlines()) (minimum, maximum or production) is 
better metric?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19217
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19256] Optimize marshal format and add version token.

2013-10-14 Thread Antoine Pitrou

Antoine Pitrou added the comment:

 The version token needed only when we want break backward
 compatibility (change the meaning of existing opcodes).

This is true. For example, my first hunch was to make w_long()
emit variable-length data, (0-254: one byte integer, 255: four
bytes integer following the 255 prefix).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19246] GC does not really free up memory in console

2013-10-14 Thread Esa Peuha

Esa Peuha added the comment:

 So best guess is that Microsoft's allocators have gotten fatally fragmented, 
 but I don't know how to confirm/refute that.

Let's test this in pure C. Compile and run the attached uglyhack.c on win32; if 
it reports something significantly less than 100%, it's probably safe to 
conclude that this has nothing to do with Python.

--
nosy: +Esa.Peuha
Added file: http://bugs.python.org/file32110/uglyhack.c

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19246
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19258] Got resource warning when running wsgiref demo app

2013-10-14 Thread Vajrasky Kok

New submission from Vajrasky Kok:

./python Lib/wsgiref/simple_server.py 
Serving HTTP on 0.0.0.0 port 8000 ...
127.0.0.1 - - [14/Oct/2013 17:23:43] GET /xyz?abc HTTP/1.1 200 4510
sys:1: ResourceWarning: unclosed socket.socket fd=4, family=2, type=1, 
proto=0, laddr=('0.0.0.0', 8000)

Attached the patch to close the socket.

--
components: Library (Lib)
files: close_server_in_wsgiref_demo.patch
keywords: patch
messages: 199858
nosy: vajrasky
priority: normal
severity: normal
status: open
title: Got resource warning when running wsgiref demo app
type: resource usage
versions: Python 3.4
Added file: http://bugs.python.org/file32111/close_server_in_wsgiref_demo.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19258
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19254] Python implementation of PBKDF2_HMAC

2013-10-14 Thread Christian Heimes

Christian Heimes added the comment:

Here is an optimized version with inline HMAC.

Contrary to the implementations in OpenSSL, PyCrypto, and pbkdf2.py the length 
of the password has almost no impact on the runtime of my implementation.

--
Added file: http://bugs.python.org/file32112/pbkdf2_py2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19254
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19082] Lib/xmlrpc/client.py demo code points to the dead server

2013-10-14 Thread Vajrasky Kok

Vajrasky Kok added the comment:

Hi, Senthil Kumaran, thank you for your review.

I have one small complain about your improved patch. Perhaps we need to give 
security warning when they want to use allow_dotted_names feature in the 
documentation. I omitted the warning in the demo because it is just a demo.

From the source code (Lib/xmlrpc/server.py):
*** SECURITY WARNING: ***

Enabling the allow_dotted_names options allows intruders
to access your module's global variables and may allow
intruders to execute arbitrary code on your machine.  Only
use this option on a secure, closed network.

Whether we want to give a separate example without allow_dotted_names feature 
or using example without allow_dotted_names feature entirely, I am not really 
sure.

What do you say?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19082
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18965] 2to3 can produce illegal bytes literals

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Benjamin, what would you say about this?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18965
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19085] Add tkinter basic options tests

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

If there are no objections I'm going to commit this.

--
assignee:  - serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19085
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1575020] Request wave support 16 bit samples

2013-10-14 Thread Serhiy Storchaka

Changes by Serhiy Storchaka storch...@gmail.com:


--
assignee:  - serhiy.storchaka
stage: test needed - needs patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1575020
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2259] Poor support other than 44.1khz, 16bit audio files?

2013-10-14 Thread Serhiy Storchaka

Changes by Serhiy Storchaka storch...@gmail.com:


--
assignee:  - serhiy.storchaka
stage: test needed - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2259
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19254] Python implementation of PBKDF2_HMAC

2013-10-14 Thread Christian Heimes

Christian Heimes added the comment:

I have optimized XOR and now it's even faster than OpenSSL's code for 
reasonable long passwords. :(

--
Added file: http://bugs.python.org/file32113/pbkdf2_py3.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19254
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19232] Speed up _decimal import

2013-10-14 Thread Stefan Krah

Stefan Krah added the comment:

About IDLE I can't say anything, but I'm not entirely sure if the
PEP-399 import method is easier to understand for users, see e.g.:

http://stackoverflow.com/questions/13194384/instantiate-decimal-class

I get the impression that the posters at first did not even realize
that there *is* an accelerator in Python 3.3, so they had a hard time
debugging the issue.


As for the load time: Personally I don't have any application
that relies on a very short load time, but I wan't to note again
that importing decimal at Python startup actually doubles the
startup time.

So if there are applications that start a new Python script
for each request (e.g. via djb's tcpserver), it could really
matter.


OTOH I don't like moving code around either, so we can wait until
there's a demonstrated need for the speedup.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19232
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16525] wave file module does not support 32bit float format

2013-10-14 Thread Serhiy Storchaka

Changes by Serhiy Storchaka storch...@gmail.com:


--
assignee:  - serhiy.storchaka
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16525
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19254] Python implementation of PBKDF2_HMAC

2013-10-14 Thread Stefan Krah

Changes by Stefan Krah stefan-use...@bytereef.org:


--
nosy: +skrah

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19254
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1483545] Wave.py support for ulaw and alaw audio

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

For consistency with the aifc and sunau modules the wave module should 
compress/uncompress u-law and A-law data.

--
nosy: +serhiy.storchaka
stage: test needed - needs patch
versions: +Python 3.4 -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1483545
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19246] GC does not really free up memory in console

2013-10-14 Thread STINNER Victor

STINNER Victor added the comment:

Python uses an allocator called pymalloc. For allocations smaller
than 512 bytes, it uses arenas of 256 KB. If you allocate many small
objects and later release most of them (but not all!), the memory is
fragmented. For allocations larger than 512 bytes, Python falls back
to malloc/free.

It was discussed to replace pymalloc with Windows Low Fragmented Heap allocator.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19246
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19256] Optimize marshal format and add version token.

2013-10-14 Thread Kristján Valur Jónsson

Kristján Valur Jónsson added the comment:

Right, the idea of the version token is to introduce it now, as early as 
possible, even if it is not needed, for prudence.
For example, if version 5 decides to change the semantics of some of the 
opcodes, we can then support both kinds, in the future.  Read old files _and_ 
the new ones.

Despite the fact that we claim that we don't guarantee interoperability, in 
reality it is very desirable.  During development, for instance. Frozen 
modules, .pyc files, and all that.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19259] Provide Python implementation of operator.compare_digest()

2013-10-14 Thread Christian Heimes

New submission from Christian Heimes:

The operator module doesn't have a Python implementation of _compare_digest. 
This code mimicks the C code:

def _compare_digest(a, b):
if isinstance(a, str) and isinstance(b, str):
a = a.encode(ascii)
b = b.encode(ascii)
a = memoryview(a)
len_a = len(a)
right = memoryview(b)
len_b = len(right)
if len_a == len_b:
result = 0
left = a
# loop count depends on length of b
if len_a != len_b:
result = 1
left = b
for l, r in zip(left, right):
result |= l ^ r
return result == 0

--
messages: 199868
nosy: christian.heimes, pitrou, serhiy.storchaka
priority: normal
severity: normal
stage: needs patch
status: open
title: Provide Python implementation of operator.compare_digest()
type: enhancement
versions: Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19259
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19256] Optimize marshal format and add version token.

2013-10-14 Thread STINNER Victor

STINNER Victor added the comment:

Should we support serialization in an older version? For example,
disable the new SMALL and ASCII tokens?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19259] Provide Python implementation of operator.compare_digest()

2013-10-14 Thread STINNER Victor

STINNER Victor added the comment:

#15061 explains why the function is not implemented in Python :)

--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19259
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue8311] wave module sets data subchunk size incorrectly when writing wav file

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Here is a patch for all three audio modules. After dropping support of string 
(which is meanless) in the audioop module (issue16685) it can be simplified.

I doubt that this should be applied in maintenance releases. Support of 
non-bytes arguments in writerawframes() is a new feature.

--
assignee:  - serhiy.storchaka
stage: needs patch - patch review
type: behavior - enhancement
versions:  -Python 2.7, Python 3.3
Added file: http://bugs.python.org/file32114/audio_write_nonbytes.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8311
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19232] Speed up _decimal import

2013-10-14 Thread Antoine Pitrou

Antoine Pitrou added the comment:

 OTOH I don't like moving code around either, so we can wait until
 there's a demonstrated need for the speedup.

Keep in mind that people who have startup speed problems aren't
likely to open an issue on the tracker about it, let alone
diagnose it enough to put the blame on decimal.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19232
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19256] Optimize marshal format and add version token.

2013-10-14 Thread Antoine Pitrou

Antoine Pitrou added the comment:

 Should we support serialization in an older version? For example,
 disable the new SMALL and ASCII tokens?

It is officially supported with the version parameter:
http://docs.python.org/3.4/library/marshal.html#marshal.dump

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19256] Optimize marshal format and add version token.

2013-10-14 Thread Kristján Valur Jónsson

Kristján Valur Jónsson added the comment:

We have done so previously and should continue to do that.  Thanks for pointing 
out that the new SHORT_REF needs that fix :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19259] Provide Python implementation of operator.compare_digest()

2013-10-14 Thread Antoine Pitrou

Antoine Pitrou added the comment:

It explains why the function isn't implemented in Python, it doesn't say that 
there shouldn't be a best-effort Python fallback.

All in all, Christian's version looks reasonable. All arithmetic is done on 
small ints, so there shouldn't be a strong data-dependent timing issue.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19259
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19246] freeing then reallocating lots of memory fails under Windows

2013-10-14 Thread Antoine Pitrou

Changes by Antoine Pitrou pit...@free.fr:


--
title: GC does not really free up memory in console - freeing then 
reallocating lots of memory fails under Windows

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19246
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19254] Python implementation of PBKDF2_HMAC

2013-10-14 Thread Antoine Pitrou

Antoine Pitrou added the comment:

 I have optimized XOR and now it's even faster than OpenSSL's code for
 reasonable long passwords. :(

Uh... and it gives the right results? Perhaps OpenSSL should be reimplemented 
in Python :-)

If your code is resistant to timing attacks, I suppose we don't need the C 
implementation anymore? Or does it have a larger startup cost?
(what is a reasonably long password for you? 10 chars or 64? :-))

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19254
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19253] PyArg_ParseTuple: wrong use of seterror() clips helpful type error annotation

2013-10-14 Thread Antoine Pitrou

Antoine Pitrou added the comment:

The original commit doesn't contain any tests, so you should add some to be 
sure there's no regression in both directions (i.e. no regression for issue 
#6624 and for this issue):
http://hg.python.org/cpython/rev/83b46a5988b0/

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19253
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19256] Optimize marshal format and add version token.

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

 Right, the idea of the version token is to introduce it now, as early as 
 possible, even if it is not needed, for prudence.

How it will help? If we will break backward compatibility in version 10, then 
we will introduce the version token for version 10 and larger. If the file will 
not contain the version token, then it will compatible with version 9.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19256] Optimize marshal format and add version token.

2013-10-14 Thread Kristján Valur Jónsson

Kristján Valur Jónsson added the comment:

Only output TYPE_SHORT_REF for version = 4

--
Added file: http://bugs.python.org/file32115/marshal2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19256] Optimize marshal format and add version token.

2013-10-14 Thread Kristján Valur Jónsson

Kristján Valur Jónsson added the comment:

Quoting myself: for prudence.
We probably should have had this from the beginning.  Adding this now makes it 
easier to make such changes in future, because then you don't have to re-invent 
the versioning mechanism.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19254] Python implementation of PBKDF2_HMAC

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Christian, does you noticed my comments on Rietveld?

--
nosy: +serhiy.storchaka

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19254
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19256] Optimize marshal format and add version token.

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

What is difference between introducing the version token right now or only when 
(if?) we will need it?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19260] int comment in marshal.c is outdated

2013-10-14 Thread Larry Hastings

New submission from Larry Hastings:

In r_string() (read a string) in marshal.c we see this comment:

/* The result fits into int because it must be =n. */
read = fread(p-buf, 1, n, p-fp);

This comment was first committed in r36501 by MvL.  Back then the read and 
n variables were int, but (of course) the return size of fread was size_t.  
Since then, both n and read have become ssize_t.

I suggest changing the wording slightly anyway, because I had to meditate on 
what the comment was originally trying to say.  I suggest:

/* The result fits into ssize_t because n is ssize_t. */

Patch appended too.  Bikeshedding away!

Should this be fixed in previous versions too?

--
files: larry.marshal.outdated.comment.r1.diff
keywords: patch
messages: 199883
nosy: larry
priority: normal
severity: normal
status: open
title: int comment in marshal.c is outdated
versions: Python 3.4
Added file: 
http://bugs.python.org/file32116/larry.marshal.outdated.comment.r1.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19260
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-10-14 Thread Nick Coghlan

Nick Coghlan added the comment:

Added some structural comments to the patch. I'll defer to Serhiy when it comes 
to assessing the algorithm details :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19183
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19256] Optimize marshal format and add version token.

2013-10-14 Thread Kristján Valur Jónsson

Kristján Valur Jónsson added the comment:

Never put off to tomorrow what you can do today :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19256
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11471] If without else generates redundant jump

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

Python-ast.c can't be changed; it is auto-generated.  But the whole thing can 
be handled in compile.c I think -- see attached patch.  Test suite passes 
(except for test_dis, which checks compilation result against a given list of 
bytecodes).

--
nosy: +georg.brandl, pitrou, rhettinger
Added file: http://bugs.python.org/file32117/if_else_nojump.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11471] If without else generates redundant jump

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

I'll make a complete patch with test suite additions (and fixing test_dis) if 
this is deemed to be a correct approach.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue14407] concurrent.futures tests don't adher to test_cases protocol

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
nosy: +bquinlan

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14407
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11646] 2to3: msvcrt.(get|put)ch - (get|put)wch

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
nosy: +benjamin.peterson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11646
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue7979] connect_ex returns 103 often

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

Is this still the case with Python 2.7?

--
nosy: +georg.brandl
resolution:  - out of date
status: open - pending

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue7979
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15817] Misc/gdbinit: Expose command documentation to gdb help

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
assignee:  - dmalcolm
nosy: +dmalcolm

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15817
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19252] Enum.py : Enum.__new__() : Test Coverage

2013-10-14 Thread Ethan Furman

Ethan Furman added the comment:

CliffM added the comment:

 Sorry -- I could have been clearer :

 The conditional:

   if member.value == value:

 Is redundant as the tests stand.  If you comment it out -- everything works. 
 So therefore we are missing a test.

Are you saying that you are commenting out the if test, but leaving in the 
return member?

 This makes the if-clause fragile for future maintenance.  So we need another 
 test to ensure the loop is covered.

In case Python for loops suddenly stop working?

Sorry to be so dense, but I am not understanding the point you are trying to 
make... ahh!  Are trying to guard 
against the possibility that in the future someone might accidentally delete 
the if test, and the unit test won't catch 
it?  That certainly is a good reason to test values further into the loop.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19252
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17154] the 'ignore' pdb command raises IndexError

2013-10-14 Thread Roundup Robot

Roundup Robot added the comment:

New changeset 3507be2f94d4 by Georg Brandl in branch '3.3':
Closes #17154: error out gracefully on ignore or condition without argument.
http://hg.python.org/cpython/rev/3507be2f94d4

--
nosy: +python-dev
resolution:  - fixed
stage:  - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17154
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11471] If without else generates redundant jump

2013-10-14 Thread Benjamin Peterson

Benjamin Peterson added the comment:

I think it's fine with the simplification I suggested.

--
nosy: +benjamin.peterson

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17294] compile-flag for single-execution to return value instead of printing it

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

If you know you have an expression and would like the value, you should use the 
eval mode.

In the case of single, you can adapt sys.displayhook to change where to print 
(if at all) the values.  Note that single sometimes prints multiple values 
(try e.g. for i in range(10):\ni\n).

--
nosy: +georg.brandl
resolution:  - rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17294
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17095] Modules/Setup *shared* support broken

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
versions:  -Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17095
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16425] minidom replaceChild(new_child, old_child) removes new_child even if in another document

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
nosy: +eli.bendersky

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16425
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue16845] warnings.simplefilter should validate input

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
nosy: +brett.cannon

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16845
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18965] 2to3 can produce illegal bytes literals

2013-10-14 Thread Benjamin Peterson

Benjamin Peterson added the comment:

I think it's too bad parsing of b-prefixed strings in Python 2 doesn't reject 
non-ASCII characters.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18965
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15648] stderr refs output does not respect PYTHONIOENCODING

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

The refs output is only active in debug mode, and only for debugging. It is 
printed directly to stderr using C fprintf(), I don't think it's worth the 
complication.

--
nosy: +georg.brandl
resolution:  - wont fix
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15648
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15613] argparse ArgumentDefaultsHelpFormatter interacts badly with --arg and nargs=+

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
nosy: +bethard

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15613
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15440] multiprocess fails to re-raise exception which has mandatory arguments

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
nosy: +sbt

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15440
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue15371] test_cmd_line_script should include namespace package tests

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
versions: +Python 3.4

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue15371
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18300] script_helper._asert_python should set TERM='' by default.

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

Sounds good to me.

--
nosy: +georg.brandl

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18300
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18209] Bytearray type not supported as a mutable object in the fcntl.ioctl function

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18209
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18068] pickle + weakref.proxy(self)

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18068
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18096] bad library order returned by python-config.in

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
nosy: +barry, ned.deily

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18096
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18254] Accessing attr dict at definition time of a class from a metaclass results in changed type.

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

Only affects 3.2, so this won't be fixed anymore.

--
nosy: +georg.brandl
resolution:  - out of date
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18254
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2919] Merge profile/cProfile in 3.n+1

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

Last desperate ping for 3.4?

--
nosy: +georg.brandl

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2919
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17765] weakref.ref ignores a 'callback' keyword argument

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

See attached patch, it handles this like all other builtins that don't support 
keyword arguments in their constructor.

--
keywords: +patch
nosy: +georg.brandl, pitrou
versions: +Python 2.7, Python 3.3
Added file: http://bugs.python.org/file32118/no_weakref_kwargs.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17765
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19260] int comment in marshal.c is outdated

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

aside The rXXX notation is reserved for SVN revision numbers, which are 
unambiguous.  The revision numbers in Mercurial are specific to each clone. 
/aside

Other than that, LGTM.

--
nosy: +georg.brandl

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19260
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19258] Got resource warning when running wsgiref demo app

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
nosy: +georg.brandl

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19258
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12866] Add support for 24-bit samples in the audioop module

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

If there are no objections I will commit this.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12866
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19258] Got resource warning when running wsgiref demo app

2013-10-14 Thread Roundup Robot

Roundup Robot added the comment:

New changeset f1e66ef64d17 by Georg Brandl in branch '3.3':
Closes #19258: close WSGI server after handling request in demo code.
http://hg.python.org/cpython/rev/f1e66ef64d17

New changeset 64a1e224042e by Georg Brandl in branch '2.7':
Closes #19258: close WSGI server after handling request in demo code.
http://hg.python.org/cpython/rev/64a1e224042e

--
nosy: +python-dev
resolution:  - fixed
stage:  - committed/rejected
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19258
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19138] doctest.IGNORE_EXCEPTION_DETAIL doesn't match when no detail exists

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
nosy: +tim.peters

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19138
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18068] pickle + weakref.proxy(self)

2013-10-14 Thread Antoine Pitrou

Antoine Pitrou added the comment:

I don't think weakref objects are meant to be picklable at all. At least 
there's no support code for that, so pickling weak proxies only works by chance.

--
nosy: +alexandre.vassalotti
type: behavior - enhancement
versions: +Python 3.4 -Python 2.6, Python 2.7

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18068
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18209] Bytearray type not supported as a mutable object in the fcntl.ioctl function

2013-10-14 Thread Antoine Pitrou

Antoine Pitrou added the comment:

It doesn't work in 2.7 because bytearray only supports the new buffer API 
(which is more secure), not the old one. I don't think it's worth trying to fix 
at this point, so I'm tempted to close as won't fix.

--
nosy: +georg.brandl

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18209
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17765] weakref.ref ignores a 'callback' keyword argument

2013-10-14 Thread Antoine Pitrou

Antoine Pitrou added the comment:

Why the PyWeakref_Check() in your patch?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17765
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19260] int comment in marshal.c is outdated

2013-10-14 Thread Antoine Pitrou

Antoine Pitrou added the comment:

Well, the comment should actually be removed, it's just pointless.

--
nosy: +pitrou

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19260
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue12866] Add support for 24-bit samples in the audioop module

2013-10-14 Thread Peder Jørgensen

Peder Jørgensen added the comment:

This is great!
My brother did a few more updates to it and added support for endian 
conversion, and i've been using it a lot with out any problems, but i must 
admit your patch looks a lot cleaner Serhiy. Great work. Can't wait to test it. 
This is going to be of great use to everyone working with audio in python.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue12866
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19260] int comment in marshal.c is outdated

2013-10-14 Thread Martin v . Löwis

Martin v. Löwis added the comment:

I agree that the comment can be removed. If the code is (now) statically 
type-safe, there is no point in keeping it.

--
nosy: +loewis

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19260
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19260] int comment in marshal.c is outdated

2013-10-14 Thread STINNER Victor

Changes by STINNER Victor victor.stin...@gmail.com:


--
nosy: +haypo

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19260
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18209] Bytearray type not supported as a mutable object in the fcntl.ioctl function

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

Agreed.  This is not really a bugfix.

--
resolution:  - wont fix
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18209
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17765] weakref.ref ignores a 'callback' keyword argument

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

Good point, that is pointless in __init__().

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17765
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue17765] weakref.ref ignores a 'callback' keyword argument

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


Added file: http://bugs.python.org/file32119/no_weakref_kwargs_2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17765
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11471] If without else generates redundant jump

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

Updated patch with test suite update.

--
Added file: http://bugs.python.org/file32120/if_else_nojump_2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11471] If without else generates redundant jump

2013-10-14 Thread Benjamin Peterson

Benjamin Peterson added the comment:

lgtm

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue18919] Unify audio modules tests

2013-10-14 Thread R. David Murray

R. David Murray added the comment:

In 2.7 unexpected output is a test failure, yes.

In 3.x we removed that check.  But I wonder if that was wise :)  (We did it for 
technical reasons when adding other features to regrtest).

Yes, using captured_stdout and checking for the expected warnings would be a 
better test, IMO.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue18919
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11471] If without else generates redundant jump

2013-10-14 Thread Antoine Pitrou

Antoine Pitrou added the comment:

Just for the record, have you passed the whole test suite after cleaning up the 
pyc files,

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue2259] Poor support other than 44.1khz, 16bit audio files?

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

I tested 2.6, 2.7, 3.2, 3.3, and 3.4. All of them read and write 24b48k.aif. 
Currently 2.7, 3.3, and 3.4 have tests for 24-bit aifc files. Seems this issue 
is not more actual.

--
dependencies:  -Add support for 24-bit samples in the audioop module
resolution:  - out of date
stage: patch review - committed/rejected
status: open - pending

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue2259
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue19253] PyArg_ParseTuple: wrong use of seterror() clips helpful type error annotation

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

Issue #6624 wasn't an issue, it should have been closed-invalid :)

But you're right, a test case is needed, see new patch.

--
Added file: http://bugs.python.org/file32121/seterror_fix_2.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19253
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1575020] Request wave support 16 bit samples

2013-10-14 Thread Serhiy Storchaka

Serhiy Storchaka added the comment:

Currently 24-bit wave files are supported at least in 2.7, 3.3, and 3.4 (there 
are tests for this). The audioop module yet not supports 24-bit data, but this 
is another issue.

--
dependencies:  -Add support for 24-bit samples in the audioop module
resolution:  - out of date
stage: needs patch - committed/rejected
status: open - pending

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1575020
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue11471] If without else generates redundant jump

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

Yep :)

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue11471
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1575020] Request wave support 16 bit samples

2013-10-14 Thread Georg Brandl

Georg Brandl added the comment:

Serhiy, you're welcome to set issues to pending, but please don't forget to 
close them after a certain time...

--
status: pending - open

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1575020
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue1575020] Request wave support 16 bit samples

2013-10-14 Thread Georg Brandl

Changes by Georg Brandl ge...@python.org:


--
status: open - pending

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue1575020
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



  1   2   >