[issue16074] Bad error message in os.rename, os.link, and os.symlink
Vajrasky Kok added the comment:
Is there any possibility this ticket could be committed in Python 3.4? If yes,
it would be good because we would have a good foundation for creating better
error message in Python 3.5.
Anyway, I check Python's competitors' behaviour.
Ruby displays both files.
irb(main):001:0 File.symlink('a.txt', 'b')
Errno::EEXIST: File exists @ sys_fail2 - (a.txt, b)
from (irb):1:in `symlink'
from (irb):1
from /home/ethan/Documents/code/ruby/localruby/bin/irb:11:in `main'
Perl omits the files.
DB8 print symlink(a.txt, b);
0
DB9 print $!;
File exists
PHP omits the files.
php -r symlink('b', 'a');
PHP Warning: symlink(): File exists in Command line code on line 1
PHP Stack trace:
PHP 1. {main}() Command line code:0
PHP 2. symlink() Command line code:1
Warning: symlink(): File exists in Command line code on line 1
Call Stack:
0.0001 225688 1. {main}() Command line code:0
0.0001 226392 2. symlink() Command line code:1
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16074
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20019] platform.py line _sys_version function
Marc-Andre Lemburg added the comment: Closing, since there's nothing much we can do about the problem. -- resolution: - invalid status: open - closed versions: +3rd party -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20019 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20022] modernize the Mac bundlebuilder.py script
Ned Deily added the comment: bundlebuild.py is a deprecated legacy tool that has been superseded by the third-party py2app. AFAIK, its only use in Python 3 is to build PythonLauncher.app; it is not included in a Python installation. Rather than refactor it, its use should be eliminated in Mac/PythonLauncher/Makefile.in. -- assignee: - ned.deily nosy: +ned.deily, ronaldoussoren ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20022 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14455] plistlib unable to read json and binary plist files
Ronald Oussoren added the comment: I'm working on an update for your patch that addresses these comments: * I don't like supporting 128 bit integers because Apple's public APIs don't support those values. That is, the value 'kCFNumberSInt128Type' is not in a public header for the OSX 10.9 SDK. * The test_int method that you introduced tests conversions to and from XML, and doesn't test the problem with negative values in binary plists. * I don't understand why test_int converts a value to a binary plist twice, that is the 'data2 = plistlib.dumps(pl2)' bit. * I'm adding negative integers to the _create method as well, with the corresponding changes to the binary TESTDATA dictionary. * I don't understand your comment about the writePlistToBytes documentation, there was no versionchanged in the documentation. The version changed for dump was wrong, that should be versionadded (and the other new functions should have a versionadded as well) * I agree that this change should be mentioned in What's New. * I agree that _write_object should raise TypeError BTW. What about out-of-range integer values? Those currently raise struct.error, I'd prefer to raise TypeError instead because the use of the struct module should be an implementation detail. And a final question: integers with '2 ** 63 = value 2 ** 64' (e.g. values that are in the range of uint64_t but not in the range of int64_t) can be written to a binary plist, but will be read back as a negative value (which is the same behavior as in Apple's code). Should we warn about this in the documentation? I'll post an updated patch later today. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14455 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20023] _csv.Dialect() does not check type for delimiter, escapechar and quotechar fields
New submission from STINNER Victor: Example: $ ./python -c import _csv; _csv.Dialect(escapechar=b'x') python: Python/ceval.c:4262: call_function: Assertion `(x != ((void *)0) !PyErr_Occurred()) || (x == ((void *)0) PyErr_Occurred())' failed. Abandon (core dumped) Attached patch should fix this issue and adds a unit test. Note: I found this issue using Fusil the fuzzer. -- files: csv.patch keywords: patch messages: 206593 nosy: haypo, serhiy.storchaka priority: normal severity: normal status: open title: _csv.Dialect() does not check type for delimiter, escapechar and quotechar fields versions: Python 3.4 Added file: http://bugs.python.org/file33203/csv.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20023 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14455] plistlib unable to read json and binary plist files
Ronald Oussoren added the comment: The attached patch should fix the open issues: * Negative integers are supported (based on Serhiy's patch), but without support for 128-bit integer (as per my previous comment) * Test updates for this * Updated version tags in the documentation * Documented the odd behavior for 64-bit unsigned values larger than the largest 64-bit signed value. * Raise TypeError when trying to write an object that isn't supported (with test) * Raise OverflowError when trying to write an integer that cannot be represented in a binary plist * Add entry to What's New -- Added file: http://bugs.python.org/file33204/negative_int_support.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14455 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14455] plistlib unable to read json and binary plist files
Serhiy Storchaka added the comment: * I don't like supporting 128 bit integers because Apple's public APIs don't support those values. That is, the value 'kCFNumberSInt128Type' is not in a public header for the OSX 10.9 SDK. At least we should support integers from -2**63 to 2**64-1 (signed and unsigned 64-bit). * The test_int method that you introduced tests conversions to and from XML, and doesn't test the problem with negative values in binary plists. Indeed. * I don't understand why test_int converts a value to a binary plist twice, that is the 'data2 = plistlib.dumps(pl2)' bit. I have copied this from test_bytes(). I suppose that pl2 can be int subclass. Agree, for now this check is redundant. * I don't understand your comment about the writePlistToBytes documentation, there was no versionchanged in the documentation. The version changed for dump was wrong, that should be versionadded (and the other new functions should have a versionadded as well) http://hg.python.org/cpython/file/673ca119dbd0/Doc/library/plistlib.rst#l165 BTW. What about out-of-range integer values? Those currently raise struct.error, I'd prefer to raise TypeError instead because the use of the struct module should be an implementation detail. Agree. Especially if OSX SDK doesn't support deserialization of integers larger than 64-bit. Perhaps we should add this check for XML format too. And document this limitation. And a final question: integers with '2 ** 63 = value 2 ** 64' (e.g. values that are in the range of uint64_t but not in the range of int64_t) can be written to a binary plist, but will be read back as a negative value (which is the same behavior as in Apple's code). Should we warn about this in the documentation? These values should be written as 128-bit integers (token b'\x14'). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14455 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue7464] circular reference in HTTPResponse by urllib2
Kristján Valur Jónsson added the comment: Here it is. Notice the incredible nesting depth in python 2.7. The socket itself is found at response.fp._sock.fp._sock There are two socket._fileobjects in use! -- Added file: http://bugs.python.org/file33205/httpleak.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7464 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20023] _csv.Dialect() does not check type for delimiter, escapechar and quotechar fields
Vajrasky Kok added the comment: Bear in the mind, the bug is only reproducible with debug flag (--with-pydebug). Victor, we have a more complete solution for this problem in #18829. -- nosy: +vajrasky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20023 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20023] _csv.Dialect() does not check type for delimiter, escapechar and quotechar fields
Serhiy Storchaka added the comment: This is a duplicate of issue18829. -- resolution: - duplicate superseder: - csv produces confusing error message when passed a non-string delimiter ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20023 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18829] csv produces confusing error message when passed a non-string delimiter
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18829 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19713] Deprecate various things in importlib thanks to PEP 451
Nick Coghlan added the comment: Please don't emit a deprecation warning for loaders that only implement load_module - there are still things load_module can do that create/exec can't, and it's still possible it will remain the long term API for those use cases. Plus builtins and extensions are still loaded with load_module - we can't deprecate an API we're still using. I'm actually still -0 on doing any programmatic deprecations in 3.4 at all. What maintenance burden are we eliminating for ourselves that justifies the pain we're inflicting on users? I want import system specialists to be *excited* about PEP 451, but if we deprecate everything and *force* them to migrate immediately (rather than giving them until 3.5 before they get warnings), they're going to hate it :( -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19713 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14455] plistlib unable to read json and binary plist files
Ronald Oussoren added the comment: Attached a script (using PyObjC) that demonstrates the behavior of Apple's Foundation framework with large integers. The same behavior should occur when the script is rewritten in Objective-C. -- Added file: http://bugs.python.org/file33206/apple-behavior-with-large-integers.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14455 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14455] plistlib unable to read json and binary plist files
Ronald Oussoren added the comment: Updated patch. -- Added file: http://bugs.python.org/file33207/negative_int_support-2.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14455 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20024] Py_BuildValue() can call Python code with an exception set
Changes by STINNER Victor victor.stin...@gmail.com: Added file: http://bugs.python.org/file33209/parsermodule.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20024 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20024] Py_BuildValue() can call Python code with an exception set
New submission from STINNER Victor:
In Python 3.4, an assertion now checks that no exception is set when arbitrary
Python code is called. Python code may suppress the exception.
When Py_BuildValue() is used to build a tuple and an error when the creation of
an item failed, the function may execute indirectly Python code with an
exception set.
Attached patch works around the issue by storing the current exception in a
variable and then restore it. It changes the behaviour if more than one
exception is raised: at the end, its the first exception which is passed to the
caller. I prefer to get the first exception instead of the following
exceptions, because following exceptions may be caused by the first exception.
See for example the parser bug below for an example of a second exception
caused by the first exception.
--
Example with the parser module:
PyObject *err = Py_BuildValue(os, elem,
Illegal node construct.);
PyErr_SetObject(parser_error, err);
The o is not a valid format and so a SystemError is raised, but then the
UTF-8 decoder tries to raise a second exception, an UnicodeDecodeError, because
the decoders is called with an invalid bytes string (elem variable, instead of
the Illegal node construct. string, because o format didn't increment the
argument pointer). The bug is obvious in the parser module, but the problem is
more general than that.
Gdb traceback of the parser bug:
python: Objects/typeobject.c:741: type_call: Assertion `!PyErr_Occurred()'
failed.
Program received signal SIGABRT, Aborted.
0x00301c0359e9 in raise () from /lib64/libc.so.6
Missing separate debuginfos, use: debuginfo-install glibc-2.17-19.fc19.x86_64
(gdb) where
#0 0x00301c0359e9 in raise () from /lib64/libc.so.6
#1 0x00301c0370f8 in abort () from /lib64/libc.so.6
#2 0x00301c02e956 in __assert_fail_base () from /lib64/libc.so.6
#3 0x00301c02ea02 in __assert_fail () from /lib64/libc.so.6
#4 0x004dae18 in type_call (type=0x906780 _PyExc_UnicodeDecodeError,
args=('utf-8', b'\xc8\x87\xe0\xf7\xff\x7f', 2, 3, 'invalid continuation byte'),
kwds=0x0)
at Objects/typeobject.c:741
#5 0x0045fb75 in PyObject_Call (func=type at remote 0x906780,
arg=('utf-8', b'\xc8\x87\xe0\xf7\xff\x7f', 2, 3, 'invalid continuation byte'),
kw=0x0)
at Objects/abstract.c:2067
#6 0x0045fd0f in call_function_tail (callable=type at remote
0x906780, args=('utf-8', b'\xc8\x87\xe0\xf7\xff\x7f', 2, 3, 'invalid
continuation byte'))
at Objects/abstract.c:2104
#7 0x0045ff94 in _PyObject_CallFunction_SizeT (callable=type at
remote 0x906780, format=0x669e19 sy#nns) at Objects/abstract.c:2150
#8 0x0048643d in PyUnicodeDecodeError_Create (encoding=0x67e312
utf-8, object=0x76ddcf40 \310\207\340\367\377\177, length=6, start=2,
end=3,
reason=0x67f1c1 invalid continuation byte) at Objects/exceptions.c:1960
#9 0x0050fe7c in make_decode_exception
(exceptionObject=0x7fff9090, encoding=0x67e312 utf-8,
input=0x76ddcf40 \310\207\340\367\377\177, length=6,
startpos=2, endpos=3, reason=0x67f1c1 invalid continuation byte) at
Objects/unicodeobject.c:4009
#10 0x00510015 in unicode_decode_call_errorhandler_writer (errors=0x0,
errorHandler=0x7fff9098, encoding=0x67e312 utf-8,
reason=0x67f1c1 invalid continuation byte, input=0x7fff90b8,
inend=0x7fff90b0, startinpos=0x7fff90a8, endinpos=0x7fff90a0,
exceptionObject=0x7fff9090, inptr=0x7fff9088,
writer=0x7fff90c0) at Objects/unicodeobject.c:4157
#11 0x005163a8 in PyUnicode_DecodeUTF8Stateful (s=0x76ddcf42
\340\367\377\177, size=6, errors=0x0, consumed=0x0) at
Objects/unicodeobject.c:4798
#12 0x00506198 in PyUnicode_FromStringAndSize (u=0x76ddcf40
\310\207\340\367\377\177, size=6) at Objects/unicodeobject.c:1840
#13 0x005da9d2 in do_mkvalue (p_format=0x7fff92e0,
p_va=0x7fff92c8, flags=0) at Python/modsupport.c:319
#14 0x005d9e50 in do_mktuple (p_format=0x7fff92e0,
p_va=0x7fff92c8, endchar=0, n=2, flags=0) at Python/modsupport.c:164
#15 0x005db067 in va_build_value (format=0x7750f34b os,
va=0x7fff9310, flags=0) at Python/modsupport.c:455
#16 0x005dae8c in Py_BuildValue (format=0x7750f34b os) at
Python/modsupport.c:410
#17 0x7750641c in build_node_children (tuple=(1467, -415088696226,
183475025091, 3, -85006798, 915338703290779849), root=0x77f7f6b8,
line_num=0x7fff95cc)
at /home/haypo/prog/python/default/Modules/parsermodule.c:788
--
files: py_buildvalue_failed.patch
keywords: patch
messages: 206602
nosy: haypo, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Py_BuildValue() can call Python code with an exception set
versions: Python 3.4
Added file: http://bugs.python.org/file33208/py_buildvalue_failed.patch
[issue20024] Py_BuildValue() can call Python code with an exception set
STINNER Victor added the comment: parsermodule.patch: fix usage of Py_BuildValue() in the parser module. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20024 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20025] ssl.RAND_bytes() and ssl.RAND_pseudo_bytes() don't check if num is negative
New submission from STINNER Victor: ssl.RAND_bytes() and ssl.RAND_pseudo_bytes() should raise a ValueError, not a SystemError, if num is negative. Attached patch fixes that. -- files: ssl_rand.patch keywords: patch messages: 206604 nosy: christian.heimes, haypo, serhiy.storchaka priority: normal severity: normal status: open title: ssl.RAND_bytes() and ssl.RAND_pseudo_bytes() don't check if num is negative versions: Python 3.3, Python 3.4 Added file: http://bugs.python.org/file33210/ssl_rand.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20025 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20025] ssl.RAND_bytes() and ssl.RAND_pseudo_bytes() don't check if num is negative
Christian Heimes added the comment: LGTM -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20025 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19902] logging docs don't document integer constants
Roundup Robot added the comment: New changeset 16bfddf5a091 by Vinay Sajip in branch '2.7': Issue #19902: Added list of logging levels. http://hg.python.org/cpython/rev/16bfddf5a091 New changeset e812094d42f9 by Vinay Sajip in branch '3.3': Issue #19902: Added list of logging levels. http://hg.python.org/cpython/rev/e812094d42f9 New changeset 45bd58a15bb9 by Vinay Sajip in branch 'default': Closes #19902: Merged update from 3.3. http://hg.python.org/cpython/rev/45bd58a15bb9 -- nosy: +python-dev resolution: invalid - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19902 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19946] Handle a non-importable __main__ in multiprocessing
Roundup Robot added the comment: New changeset 460961e80e31 by Nick Coghlan in branch 'default': Issue #19946: appropriately skip new multiprocessing tests http://hg.python.org/cpython/rev/460961e80e31 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19946 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20020] modernize the modulefinder module
Thomas Heller added the comment: I have written a new modulefinder based on importlib. It is not a refactoring of the old one, so it is no plug-in replacement. Instead it has some new features: - Better logging output - collects dependencies (self._depgraph maps module names to callers) - when run as script, the command line syntax are easier to understand (although parsing is still done by getopt; argparse would be event better) - The Module proxies that modulefinder collects give better access to the module's attributes, including the byte code It is not yet tested in the wild but I will use it for the Python3 py2exe implementation. If anyone wants to take a look the current version is here: http://code.google.com/p/ctypes-stuff/source/browse/trunk/mf/py2exe/mf3.py -- nosy: +theller ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20020 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20022] modernize the Mac bundlebuilder.py script
Changes by Ronald Oussoren ronaldousso...@mac.com: -- keywords: +needs review, patch stage: - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20022 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20022] modernize the Mac bundlebuilder.py script
Ronald Oussoren added the comment: Removing bundle builder should be easy enough if it is only used to create the PythonLauncher application bundle: that bundle does not contain python code at all and constructing it is just a matter of copying files to the right location. The attached patch should do the trick. The patch is very rough, but does work. -- Added file: http://bugs.python.org/file33211/python-launcher-no-bundlebuilder.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20022 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20026] sqlite: handle correctly invalid isolation_level
New submission from STINNER Victor: The C function pysqlite_connection_init() doesn't check if pysqlite_connection_set_isolation_level() failed or not. Attached patch fixes that. -- files: sqlite.patch keywords: patch messages: 206610 nosy: haypo priority: normal severity: normal status: open title: sqlite: handle correctly invalid isolation_level versions: Python 3.4 Added file: http://bugs.python.org/file33212/sqlite.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20026 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20026] sqlite: handle correctly invalid isolation_level
STINNER Victor added the comment: $ python Python 3.4.0b1 (default:298d98486794+, Dec 19 2013, 13:45:07) [GCC 4.8.2 20131017 (Red Hat 4.8.2-1)] on linux Type help, copyright, credits or license for more information. import sqlite3 con=sqlite3.connect(:memory:, isolation_level=3) python: Objects/typeobject.c:741: type_call: Assertion `!PyErr_Occurred()' failed. Program terminated with signal SIGABRT, Aborted. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20026 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16136] Removal of VMS support
Christian Heimes added the comment: Unless somebody says otherwise I'm going to remove VMS-related code over the course of the next couple of days. PEP 11 says: Name: VMS (issue 16136) Unsupported in: Python 3.3 Code removed in: Python 3.4 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16136 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18829] csv produces confusing error message when passed a non-string delimiter
Roundup Robot added the comment: New changeset 5ed75e36be8e by Serhiy Storchaka in branch '2.7': Issue #18829: csv.Dialect() now checks type for delimiter, escapechar and http://hg.python.org/cpython/rev/5ed75e36be8e New changeset 52d03fbdf67a by Serhiy Storchaka in branch '3.3': Issue #18829: csv.Dialect() now checks type for delimiter, escapechar and http://hg.python.org/cpython/rev/52d03fbdf67a New changeset 6b17803bfddd by Serhiy Storchaka in branch 'default': Issue #18829: csv.Dialect() now checks type for delimiter, escapechar and http://hg.python.org/cpython/rev/6b17803bfddd -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18829 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18829] csv produces confusing error message when passed a non-string delimiter
Serhiy Storchaka added the comment: Thank you Vajrasky for your patch. I have simplified and fixed (escapechar can be empty) it. Reverted ValueError back to TypeError because ord() raises TypeError for non-1-character strings. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18829 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18829] csv produces confusing error message when passed a non-string delimiter
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18829 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14455] plistlib unable to read json and binary plist files
Serhiy Storchaka added the comment: I can't test on OSX, but I see that Apple's code can write any 128-bit integers and read signed and unsigned 64-bit integers. Can Apple's utilities read this file? What is a result? -- Added file: http://bugs.python.org/file33213/18446744073709551615.plist ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14455 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19940] ssl.cert_time_to_seconds() returns wrong results if local timezone is not UTC
gudge added the comment: 1) Can I get a list of failures. The summary of test results which I compare on my machine. 2) - import ssl ssl.cert_time_to_seconds(May 9 00:00:00 2007 GMT) 1178649000.0 from datetime import datetime datetime.utcfromtimestamp(1178668800) datetime.datetime(2007, 5, 9, 0, 0) import time time.gmtime(1178668800) time.struct_time(tm_year=2007, tm_mon=5, tm_mday=9, tm_hour=0, tm_min=0, tm_sec=0, tm_wday=2, tm_yday=129, tm_isdst=0) import calender Traceback (most recent call last): File stdin, line 1, in module ImportError: No module named 'calender' import callendar Traceback (most recent call last): File stdin, line 1, in module ImportError: No module named 'callendar' import calendar calendar.timegm(time.strptime(May 9 00:00:00 2007 GMT, %b %d %H:%M:%S %Y GMT)) 1178668800 I am running a VM on windows host machine. In your comment ou have specified: import ssl ssl.cert_time_to_seconds(May 9 00:00:00 2007 GMT) 1178694000.0 It should be `1178668800`: But I get also get the same answer with the Python build from latest sources? Therefore I do not get you? 3) 3 tests omitted: test___all__ test_site test_urllib2net 348 tests OK. 3 tests failed: test_codecs test_distutils test_ioctl 2 tests altered the execution environment: test___all__ test_site 33 tests skipped: test_bz2 test_codecmaps_cn test_codecmaps_hk test_codecmaps_jp test_codecmaps_kr test_codecmaps_tw test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_gzip test_idle test_kqueue test_lzma test_msilib test_ossaudiodev test_readline test_smtpnet test_socketserver test_sqlite test_ssl test_startfile test_tcl test_timeout test_tk test_ttk_guionly test_ttk_textonly test_urllibnet test_winreg test_winsound test_xmlrpc_net test_zipfile64 test_zlib Are these results fine. These results are with no changes. How can I make all tests (skipped and omiited pass) What about the 3 tests which failed. Are these known failures? 4) Now say I have to pull time again to get the latest code. Does it help to do a make. Or I will have o do configure again. 5) I had posted a query on core-metorship? No answers? Not that I am entitled to. Thanks -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19940 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19940] ssl.cert_time_to_seconds() returns wrong results if local timezone is not UTC
gudge added the comment: Sorry I think I did not read msg205774 (1st comment) correctly. It clearly says: cert_time_to_seconds() uses `time.mktime()` [1] to convert utc time tuple to seconds since epoch. `mktime()` works with local time. It should use `calendar.timegm()` analog instead. So the function cert_time_to_seconds() has to be fixed? Thanks -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19940 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20019] platform.py line _sys_version function
Wes added the comment: I'll submit this to Continuum Analytics so they know it's their issue. On Thu, Dec 19, 2013 at 3:06 AM, Marc-Andre Lemburg rep...@bugs.python.orgwrote: Marc-Andre Lemburg added the comment: Closing, since there's nothing much we can do about the problem. -- resolution: - invalid status: open - closed versions: +3rd party -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20019 ___ -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20019 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14455] plistlib unable to read json and binary plist files
Ronald Oussoren added the comment:
Conversion to XML results in:
$ plutil -convert xml1 -o - 18446744073709551615.plist
?xml version=1.0 encoding=UTF-8?
!DOCTYPE plist PUBLIC -//Apple//DTD PLIST 1.0//EN
http://www.apple.com/DTDs/PropertyList-1.0.dtd;
plist version=1.0
dict
keya/key
integer18446744073709551615/integer
/dict
/plist
This is the same as what I get with my latest patch:
import plistlib
plistlib.load(open('18446744073709551615.plist', 'rb'))
__main__:1: ResourceWarning: unclosed file _io.BufferedReader
name='18446744073709551615.plist'
{'a': 18446744073709551615}
(and I have check that I can create a binary plist with a negative integer in
this shell session)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue14455
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19940] ssl.cert_time_to_seconds() returns wrong results if local timezone is not UTC
Antoine Pitrou added the comment: So the function cert_time_to_seconds() has to be fixed? Yes! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19940 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20026] sqlite: handle correctly invalid isolation_level
Serhiy Storchaka added the comment: LGTM. -- assignee: - haypo components: +Library (Lib) nosy: +serhiy.storchaka stage: - commit review type: - crash ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20026 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20025] ssl.RAND_bytes() and ssl.RAND_pseudo_bytes() don't check if num is negative
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - haypo stage: - commit review type: - crash ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20025 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20026] sqlite: handle correctly invalid isolation_level
Roundup Robot added the comment: New changeset 11a161cf0e5d by Victor Stinner in branch '3.3': Issue #20026: Fix the sqlite module to handle correctly invalid isolation level http://hg.python.org/cpython/rev/11a161cf0e5d New changeset f9b6c8ef55b6 by Victor Stinner in branch 'default': (Merge 3.3) Issue #20026: Fix the sqlite module to handle correctly invalid http://hg.python.org/cpython/rev/f9b6c8ef55b6 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20026 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20026] sqlite: handle correctly invalid isolation_level
Changes by STINNER Victor victor.stin...@gmail.com: -- resolution: - fixed status: open - pending versions: +Python 2.7, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20026 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20026] sqlite: handle correctly invalid isolation_level
Roundup Robot added the comment: New changeset 572e4b054899 by Victor Stinner in branch '2.7': Issue #20026: Fix the sqlite module to handle correctly invalid isolation level http://hg.python.org/cpython/rev/572e4b054899 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20026 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20023] _csv.Dialect() does not check type for delimiter, escapechar and quotechar fields
Changes by STINNER Victor victor.stin...@gmail.com: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20023 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20025] ssl.RAND_bytes() and ssl.RAND_pseudo_bytes() don't check if num is negative
Roundup Robot added the comment: New changeset 68ec8949dbf1 by Victor Stinner in branch '3.3': Issue #20025: ssl.RAND_bytes() and ssl.RAND_pseudo_bytes() now raise a http://hg.python.org/cpython/rev/68ec8949dbf1 New changeset c1d2c90ece99 by Victor Stinner in branch 'default': (Merge 3.3) Issue #20025: ssl.RAND_bytes() and ssl.RAND_pseudo_bytes() now http://hg.python.org/cpython/rev/c1d2c90ece99 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20025 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20025] ssl.RAND_bytes() and ssl.RAND_pseudo_bytes() don't check if num is negative
Changes by STINNER Victor victor.stin...@gmail.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20025 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19967] asyncio: remove _TracebackLogger
STINNER Victor added the comment: Updated patch to address Guido's comments. -- Added file: http://bugs.python.org/file33214/asyncio_log_traceback-3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19967 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20024] Py_BuildValue() can call Python code with an exception set
Changes by Serhiy Storchaka storch...@gmail.com: -- stage: - test needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20024 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19983] Ctrl-C at startup can end in a Py_FatalError call
STINNER Victor added the comment: init_error.patch: modify Py_Initialize() to exit with exit(1) instead of abort(), to not call the sytem fault handler (ex: dump a coredump on Linux, or open a popup on Windows). The patch calls also initsigs() before initfsencoding(), because initfsencoding() may call Python code (encodings implemented in Python). Example with gdb (to simulate a CTRL+c during Python startup): $ gdb ./python (gdb) b initfsencoding (gdb) run Breakpoint 1, initfsencoding (interp=0x971420) at Python/pythonrun.c:972 (gdb) signal SIGINT (gdb) cont Python initialization error: Unable to get the locale encoding Traceback (most recent call last): File frozen importlib._bootstrap, line 2152, in _find_and_load KeyboardInterrupt [Inferior 1 (process 15566) exited with code 01] The process exited with exit code 1, not with SIGABRT. -- keywords: +patch Added file: http://bugs.python.org/file33215/init_error.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19997] imghdr.what doesn't accept bytes paths
Changes by STINNER Victor victor.stin...@gmail.com: -- dependencies: +Add unittests for imghdr module ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19997 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19967] asyncio: remove _TracebackLogger
Guido van Rossum added the comment: So the new patch is fine, but I still think it's confusing that the _tb_logger variable has a different type depending on the Python version. If you really don't want to fix this, just go ahead and check in, it's not a blocker. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19967 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19493] Report skipped ctypes tests as skipped
Changes by Zachary Ware zachary.w...@gmail.com: Added file: http://bugs.python.org/file33216/skip_tests_ctypes.v3.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19493 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19493] Report skipped ctypes tests as skipped
Zachary Ware added the comment: Here's a new patch addressing your review comment, Serhiy. It also addresses some failures on Windows in test_values: Win_ValuesTestCase depends on 'pydll' being defined in the module toplevel and shadowing ctypes.pydll; this definition was removed some years ago (before ctypes was merged into Python). I replaced each instance of 'pydll' with 'pythonapi', which makes the tests pass (with appropriate update to test_frozentable's expectations), but I don't understand all of ctypes well enough to be sure that it is definitely the correct fix. Also, a few long lines that were already touched have been split (without messing with other long lines) and a couple of tests have been converted from def X_test to def test_X with an unconditional skip. Another empty file has also been removed: test_errcheck is completely commented out except for a couple of imports, so it is removed entirely. The test that calls doctest.testmod in test_objects has been adjusted to fail the test if any of the doctests fail, and to not care about sys.version. Finally, test_wintypes has been rearranged to skip the test class rather than the module on non-Windows platforms to keep the same number of tests between platforms. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19493 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19940] ssl.cert_time_to_seconds() returns wrong results if local timezone is not UTC
gudge added the comment: Patch is uploaded. I will also copy paste it. I have created the patch with git. Let me know if it is okay with you. If it is unacceptable I will try and create one for mercury Patch: -- diff --combined Doc/library/ssl.rst index a6ce5d6,30cb732..000 --- a/Doc/library/ssl.rst +++ b/Doc/library/ssl.rst @@@ -366,7 -366,7 +366,7 @@@ Certificate handlin import ssl ssl.cert_time_to_seconds(May 9 00:00:00 2007 GMT) - 1178694000.0 + 1178668800 import time time.ctime(ssl.cert_time_to_seconds(May 9 00:00:00 2007 GMT)) 'Wed May 9 00:00:00 2007' diff --combined Lib/ssl.py index f81ef91,052a118..000 --- a/Lib/ssl.py +++ b/Lib/ssl.py @@@ -852,8 -852,7 +852,8 @@@ def cert_time_to_seconds(cert_time) a Python time value in seconds past the epoch. import time -return time.mktime(time.strptime(cert_time, %b %d %H:%M:%S %Y GMT)) +import calendar +return calendar.timegm(time.strptime(cert_time, %b %d %H:%M:%S %Y GMT)) PEM_HEADER = -BEGIN CERTIFICATE- PEM_FOOTER = -END CERTIFICATE- - Test Results: 358 tests OK. 1 test failed: test_compileall 1 test altered the execution environment: test___all__ 28 tests skipped: test_codecmaps_cn test_codecmaps_hk test_codecmaps_jp test_codecmaps_kr test_codecmaps_tw test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_idle test_kqueue test_lzma test_msilib test_ossaudiodev test_smtpnet test_socketserver test_sqlite test_startfile test_tcl test_timeout test_tk test_ttk_guionly test_ttk_textonly test_urllibnet test_winreg test_winsound test_xmlrpc_net test_zipfile64 Doc changes won't effect the code. The tests would not fail. How would I check if the doc changes are coming up fine in the final version. import ssl ssl.cert_time_to_seconds(May 9 00:00:00 2007 GMT) 1178668800 I do not have a printer curretly. I will sign the license agreement in a few days. -- Added file: http://bugs.python.org/file33217/patch.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19940 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18576] Rename and document test.script_helper as test.support.script_helper
Changes by Eric Snow ericsnowcurren...@gmail.com: -- nosy: +eric.snow ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18576 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16492] Add a load_parents argument to importlib.find_loader()
Eric Snow added the comment: find_loader() is now deprecated and we're going to support auto-importing parent modules in find_spec() (see #19944) -- nosy: +eric.snow resolution: - duplicate stage: test needed - committed/rejected status: open - closed superseder: - Make importlib.find_spec load packages as needed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16492 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19944] Make importlib.find_spec load packages as needed
Eric Snow added the comment: I've closed #16492 in favor of this ticket. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19944 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19648] Empty tests in pickletester need to be implemented or removed
Zachary Ware added the comment: The patch looks good to me, but I can't claim to know enough about pickle to say whether the tests are correct. Alexandre or Antoine? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19648 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5815] locale.getdefaultlocale() missing corner case
Roundup Robot added the comment: New changeset 3d805bee06e2 by Serhiy Storchaka in branch '2.7': Issue #5815: Fixed support for locales with modifiers. Fixed support for http://hg.python.org/cpython/rev/3d805bee06e2 New changeset 28883e89f335 by Serhiy Storchaka in branch '3.3': Issue #5815: Fixed support for locales with modifiers. Fixed support for http://hg.python.org/cpython/rev/28883e89f335 New changeset b50971bccfc3 by Serhiy Storchaka in branch 'default': Issue #5815: Fixed support for locales with modifiers. Fixed support for http://hg.python.org/cpython/rev/b50971bccfc3 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5815 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5815] locale.getdefaultlocale() missing corner case
Serhiy Storchaka added the comment: Committed without devanagari special case and tests. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5815 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19940] ssl.cert_time_to_seconds() returns wrong results if local timezone is not UTC
Antoine Pitrou added the comment: Answering to your questions: I have created the patch with git. Let me know if it is okay with you. Yes, it's ok. Also, please don't copy / paste it. Uploading is enough. Doc changes won't effect the code. The tests would not fail. How would I check if the doc changes are coming up fine in the final version. The devguide has detailed documentation about how to modify and build the documentation :) http://docs.python.org/devguide/documenting.html#building-the-documentation As for the tests: 1. for this issue you should probably concentrate on test_ssl: to run it in verbose mode, ./python -m test -v test_ssl (please read http://docs.python.org/devguide/runtests.html) 2. you will need to add a new test to test_ssl, to check that this bug is indeed fixed -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19940 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20027] Fixed support for Indian locales
New submission from Serhiy Storchaka: The locales alias table contains invalid entries for devanagari modifiers (see issue5815): 'ks_in@devanagari': 'ks...@devanagari.utf-8', 'sd': 'sd...@devanagari.utf-8', Here is a patch which fixes aliases for these locales. -- components: Library (Lib) files: locale_aliases.patch keywords: patch messages: 206636 nosy: lemburg, loewis, serhiy.storchaka priority: normal severity: normal stage: patch review status: open title: Fixed support for Indian locales type: behavior versions: Python 2.7, Python 3.3, Python 3.4 Added file: http://bugs.python.org/file33218/locale_aliases.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20027 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue777588] asyncore is broken for windows if connection is refused
Changes by Marc Schlaich marc.schla...@googlemail.com: -- nosy: -schlamar ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue777588 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20027] Fixed support for Indian locales
Changes by Serhiy Storchaka storch...@gmail.com: Added file: http://bugs.python.org/file33219/locale_devanagari.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20027 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20027] Fixed support for Indian locales
Changes by Serhiy Storchaka storch...@gmail.com: Removed file: http://bugs.python.org/file33218/locale_aliases.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20027 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5815] locale.getdefaultlocale() missing corner case
Serhiy Storchaka added the comment: For devanagari modifier opened new issue20027. -- resolution: - fixed stage: patch review - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5815 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19683] test_minidom has many empty tests
Roundup Robot added the comment: New changeset 2737c0e7ba71 by Zachary Ware in branch '2.7': Issue #19683: Removed empty tests from test_minidom. http://hg.python.org/cpython/rev/2737c0e7ba71 New changeset 5e510117b71a by Zachary Ware in branch '3.3': Issue #19683: Removed empty tests from test_minidom. Patch by Ajitesh Gupta. http://hg.python.org/cpython/rev/5e510117b71a -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19683] test_minidom has many empty tests
Zachary Ware added the comment: Thanks for the removal patch, Ajitesh! Julian, are you still working on implementing the tests on default? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19967] asyncio: remove _TracebackLogger
STINNER Victor added the comment: So the new patch is fine, but I still think it's confusing that the _tb_logger variable has a different type depending on the Python version. To be honest, I'm also concerned by this strange variable :-) Here is a new fix which reuses the name used in the first patch (_traceback). -- Added file: http://bugs.python.org/file33220/asyncio_log_traceback-4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19967 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19683] test_minidom has many empty tests
Julian Gindi added the comment: I have not started yet, wasn't completely sure of the status of this. I'll get going filling in those tests to the best of my ability. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19683] test_minidom has many empty tests
Zachary Ware added the comment: Alright, sounds good. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19683] test_minidom has many empty tests
Changes by Zachary Ware zachary.w...@gmail.com: -- versions: +Python 3.4 -Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19967] asyncio: remove _TracebackLogger
STINNER Victor added the comment: asyncio_log_traceback-5.patch: new try :-) -- Added file: http://bugs.python.org/file33221/asyncio_log_traceback-5.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19967 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19493] Report skipped ctypes tests as skipped
Serhiy Storchaka added the comment: I can't say anything about pydll, other changes LGTM. Except that I'm not sure that test_wintypes needs a fix. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19493 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5815] locale.getdefaultlocale() missing corner case
STINNER Victor added the comment: Buildbot failure: http://buildbot.python.org/all/builders/x86%20Gentoo%20Non-Debug%203.3/builds/1314/steps/test/logs/stdio == ERROR: test_locale_alias (test.test_locale.NormalizeTest) -- Traceback (most recent call last): File /var/lib/buildslave/3.3.murray-gentoo-wide/build/Lib/test/test_locale.py, line 374, in test_locale_alias with self.subTest(locale=(localename, alias)): AttributeError: 'NormalizeTest' object has no attribute 'subTest' -- resolution: fixed - status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5815 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5815] locale.getdefaultlocale() missing corner case
Roundup Robot added the comment: New changeset e0675408f4af by Serhiy Storchaka in branch '2.7': Don't use sebTest() in tests for issue #5815. http://hg.python.org/cpython/rev/e0675408f4af New changeset ed16f6695638 by Serhiy Storchaka in branch '3.3': Don't use sebTest() in tests for issue #5815. http://hg.python.org/cpython/rev/ed16f6695638 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5815 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue5815] locale.getdefaultlocale() missing corner case
Serhiy Storchaka added the comment: Oh, thanks Victor. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue5815 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19967] asyncio: remove _TracebackLogger
Guido van Rossum added the comment: Looks good. I can fix that long line myself. :-) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19967 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19493] Report skipped ctypes tests as skipped
Zachary Ware added the comment: I'd prefer to keep the change to test_wintypes, simply because I was rather surprised to find an extra test being run on Windows. As for the pydll/pythonapi issue, any thoughts from Amaury, Meador, or Alexander? The relevant change that removed the definition of pydll in test_values can be found here[1]. That also makes me wonder why exactly the test is named *Win*_ValuesTestCase and whether it actually needs a skip or just a rename, since there doesn't appear to me to be anything related to Windows about the test. [1] http://ctypes.cvs.sourceforge.net/viewvc/ctypes/ctypes/ctypes/test/test_values.py?hideattic=0r1=1.1.2.1r2=1.1.2.2 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19493 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19946] Handle a non-importable __main__ in multiprocessing
Christian Heimes added the comment: The OpenIndiana tests are still failing. OpenIndiana doesn't support forkserver because it doesn't implement the send handle feature. The patch skips the forkserver tests if HAVE_SEND_HANDLE is false. -- Added file: http://bugs.python.org/file33222/skip_forkserver.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19946 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17202] Add .bat line to .hgeol
Zachary Ware added the comment: Any objections to proceeding with this? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17202 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19967] asyncio: remove _TracebackLogger
Roundup Robot added the comment: New changeset 5e9728ebb1d3 by Victor Stinner in branch 'default': Close #19967: Thanks to the PEP 442, asyncio.Future can use a destructor in http://hg.python.org/cpython/rev/5e9728ebb1d3 -- nosy: +python-dev resolution: - fixed stage: - committed/rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19967 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19946] Handle a non-importable __main__ in multiprocessing
Nick Coghlan added the comment: I think that needs to be fixed on the multiprocessing side rather than just in the tests - we shouldn't create a concrete context for a start method that isn't going to work on that platform. Finding that kind of discrepancy was part of my rationale for basing the skips on the available contexts (although my main motivation was simplicity). There may also be docs implications in describing which methods are supported on different platforms (although I haven't looked at how that is currently documented). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19946 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19713] Deprecate various things in importlib thanks to PEP 451
Eric Snow added the comment: I'm glad you spoke up, Nick. Holding off on the DeprecationWarnings is fine with me. It's not like we are going to drop support for the APIs before Python 4! That said, DeprecationWarnings are disabled by default. So how big a deal do you think it is to leave the warnings in (minus loader.load_module)? I simply don't have a sense of how often people would be running with all warnings enabled (and not want that to let them know about these deprecations). The latest patch already yanks most of the load_module() warnings. It had slipped my mind in the first patch. Of the warnings that are left, I'd still like to leave them in for: * importlib.find_loader() * NamespaceLoader (still not sure what to think about that class) * loader.module_repr() (if I can figure out a good way to make it work) since it will end up being a 3.3-only feature * importlib.util.set_loader() * importlib.util.set_package() That basically leaves removing warnings for finders (and maybe one or two others I missed): * finder.find_module() * finder.find_loader() As I said, I'm fine with doing so (or even pulling all the warnings). I simply thought of the warnings as a service to Python users to make them aware of the deprecations if they chose to check. However, I haven't been doing this nearly as long as you. :) So I'll readily concede that I may be missing something. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19713 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19946] Handle a non-importable __main__ in multiprocessing
Richard Oudkerk added the comment:
On 19/12/2013 10:00 pm, Nick Coghlan wrote:
I think that needs to be fixed on the multiprocessing side rather than just
in the tests - we shouldn't create a concrete context for a start method
that isn't going to work on that platform. Finding that kind of discrepancy
was part of my rationale for basing the skips on the available contexts
(although my main motivation was simplicity).
There may also be docs implications in describing which methods are
supported on different platforms (although I haven't looked at how that is
currently documented).
If by concrete context you mean _concrete_contexts['forkserver'], then
that is supposed to be private. If you write
ctx = multiprocessing.get_context('forkserver')
then this will raise ValueError if the forkserver method is not
available. You can also use
'forkserver' in multiprocessing.get_all_start_methods()
to check if it is available.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue19946
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19967] asyncio: remove _TracebackLogger
Antoine Pitrou added the comment: I think this patch is bad and should be reverted. It always calls traceback.format_exception() which is an expensive operation, while the _TracebackLogger takes care to call it only when necessary. -- assignee: - haypo status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19967 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19967] asyncio: remove _TracebackLogger
Guido van Rossum added the comment: Eew. You're right. Sorry I didn't see this. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19967 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19713] Deprecate various things in importlib thanks to PEP 451
Nick Coghlan added the comment: Test suites enable deprecation warnings by default, and many projects have a no warnings allowed rule. By adding programmatic deprecation warnings for the old APIs where there's no other way to it in a 3.3 compatible way, we make things more difficult for people that still need to support 3.3. I'm OK with doing that when there's a concrete payoff in significantly reducing our maintenance burden, eliminating an attractive nuisance (I took that as far as removing contextlib.nested entirely before coming up with ExitStack as a replacement), or when there's a concrete benefit to the *user* in migrating, but otherwise lean towards the I want major Python upgrades to be exciting, not annoying school of thought most of the time. And yes, I'm biased through working on package stuff - all of that needs to straddle 2.6+ and 3.2+ due to platform support requirements, and I want people to be free to work on metadata 2.0 rather than figuring out how to avoid new deprecation warnings :) Your updated list of suggested near-term deprecations sounds a lot more reasonable to me - that stuff is all 3.3 specific, and the packaging ecosystem hasn't really adjusted to those yet anyway (given the heavy 2.6+ and 3.2+ bias). It was mostly the method deprecations that bothered me, since providing the lowest common denominator APIs is the easiest way to implement cross version compatible finders and loaders. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19713 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19946] Handle a non-importable __main__ in multiprocessing
Nick Coghlan added the comment: Ah, I should have looked more closely at the docs to see if there was a public API for that before poking around in the package internals. In that case, I suggest we change this bit in the test: # We look inside the context module to find out which # start methods we can check from multiprocessing.context import _concrete_contexts to use the appropriate public API: # Need to know which start methods we should test import multiprocessing AVAILABLE_START_METHODS = set(multiprocessing.get_all_start_methods()) And then adjust the skip check to look in AVAILABLE_START_METHODS rather than _concrete_contexts. I'll make that change tonight if nobody beats me to it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19946 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19713] Deprecate various things in importlib thanks to PEP 451
Eric Snow added the comment: Sounds good. Thanks for the explanation. It sounds like you're effectively concerned just with finder.find_module() and loader.load_module() (which is fine with me). Everything else (including some of the ABCs) is 3.3-only. For the sake of simplicity I could also leave the warnings off finder.find_loader() as well (if you want). Sorry for all the fuss. I've never *really* deprecated anything before. :) This has been really helpful. I see the value in the warnings (when things are going to be removed later vs. there's something better), but also see your point about the pain warnings can cause (especially when we don't have concrete plans for removal). What a weird balance. p.s. If only I had a time machine to put PendingDeprecationWarnings on those 3.3-only APIs! wink -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19713 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue3566] httplib persistent connections violate MUST in RFC2616 sec 8.1.4.
Alan Justino added the comment: Seems to affect 2.7 too. -- nosy: +alanjds versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue3566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19524] ResourceWarning when urlopen() forgets the HTTPConnection object
Martin Panter added the comment: How is it safer to manually set “h.sock._closed”? Playing with the internals of HTTPConnection is one thing, but playing with the internals of the socket object as well does not seem necessary. Also the ResourceWarning is warning that the socket and connection were closed by the garbage collector at some arbitrary point. I don’t think a new __del__() method is going to help. Sorry to be so negative :) Related issues: Issue 18144: FD leak in urllib2 (probably an exact dupe) Issue 11563: test_urllibnet is triggering a ResourceWarning (bug closed, but real issue was only side-stepped IMO) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19524 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20028] Confusing error message when giving invalid quotechar in initializing csv dialect
New submission from Vajrasky Kok: Python 3.4.0b1 (default:13a505260f17, Dec 20 2013, 12:02:44) [GCC 4.7.2] on linux import _csv import csv _csv.Dialect(quotechar=b'+') Traceback (most recent call last): File stdin, line 1, in module TypeError: quotechar must be string, not bytes Hey, that's not true. Quotechar can be None. _csv.Dialect(quotechar=None) _csv.Dialect object at 0x7f64a8534790 _csv.Dialect(quotechar=cutecat) Traceback (most recent call last): File stdin, line 1, in module TypeError: quotechar must be an 1-character string That's not strictly true. Quotechar can be 0-character string in certain situation. _csv.Dialect(quotechar=, quoting=csv.QUOTE_NONE) _csv.Dialect object at 0x7f64a85345f0 Python 2.7 suffers the same issue. -- components: Library (Lib) messages: 206663 nosy: r.david.murray, serhiy.storchaka, vajrasky priority: normal severity: normal status: open title: Confusing error message when giving invalid quotechar in initializing csv dialect type: behavior versions: Python 2.7, Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20028 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19977] Use surrogateescape error handler for sys.stdin and sys.stdout on UNIX for the C locale
Changes by Martin Panter vadmium...@gmail.com: -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19977 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16000] test_curses should use unittest
Zachary Ware added the comment: It's only taken me 6 months, but I'm looking at this issue again :) Ed, basically the only reason I used setUpModule was because it was a very direct translation from test_main to setUpModule--only the name and signature changed, the skip and initialization code stayed exactly the same. It does make more sense for it to be in setUpClass, though, so that's done in the new patch. Thanks for pointing out the typo, fixed. -- Added file: http://bugs.python.org/file33223/issue16000.v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16000 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20009] Property should expose wrapped function.
Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo, ncoghlan versions: -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20009 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20029] asyncio.SubprocessProtocol is missing
New submission from akira: `SubprocessProtocol` is documented to be accessible as `asyncio.SubprocessProtocol` [1] but it is not included in `asyncio.protocols.__all__` [2] that leads to `AttributeError`: python3.4 -c import asyncio; asyncio.SubprocessProtocol Traceback (most recent call last): File string, line 1, in module AttributeError: 'module' object has no attribute 'SubprocessProtocol' The following works as expected: python3.4 -c import asyncio; asyncio.protocols.SubprocessProtocol No error. [1]: http://docs.python.org/3.4/library/asyncio-protocol.html#asyncio.SubprocessProtocol [2]: http://hg.python.org/cpython/file/13a505260f17/Lib/asyncio/protocols.py#l3 -- components: Library (Lib) messages: 206665 nosy: akira priority: normal severity: normal status: open title: asyncio.SubprocessProtocol is missing type: behavior versions: Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20029 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19940] ssl.cert_time_to_seconds() returns wrong results if local timezone is not UTC
akira added the comment: gudge, have you seen http://bugs.python.org/msg205860 (the locale issue)? If you can't fix it; say so, I'll open another issue after this issue is fixed. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19940 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20028] Confusing error message when giving invalid quotechar in initializing csv dialect
Vajrasky Kok added the comment: Here is the preliminary patch for Python 3.3 and 3.4. -- keywords: +patch Added file: http://bugs.python.org/file33224/fix_handling_invalid_quotechar.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20028 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20028] Confusing error message when giving invalid quotechar in initializing csv dialect
Vajrasky Kok added the comment: Here is the preliminary patch for Python 2.7. -- Added file: http://bugs.python.org/file33225/fix_handling_invalid_quotechar_python27.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20028 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20028] Confusing error message when giving invalid quotechar in initializing csv dialect
Changes by Vajrasky Kok sky@speaklikeaking.com: Removed file: http://bugs.python.org/file33225/fix_handling_invalid_quotechar_python27.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20028 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20028] Confusing error message when giving invalid quotechar in initializing csv dialect
Changes by Vajrasky Kok sky@speaklikeaking.com: Added file: http://bugs.python.org/file33226/fix_handling_invalid_quotechar.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20028 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
