[issue24230] tempfile.mkdtemp() doesn't work with bytes paths
Gregory P. Smith added the comment: code review comments addressed. -- Added file: http://bugs.python.org/file39464/issue24230-gps02.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24230 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23969] please set a SOABI for MacOSX
Ned Deily added the comment: Ronald, the change to set the SOABI was pushed several weeks ago (but, because I left out a #, the commit message did not also show up here as I intended): New changeset 32c24eec035f by Ned Deily in branch 'default': Issues #22980, 23969: For OS X, use PEP 3149-style file names for extension https://hg.python.org/cpython/rev/32c24eec035f As noted in the commit message, the names are now of the form: _ssl.cpython-35m-darwin.so As was extensively discussed in Issue22980, I chose to not try to add hardware architecture and deployment target to the file name as I think pip and friends are already managing this correctly (msg241254). We could change the name from -darwin to -macosx if you feel strongly about it but, if so, we should do that now, before beta1. I don't feel too strongly about it (e.g. -darwin vs -macosx) but I would rather not re-open the discussion at this point if possible. Also, given the discussion there, I'd rather not attempt to change the extension from .so to something else; I think that is more likely to be disruptive to the external packaging ecosphere. So unless you *really* want it changed, I intend to let things stand for 3.5 as implemented in 32c24eec035f. -- resolution: - fixed stage: needs patch - resolved status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23969 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24221] Clean-up and optimization for heapq siftup() and siftdown()
Roundup Robot added the comment: New changeset 490720fc1525 by Raymond Hettinger in branch 'default': Issue #24221: Small optimizations for heapq. https://hg.python.org/cpython/rev/490720fc1525 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24221 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24221] Clean-up and optimization for heapq siftup() and siftdown()
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24221 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24262] logging.FileHandler.close() is not thread-safe
Gleb Dubovik added the comment: We used a very old version of python shipped with 12.04 LTS. The bug was fixed in 2.7.3 in 2ab3a97d544c by Vinay. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24262 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used
Nick Coghlan added the comment: The patch mostly looks good to me, but I suggest using test.support.check_warnings for the cases where you're checking that the warning is raised as expected: https://docs.python.org/3/library/test.html#test.support.check_warnings It's slightly simpler than constructing the same logic yourself using warnings.catch_warnings. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24237 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24264] imageop Unsafe Arithmetic
Changes by Ned Deily n...@acm.org: -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24264 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24230] tempfile.mkdtemp() doesn't work with bytes paths
Martin Panter added the comment: Looks good in general. I think the signatures in Doc/library/tempfile.rst need updating for the following functions (possibly also version changed notices added somewhere): * NamedTemporaryFile * TemporaryFile * SpooledTemporaryFile * TemporaryDirectory -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24230 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24257] Incorrect use of PyObject_IsInstance
Changes by Serhiy Storchaka storch...@gmail.com: -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24257 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22107] tempfile module misinterprets access denied error on Windows
eryksun added the comment: My reluctance to commit the os.access patch is because it will cause such a behaviour change in a function which has been pretty stable for a long while. The original behavior could be preserved as the default. A keyword-only argument could enable checking access based on the file security and thread token. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22107 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24221] Clean-up and optimization for heapq siftup() and siftdown()
Stefan Behnel added the comment: There are calls to PyObject_RichCompareBool() in the loops, which means that user code might get executed. What if that's evil code that modifies the heap list? Couldn't that lead to list resizing and thus invalidation of the list item pointer? -- nosy: +scoder ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24221 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24257] Incorrect use of PyObject_IsInstance
Roundup Robot added the comment: New changeset bccaba8a5482 by Serhiy Storchaka in branch '2.7': Issue #24257: Fixed segmentation fault in sqlite3.Row constructor with faked https://hg.python.org/cpython/rev/bccaba8a5482 New changeset c7b9645a6f35 by Serhiy Storchaka in branch '3.4': Issue #24257: Fixed incorrect uses of PyObject_IsInstance(). https://hg.python.org/cpython/rev/c7b9645a6f35 New changeset a5101529a8a9 by Serhiy Storchaka in branch 'default': Issue #24257: Fixed incorrect uses of PyObject_IsInstance(). https://hg.python.org/cpython/rev/a5101529a8a9 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24257 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24264] imageop Unsafe Arithmetic
New submission from JohnLeitch:
Several functions within the imageop module are vulnerable to exploitable
buffer overflows due to unsafe arithmetic in check_multiply_size(). The problem
exists because the check to confirm that size == product / y / x does not take
remainders into account.
static int
check_multiply_size(int product, int x, const char* xname, int y, const char*
yname, int size)
{
if ( !check_coordonnate(x, xname) )
return 0;
if ( !check_coordonnate(y, yname) )
return 0;
if ( size == (product / y) / x )
return 1;
PyErr_SetString(ImageopError, String has incorrect length);
return 0;
}
Consider a call to check_multiply_size() where product is 16, x is 1, and y is
9. In the Windows x86 release of Python 2.7.9, the division is performed using
the idiv instruction:
0:000 dV
product = 0n16
x = 0n1
xname = 0x1e1205a4 x
y = 0n9
yname = 0x1e127ab8 y
size = 0n1
0:000 u eip
python27!check_multiply_size+0x25 [c:\build27\cpython\modules\imageop.c @ 53]:
1e0330e5 f7ffidiveax,edi
1e0330e7 99 cdq
1e0330e8 f7feidiveax,esi
1e0330ea 3944240ccmp dword ptr [esp+0Ch],eax
1e0330ee 7506jne python27!check_multiply_size+0x36 (1e0330f6)
1e0330f0 b80100 mov eax,1
1e0330f5 c3 ret
1e0330f6 8b15e47e241emov edx,dword ptr [python27!ImageopError
(1e247ee4)]
0:000 ?eax
Evaluate expression: 16 = 0010
0:000 ?edi
Evaluate expression: 9 = 0009
When the first idiv instruction is executed, the result (eax) is 1 with a
remainder of 7 (edx):
0:000 p
eax=0001 ebx= ecx=1e127ab8 edx=0007 esi=0001 edi=0009
eip=1e0330e7 esp=0027fcec ebp=0001 iopl=0 nv up ei pl nz na po nc
cs=0023 ss=002b ds=002b es=002b fs=0053 gs=002b efl=0202
python27!check_multiply_size+0x27:
1e0330e7 99 cdq
0:000 ?eax
Evaluate expression: 1 = 0001
0:000 ?edx
Evaluate expression: 7 = 0007
Because size is 1, the check passes:
Breakpoint 4 hit
eax=0001 ebx= ecx=1e127ab8 edx= esi=0001 edi=0009
eip=1e0330f0 esp=0027fcec ebp=0001 iopl=0 nv up ei pl zr na pe nc
cs=0023 ss=002b ds=002b es=002b fs=0053 gs=002b efl=0246
python27!check_multiply_size+0x30:
1e0330f0 b80100 mov eax,1
This is problematic because some of the imageop functions, such as grey2rgb,
utilize check_multiply_size() to check divisibility prior to copying data into
a buffer. Consider a call to grey2rgb where x is 1, y is 9, and len is 16.
static PyObject *
imageop_grey2rgb(PyObject *self, PyObject *args)
{
int x, y, len, nlen; x = 1, y = 9, and len = 16.
unsigned char *cp;
unsigned char *ncp;
PyObject *rv;
int i;
unsigned char value;
int backward_compatible = imageop_backward_compatible();
if ( !PyArg_ParseTuple(args, s#ii, cp, len, x, y) )
return 0;
if ( !check_multiply(len, x, y) ) 16 != 1 * 9, but this check
still passes.
return 0;
nlen = x*y*4; 1 * 9 * 4 == 36.
if ( !check_multiply_size(nlen, x, x, y, y, 4) )
return 0;
rv = PyString_FromStringAndSize(NULL, nlen); This creates a buffer
of length 36.
if ( rv == 0 )
return 0;
ncp = (unsigned char *)PyString_AsString(rv); This retrieves the
buffer of length 36.
for ( i=0; i len; i++ ) { This loop assumes that len * 4 ==
nlen, which is incorrect
in this case.
value = *cp++;
if (backward_compatible) {
Each iteration copies 4 bytes into the 36 byte buffer
pointed to by ncp and
advances the pointer by 4. Because len is 16, 64 bytes are
ultimately copied
into the buffer, leading to an exploitable buffer overflow
condition.
* (Py_UInt32 *) ncp = (Py_UInt32) value | ((Py_UInt32) value 8 )
| ((Py_UInt32) value 16);
ncp += 4;
} else {
*ncp++ = 0;
*ncp++ = value;
*ncp++ = value;
*ncp++ = value;
}
}
return rv;
}
When the call completes, memory has been corrupted:
0:000 g
(12f4.640): Access violation - code c005 (first chance)
First chance exceptions are reported before any exception handling.
This exception may be expected and handled.
eax=0044 ebx=0001 ecx=1e201d98 edx=00303030 esi=1e201d98 edi=1e201d98
eip=1e031fc6 esp=0027fe7c ebp=0002 iopl=0 nv up ei ng nz ac pe cy
cs=0023 ss=002b ds=002b es=002b fs=0053 gs=002b efl=00010297
python27!update_refs+0x6:
1e031fc6 8b5010 mov edx,dword ptr [eax+10h]
ds:002b:0054=
0:000 g
(12f4.640): Access violation - code c005 (!!! second chance !!!)
eax=0044 ebx=0001 ecx=1e201d98 edx=00303030 esi=1e201d98 edi=1e201d98
eip=1e031fc6 esp=0027fe7c
[issue22107] tempfile module misinterprets access denied error on Windows
Tim Golden added the comment: That is a possibility which hadn't occurred to me. @eryksun, would you mind eyeballing the patch over on issue2582? It almost certainly won't apply cleanly as it's been almost two years since I last refreshed it, but you can hopefully gauge the intent. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22107 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22107] tempfile module misinterprets access denied error on Windows
eryksun added the comment: Ok, I think I understand now. You chose an indirect check to avoid the race condition. If we have write access to the directory, then the PermissionError must be because a directory exists with the same name. Unfortunately os.access doesn't currently tell us this information. Moreover, checking `isdir(dir) and access(dir, W_OK)` is actually redundant as things currently stand. If `isdir` returns True that means GetFileAttributes didn't fail, which means `access` must return True as designed: return_value = (attr != INVALID_FILE_ATTRIBUTES) ( !(mode 2) || !(attr FILE_ATTRIBUTE_READONLY) || (attr FILE_ATTRIBUTE_DIRECTORY) ); -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22107 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24263] Why VALID_MODULE_NAME in unittest/loader.py is r'[_a-z]\w*\.py$' not r'\w+\.py$' ?
Changes by Ned Deily n...@acm.org: -- components: -Unicode nosy: +rbcollins versions: +Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24263 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24221] Clean-up and optimization for heapq siftup() and siftdown()
Serhiy Storchaka added the comment: The list item pointer is updated just after calling PyObject_RichCompareBool(). The code LGTM. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24221 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24262] logging.FileHandler.close() is not thread-safe
Changes by Ned Deily n...@acm.org: -- nosy: +vinay.sajip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24262 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24263] Why VALID_MODULE_NAME in unittest/loader.py is r'[_a-z]\w*\.py$' not r'\w+\.py$' ?
Changes by sih4sing5hong5 ihc...@gmail.com: -- components: Unicode nosy: ezio.melotti, haypo, sih4sing5hong5 priority: normal severity: normal status: open title: Why VALID_MODULE_NAME in unittest/loader.py is r'[_a-z]\w*\.py$' not r'\w+\.py$' ? type: behavior versions: Python 3.2, Python 3.3, Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24263 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24219] Repeated integer in Lexical analysis/Integer literals section
Dmitry Kazakov added the comment: Please, do tell me if I'm wrong deleting that literal and it actually serves some purpose... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24219 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12319] [http.client] HTTPConnection.request not support chunked Transfer-Encoding to send data
Rolf Krahl added the comment: I disagree. I believe that the suggested modification of AbstractHTTPHandler.do_request_() belongs into this change set for the following reasons: 1. This module [http.client] defines classes which implement the client side of the HTTP and HTTPS protocols. It is normally not used directly — the module urllib.request uses it to handle URLs that use HTTP and HTTPS. Quote from the http.client documentation. urllib.request is the high level API for HTTP requests. Both modules must fit together. Since urllib's HTTPHandler directly calls HTTPConnection, it can and should rely on the abilities of HTTPConnection. 2. The code in AbstractHTTPHandler is based on the assumption that each HTTP request having a non empty body must have a Content-length header set. The truth is that a HTTP request must either have a Content-length header or use chunked transfer encoding (and then must not have a Content-length header). As long as the underlying low level module did not support chunked transfer encoding anyway, this assumption might have been acceptable. Now that this change set introduces support for chunked transfer encoding, this assumption is plain wrong and the resulting code just faulty. 3. This change set introduces a sophisticated determination of the correct content length, covering several different cases, including file like objects and iterables. There is no need any more for the high level API to care about the content length, if this is already done in the low level method. But even worse, all the efforts of HTTPConnection to determine the proper content length is essentially overridden by the rather blunt method in the high level API that get priority and that essentially insists the body to be a buffer like object. This is strange. 4. The very purpose of this change set is to implement chunked transfer encoding. But this is essentially disabled by a high level API that insists a Content-length header to be set. This is plain silly. Just to illustrate the current situation, I attach the modified version of my old chunkedhttp.py module, adapted to Demian's patch that I have used to test it. It shows how a user would need to monkey patch the high level API in order to be able to use the features that is implemented by this change in the low level module. I wouldn't mind to file another issue against urllib.request.HTTPHandler if this makes things easier. But what I really would like to avoid, is to have any Python version in the wild that has this current issue fixed, but HTTPHandler still broken. Having to support a wide range of different Python versions is difficult enough for third party library authors like me. Adding a switch to distinguish between 3.6 (I can use the standard lib right away) and older (I need to replace it be my own old chunkedhttp implementation) is ok. But having to support a third case (the low level HTTPConnection module would work, but I need to monkey patch the high level API in order to be able to use it) in-between would make things awkward. That's why I would prefer to see the fix for HTTPHandler in the same change set. -- Added file: http://bugs.python.org/file39466/chunkedhttp-2.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12319 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20438] inspect: Deprecate getfullargspec?
Yury Selivanov added the comment: I'm copying/pasting my latest commit message on this issue here: Add a note about deprecating old inspect APIs to whatsnew. Also, deprecate formatargspec, formatargvalues, and getargvalues functions. Since we are deprecating 'getfullargspec' function in 3.5 (documentation only, no DeprecationWarning), it makes sense to also deprecate functions designed to be directly used with it. In 3.6 we will remove 'getargsspec' function (was deprecated since Python 3.0), and start raising DeprecationWarnings in other 'getarg*' family of functions. We can remove them in 3.7 or later. Also, it is worth noting, that Signature API does not provide 100% of functionality that deprecated APIs have. It is important to do a soft deprecation of outdated APIs in 3.5 to gather users feedback, and improve Signature object. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24204] string.strip() documentation is misleading
Raymond Hettinger added the comment: This patch looks reasonable. -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24204 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24056] Expose closure generator status in function repr()
Raymond Hettinger added the comment: It's mostly pedagogical - similar to normal functions vs generator functions, I see a need for this but object to calling it a generator rather than a function that makes a generator or generator creating function or somesuch. There is a huge semantic difference between the two. Another thought this that I'm not sure that a __repr__ should try usurp something that is the primary responsibility of a docstring or function annotation here. Whether a function call runs code and returns a value or whether it returns a generator is fundamental to what the function does. The usual job of the __repr__ is to tell what the object is. The usual job of a docstring or type annotation to the describe what is returned. Marking closure functions as such is a bit more subtle. However, there ia a real point that closure functions have a hidden input. I don't see a need for this and think it make cause more confusion than help. I try to teach that callables are all conceptually the same thing (something that has a __call__ method). It matters very little whether a callable is implemented as a closure or using a class with a __call__ method. So, put me down for -1 on this one. -- nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24056 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23509] Speed up Counter operators
Raymond Hettinger added the comment: Sorry, I don't want to any of these changes (though it is a close call on a couple of them). Before the particulars, here are some high-level thoughts (not definitive). I would like to confine the optimizations and complexities to the more important parts of the API (actually counting as opposed to counter-to-counter operations). Also, I don't want to preclude some of the future possibilities under consideration (for example, I am leaning toward guaranteeing the order of updates so that the OrderedCounter recipe has guaranteed behavior). Also, I'm considering removing the existing self.get(elem, 0) in update() and substract() so that subclassers can usefully override/extend the __missing__ method to return other types (like decimals, fractions, etc) or have other behaviors like logging missing entries, etc. And the self.get optimization doesn't seem to perform well under PyPy in contrast to an inherited __getitem__. The current code choices were biased towards simplicity, space-over-speed, and keeping a predictable operation order where possible. Particulars: 1) get() bound method optimization: This is a close call. We already use this in update() and subtract() though I'm thinking of removing those two cases. Switching from c[k] to c.get(k, 0) is a semantic change that affects subclasses that define, __getitem__(), get(), or __missing__(). Speedwise, c.get() is faster than a fallback to __missing__() for missing keys; conversely, the inherited __getitem__() is faster than c.get(k, 0) when the keys are present. There is some room for debate about which is the common case (it really depends on what your application is) and I would prefer at this point not to shift assumptions about is more common. Clarity-wise: The square brackets are clearer than the boundmethod trick which I would like to use only where it really matters. 2) The current _keep_positive() is shorter, clearer, maintains order for the OrderedCounter use case, and is more space-efficient (never using more space than the original counter and intentionally choosing to remove elements rather than building a new one from scratch). This is how it was done in setobject.c for the same reasons. 3) Other than brevity, I don't see any advantage to __add__ and __or__ being defined via inplace operations. That is a semantic change that can affect subclassers, violating the open-closed-principle (I want people to be able to override/extend the in-place methods without unintentionally breaking add/or methods). Also, the current approach has a space saving bias (not storing negative counts in the first place rather than using a follow-on call to _keep_positive pass to eliminate the negatives after they have been stored). 4) The code expansion for __pos__ and __neg__ grows the code and is less clear (IMO). The change for __pos__ scrambles the order, interfering with the OrderedCounter example. Also, I want the meaning of +c to be the same as c plus an empty counter (at least, that is how I think of the operation). FWIW, the unary plus operation was intended to be a trigger for _keep_positive. It was modeled after the unary plus in Decimal which serves the purpose of triggering rounding. I'm sure there is room for argument about any one of the points above, some are just judgment calls. I'm closing this because the OP's original concern about wanting an in-place operation was already solved and because the proposed optimizations slightly change semantics, aren't really the important part of the API, the snarl the code a bit, and they interfere with some future directions I want keep open. Also, I've already spent several hours to reviewing this patch and need to return attention to other matters. -- resolution: - rejected status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23509 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20438] inspect: Deprecate getfullargspec?
Berker Peksag added the comment: Just a minor comment on the patch: +warnings.warn(inspect.getargspec() is deprecated, + use inspect.signature() instead, DeprecationWarning) Can you also add stacklevel=2? -- nosy: +berker.peksag ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24244] Python exception on strftime with %f on Python 3 and Python 2 on windows
Roundup Robot added the comment: New changeset 254b8e68959e by Steve Dower in branch 'default': Issue 24244: Prevents termination when an invalid format string is encountered on Windows. https://hg.python.org/cpython/rev/254b8e68959e -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24244 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16991] Add OrderedDict written in C
Eric Snow added the comment: Include/opcode.h shouldn't be in the change (and won't be when committed). I'm guessing it being there is related to one of the recent merges I did from default into the feature branch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16991 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23955] Add python.ini file for embedded/applocal installs
Steve Dower added the comment: The support is in and the option remains named applocal. Hopefully this (and the ZIP file version, which will include the preconfigured pyvenv.cfg) will help with app distributions, though I'm still open to make changes if it doesn't. -- resolution: - fixed stage: - resolved status: open - closed type: - enhancement ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23955 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24199] Idle: remove idlelib.idlever.py and its use in About dialog
Roundup Robot added the comment: New changeset 117af4bc0513 by Benjamin Peterson in branch '2.7': make idlever.py self-updating (closes #24199) https://hg.python.org/cpython/rev/117af4bc0513 -- resolution: - fixed stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24199 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20438] inspect: Deprecate getfullargspec?
Roundup Robot added the comment: New changeset 666e5b554f32 by Yury Selivanov in branch 'default': Issue 20438: Adjust stacklevel of inspect.getargspec() warning. https://hg.python.org/cpython/rev/666e5b554f32 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23955] Add python.ini file for embedded/applocal installs
Roundup Robot added the comment: New changeset 620a247b4960 by Steve Dower in branch 'default': Issue #23955: Add pyvenv.cfg option to suppress registry/environment lookup for generating sys.path. https://hg.python.org/cpython/rev/620a247b4960 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23955 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24244] Python exception on strftime with %f on Python 3 and Python 2 on windows
Steve Dower added the comment: That handles Python 3.5 and future versions, even if the supported formats change. Is there something that needs fixing in 3.4? I don't get a crash, just the ValueError... -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24244 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24219] Repeated integer in Lexical analysis/Integer literals section
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- assignee: docs@python - rhettinger nosy: +rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24219 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24195] Add `Executor.filter` to concurrent.futures
Brian Quinlan added the comment: Ethan: I'm -0 so I'd happily go with the consensus. Does anyone have a strong opinion? Ram: What did you mean by Possible issues? Did you mean that to be an example using the executor.map() technique? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24195 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21448] Email Parser use 100% CPU
Roundup Robot added the comment: New changeset 830bcf4fb29b by Raymond Hettinger in branch 'default': Issue #21448: Improve performance of the email feedparser https://hg.python.org/cpython/rev/830bcf4fb29b -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21448 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23969] please set a SOABI for MacOSX
Matthias Klose added the comment: so what you could do is to define more than one SOABI. The code in Python/dynload_shlib.c reads: . SOABI .so, .abi PYTHON_ABI_STRING .so, .so, so it still recognizes .so names. If you want to recognize architecture specific sonames, then you would need something like . cpython-35m-cpu-darwin .so, . cpython-35m-darwin .so, .abi PYTHON_ABI_STRING .so, .so, that would prefer to load the most specific so. Unfortunately that would be also seen as the visible soname to build extensions, which is probably not something like you want. I still would prefer to use darwin instead of macosx, because that's the way config.sub/config.guess recognizes this platform. -- status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23969 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24056] Expose closure generator status in function repr()
Nick Coghlan added the comment: I don't think we should rush this one, especially as PEP 484 provides the possibility for tools (including educational tools) to infer the appropriate return types for generator and coroutine functions. Bumping the target version to 3.6 accordingly. -- versions: +Python 3.6 -Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24056 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12849] Cannot override 'connection: close' in urllib2 headers
Martin Panter added the comment: So far the only reasons that have been given to override this header (mine and the one in Issue 15943) seem to be to work around buggy servers. It is already documented that HTTP 1.1 and “Connection: close” are used, so if this issue is only about working around buggy servers, the best thing might be to close this as being “not a Python bug”. The user can always still use the low-level HTTP client, or make a custom urllib.request handler class (which is what I did). Shubhojeet: What was the reason you wanted to set a keep-alive header? If this is about proper keep-alive (a.k.a persistent) connection support in urllib.request, perhaps have a look at Issue 9740. -- resolution: - not a bug status: open - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12849 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12319] [http.client] HTTPConnection.request not support chunked Transfer-Encoding to send data
Martin Panter added the comment: Okay perhaps a new issue at this stage isn’t the best idea, especially if you want both modules updated at the same time. With the urlopen() API, it currently has no explicit support for file objects. So you either have to make sure they get treated like any other iterable, or add in explicit support. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12319 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23086] Add start and stop parameters to the Sequence.index() ABC mixin method
Roundup Robot added the comment: New changeset cabd7261ae80 by Raymond Hettinger in branch 'default': Issue #23086: Add start and stop arguments to the Sequence.index() mixin method. https://hg.python.org/cpython/rev/cabd7261ae80 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23086 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23086] Add start and stop parameters to the Sequence.index() ABC mixin method
Raymond Hettinger added the comment: Devin, thanks for the patch. Serhiy, I added a performance note discussing the computational complexity. -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23086 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15535] Fix pickling efficiency of named tuples in 2.7.3
Raymond Hettinger added the comment: What is left to do with this issue? Nothing that I can see. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15535 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24230] tempfile.mkdtemp() doesn't work with bytes paths
Roundup Robot added the comment: New changeset 870899ce71f4 by Gregory P. Smith in branch 'default': Issue 24230: The tempfile module now accepts bytes for prefix, suffix and dir https://hg.python.org/cpython/rev/870899ce71f4 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24230 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22189] collections.UserString missing some str methods
Roundup Robot added the comment: New changeset c06b2480766d by Raymond Hettinger in branch 'default': Issue 22189: Add missing methods to UserString https://hg.python.org/cpython/rev/c06b2480766d -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22189 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22189] collections.UserString missing some str methods
Raymond Hettinger added the comment: Thanks Joe. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22189 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21448] Email Parser use 100% CPU
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- assignee: rhettinger - resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21448 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23968] rename the platform directory from plat-$(MACHDEP) to plat-$(PLATFORM_TRIPLET)
Matthias Klose added the comment: ping? I would like to get this into 3.5. -- keywords: +needs review -patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23968 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue14132] Redirect is not working correctly in urllib2
Martin Panter added the comment: The proposed patch looks good to me. A test case would be nice though. Also I wonder why the “malformed URL” logic needs to be in urllib.request. Surely it either belongs in urljoin(), or in the underlying http.client. That needs more thought, but either way the current patch is a definite improvement. -- nosy: +vadmium stage: - test needed versions: +Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14132 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24195] Add `Executor.filter` to concurrent.futures
Nick Coghlan added the comment: I vary between +0 and -0 for the addition of the concrete method. When I'm at +0, the main rationale is that we *don't* have the Where do we stop? risk here that itertools faces, as we're just replicating the synchronous builtins. When I'm at -0, the main rationale is that a recipe works with *any* version of Python that provides concurrent.futures (including any version of the PyPI backport), and is hence useful immediately, while a method would only work the version where we added it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24195 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24230] tempfile.mkdtemp() doesn't work with bytes paths
Gregory P. Smith added the comment: that should take care of it. if you see any other issues with this post commit, either raise them here or fix them directly. the reviews were helpful. -- resolution: - fixed stage: patch review - commit review status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24230 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16991] Add OrderedDict written in C
Eric Snow added the comment:
If I still the following at Lib/test/test_configparser.py:328:
print(len(cf._proxies), len(list(cf._proxies)), list(cf._proxies))
print(len(cf._sections), len(list(cf._sections)), list(cf._sections))
I get unexpected results that are a clear indication of a problem:
9 8 ['DEFAULT', 'Foo Bar', 'Spacey Bar', 'Spacey Bar From The Beginning',
'Commented Bar', 'Long Line', 'Section\\with$weird%characters[\t',
'Internationalized Stuff']
8 7 ['Foo Bar', 'Spacey Bar', 'Spacey Bar From The Beginning', 'Commented
Bar', 'Long Line', 'Section\\with$weird%characters[\t', 'Internationalized
Stuff']
Note that OrderedDict.__len__ is just dict.__len__, so the first number (the
actual length) should be the same as the second number (the number of keys).
Also note that OrderedDict.keys() is working (even if not exactly correct).
Between the two observations, this implies that for this one test the keys are
not only off, but at least one of the keys in the linked list is not in the
underlying dict.
I'm sure this is consequence of resizing. At the last point that we resize
this is the state of the cf._proxies and cf._sections (ignore the trailing
NULL (?)):
OrderedDict([('DEFAULT', Section: DEFAULT), ('Foo Bar', Section: Foo
Bar), ('Spacey Bar', Section: Spacey Bar), ('Spacey Bar From The Beginning',
Section: Spacey Bar From The Beginning), ('Commented Bar', Section:
Commented Bar), NULL])
OrderedDict([('Foo Bar', OrderedDict([('foo', ['bar1'])])), ('Spacey Bar',
OrderedDict([('foo', ['bar2'])])), ('Spacey Bar From The Beginning',
OrderedDict([('foo', ['bar3']), ('baz', ['qwe'])])), ('Commented Bar',
OrderedDict([('foo', ['bar4']), ('baz', ['qwe'])])), ('Long Line',
OrderedDict([('foo', ['this line is much, much longer than my editor', 'likes
it.'])])), NULL])
I haven't had time to analyze this but I'll be taking a closer look in later
tonight. I'm not giving up on 3.5. :)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue16991
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24219] Repeated integer in Lexical analysis/Integer literals section
Roundup Robot added the comment: New changeset 645a03e93008 by Raymond Hettinger in branch '3.4': Issue #24219: Remove duplicate literal in docs. https://hg.python.org/cpython/rev/645a03e93008 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24219 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16991] Add OrderedDict written in C
Eric Snow added the comment: Just to narrow things down a bit further, the failure happens specifically under ConfigParserTestCaseNoValue: PYTHONHASHSEED=7 ./python -m unittest test.test_configparser.ConfigParserTestCaseNoValue.test_basic -v -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16991 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24266] raw_input + readline: Ctrl+C during search breaks readline
Martin Panter added the comment: Also applies to the interactive interpreter mode. -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24266 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24230] tempfile.mkdtemp() doesn't work with bytes paths
Augie Fackler added the comment: I just removed my hack that gave us unicode to hand to mkdtemp() and everything still passes with your new commit. Thanks much for the quick response! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24230 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23712] Experiment: Assume that exact unicode hashes are perfect discriminators
Raymond Hettinger added the comment: Closing this because it was never an active proposal, just more of a thought experiment that I didn't want to lose track of. -- resolution: - not a bug status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23712 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24209] Allow IPv6 bind in http.server
Martin Panter added the comment: I am no IPv6 expert, but this looks like a reasonable first approximation. The “http.server” module documentation should also be updated to say IPv6 addresses are supported on the command line, and I guess there should be a test case added. But maybe see Lib/smtpd.py line 657 for how this is done in a more general way for the SMTP server module (Issue 14758), using getaddrinfo(). There is also Issue 20215 proposing to do something equivalent in the lower level “socketserver” module, which would probably make this change redundant. It would also be nice for it to bind to both IPv4 and IPv6 if possible, but that is apparently not easy to do cross platform; see Issue 3213. -- stage: - test needed versions: -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24209 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24219] Repeated integer in Lexical analysis/Integer literals section
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24219 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20215] socketserver can not listen IPv6 address
Martin Panter added the comment: I’m no IPv6 expert, but see Lib/smtpd.py:657 and Issue 14758 for how this sort of thing was done for the SMTP server using getaddrinfo(). I think it is similar to David’s suggestion. I also left a comment about the documentation. And it probably needs a test case as well. -- nosy: +vadmium title: Python2.7 socketserver can not listen IPv6 address - socketserver can not listen IPv6 address ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20215 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20438] inspect: Deprecate getfullargspec?
Yury Selivanov added the comment: Thanks Berker! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20438] inspect: Deprecate getfullargspec?
Roundup Robot added the comment: New changeset 621e98bfc74b by Yury Selivanov in branch 'default': Issue 20438: Add a note about deprecating old inspect APIs to whatsnew. https://hg.python.org/cpython/rev/621e98bfc74b -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23970] Update distutils.msvccompiler for VC14
Steve Dower added the comment: We don't strictly need this for beta 1, but I'd like to get it in. Final call for feedback (I'll probably hold off checking in until tomorrow morning, ~18 hours from now) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23970 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24265] IDLE produces error message when run with both -s and -c.
New submission from ppperry: When I run python -m idlelib.idle -sc [command] from the command line, IDLE runs the startup file, but then pops up an error message saying the Python Shell window is already executing a command;please wait until it is finished. When the error window is closed, the command executes, unless the main Python Shell has already been closed, in which case a traceback occurs: Traceback (most recent call last): File C:\Python27\lib\runpy.py, line 162, in _run_module_as_main __main__, fname, loader, pkg_name) File C:\Python27\lib\runpy.py, line 72, in _run_code exec code in run_globals File C:\Python27\lib\idlelib\idle.py, line 11, in module idlelib.PyShell.main() File C:\Python27\lib\idlelib\PyShell.py, line 1602, in main shell.interp.execsource(cmd) AttributeError: 'NoneType' object has no attribute 'execsource' -- components: IDLE messages: 243824 nosy: kbk, ppperry, roger.serwy, terry.reedy priority: normal severity: normal status: open title: IDLE produces error message when run with both -s and -c. versions: Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24265 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24265] IDLE produces error message when run with both -s and -c.
Changes by ppperry maprea...@olum.org: -- type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24265 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24262] logging.FileHandler.close() is not thread-safe
Changes by R. David Murray rdmur...@bitdance.com: -- resolution: fixed - out of date stage: - resolved ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24262 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24219] Repeated integer in Lexical analysis/Integer literals section
R. David Murray added the comment: I believe you are correct. -- nosy: +r.david.murray ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24219 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24221] Clean-up and optimization for heapq siftup() and siftdown()
Stefan Behnel added the comment: Ah, sorry, yes. I somehow misread the arguments being passed *into* richcompare as subsequent array access. LGTM too. Sorry for the noise. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24221 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used
Yury Selivanov added the comment: Nick, I updated the code to use assertWarnsRegex (thanks for suggestion, Berker!) Closing the issue. -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24237 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20438] inspect: Deprecate getfullargspec?
Changes by Yury Selivanov yseliva...@gmail.com: -- resolution: - fixed stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22906] PEP 479: Change StopIteration handling inside generators
Roundup Robot added the comment: New changeset 2771a0ac806b by Yury Selivanov in branch 'default': Issue 24237: Raise PendingDeprecationWarning per PEP 479 https://hg.python.org/cpython/rev/2771a0ac806b -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22906 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used
Berker Peksag added the comment: Another alternative is using assertWarnsRegex. -- nosy: +berker.peksag ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24237 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24237] PEP 479: missing DeprecationWarning when generator_stop is not used
Roundup Robot added the comment: New changeset 2771a0ac806b by Yury Selivanov in branch 'default': Issue 24237: Raise PendingDeprecationWarning per PEP 479 https://hg.python.org/cpython/rev/2771a0ac806b -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24237 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22906] PEP 479: Change StopIteration handling inside generators
Roundup Robot added the comment: New changeset c8a3e49f35e7 by Yury Selivanov in branch 'default': docs: Mention PEP 479 in whatsnew. https://hg.python.org/cpython/rev/c8a3e49f35e7 -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22906 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24266] raw_input function (with readline): Ctrl+C (during search mode but not only) leaves readline in broken state
Changes by sping sebast...@pipping.org: Added file: http://bugs.python.org/file39468/raw_input__minimal.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24266 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24266] raw_input function (with readline): Ctrl+C (during search mode but not only) leaves readline in broken state
New submission from sping: Hi! A college of mine ran into a bug with raw_input. We have a shell derived from stdlib module cmd here but the bug shows with plain raw_input, as well (see demo code). For the symptoms: the shell is executing commands from history that the user explicitly chose not to run. Since our shell does things like deallocation of LVM volumes, that behavior is rather troublesome :) How does it happen? * When pressing Ctrl+R, an incremental reverse history search is started. During that search, you normalled press Escape/Ctrl+J/Ctrl+G to end search or Return to pick a result. * When you press Ctrl+C though, the next call to the raw_input function believes to be in search mode still (while not showing (reverse-i-search) or indicating search some way). * Now when (entering some text and) pressing return now, the string last shown during incremental search is being return from raw_input (and executed in context of the cmd module). I have re-produced the issue with Python 2.7.3, 2.7.9, 3.2.3, 3.4.2. For a workaround, one can handle KeyboardInterrupt and internal adjust variable rl_readline_state of the C readline library. I'm attaching (a minimal bug demo and) the ctypes based workaround that works well over here. (The workaround demo also shows that readline state is not fully reset when Ctrl+C was pressed outside of search mode, since flag RL_STATE_DONE is not set after.) It would rock the house if this could be fixed in Python. I'm looking forward to your reply. Best, Sebastian -- components: Interpreter Core files: raw_input__workaround_demo.py messages: 243828 nosy: sping priority: normal severity: normal status: open title: raw_input function (with readline): Ctrl+C (during search mode but not only) leaves readline in broken state type: behavior versions: Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5, Python 3.6 Added file: http://bugs.python.org/file39467/raw_input__workaround_demo.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24266 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24180] PEP 492: Documentation
Yury Selivanov added the comment: Closing this issue. -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24180 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24056] Expose closure generator status in function repr()
Yury Selivanov added the comment: Nick, Berker, a kind reminder -- please review the patch if we want to have it in 3.5. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24056 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20438] inspect: Deprecate getfullargspec?
Roundup Robot added the comment: New changeset 3a5fec5e025d by Yury Selivanov in branch 'default': Issue 20438: Deprecate inspect.getargspec() and friends. https://hg.python.org/cpython/rev/3a5fec5e025d -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20438 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24056] Expose closure generator status in function repr()
Berker Peksag added the comment: I'm not the ideal candidate to review the second patch since I'm not familiar with the best practices of C :) -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24056 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue23699] Add a macro to ease writing rich comparisons
Petr Viktorin added the comment: Just a reminder: if you want this to be in Python 3.5, please review the patch -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23699 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue12319] [http.client] HTTPConnection.request not support chunked Transfer-Encoding to send data
Demian Brecht added the comment: FWIW, I was intending to address the issues Rolf raised. Also, I agree that a patch shouldn't knowingly have negative knock-on effects to dependents. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue12319 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24204] string.strip() documentation is misleading
Terry J. Reedy added the comment: With 'leading end' and 'trailing end' replaced by 'left and 'right', the addition looks good to me. -- nosy: +terry.reedy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24204 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20035] Clean up Tcl library discovery in Tkinter on Windows
Roundup Robot added the comment: New changeset 951318b651be by Zachary Ware in branch 'default': Issue #20035: Reimplement tkinter._fix module as a C function. https://hg.python.org/cpython/rev/951318b651be -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20035 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20035] Clean up Tcl library discovery in Tkinter on Windows
Zachary Ware added the comment: Committed, thanks for the reviews, Serhiy and Steve! -- assignee: - zach.ware resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20035 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24209] Allow IPv6 bind in http.server
Changes by Demian Brecht demianbre...@gmail.com: -- nosy: +demian.brecht ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24209 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24266] raw_input + readline: Ctrl+C during search breaks readline
Terry J. Reedy added the comment: 3.2 and 3.3 only get security fixes. I condensed the title to be visible in display boxes. It would help if you signed the PSF Contributor Agreement https://www.python.org/psf/contrib/ https://www.python.org/psf/contrib/contrib-form/ and contributed a usable patch for test_readline under that agreement. -- nosy: +terry.reedy, twouters stage: - test needed title: raw_input function (with readline): Ctrl+C (during search mode but not only) leaves readline in broken state - raw_input + readline: Ctrl+C during search breaks readline versions: -Python 3.2, Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24266 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24056] Expose closure generator status in function repr()
Serhiy Storchaka added the comment: I like the look of the repr Terry proposes better. For generator objects the repr is either coroutine object %S at %p or generator object %S at %p. coroutine function %S at %p and generator function %S at %p would be consistent with this. It also shows the relation and the difference between the generator function and the generator object. Yet one argument is that both terms generator object and generator function are searchable in the documentation. There are other precedences with exposing flags at the start of the repr. built-in function %s and built-in method %s of %s object at %p, unlocked %s object at %p and locked %s object at %p. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24056 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24266] raw_input + readline: Ctrl+C during search breaks readline
Serhiy Storchaka added the comment: This behavior annoyed me long time, but I had no idea how to fix this. -- nosy: +pitrou, serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24266 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24230] tempfile.mkdtemp() doesn't work with bytes paths
Gregory P. Smith added the comment: updated, thanks for the great reviews. -- Added file: http://bugs.python.org/file39469/issue24230-gps03.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24230 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24234] Should we define complex.__complex__ and bytes.__bytes__?
Terry J. Reedy added the comment: To my understanding, the presence of int.__int__ and float.__float__ are implementation issues. I presume that float(ob) just calls ob.__float__ without slowing down for an isinstance(ob, float) check. Ditto for int(ob). The processing for complex(args) and bytes(args) are more complex and currently neither call an eponyous method. Would either be improved if it did? One difference between int and complex, for instance, that might account for the internal implementation difference is that the second argument of int can only be used with a string first argument, while the second argument of complex cannot be used with a string first argument, and must support multiplication by 1j. So int.__int__(self) does not allow a second parameter and can (and does) just return self. -- nosy: +terry.reedy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24234 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16991] Add OrderedDict written in C
Jim Jewett added the comment: Why does generated file Include/opcode.h show up as changed? It looks like pure whitespace, but I wonder if a similar whitespace change might be making something a space too long somewhere. -- nosy: +Jim.Jewett ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16991 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
