[issue28409] test.regrtest does not support multiple -x flags

[Xiang Zhang]

Xiang Zhang added the comment:

>   ./python -m test.regrtest test_unary -v test_binop
>   ./python -m test.regrtest test_unary -u all test_binop

These also fail in 3.6.0a4. You can only specify options after args now. 
test_binop is not valid option. Isn't this the expected behaviour?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28409] test.regrtest does not support multiple -x flags

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

This issue is not specific to -x, but affects all options. Following lines work:

./python -m test.regrtest -v test_unary test_binop
./python -m test.regrtest -u all test_unary test_binop
./python -m test.regrtest test_unary test_binop -v
./python -m test.regrtest test_unary test_binop -u all

But following lines don't work:

./python -m test.regrtest test_unary -v test_binop
./python -m test.regrtest test_unary -u all test_binop

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28409] test.regrtest does not support multiple -x flags

[Xiang Zhang]

Xiang Zhang added the comment:

So should we still consider this a regression? Actually -x is used as a hint 
flag and should not be used as -x arg pair. The right usage could still work 
now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28409] test.regrtest does not support multiple -x flags

[Xiang Zhang]

Xiang Zhang added the comment:

This regression is introduced in 4df2d43e995d. 

And actually to skip multiple tests, you should use python3 -m test.regrtest -x 
test_venv test_gdb. Although Charalampos's example could work, it actually 
treats -x as a test.

--
nosy: +xiang.zhang

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28411] Eliminate PyInterpreterState.modules.

[Graham Dumpleton]

Graham Dumpleton added the comment:

I always use PyImport_GetModuleDict(). So long as that isn't going away I 
should be good.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28411] Eliminate PyInterpreterState.modules.

[Nick Coghlan]

Nick Coghlan added the comment:

(added Graham Dumpleton to the nosy list to ask if this change may impact 
mod_wsgi for 3.7)

+1 on the general idea, but given that the current field is a public part of 
the interpreter state, the replacement access API should really be public as 
well - we can't be sure folks will always be going through the 
"PyImport_GetModuleDict()" API.

If you replace the addition of the `_PyImport_GetModuleDict` API with a public 
`PyInterpreterState_GetModuleDict` API, I think that will cover it - the new 
calls would just be "PyInterpreterState_GetModuleCache(tstate->interp)" rather 
than `_PyImport_GetModuleDict(tstate)`

Folks accessing this field directly can then define their own shim function if 
PyInterpreterState_GetModuleCache isn't defined.

(The rationale for the GetModuleDict -> GetModuleCache change is that 
"ModuleDict" is ambiguous - every module has a dict. For PyImport_* we're stuck 
with it, but the "PyImport" prefix at least gives a hint that the reference 
might be to the sys.modules cache. That affordance doesn't exist for the 
"PyInterpeterState" prefix.

--
nosy: +grahamd

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28208] update sqlite to 3.14.2

[Roundup Robot]

Roundup Robot added the comment:

New changeset b7e068d6c53f by Zachary Ware in branch '3.6':
Issue #28208: Update Windows build to use SQLite 3.14.2.0
https://hg.python.org/cpython/rev/b7e068d6c53f

New changeset 3e329b553567 by Zachary Ware in branch 'default':
Issue #28208: Merge with 3.6
https://hg.python.org/cpython/rev/3e329b553567

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28248] Upgrade installers to OpenSSL 1.0.2j

[Roundup Robot]

Roundup Robot added the comment:

New changeset c29045efd25e by Zachary Ware in branch '2.7':
Issue #28248: Update Windows build to use OpenSSL 1.0.2j
https://hg.python.org/cpython/rev/c29045efd25e

New changeset d7b9ce8ae79b by Zachary Ware in branch '3.4':
Issue #28248: Update Windows build to use OpenSSL 1.0.2j
https://hg.python.org/cpython/rev/d7b9ce8ae79b

New changeset 5fa74d8c987b by Zachary Ware in branch '3.5':
Issue #28248: Merge with 3.4
https://hg.python.org/cpython/rev/5fa74d8c987b

New changeset cc5006dab787 by Zachary Ware in branch '3.6':
Issue #28248: Merge with 3.5
https://hg.python.org/cpython/rev/cc5006dab787

New changeset fea9ff9e745d by Zachary Ware in branch 'default':
Issue #28248: Merge with 3.6
https://hg.python.org/cpython/rev/fea9ff9e745d

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28248] Upgrade installers to OpenSSL 1.0.2j

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Hi, I updated the openssl version from 1.0.2h to 1.0.2j in build-installer.py

Please let me know if this works.

Thanks :)

--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45054/issue28248.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28208] update sqlite to 3.14.2

[Mariatta Wijaya]

Mariatta Wijaya added the comment:

Hello,

Attached is the patch for updating sqlite version to 3.14.2.

Please review, and let me know if this works.

Thanks :)

--
keywords: +patch
nosy: +Mariatta
Added file: http://bugs.python.org/file45053/issue28208.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28410] Add convenient C API for "raise ... from ..."

[Nick Coghlan]

Nick Coghlan added the comment:

Serhiy, how does this version compare/relate to the previous discussion in 
http://bugs.python.org/issue23188 ?

--
nosy: +ncoghlan

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue13646] Document poor interaction between multiprocessing and -m on Windows

[Nick Coghlan]

Nick Coghlan added the comment:

These interactions were fixed in the release where *nix multiprocessing gained 
the ability to mimic the Windows behaviour.

--
resolution:  -> out of date
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28208] update sqlite to 3.14.2

[Ned Deily]

Ned Deily added the comment:

I'd like to see this in 3.6.0b3.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28248] Upgrade installers to OpenSSL 1.0.2j

[Ned Deily]

Ned Deily added the comment:

We didn't get this into 3.6.0b2; needs to be in 3.6.0b3.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28410] Add convenient C API for "raise ... from ..."

[Emanuel Barry]

Changes by Emanuel Barry :


--
nosy: +ebarry

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28334] netrc does not work if $HOME is not set

[Terry J. Reedy]

Terry J. Reedy added the comment:

FWIW, some history: The $HOME lookup was in Guido's original 1998-12-22 patch:
if not file:
file = os.path.join(os.environ['HOME'], ".netrc")
The lookup was wrapped in try-except 4 years later to give a 'consistent error 
message'.

Module ntpath dates back to 1994.  Expanduser only used HOMEDRIVE and HOMEPATH. 
 Guido added support for HOME in 1997.  Support for USERPROFILE was added a 
decade later.

Since the module is NOT marked 'Unix-only', I think it a bug to not use 
os.path.expanduser.  Larry, Ned, do either of you have an opinion on whether 
the change should be made in current versions or only 3.7?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28412] os.path.splitdrive documentation out of date

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +benjamin.peterson

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28412] os.path.splitdrive documentation out of date

[Michael Partridge]

New submission from Michael Partridge:

ntpath.splitdrive was updated in patch 26ec6248ee8b. (I think this was released 
in 2.7.8.)

This changes the behaviour of splitdrive for UNC style paths. Previously:

>>> ntpath.splitdrive(r'\\nancy\foo\bar')
('', 'nancy\\foo\\bar') 
 
>>> 

Now:
>>> ntpath.splitdrive(r'\\nancy\foo\bar')
('nancy\\foo', '\\bar')
>>> 

The documentation should be updated to say the same.

--
assignee: docs@python
components: Documentation
messages: 278446
nosy: docs@python, snooter
priority: normal
severity: normal
status: open
title: os.path.splitdrive documentation out of date
type: behavior
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28411] Eliminate PyInterpreterState.modules.

[Eric Snow]

New submission from Eric Snow:

tl;dr PyInterpreterState does not need a "modules" field.  Attached is a patch 
that removes it.

During interpreter startup [1] the sys module is imported using the same C API 
[2] as any other builtin module.  That API only requires one bit of import 
state, sys.modules.  Obviously, while the sys module is being imported, 
sys.modules does not exist yet.  To accommodate this situation, 
PyInterpreterState has a "modules" field.  The problem is that 
PyInterpreterState.modules remains significant in the C-API long after it is 
actually needed during startup.  This creates the potential for sys.modules and 
PyInterpreterState.modules to be out of sync.

Currently I'm working on an encapsulation of the import state.  
PyInterpreterState.modules complicates the scene enough that I'd like to see it 
go away.  The attached patch does so by adding private C-API functions that 
take a modules arg, rather than getting it from the interpreter state.  These 
are used during interpreter startup, rendering PyInterpreterState.modules 
unnecessary and allowing sys.modules to become the single source of truth.

If this patch lands, we can close issue12633.


[1] see _Py_InitializeEx_Private() and Py_NewInterpreter() in 
Python/pylifecycle.c
[2] see PyModule_Create2() and _PyImport_FindBuiltin() in Python/import.c

--
components: Interpreter Core
files: drop-interp-modules.diff
keywords: patch
messages: 278445
nosy: brett.cannon, eric.snow, ncoghlan
priority: normal
severity: normal
stage: patch review
status: open
title: Eliminate PyInterpreterState.modules.
versions: Python 3.7
Added file: http://bugs.python.org/file45052/drop-interp-modules.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28405] Compile error on Modules/_futuresmodule.c

[Berker Peksag]

Changes by Berker Peksag :


--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28230] tarfile does not support pathlib

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

It seems to me that tarfile already supports path protocol for all external 
patches and no changes for tarfile are needed.

Proposed patch adds tests for (already implemented) support of pathlike 
protocol in tarfile.

--
Added file: http://bugs.python.org/file45051/test_tarfile_pathlike.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28404] Logging SyslogHandler not appending '\n' to the end

[Vinay Sajip]

Vinay Sajip added the comment:

> So I think it must be a Fluentd error.

So I'll close this.

--
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26869] unittest longMessage docs

[Thomas Guettler]

Thomas Guettler added the comment:

@Mariatta thank you very much. This update makes the docs easy to read and 
understand. Thank you :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28214] Improve exception reporting for problematic __set_name__ attributes

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
dependencies: +Add convenient C API for "raise ... from ..."

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28410] Add convenient C API for "raise ... from ..."

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

Sometimes after catching an exception we need to raise new exception of 
specific type, but save the information about current exception. In Python the 
syntax "raise ... from ..." serves this purpose (PEP 3134). But in C the code 
that implements this is too cumbersome. Proposed patch adds private convenient 
function that raises an exception and sets previously raised exception as its 
__context__ and __cause__ attributes. This is a generalized version of 
gen_chain_runtime_error() from Objects/genobject.c. It could be reused in three 
other places: Objects/abstract.c, Objects/unicodeobject.c, and 
Modules/zipimport.c (currently only __context__ is set, but setting __cause__ 
looks preferable), and in new code for issue28214. Maybe there are other 
opportunities.

--
components: Interpreter Core
files: _PyErr_FormatFromCause.patch
keywords: patch
messages: 278441
nosy: haypo, serhiy.storchaka, yselivanov
priority: normal
severity: normal
stage: patch review
status: open
title: Add convenient C API for "raise ... from ..."
type: enhancement
versions: Python 3.5, Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45050/_PyErr_FormatFromCause.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28404] Logging SyslogHandler not appending '\n' to the end

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue2897] Deprecate structmember.h

[Alexander Belopolsky]

Changes by Alexander Belopolsky :


--
assignee: docs@python -> belopolsky
stage: patch review -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28314] ElementTree: Element.getiterator(tag) broken in 3.6

[Ned Deily]

Changes by Ned Deily :


--
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28230] tarfile does not support pathlib

[Ned Deily]

Changes by Ned Deily :


--
nosy: +lars.gustaebel

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28409] test.regrtest does not support multiple -x flags

[R. David Murray]

R. David Murray added the comment:

That sounds like a regression in argparse that we'd better track down.

--
nosy: +larry, ned.deily, r.david.murray
priority: normal -> release blocker

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20215] socketserver.TCPServer can not listen IPv6 address

[Jason R. Coombs]

Changes by Jason R. Coombs :


--
nosy: +jason.coombs

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28409] test.regrtest does not support multiple -x flags

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Seems this is related to some changes in argparse.

--
nosy: +bethard, serhiy.storchaka
versions: +Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28334] netrc does not work if $HOME is not set

[Dimitri Merejkowsky]

Dimitri Merejkowsky added the comment:

> if it make sense to run this on Windows

I found this issue while running cross-platform code. I needed to store some 
credentials, did not mind having them in plain-text and I thought .netrc was a 
good place for this. (did not need to re-invent the wheel ...)

>  don't know what unix users might reasonbly expect.

Well, I guess as a bonus of this patch we could add a link to the 
`os.path.expanduser` section[1] in `netrc` documentation.

The behavior when $HOME is not set is properly documented there.

[1] https://docs.python.org/3/library/os.path.html#os.path.expanduser

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28409] test.regrtest does not support multiple -x flags

[Serhiy Storchaka]

Changes by Serhiy Storchaka :


--
nosy: +haypo
stage:  -> needs patch
type:  -> behavior
versions: +Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue20463] sqlite dumpiter dumps invalid script when virtual tables are used

[Aviv Palivoda]

Aviv Palivoda added the comment:

Attached is patch with a fix for this issue. This is not as comprehensive as 
the solution in apsw but I think this should cover most of the cases. The 
result for Ronny dump after this fix is:

BEGIN TRANSACTION;
PRAGMA writable_schema=ON;
INSERT INTO 
sqlite_master(type,name,tbl_name,rootpage,sql)VALUES('table','test','test',0,'CREATE
 VIRTUAL TABLE test using fts4(example)');
CREATE TABLE 'test_content'(docid INTEGER PRIMARY KEY, 'c0example');
CREATE TABLE 'test_docsize'(docid INTEGER PRIMARY KEY, size BLOB);
CREATE TABLE 'test_segdir'(level INTEGER,idx INTEGER,start_block 
INTEGER,leaves_end_block INTEGER,end_block INTEGER,root BLOB,PRIMARY KEY(level, 
idx));
CREATE TABLE 'test_segments'(blockid INTEGER PRIMARY KEY, block BLOB);
CREATE TABLE 'test_stat'(id INTEGER PRIMARY KEY, value BLOB);
PRAGMA writable_schema=OFF;
COMMIT;

--
keywords: +patch
nosy: +palaviv
Added file: http://bugs.python.org/file45049/20463.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28179] Segfault in test_recursionlimit_fatalerror

[Ned Deily]

Ned Deily added the comment:

Since this is also reproducible on some 3.5.2 platforms, I don't think it 
qualifies as a release blocker for 3.6.0.  But it still should be addressed.

--
priority: release blocker -> high

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28409] test.regrtest does not support multiple -x flags

[Charalampos Stratakis]

New submission from Charalampos Stratakis:

Until python3.6.0a04 it was possible to pass multiple times the -x option at 
regrtest.

However since the 3.6.0b1 when trying the same thing I get an error. Test names 
are random.

python3 -m test.regrtest -x test_venv -x test_gdb
usage: python -m test [options] [test_name1 [test_name2 ...]]
python path/to/Lib/test/regrtest.py [options] [test_name1 [test_name2 ...]]
regrtest.py: error: unrecognized arguments: test_gdb

If however I omit the second -x, the tests run fine and correctly exclude the 
specific tests.

Was the change intentional or a side effect from something else?

--
components: Tests
messages: 278435
nosy: cstratak
priority: normal
severity: normal
status: open
title: test.regrtest does not support multiple -x flags
versions: Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28328] statistics.geometric_mean has no tests. Defer to 3.7?

[Ned Deily]

Changes by Ned Deily :


--
priority: release blocker -> normal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28408] Fix redundant code and memory leak in _PyUnicodeWriter_Finish

[Xiang Zhang]

New submission from Xiang Zhang:

_PyUnicodeWriter_Finish gets 2 problems now:

1. It has two same branches handling empty strings which is redundant.

2. It may leak the inner buffer object when resize_compact fails. When 
resize_compact fails, the buffer object is left untouched. Then the writer 
itself is freed and the buffer is leaked.

--
components: Interpreter Core
files: _PyUnicodeWriter_Finish.patch
keywords: patch
messages: 278434
nosy: haypo, serhiy.storchaka, xiang.zhang
priority: normal
severity: normal
stage: patch review
status: open
title: Fix redundant code and memory leak in _PyUnicodeWriter_Finish
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7
Added file: http://bugs.python.org/file45048/_PyUnicodeWriter_Finish.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28405] Compile error on Modules/_futuresmodule.c

[Roundup Robot]

Roundup Robot added the comment:

New changeset a8dd18e375c8 by INADA Naoki in branch '3.6':
Issue #28405: Fix compile error for _futuresmodule.c on Cygwin.
https://hg.python.org/cpython/rev/a8dd18e375c8

New changeset d2a313d13542 by INADA Naoki in branch 'default':
Issue #28405: Fix compile error for _futuresmodule.c on Cygwin.
https://hg.python.org/cpython/rev/d2a313d13542

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28405] Compile error on Modules/_futuresmodule.c

[Ned Deily]

Ned Deily added the comment:

revised patch LGTM

--
nosy: +ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28405] Compile error on Modules/_futuresmodule.c

[INADA Naoki]

INADA Naoki added the comment:

Oh! Thanks, While I ran make, I had missed error message somehow.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28407] Improve coverage of email.utils.make_msgid()

[Dillon Brock]

New submission from Dillon Brock:

There were 2 lines of email.utils.make_msgid() that were not covered (lines 202 
and 204 of Lib/email/utils.py), so I wrote a quick patch to cover them.

--
components: Tests, email
files: make_msgid_coverage.patch
keywords: patch
messages: 278430
nosy: barry, dillon.brock, r.david.murray
priority: normal
severity: normal
status: open
title: Improve coverage of email.utils.make_msgid()
type: enhancement
versions: Python 3.7
Added file: http://bugs.python.org/file45047/make_msgid_coverage.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28405] Compile error on Modules/_futuresmodule.c

[Masayuki Yamamoto]

Masayuki Yamamoto added the comment:

Thanks, INADA.
I confirmed your solution, and has succeeded to build _futures extension. Your 
patch has a little misspell. I fixed it.

--
Added file: http://bugs.python.org/file45046/gc_track-2.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28230] tarfile does not support pathlib

[Ethan Furman]

Ethan Furman added the comment:

As Serhiy was alluding to, if the incoming path is for the actual tar file and 
is only passed along to Python itself then we probably don't need to worry 
about os.fspath().  For names that will be interally stored, or are for 
accessing internal files, then the proper sequence is check for and call 
os.fspath if necessary, and then double-check that the name to be used is a 
str.  The double-check is needed because os.fspath may return a bytes object, 
which tar does not allow.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28406] Possible PyUnicode_InternInPlace() edge-case bug

[INADA Naoki]

INADA Naoki added the comment:

I think the comment described "Why Py_ALLOW_RECURSION is required", not "t may 
be NULL even if s is in the intern dict".

> If PyDict_GetItem fails due to stack overflow, perhaps the Python process is 
> doomed to fail soon anyway.

When I changed the code to use PyDict_SetDefault(), I found "USE_STACKCHECK" 
macro.
See https://docs.python.org/3/c-api/sys.html#c.PyOS_CheckStack

But I don't know this can be really happend. Interned dict only contains exact 
unicode objects. There is no chance for
calling user defined __hash__() or __eq__().

--
nosy: +inada.naoki

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28406] Possible PyUnicode_InternInPlace() edge-case bug

[Larry Hastings]

Larry Hastings added the comment:

Ah, indeed.  My mistake--I'm working in the Gilectomy branch, which is 
hilariously out of date.  (It's stuck in February 2016.)

The new version using PyDict_SetDefault() won't have *this* specific problem.  
Perhaps later I'll read the new code and see if I can spot a similar problem.  
But for now it only makes sense to close this issue.

--
resolution:  -> fixed
stage: test needed -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27761] Private _nth_root function loses accuracy

[Ned Deily]

Changes by Ned Deily :


--
priority: release blocker -> normal

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28406] Possible PyUnicode_InternInPlace() edge-case bug

[Xiang Zhang]

Xiang Zhang added the comment:

The code has already been changed in #27454.

--
nosy: +xiang.zhang

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24459] Mention PYTHONFAULTHANDLER in the man page

[Joshua Jay Herman]

Joshua Jay Herman added the comment:

Thanks for reviewing Mariatta I have made a new patch that has those typos 
corrected.

--
Added file: 
http://bugs.python.org/file45045/correctedRebasedAddMissingEnvironmentalVariables.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28405] Compile error on Modules/_futuresmodule.c

[INADA Naoki]

INADA Naoki added the comment:

I need another LGTM from core developer before committing.
Yury, could you see it?  This is one line patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28405] Compile error on Modules/_futuresmodule.c

[INADA Naoki]

INADA Naoki added the comment:

Thank you for reporting.

C-API doc 
[https://docs.python.org/3.7/c-api/gcsupport.html#c._PyObject_GC_TRACK] says:

> A macro version of PyObject_GC_Track(). It should not be used for extension 
> modules.

So simply replacing it to PyObject_GC_Track() may solve the issue.

--
assignee:  -> inada.naoki
priority: normal -> high
stage:  -> commit review
Added file: http://bugs.python.org/file45044/28045-gc_track.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28406] Possible PyUnicode_InternInPlace() edge-case bug

[Larry Hastings]

New submission from Larry Hastings:

A visual inspection of PyUnicode_InternInPlace() suggests there might be a rare 
edge-case bug lurking there.

Specifically, the bug has to do with "interned mortal" strings.  Interned 
mortal strings are stored in the static "interned" dictionary, with their key 
and value set to the same string.  (If "x" is interned, then in the interned 
dictionary "x" is set to "x".)  Under normal circumstances, these two 
references would keep the string alive forever.  However, in order for the 
string to be *mortal*, the unicode object then DECREFs the string twice so the 
references in the "interned" dict no longer "count".  When the refcnt reaches 
0, and the string is being destroyed, unicode_dealloc() temporarily resurrects 
the object, bumping its reference count up to 3.  It then removes the string 
from the interned dict and destroys it as normal.

The actual intern substitution happens in a function called 
PyUnicode_InternInPlace().  This function looks the string up in the "interned" 
dictionary, and if the string is there it substitutes in the interned version 
from the dictionary.  There's a curious comment in that function:

/* It might be that the GetItem call fails even
   though the key is present in the dictionary,
   namely when this happens during a stack overflow. */
Py_ALLOW_RECURSION
t = PyDict_GetItem(interned, s);
Py_END_ALLOW_RECURSION

If t is NULL, then PyUnicode_InternInPlace() goes on to set t in the interned 
dictionary, reduces the refcnt by 2, etc etc.

The problem: if t is in the dictionary, but PyDict_GetItem() fails (during a 
stack overflow?), then the subsequent PyDict_SetItem() will *overwrite* the 
existing interned string.  Which means the "interned" dict will drop its two 
references, which means two REFCNTs.  If there were only 1 or 2 extant 
references to this string, it means the string will be immediately dealloc'd, 
*even though the string was still in use*.

I suppose this is already such a speculative condition that it's probably not 
worrying over.  If PyDict_GetItem fails due to stack overflow, perhaps the 
Python process is doomed to fail soon anyway.  Perhaps PyDict_SetItem has no 
chance of working.  But it *seems* like this code is intended to function 
correctly even when PyDict_GetItem fails due to stack overflow, and I suspect 
it won't.

--
components: Interpreter Core
messages: 278421
nosy: larry
priority: low
severity: normal
stage: test needed
status: open
title: Possible PyUnicode_InternInPlace() edge-case bug
type: behavior
versions: Python 3.5, Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28403] Porting guide: disabling & warning on implicit unicode conversions

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

On 10.10.2016 15:08, Petr Viktorin wrote:
> If sys.setdefaultencoding('undefined') breaks parts of the standard library, 
> it might be OK for smaller scripts but I fear it won't help big projects much.

That's true. It does break the stdlib (the codec was originally
added in order to test exactly this scenario).

A new codec "ascii-warn" could easily be added, based on the
code used for "undefined".

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28405] Compile error on Modules/_futuresmodule.c

[Xiang Zhang]

Changes by Xiang Zhang :


--
nosy: +inada.naoki, yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28405] Compile error on Modules/_futuresmodule.c

[Masayuki Yamamoto]

New submission from Masayuki Yamamoto:

I tried to build cpython on cygwin (vista x86).
Core interpretor has built to success, but '_futures' extension module has 
failed (compile error on Modules/_futuresmodule.c:946 ). It has occured since 
f8815001a390

part of build log:
$ uname -a
CYGWIN_NT-6.0 masayuki-PC 2.6.0(0.304/5/3) 2016-08-31 14:27 i686 Cygwin
$ ./configure --without-threads --prefix=/opt/py37
$ LANG=C make
(snip)
building '_futures' extension
gcc -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall 
-Wstrict-prototypes -std=c99 -Wextra -Wno-unused-result -Wno-unused-parameter 
-Wno-missing-field-initializers -I./Include -I/opt/py37/include -I. 
-I/usr/local/include -I/home/masayuki/var/repos/py37-work01/Include 
-I/home/masayuki/var/repos/py37-work01 -c 
/home/masayuki/var/repos/py37-work01/Modules/_futuresmodule.c -o 
build/temp.cygwin-2.6.0-i686-3.7/home/masayuki/var/repos/py37-work01/Modules/_futuresmodule.o
gcc -shared -Wl,--enable-auto-image-base 
build/temp.cygwin-2.6.0-i686-3.7/home/masayuki/var/repos/py37-work01/Modules/_futuresmodule.o
 -L. -L/opt/py37/lib -L/usr/local/lib -L. -lpython3.7m -o 
build/lib.cygwin-2.6.0-i686-3.7/_futures.dll
build/temp.cygwin-2.6.0-i686-3.7/home/masayuki/var/repos/py37-work01/Modules/_futuresmodule.o:
 In function `new_future_iter':
/home/masayuki/var/repos/py37-work01/Modules/_futuresmodule.c:946: undefined 
reference to `_PyGC_generation0'
/home/masayuki/var/repos/py37-work01/Modules/_futuresmodule.c:946: undefined 
reference to `_PyGC_generation0'
/home/masayuki/var/repos/py37-work01/Modules/_futuresmodule.c:946: undefined 
reference to `_PyGC_generation0'
collect2: error: ld returned 1 exit status
(snip)

--
components: Build, Extension Modules
messages: 278418
nosy: bquinlan, masamoto
priority: normal
severity: normal
status: open
title: Compile error on Modules/_futuresmodule.c
type: compile error
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28405] Compile error on Modules/_futuresmodule.c

[Masayuki Yamamoto]

Masayuki Yamamoto added the comment:

I searched declaration for _PyGC_generation0, And it has be found at 
Include/objimpl.h:259
The found declaration hasn't used PyAPI_DATA macro. Hence, I wrote a patch to 
wrap declaration by the macro. I has succeeded to build _futures module using 
the patch.

By the way, I has found similar declarations and defines. I'd like to report 
them, but Should I create each another issues by places?

--
keywords: +patch
Added file: http://bugs.python.org/file45043/_PyGC_generation0-declaration.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28404] Logging SyslogHandler not appending '\n' to the end

[José Manuel]

José Manuel added the comment:

After reading the RFC5424 it seems that there is no such "new line message 
delimiter":


4.3.1.  Message Length

   The message length is the octet count of the SYSLOG-MSG in the
   SYSLOG-FRAME.  A transport receiver MUST use the message length to delimit a 
syslog message


So I think it must be a Fluentd error. This is what caused my confusion:

>From in_syslog.rb 
>(https://github.com/athenahealth/fluent-plugin-newsyslog/blob/master/lib/fluent/plugin/in_newsyslog.rb):


# syslog family add "\n" to each message and this seems only way to split 
messages in tcp stream
Coolio::TCPServer.new(@bind, @port, SocketUtil::TcpHandler, log, "\n", callback)


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28230] tarfile does not support pathlib

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

There are two kinds of paths in tarinfo:

1) External paths that correspond to filesystem paths. The path of the tar file 
itself, patches of added files and target directory for extraction. Supporting 
path protocol looks reasonable for them.

1) Internal paths, they are just string keys inside an archive. They come from 
TarFile.getnames() and always are strings. I'm not sure that pathlib have 
relation to this. This issue needs more thoughts. I would not haste with this.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28403] Porting guide: disabling & warning on implicit unicode conversions

[Petr Viktorin]

Petr Viktorin added the comment:

In portingguide [0] I could only recommend sitecustomize with a (possibly 
third-party) codec that emits warnings; not 'undefined'.

The things that aren't ported yet are generally either Non-Python applications 
with Python bindings or plugins (Gimp, Samba, ...), projects that are very 
large relative to the count of available maintainers (VCSs, Sugar, wxPython, 
...), or code that depends on those.

If sys.setdefaultencoding('undefined') breaks parts of the standard library, it 
might be OK for smaller scripts but I fear it won't help big projects much.


[0] http://portingguide.readthedocs.io/en/latest/

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28230] tarfile does not support pathlib

[Berker Peksag]

New submission from Berker Peksag:

Here's an updated patch with different tests and documentation changes. I 
simplified Lib/tarfile.py a bit (see my review comments)

A slightly off-topic question: I had to update both docstrings and 
documentation. Should we use this as an opportunity to simplify the docstrings?

--
Added file: http://bugs.python.org/file45042/issue28230_v2.diff

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28403] Porting guide: disabling & warning on implicit unicode conversions

[Nick Coghlan]

Nick Coghlan added the comment:

Adding Petr to the nosy list, as I'd like to get his perspective on this once I 
have a draft docs patch to review.

I also realised it made more sense to just repurpose this issue to cover the 
proposed docs updates.

--
assignee:  -> docs@python
components: +Documentation
nosy: +docs@python, encukou
stage:  -> needs patch
title: Migration RFE: optional warning for implicit unicode conversions -> 
Porting guide: disabling & warning on implicit unicode conversions

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28404] Logging SyslogHandler not appending '\n' to the end

[José Manuel]

New submission from José Manuel:

I'm using SyslogHandler from logging.handlers to send syslog messages to a 
Fluentd input 
(https://github.com/fluent/fluentd/blob/master/lib/fluent/plugin/in_syslog.rb), 
both in TCP and UDP. UDP works fine, but TCP does not work. 

The "problem" is that the handler is not ending messages with a new line '\n' 
character (I realized that using tcpdump). I've temporarily added this to line 
855 of handlers.py: 
msg = prio + msg + '\n' 
And now is working. 

Now I'm confused because maybe this is not an issue but a problem of Fluentd. 
For the time, I will create a new class extending SyslogHandler and override 
the emit function.

Thank you for your time.

--
components: Library (Lib)
messages: 278412
nosy: elelement
priority: normal
severity: normal
status: open
title: Logging SyslogHandler not appending '\n' to the end
type: behavior
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28403] Migration RFE: optional warning for implicit unicode conversions

[Nick Coghlan]

Nick Coghlan added the comment:

The main problem with the "undefined" encoding is that it actually *fails* the 
application, rather than allowing it to continue, but providing a warning at 
each new point where it encounters implicit encoding or decoding. This means 
the parts of the standard library that actually rely on implicit coercion fail 
outright, rather than just generate warning noise that you can filter out as 
irrelevant to your particular application.

You raise a good point about `sitecustomize.py` though - I always forget about 
that feature myself, and it didn't come up in any of the Google results I 
looked at either.

The existing "undefined" option also at least allows you to categorically 
ensure you're not relying on implicit conversions at all, so the Python 3 
porting guide could be updated to explicitly cover:

1. Finding the site customization path for your active virtual environment:

python -c 'import os.path, sysconfig; 
print(os.path.join(sysconfig.get_path("purelib"), "sitecustomize.py"))'

2. What to write to that location to disable implicit Unicode conversions:

import sys
sys.setdefaultencoding('undefined')

Giving folks the following tiered path to Python 3 support:

- get "pylint --py3k" passing (e.g. via python-modernize)
- eliminate "python -3" warnings under Python 2
- (optional) support running with the above site customizations
- actually run under Python 3

Brett, does the above approach sound reasonable to you? If so, then I'll do 
that as a pure documentation change in the Py3k porting guide with a "See Also" 
to the above blog post, and then mark this as closed/postponed (given the 
`sitecustomize` approach to enable it, the 3rd party codec should be fine for 
folks that want the warning behaviour instead)

--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28397] Faster index range checks

[Stefan Krah]

Stefan Krah added the comment:

The same applies to memoryview.c and _testbuffer.c -- I doubt that there's any 
measurable speed benefit and the clarity is reduced (I also don't want macros 
there).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28214] Improve exception reporting for problematic __set_name__ attributes

[Nick Coghlan]

Nick Coghlan added the comment:

You're right, RuntimeError is a more suitable exception type.

So +1 for the second version of the patch that uses `__cause__` and the patch 
itself looks good to me.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28397] Faster index range checks

[Stefan Krah]

Stefan Krah added the comment:

Serhiy, could you please take out _decimal.c?

I thought we had been through that before. :) :) :)

--
nosy: +skrah

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue27972] Confusing error during cyclic yield

[Max von Tettenborn]

Max von Tettenborn added the comment:

You are very welcome, glad I could help.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28373] input() prints to original stdout even if sys.stdout is wrapped

[Adam Bartoš]

Adam Bartoš added the comment:

Does GNU readline do anything fancy about printing the prompt? Because you may 
want to use GNU readline for autocompletition while still enable colored output 
via wrapped stdout. Both at the same time with one call to input(). It seems 
that currently either you go interactive and ignore sys.std*, or you lose 
readline capabilities.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28403] Migration RFE: optional warning for implicit unicode conversions

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

Nick, I think you've missed the "undefined" encoding that we've had for this 
ever since Unicode was added to Python.

You put the needed code into your sitecustomize.py file and Python2 will then 
behave just like Python3, i.e. raise an exception instead of coercing to 
Unicode:

sitecustomize.py:
import sys
sys.setdefaultencoding('undefined')

There's no need to hack this into site.py or to make sys.setdefaultencoding() 
available outside sitecustomize.py.

If you want an OS environ switch, you can put the necessary logic into 
sitecustomize.py as well.

--
nosy: +lemburg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28395] Remove unnecessary semicolons

[Mariatta Wijaya]

New submission from Mariatta Wijaya:

Thanks scop. 

The patch looks good to me, and it can be applied cleanly to 3.5, 3.6, and 
default branches.

I did find more occurrences of unnecessary semicolons, for example (not a 
complete list)
https://github.com/python/cpython/blob/master/Lib/smtpd.py#L569
https://github.com/python/cpython/blob/master/Lib/smtpd.py#L611
https://github.com/python/cpython/blob/master/Lib/test/test_itertools.py#L120
https://github.com/python/cpython/blob/master/Lib/test/test_pyexpat.py#L572

Not sure if it's really worth trying to fix all of them?
Thanks :)

--
nosy: +Mariatta

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com