[issue35454] Fix miscellaneous issues in error handling

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 8855d9339858683c9b4fcd50b02a7bca526d4726 by Serhiy Storchaka in 
branch '3.6':
[3.6] bpo-35454: Fix miscellaneous minor issues in error handling. (GH-11077) 
(GH-11106)
https://github.com/python/cpython/commit/8855d9339858683c9b4fcd50b02a7bca526d4726


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35444] Unify and optimize the helper for getting a builtin object

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +10336

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

[Chris Withers]

Chris Withers  added the comment:

Ah, yeah, I can see the blanket patch and a more local patch in a monorepo 
being a thing, cool, let's have a look!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35454] Fix miscellaneous issues in error handling

[miss-islington]

miss-islington  added the comment:


New changeset 62674f3a36ec55f86a5f20ee028a37fbd549bd6c by Miss Islington (bot) 
in branch '3.7':
bpo-35454: Fix miscellaneous minor issues in error handling. (GH-11077)
https://github.com/python/cpython/commit/62674f3a36ec55f86a5f20ee028a37fbd549bd6c


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

[Anthony Sottile]

Anthony Sottile  added the comment:

to be honest, I don't recall exactly given it's been 2 and a half years since 
the original report with no activity.

if I recall correctly, this was encountered while upgrading the `mock` backport 
in yelp's monolithic repository.

I want to say the reason this was hard to "fix" properly was due to some 
blanket patches being applied in a base test case and then other test cases 
re-patching those methods to add more specific behaviour.  This worked fine in 
python2.7 and all the way until python3.3 but then was broken by changes in 
python3.4

Fortunately, they've been fixed in python3.7.  I guess I've been encouraged to 
write a patch with a test so it does not regress in the future

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35402] Upgrade macOS and Windows installers to Tcl 8.6.9 and Tk 8.6.9.1

[Ned Deily]

Ned Deily  added the comment:

The macOS installers will use Tcl 8.6.9 and Tk 8.6.9.1 starting with 3.7.2rc1 
and 3.6.8rc1.  Due to time constraints, the Windows builds will get updated 
later.

--
title: Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1 -> Upgrade 
macOS and Windows installers to Tcl 8.6.9 and Tk 8.6.9.1

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35454] Fix miscellaneous issues in error handling

[Serhiy Storchaka]

Change by Serhiy Storchaka :


--
pull_requests: +10335

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35448] ConfigParser .read() - handling of nonexistent files

[hongweipeng]

Change by hongweipeng :


--
nosy: +hongweipeng

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

[miss-islington]

miss-islington  added the comment:


New changeset aa580508431d231677cfaa13ac9b6aa37538b9ef by Miss Islington (bot) 
in branch '2.7':
bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)
https://github.com/python/cpython/commit/aa580508431d231677cfaa13ac9b6aa37538b9ef


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35454] Fix miscellaneous issues in error handling

[miss-islington]

Change by miss-islington :


--
pull_requests: +10334

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35454] Fix miscellaneous issues in error handling

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset 8905fcc85a6fc3ac394bc89b0bbf40897e9497a6 by Serhiy Storchaka in 
branch 'master':
bpo-35454: Fix miscellaneous minor issues in error handling. (#11077)
https://github.com/python/cpython/commit/8905fcc85a6fc3ac394bc89b0bbf40897e9497a6


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

[Chris Withers]

Chris Withers  added the comment:

More tests are generally a good thing, so go for it :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue28054] Diff for visually comparing actual with expected in mock.assert_called_with.

[Chris Withers]

Chris Withers  added the comment:

This is a tricky one as there's plenty of prior art, with pytest's assertion 
rewriting [1], testfixtures compare [2] and the stuff that unittest already 
does [3].

I don't think any solution should rely on a TestCase being used as pytest, 
which is the most prevalent testing framework now, doesn't want to rely on them 
(they do come with a lot of baggage ;-)).

Can we make use of the pretty diffing stuff in unittest without explicitly 
making it a requirement?

[1] https://docs.pytest.org/en/latest/assert.html

[2] https://testfixtures.readthedocs.io/en/latest/comparing.html#dicts

[3] 
https://docs.python.org/3.8/library/unittest.html#unittest.TestCase.assertDictEqual

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

[miss-islington]

miss-islington  added the comment:


New changeset 37607f26697351751165a042f91f04530ce333f7 by Miss Islington (bot) 
in branch '3.6':
bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)
https://github.com/python/cpython/commit/37607f26697351751165a042f91f04530ce333f7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35444] Unify and optimize the helper for getting a builtin object

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:


New changeset bb86bf4c4eaa30b1f5192dab9f389ce0bb61114d by Serhiy Storchaka in 
branch 'master':
bpo-35444: Unify and optimize the helper for getting a builtin object. 
(GH-11047)
https://github.com/python/cpython/commit/bb86bf4c4eaa30b1f5192dab9f389ce0bb61114d


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

[miss-islington]

miss-islington  added the comment:


New changeset 3b9a0186c44d0c3e477c38fdc00203ec99aec912 by Miss Islington (bot) 
in branch '3.7':
bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)
https://github.com/python/cpython/commit/3b9a0186c44d0c3e477c38fdc00203ec99aec912


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

[Chris Withers]

Chris Withers  added the comment:

Before we get too far: what's the use case for this double patching?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

[miss-islington]

Change by miss-islington :


--
pull_requests: +10332

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

[miss-islington]

Change by miss-islington :


--
pull_requests: +10331

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

[miss-islington]

Change by miss-islington :


--
pull_requests: +10333

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

[Ned Deily]

Ned Deily  added the comment:


New changeset 7cf3d8e25174c8871883e42f3240fd7f01efd3a8 by Ned Deily in branch 
'master':
bpo-35402: Update macOS installer to use Tcl 8.6.9 / Tk 8.6.9.1 (GH-11101)
https://github.com/python/cpython/commit/7cf3d8e25174c8871883e42f3240fd7f01efd3a8


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[Ned Deily]

Change by Ned Deily :


--
assignee: christian.heimes -> 
priority: release blocker -> 
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[miss-islington]

miss-islington  added the comment:


New changeset 55076cc0ffd1b7602d67f3a9a420d6261ffd5c89 by Miss Islington (bot) 
in branch '2.7':
[3.6] bpo-35401: Update macOS installer to OpenSSL 1.0.2q (GH-11095)
https://github.com/python/cpython/commit/55076cc0ffd1b7602d67f3a9a420d6261ffd5c89


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35402] Upgrade macOS (and Windows?) installer to Tcl/Tk 8.6.9.1

[Ned Deily]

Change by Ned Deily :


--
keywords: +patch
pull_requests: +10330
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[miss-islington]

miss-islington  added the comment:


New changeset c37923ece75721c21b06f7e3645d2838c2452e18 by Miss Islington (bot) 
in branch '3.7':
bpo-35401: Update macOS installer to OpenSSL 1.1.0j (GH-11094)
https://github.com/python/cpython/commit/c37923ece75721c21b06f7e3645d2838c2452e18


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[miss-islington]

Change by miss-islington :


--
pull_requests: +10329

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[miss-islington]

miss-islington  added the comment:


New changeset 419b5ffc2ca46d7adf0be6216ca3a6e40028e50f by Miss Islington (bot) 
(Ned Deily) in branch '3.6':
[3.6] bpo-35401: Update macOS installer to OpenSSL 1.0.2q (GH-11095)
https://github.com/python/cpython/commit/419b5ffc2ca46d7adf0be6216ca3a6e40028e50f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[miss-islington]

Change by miss-islington :


--
pull_requests: +10328

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[miss-islington]

miss-islington  added the comment:


New changeset 3ec982640f89f6ce56dd2699a81e0bd834ae0c95 by Miss Islington (bot) 
(Ned Deily) in branch 'master':
bpo-35401: Update macOS installer to OpenSSL 1.1.0j (GH-11094)
https://github.com/python/cpython/commit/3ec982640f89f6ce56dd2699a81e0bd834ae0c95


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[Ned Deily]

Change by Ned Deily :


--
pull_requests: +10327

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

[miss-islington]

miss-islington  added the comment:


New changeset 9bb306d586e3f1a48db40bd9519412de4fff3ee8 by Miss Islington (bot) 
in branch '3.7':
bpo-34977: Remove unused preprocessor definition (GH-11092)
https://github.com/python/cpython/commit/9bb306d586e3f1a48db40bd9519412de4fff3ee8


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[Ned Deily]

Change by Ned Deily :


--
pull_requests: +10326

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

[miss-islington]

Change by miss-islington :


--
pull_requests: +10325

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

[Steve Dower]

Steve Dower  added the comment:


New changeset d5a6a389d492c5e3d7933bafbd5252fd86ac4d49 by Steve Dower in branch 
'master':
bpo-34977: Remove unused preprocessor definition (GH-11092)
https://github.com/python/cpython/commit/d5a6a389d492c5e3d7933bafbd5252fd86ac4d49


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35456] asyncio.Task.set_result() and set_exception() missing docstrings (and Liskov sub. principle)

[Ned Deily]

Change by Ned Deily :


--
components: +asyncio
nosy: +asvetlov, yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

[Steve Dower]

Steve Dower  added the comment:

Luckily, just noticed that I introduced a bug as part of splitting up the 
original PR into two.

It wasn't going to have an impact until the package was properly installed from 
the store, but without the proper directory resolution in there (since the 
variable I removed is never defined now), in some scenarios it wouldn't be 
possible to launch Python from a process outside of the app package, such as a 
virtual environment.

Testing in a proper app container is difficult, but I'll see if I can come up 
with a way to do it. It might require a custom buildbot, so I'll see whether 
there's a way I can do that (historically we've not been able to wire internal 
work machines - including Azure hosted ones - into other CI systems, but I'll 
try again).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35456] asyncio.Task.set_result() and set_exception() missing docstrings (and Liskov sub. principle)

[Yahya Abou Imran]

New submission from Yahya Abou Imran :

In asyncio.Task help:

 |  set_exception(self, exception, /)
 |  Mark the future done and set an exception.
 |  
 |  If the future is already done when this method is called, raises
 |  InvalidStateError.
 |  
 |  set_result(self, result, /)
 |  Mark the future done and set its result.
 |  
 |  If the future is already done when this method is called, raises
 |  InvalidStateError.

These doctrings are inherited from asyncio.Future.

But in fact it's wrong since:

https://github.com/python/cpython/blob/4824385fec0a1de99b4183f995a3e4923771bf64/Lib/asyncio/tasks.py#L161:

def set_result(self, result):
raise RuntimeError('Task does not support set_result operation')

def set_exception(self, exception):
raise RuntimeError('Task does not support set_exception operation')

Just adding another docstring is not a good solution - at leas for me - because 
the problem is in fact deeper:

This prove by itself that a Task is not a Future in fact, or shouldn't be, 
because this breaks the Liskov substitution principle.

We could have both Future and Task inheriting from some base class like 
PendingOperation witch would contain all the methods of Future except these two 
setters.

One problem to deal with might be those calls to super().set_result/exception() 
in Task._step():

https://github.com/python/cpython/blob/4824385fec0a1de99b4183f995a3e4923771bf64/Lib/asyncio/tasks.py#L254

except StopIteration as exc:
if self._must_cancel:
# Task is cancelled right before coro stops.
self._must_cancel = False
super().set_exception(exceptions.CancelledError())
else:
super().set_result(exc.value)
except exceptions.CancelledError:
super().cancel()  # I.e., Future.cancel(self).
except Exception as exc:
super().set_exception(exc)
except BaseException as exc:
super().set_exception(exc)
raise

One way to deal with that would be to let a Task have a Future.
"Prefer composition over inheritance" as they say.

I want to work on PR for this if nobody goes against it...

PS: I really don't like when some people says that Python core developers are 
known to have poor knowledge in regard to OOP principles. So I really don't 
like letting something like this in the standard library...

--
messages: 331570
nosy: yahya-abou-imran
priority: normal
severity: normal
status: open
title: asyncio.Task.set_result() and set_exception() missing docstrings (and 
Liskov sub. principle)
type: enhancement
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

[Steve Dower]

Change by Steve Dower :


--
pull_requests: +10324

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[Steve Dower]

Steve Dower  added the comment:


New changeset 3c8bd22b8f0d7f57261b9d3c90e56447cd5acf94 by Steve Dower in branch 
'2.7':
bpo-35401: Updates Windows build to OpenSSL 1.0.2q (GH-11089)
https://github.com/python/cpython/commit/3c8bd22b8f0d7f57261b9d3c90e56447cd5acf94


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[miss-islington]

miss-islington  added the comment:


New changeset d1fb21209bca0620ece849e05cca97bce861c996 by Miss Islington (bot) 
in branch '3.7':
bpo-35401: Update Windows build to OpenSSL 1.1.0j (GH-11088)
https://github.com/python/cpython/commit/d1fb21209bca0620ece849e05cca97bce861c996


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35453] pathlib.Path: glob and rglob should accept PathLike patterns

[Cristian Ciupitu]

Cristian Ciupitu  added the comment:

Err, I meant os.path.join instead of os.path.combine.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

[Steve Dower]

Steve Dower  added the comment:


New changeset 0e4ad88ff8956d9289ab0a1314636ac15b374459 by Steve Dower in branch 
'3.7':
bpo-34977: Add Windows App Store package (GH-11027)
https://github.com/python/cpython/commit/0e4ad88ff8956d9289ab0a1314636ac15b374459


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[Steve Dower]

Change by Steve Dower :


--
pull_requests: +10323

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[miss-islington]

Change by miss-islington :


--
pull_requests: +10322

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[Steve Dower]

Steve Dower  added the comment:


New changeset 309d7207f691b3eaa988d2293b9d023943982a9f by Steve Dower in branch 
'3.6':
bpo-35401: Updates Windows build to OpenSSL 1.0.2q (GH-11089)
https://github.com/python/cpython/commit/309d7207f691b3eaa988d2293b9d023943982a9f


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[Steve Dower]

Steve Dower  added the comment:


New changeset 4824385fec0a1de99b4183f995a3e4923771bf64 by Steve Dower in branch 
'master':
bpo-35401: Update Windows build to OpenSSL 1.1.0j (GH-11088)
https://github.com/python/cpython/commit/4824385fec0a1de99b4183f995a3e4923771bf64


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[David Bolen]

David Bolen  added the comment:

Ah, got it (and see the pipelines comment by Steve).

Jeremy, I suspect you might actually be able to restart the most recent 3.6 
builds on my builders since you were the committer.  It changed in Sep to only 
allow python-core users and the "owner" of the build.  Though I don't think I 
learned for sure if owner was the author of the commit or just the actual 
committer.

I think Zachary was going to look into it time permitting.  We probably need a 
different GitHub group for buildbot owners or something.

Separately, I think in the context of this issue I think it's fair to say that 
the commit need not be rolled back.  I have to imagine that anyone trying to 
build 3.6 using VS 2015 at this point is going to be better represented by 
Jeremy's worker than mine (in terms of VS point release and default SDK 
installation), and I expect to be able to resolve any remaining issues 
worker-side once some 3.6 builds go through.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[Jeremy Kloth]

Jeremy Kloth  added the comment:

> Oh, it's not the installation itself, I'm just wondering if allowing a newer 
> version is ok too?

The original PR (included in 3.7, 3.x) uses the latest discovered SDK,
but Steve stated that that logic broke the Pipelines build, so I
reworked to PR to just check for the versions already hard-coded.

> Of course, it doesn't preclude expanding the build script in the future, so 
> I've installed 15063 to both Win8/10 workers.

For 3.6, this is the last hurrah.  It goes into security mode after
tonight.  Although, it does seem that we might need to add a check for
the SDK ourselves instead of relying on MSBuild to do it (it may be a
full Visual Studio only thing, not Build Tools).

> I don't currently have access to restart builds through the buildbot web 
> interface any more

If anyone with the power to do so is watching, this is something that
I miss now, too.  It seems that the buildbot owners are not given the
proper permissions for this task.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[David Bolen]

David Bolen  added the comment:

Oh, it's not the installation itself, I'm just wondering if allowing a newer 
version is ok too?

Of course, it doesn't preclude expanding the build script in the future, so 
I've installed 15063 to both Win8/10 workers.

I don't currently have access to restart builds through the buildbot web 
interface any more, but if someone who does wants to rerun the last 3.6 build 
on each builder we can make sure this resolves the issue on those workers.  

I've done a quick manual build that compiles with the exception of not finding 
midl.exe for pyshellext, but that seems separate (every SDK has the binary) so 
I'm assuming it's environmental outside of the regular build environment.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

[Steve Dower]

Steve Dower  added the comment:


New changeset 0cd6391fd890368ea1743dac50c366b42f2fd126 by Steve Dower in branch 
'master':
bpo-34977: Add Windows App Store package (GH-11027)
https://github.com/python/cpython/commit/0cd6391fd890368ea1743dac50c366b42f2fd126


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[Jeremy Kloth]

Jeremy Kloth  added the comment:

Well, if VS2015 is installed, the simplest way to have the required SDK(s) is 
to go to Control Panel -> Uninstall -> Microsoft Visual Studio (Community) 2015

Click Modify.
Expand "Windows and Web Development"
Expand "Universal Windows App Development Tools"
Select at least "Windows 10 SDK (10.0.10586)"

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[David Bolen]

David Bolen  added the comment:

Hmm, VS2015 started as a full installation (with UI), probably right from its 
initial release.  The build tools only installation (v141) is for VS2017.

Best I can tell I'm at update 1 - my update version in the registry is 
14.0.24720 (plus I have a .1 installer still in the filesystem).  Not sure why 
I don't have 10586 if that came with update 1.  But I wouldn't be surprised if 
I'm no further.  The last time I used the VS2015 installer it completely messed 
up one of my workers and took a bunch of time to recover from.

When switching to VS2017 I think I thought it was going to be preferred for the 
3.x series when available, so I probably treated the VS2015 version as less 
critical.  I guess that didn't end up happening for earlier than 3.7.

Anyway, best next steps to close out this issue...

I assume my installing any matching SDK (say 15063) would allow the workers to 
match the build script.  Alternatively, including more recent SDKs (16299 is 
the next in line) in the build script would work with the existing workers.  
I'm fine either way.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[Jeremy Kloth]

Jeremy Kloth  added the comment:

I forgot to mention that the presence of UseWindows81SDK in the build log 
indicates that the Build Tools are at most at version 1.2 (included with VS2015 
Update 1) which should still work (it's what I tested against), but the 
difference may be the standalone Build Tools might not include an error for 
missing SDK whereas the VS2015 Tools do.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[Jeremy Kloth]

Jeremy Kloth  added the comment:

A quick look at the good build log does indicate that the 8.1 SDK was being 
used (vars UseWindows81SDK=true and WindowsTargetPlatformVersion=8.1) which is 
the default behavior for VS2015 if a matching (from python.props) Win10SDK 
cannot be found.

It seems that the build tools you have installed do not give an error when the 
selected SDK (WindowsTargetPlatformVersion) isn't found on the system.

You've said that you have the Build Tools for VS2015 installed, a quick look at 
the download date indicates that they were released prior to VS2015 Update 1 
(which includes 10.0.10586.0).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[David Bolen]

David Bolen  added the comment:

(and the working log)

--
Added file: https://bugs.python.org/file47986/msbuild-win10-good.log

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[David Bolen]

David Bolen  added the comment:

> So before the change, the 16299 SDK wasn't being detected either, but perhaps 
> the 10240 one was?

So I'm just confused

It does seems likely that 10240 of the UCRT was being used (based on the 
attached msbuild logs).  Howevr, the UCRT warning in the build process was 
fine, and said I was using 16299 (see 
https://buildbot.python.org/all/#/builders/31/builds/717/steps/1/logs/stdio for 
the last working build on Win10).  

I'm not sure what to trust - the msbuild log or whatever the ucrtused test is 
doing for detection?

In either case, this issue commmit does seem to force selection of the 
non-existent 15063 SDK, at least based on msbuild.log - the process doesn't get 
far enough to run the UCRT version check.

Using Win10 for the moment, under "Program Files (x86)" I do seem to have some 
older UCRT SDKs (in "Microsoft SDKs/Windows 
Kits/10/ExtensionSDKs/Microsoft.UniversalCRT.Debug") as 10.0.10150.0, 
10.0.10240.0 and 10.0.16299.0.  Whereas only 10.0.16299.0 exists in the 
"Windows Kits/10/Platforms/UAP" directory.

So I guess msbuild is not strictly picking the "earliest" for UCRT as 10240 
isn't quite the earliest.

In comparison, my Windows 7 worker also has the 15063 UCRT SDK so the enforced 
minimum works there for the UCRT path.  Of course, the ucrtused test in the 
build process seems to always say 16299.

I ran the requested msbuild command on the Win10 worker as part of 
PCBuild\build.bat just after the first find_msbuild.bat call.  I'm attaching 
the log files as msbuild-win10-good.log (commit prior to this change) and 
msbuild-win10-bad.log (after this change).

So I guess the question is exactly what do we need to enforce in the build 
process and/or provide at a minimum on a worker?  Should I just install the 
older 15063 SDK on Win8/10, or should we include some more recent versions in 
the build time version check?  What is a new user trying to build Python likely 
to have (assuming they're still using VS2015).

--
Added file: https://bugs.python.org/file47985/msbuild-win10-bad.log

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

[Steve Dower]

Steve Dower  added the comment:

Thanks, Paul. Appreciate it :)

Doing a final call before I hit merge in an hour or so. Right now:
* full release build works
* full test pass on all CI + custom buildbots work
* prior test package made it to the store
* docs clearly show it may change again

Any last pushback?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[Steve Dower]

Steve Dower  added the comment:

So before the change, the 16299 SDK wasn't being detected either, but perhaps 
the 10240 one was? That had some known issues in the debug UCRT, which is why 
the version gets printed out towards the end of the build.

The only thing I can think of would be the WindowsTargetPlatformVersion 
setting, which is new. It may be that it is used differently on different 
MSBuild versions (which roughly match to VS versions) by the built-in target 
files.

Are you able to run "MSBuild pythoncore.vcxproj /t:ShowVersionInfo /flp:v=diag" 
and upload the MSBuild.log file (or email it to me)?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[David Bolen]

David Bolen  added the comment:

(sorry for the rapid updates)

I'm also fairly sure that none of my workers have update 3 for VS2015.  They do 
however all have VS2017 - but I think VS2015 still gets picked for 3.6 if both 
are present, right?  So that's another variable, in that my workers wouldn't 
have run into the update 3 issue with the older configuration that Jeremy did.  

Not sure if there's a way to have the build setup to work for both cases.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35454] Fix miscellaneous issues in error handling

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

No. It is very hard to reproduce these errors.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35454] Fix miscellaneous issues in error handling

[Charalampos Stratakis]

Charalampos Stratakis  added the comment:

Maybe a release blocker for 3.7.2 and 3.6.8?

--
nosy: +cstratak, ned.deily

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[David Bolen]

David Bolen  added the comment:

Oh, since my reading comprehension must be low today, it appears like Jeremy 
actually had a closer situation previously as I'm in now, with a later (not 
older) version of the SDK that wasn't in the list.

Which is interesting, since he got an error about the SDK whereas my workers 
weren't having an issue at that point.

But I guess it still comes down to what to do if the hardcoded list doesn't 
match what's on the system, but the SDK on the system will actually work.  
Complain or let the default get used anyway?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[David Bolen]

David Bolen  added the comment:

Well, correct me if I'm wrong, but installing 15063 would then match one of the 
checks, and become the selected SDK, so be expected to work fine, right?

I think (not sure) that the issue with my Win8/10 workers is they only have the 
later 16299.  So in that case the build process is trying to enforce 10586 as a 
minimum (due to not finding anything else) which can't work.  Assuming I'm 
interpreting the new WindowsTargetPlatformVersion definition correctly).

When you say the "others were going to fail too" I don't think that's correct 
in all cases.  That is, the installed version doesn't match the checked 
versions, but it's later, so it could work fine.  And in this case it's the 
only version available so the default build tool selection is fine.

I'm guessing Jeremy's case was having older (not workable) versions and still 
not matching one of the checked versions, in which case the build default of 
oldest would fail.  And yes, in that case enforcing a missing version is no 
real difference since both options fail.

Not sure if solving both cases is possible, but at least letting the build tool 
default to an available SDK if no match is found seems more conservative.  It 
might still fail, but there are cases where it won't.  And it seems more likely 
over time that someone may only have a later SDK than that they'll have an 
earlier one or a guaranteed match to those being checked.  Or if we want to 
enforce specific versions, publishing them and forcing the build to fail hard 
would be an option too.

I don't think the difference in registry vs. folder checks is an issue, at 
least not for me.  On the Win8/10 workers, both the registry and filesystem are 
in agreement - the only thing available is 16299.

I'm also not sure if it's possible, but it would be great to have some output 
somewhere about the selection.  Right now there's nothing in the compiler stage 
output of a working vs. failing build to indicate why they are behaving 
differently.  But that's probably a separate topic.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[Steve Dower]

Steve Dower  added the comment:

Both io.h and stddef.h are from the UCRT, which *may* go through a different 
detection process than the rest of the WinSDK. That might be the cause.

The "didn't find any supported SDKs" behavior is to try and use the earliest, 
which should fail, but all the others were going to fail too. I wonder if 
checking the installed UAP platform data is the wrong check, and we should look 
for a specific Include file instead?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[Steve Dower]

Steve Dower  added the comment:

I'm also looking at it, so please don't revert it just yet.

I just installed 10.0.15063 onto my dev machine to test another 3.6 fix and it 
worked fine, so perhaps there's an option that is off here?

--
resolution: fixed -> 

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[Steve Dower]

Change by Steve Dower :


--
pull_requests: +10321

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35401] Upgrade Windows and macOS installers to use OpenSSL 1.1.0j / 1.0.2q

[Steve Dower]

Change by Steve Dower :


--
keywords: +patch
pull_requests: +10320
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35426] test_signal.test_interprocess_signal() race condition

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +10319
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[David Bolen]

David Bolen  added the comment:

I'm not that familiar (ok, at all) with the build process configuration, but in 
looking at the changes to python.props, it appears to now enforce the minimum 
in the build process regardless of whether it is found, whereas before the 
build tool was allowed to pick a default.

On my Win8/10 builders, I don't have an SDK that matches anything in the new 
checks (10586, 14393, 15063), but instead just have a single later (16299) 
version installed.  The Win7 buildbot does, however, also have an earlier 15063.

So what happens if none of the checked versions exist?  Am I correct that it'll 
enforce trying to use the minimum (10586) which won't work on my Win8/10 
workers since it doesn't exist, while the default behavior to just use the SDK 
I have would be fine

Or is the build tool supposed to ignore the missing SDK and still use a default 
if later?

It seems to me the older default of letting the build tool apply its own 
defaults if no known matching SDK is found is better than specifying a possibly 
missing SDK, but obviously the older default caused an issue in Jeremy's 
original case.  And since the prior behavior was just to try to avoid the build 
tool from defaulting to too old an SDK, another solution to problems in that 
case might be to remove the oldest SDK, thus moving the default forward.

--
nosy: +db3l

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35412] test_future4 ran no test

[Pablo Galindo Salgado]

Change by Pablo Galindo Salgado :


--
keywords: +patch
pull_requests: +10318
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35425] test_eintr fails randomly on AMD64 FreeBSD 10-STABLE Non-Debug 3.7: TypeError: 'int' object is not callable

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

I logged in into the buildbot and try to reproduce that. After 230 iterations 
of `test_eintr` I cannot reproduce the signal problem. Maybe this is an 
interaction with some other test

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35425] test_eintr fails randomly on AMD64 FreeBSD 10-STABLE Non-Debug 3.7: TypeError: 'int' object is not callable

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

Could it be that there is another test that is sending SIGALRM but does not 
disarm the ITIMER_REAL timer before restoring the previous handler? 

---

TypeError: 'int' object is not callable

Can it be that thread.file has some custom deallocator/finalizer that fails?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[Pablo Galindo Salgado]

Pablo Galindo Salgado  added the comment:

This commit broke the following (at least) the buildbots:

https://buildbot.python.org/all/#/builders/38/builds/751
https://buildbot.python.org/all/#/builders/31/builds/719

can someone work on a fix? Otherwise we would have to revert the commit per our 
policy with buildbot failures

--
nosy: +pablogsal
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35257] Avoid leaking linker flags into distutils: add PY_LDFLAGS_NODIST

[Charalampos Stratakis]

Charalampos Stratakis  added the comment:

The PR is pending another round of review.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34616] implement "Async exec"

[Matthias Bussonnier]

Matthias Bussonnier  added the comment:

> Or actually there are two options to think about: you can submit a general 
> talk, or submit a talk to the language summit. (Or write two talks and do 
> both, I guess.) They're pretty different – the summit is a more informal 
> thing (no video, smaller room), mostly just core devs, more of a working 
> meeting kind of thing where you can argue about technical details.

Thanks, I may do that then – if a core dev invite me to do so – I wouldn't have 
dared otherwise. I'm not even sure you can suggest a language summit proposal 
yet.

For the normal talk proposal here is what I have so far: 

https://gist.github.com/Carreau/20881c6c70f1cde9878db7aa247d432a

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35338] set union/intersection/difference could accept zero arguments

[Josh Rosenberg]

Josh Rosenberg  added the comment:

Given the "feature" in question isn't actually an intended feature (just an 
accident of how unbound methods work), I'm closing this. We're not going to try 
to make methods callable without self.

--
resolution:  -> wont fix
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35438] Cleanup extension functions using _PyObject_LookupSpecial

[Josh Rosenberg]

Josh Rosenberg  added the comment:

Agreed with everything in Serhiy's comments. This patch disregards why 
_PyObject_LookupSpecial and the various _Py_IDENTIFIER related stuff was 
created in the first place (to handle a non-trivial task efficiently/correctly) 
in favor of trying to avoid C-APIs that are explicitly okay to use for the 
CPython standard extensions. The goal is a mistake in the first place; no patch 
fix will make the goal correct.

Closing as not a bug.

--
resolution:  -> not a bug
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

[Anthony Sottile]

Anthony Sottile  added the comment:

I've opened a PR with the test included: 
https://github.com/python/cpython/pull/11085

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

[Anthony Sottile]

Change by Anthony Sottile :


--
pull_requests: +10317

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34616] implement "Async exec"

[Nathaniel Smith]

Nathaniel Smith  added the comment:

> I'm thinking of submitting a talk at PyCon to explain what we've discover so 
> far in IPython.

You totally should!

Or actually there are two options to think about: you can submit a general 
talk, or submit a talk to the language summit. (Or write two talks and do both, 
I guess.) They're pretty different – the summit is a more informal thing (no 
video, smaller room), mostly just core devs, more of a working meeting kind of 
thing where you can argue about technical details.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

[Steve Dower]

Steve Dower  added the comment:

Paul (and anyone else) - the below link should go directly to just the commit 
with the docs update. I did a slight rearrangement of the install docs to make 
the options clearer, and wrote up *just* enough info on nuget to help people 
use it right (I hope). Similarly for the Store package.

Any comments appreciated. Still aiming to get this in for 3.7.2rc1 today.

https://github.com/python/cpython/pull/11027/commits/7d7ddbc41bd30690de8c6227cebc41c4e0f3cf88

I've also kicked off a custom buildbot run against the 3.7 version of the 
change. The version in master ran earlier and was clean. Plus I'm running test 
builds on the release machine, so it should be ready to go.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[Steve Dower]

Change by Steve Dower :


--
resolution:  -> fixed
status: open -> closed
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35433] Correctly detect installed SDK versions

[Steve Dower]

Steve Dower  added the comment:


New changeset f04cc5fc0d2f644cccb57543aae487ee30091924 by Steve Dower (Jeremy 
Kloth) in branch '3.6':
[3.6] bpo-35433: Properly detect installed SDK versions (GH-11009)
https://github.com/python/cpython/commit/f04cc5fc0d2f644cccb57543aae487ee30091924


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35448] ConfigParser .read() - handling of nonexistent files

[David Heiberg]

Change by David Heiberg :


--
nosy: +dheiberg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35438] Cleanup extension functions using _PyObject_LookupSpecial

[Serhiy Storchaka]

Serhiy Storchaka  added the comment:

There is nothing wrong with using private C API in the implementation of 
standard CPython extensions. This API was designed for this.

In contrary, there are problems with your code:

* It is less efficient. String objects are created and destroyed twice per 
every function call, in PyObject_HasAttrString() and in PyObject_CallMethod(). 
Format string is parsed in PyObject_CallMethod(). Other temporary objects are 
created and destroyed.

* It uses inherently broken PyObject_HasAttrString(). PyObject_HasAttrString() 
swallows exceptions (for example a MemoryError raised when create a temporary 
string object) and can return an incorrect result.

* It is not equivalent with the existing code. For example it does not work 
properly if the dunder method is a static method.

--
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34616] implement "Async exec"

[pmpp]

pmpp  added the comment:

i already use prompt_toolkit on droid as it uses concurrent futures for 
completion and threads are allowed on that platform, and yeah it is quite good.

but no way to use it on emscripten where cpython is 100% async ( it uses 
dummy_threading to load asyncio ). best you can do is fill an history buffer 
with the indented input, eval the whole thing when it's done with 
PyRun_SimpleString. 

having cpython storing code until sync/async path can  be choosen could save a 
lot of external hacks with minimal impact on original repl loop, unless 
somebody is willing to make it *fully* async ( i know i can't ). 

The original repl input loop is really not made for async and i don't know if 
Sylvain Beuclair's work on "emterpreted" cpython covers also python3.

thx for the pointers anyway and your article on async and ast was inspiration.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

[Jeremy Kloth]

Jeremy Kloth  added the comment:

See also bpo-35450: venv module doesn't create a copy of python binary by 
default

--
nosy: +jkloth

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34616] implement "Async exec"

[Matthias Bussonnier]

Matthias Bussonnier  added the comment:

In IPython we use `prompt_toolkit`  which does already provide a async readline 
alternative.

Also have a look at 
https://github.com/ipython/ipython/blob/320d21bf56804541b27deb488871e488eb96929f/IPython/core/interactiveshell.py#L121-L150

Seem to be equivalent to what you aare trying to do with updating your locals 
here 
https://github.com/pmp-p/aioprompt/blob/93a25ea8753975be6ed891e8d45f22db91c52200/aioprompt/__init__.py#L78-L94

It just sets the function to not create a new local scope

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35403] support application/wasm in mimetypes and http.server

[R. David Murray]

R. David Murray  added the comment:

We don't generally add a mime type until it is a de-jure or de-facto standard.  
If it is still in testing it is probably too soon to add it.  For testing, you 
can always add it yourself in your code via the api that mimetypes provides.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31823] Opaque default value for close_fds argument in Popen.__init__

[Gregory P. Smith]

Gregory P. Smith  added the comment:

In 3.6 this help(subprocess.Popen.__init__) is accurate and encourages looking 
at the docs.  In 3.7 and later it'll simply report close_fds=True in the 
siguature as that is the case in 3.7 onwards.

I see nothing to fix here.

--
nosy: +gregory.p.smith
resolution:  -> wont fix
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34616] implement "Async exec"

[pmpp]

pmpp  added the comment:

indeed adding async flag to compile and providing some 'aexec' is a very good 
idea ! 

*an async repl is really usefull when stuck with a threadless python*

( specific engines, or emscripten cpython )

"top-level async is invalid syntax" : 
Rewinding the readline history stack to get code "async'ified" is probably not 
the best way : readline is specific to some platforms.
see https://github.com/pmp-p/aioprompt for a hack using that.

First raising an exception "top level code is async" and allowing user to get 
source code from exception would maybe a nice start to an async repl.

--
nosy: +pmpp

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue31823] Opaque default value for close_fds argument in Popen.__init__

[Gregory P. Smith]

Change by Gregory P. Smith :


--
versions:  -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35438] Cleanup extension functions using _PyObject_LookupSpecial

[Eddie Elizondo]

Eddie Elizondo  added the comment:

I also fixed the title to properly reflect what this is trying to achieve.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34616] implement "Async exec"

[Matthias Bussonnier]

Matthias Bussonnier  added the comment:

So through time our heuristic to check wether a code should be async or not 
grew: 

https://github.com/ipython/ipython/blob/320d21bf56804541b27deb488871e488eb96929f/IPython/core/async_helpers.py#L94-L165

There also seem to be some code that uses `codeop.compile_command` to figure 
out wether the user code is valid syntax (or not), so that would need some 
update too. 

I'm thinking of submitting a talk at PyCon to explain what we've discover so 
far in IPython.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35438] Cleanup extension functions using _PyObject_LookupSpecial

[Eddie Elizondo]

Change by Eddie Elizondo :


--
title: Extension modules using non-API functions -> Cleanup extension functions 
using _PyObject_LookupSpecial

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35438] Extension modules using non-API functions

[Eddie Elizondo]

Eddie Elizondo  added the comment:

@vstinner: Sorry for not being clear - The intention of this change is two-fold:
1) Simplify the implementation of these functions.
2) Reduce the surface area of the C-API.

Given that the same functionality can be achieved with public functions of the 
C-API. This is a nice cleanup over the current approach.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35438] Extension modules using non-API functions

[STINNER Victor]

STINNER Victor  added the comment:

> Three extension modules: _testcapimodule.c, posixmodule.c, and mathmodule.c 
> are using `_PyObject_LookupSpecial` which is not API.

I don't understand the issue that you are trying to solve. Yes, Python builtin 
extensions use private functions of the C API.

--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35438] Extension modules using non-API functions

[Eddie Elizondo]

Change by Eddie Elizondo :


--
keywords: +patch
pull_requests: +10316
stage:  -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

[Steve Dower]

Steve Dower  added the comment:


New changeset b264c609853eae9dbb45c6dbee11e84ae3927e88 by Steve Dower in branch 
'3.7':
[3.7] bpo-34977: Use venv redirector instead of original python.exe on Windows 
(GH-11029)
https://github.com/python/cpython/commit/b264c609853eae9dbb45c6dbee11e84ae3927e88


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34977] Release Windows Store app containing Python

[Steve Dower]

Steve Dower  added the comment:


New changeset 1c3de541e64f75046b20cdd27bada1557e550bcd by Steve Dower in branch 
'master':
bpo-34977: Use venv redirector instead of original python.exe on Windows 
(GH-11029)
https://github.com/python/cpython/commit/1c3de541e64f75046b20cdd27bada1557e550bcd


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com