date:20191127



Change by Serhiy Storchaka :


--
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> Problem with Checkbutton and  duplicate last name components

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38917] Color setting doesn't work in tkinter

2019-11-27 Thread Ned Deily



Ned Deily  added the comment:

I believe this is a duplicate of Issue36468 which identifies the issue which is 
apparently fixed in Tk 8.6.9+; it also provides a workaround for Tk 8.6.8.

--
nosy: +ned.deily
resolution:  -> duplicate
stage:  -> resolved
status: open -> closed
superseder:  -> Treeview: wrong color change

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38933] unusual behaviour on list of dependable lambdas



Karthikeyan Singaravelan  added the comment:

This could also help in understanding late binding that happens with the 
lambdas in the report : 
https://docs.python-guide.org/writing/gotchas/#late-binding-closures

--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38898] Tkinter checkbutton switch on and off together

2019-11-27 Thread Ned Deily



Change by Ned Deily :


--
nosy: +gpolo, serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children



Vegard Stikbakke  added the comment:

Oh, right! Thanks!

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38933] unusual behaviour on list of dependable lambdas

2019-11-27 Thread Vedran Čačić


Vedran Čačić  added the comment:

Why exactly is [2,3] expected? In the first example, the inner list has two 
functions that are _exactly the same_. Each of them takes a, grabs i from outer 
scope, and returns a[i]. (And of course, at the moment of evaluation of these 
functions, i is 1.) 

Do you really expect i to be "spliced" into the lambda as a value at the moment 
of constructing the function? Would you also expect

lambda x: x + input('y? ')

to ask you for input?

--
nosy: +veky

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26730] SpooledTemporaryFile rollover corrupts data silently when Unicode characters are written



Inada Naoki  added the comment:

> Do we need to explicitly document the return value change of _file which is 
> documented with a separate versionchanged directive for 3.7 and 3.8?

I feel it is too detailed.

Note that the _file attribute may be TextIOWrapper after rollover() anyway and 
the rollover() may be called implicitly.
The code depending on the specific type of the _file is fragile at first.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26730] SpooledTemporaryFile rollover corrupts data silently when Unicode characters are written



Karthikeyan Singaravelan  added the comment:

Do we need to explicitly document the return value change of _file which is 
documented with a separate versionchanged directive for 3.7 and 3.8? Code like 
below could fail in them since TextIOWrapper doesn't have getvalue attribute as 
the minor version upgrade is done.

import tempfile

with tempfile.SpooledTemporaryFile(mode='wt') as f:
f.write('abc')
assert f._file.getvalue() == 'abc'

--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26730] SpooledTemporaryFile rollover corrupts data silently when Unicode characters are written



Serhiy Storchaka  added the comment:

Thank you Inada-san.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38916] Remove array.fromstring

2019-11-27 Thread Dong-hee Na



Dong-hee Na  added the comment:

> The other deprecation in the array module says, "Deprecated since version 
> 3.3, will be removed in version 4.0".  Perhaps this one should have had the 
> same qualifier.

I agree,
How about note it in the documentation and logging rather than removing them?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26730] SpooledTemporaryFile rollover corrupts data silently when Unicode characters are written



Change by Inada Naoki :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38524] functools.cached_property is not supported for setattr



Tal Einat  added the comment:

Thanks for the suggestion hongweipeng!

Thanks for the PR Florian, and congratulations on your first contribution to 
the project! May it be the first of many.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38524] functools.cached_property is not supported for setattr



miss-islington  added the comment:


New changeset c0db88f6abbace79644b2aca2290bf41b1a37174 by Miss Islington (bot) 
in branch '3.8':
bpo-38524: clarify example a bit and improve formatting (GH-17406)
https://github.com/python/cpython/commit/c0db88f6abbace79644b2aca2290bf41b1a37174


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38524] functools.cached_property is not supported for setattr



miss-islington  added the comment:


New changeset 7e9bbbe51e74e5928e6a6c3e70434d824970ef58 by Miss Islington (bot) 
in branch '3.7':
bpo-38524: clarify example a bit and improve formatting (GH-17406)
https://github.com/python/cpython/commit/7e9bbbe51e74e5928e6a6c3e70434d824970ef58


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37883] threading.Lock.locked is not documented



Tal Einat  added the comment:

Ido, I don't see why this should be closed. The suggestion is good and the PR 
is good. I'm only waiting for the CLA signing to be worked through to merge the 
PR.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26730] SpooledTemporaryFile rollover corrupts data silently when Unicode characters are written



Inada Naoki  added the comment:


New changeset e65b3fa9f16537d20f5f37c25673ac899fcd7099 by Inada Naoki in branch 
'3.7':
bpo-26730: Fix SpooledTemporaryFile data corruption (GH-17400)
https://github.com/python/cpython/commit/e65b3fa9f16537d20f5f37c25673ac899fcd7099


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26730] SpooledTemporaryFile rollover corrupts data silently when Unicode characters are written



miss-islington  added the comment:


New changeset d21b8e82dda3caf0989bb39bc0e0ce2bfef97081 by Miss Islington (bot) 
in branch '3.8':
bpo-26730: Fix SpooledTemporaryFile data corruption (GH-17400)
https://github.com/python/cpython/commit/d21b8e82dda3caf0989bb39bc0e0ce2bfef97081


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38524] functools.cached_property is not supported for setattr



Change by miss-islington :


--
pull_requests: +16892
pull_request: https://github.com/python/cpython/pull/17412

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38524] functools.cached_property is not supported for setattr



Change by miss-islington :


--
pull_requests: +16891
pull_request: https://github.com/python/cpython/pull/17411

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38524] functools.cached_property is not supported for setattr



Tal Einat  added the comment:


New changeset 02519f75d15b063914a11351da30178ca4ceb54b by Tal Einat in branch 
'master':
bpo-38524: clarify example a bit and improve formatting (GH-17406)
https://github.com/python/cpython/commit/02519f75d15b063914a11351da30178ca4ceb54b


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children



Karthikeyan Singaravelan  added the comment:

Thanks Vegard for the report. The docs say "Child mocks and the return value 
mock (if any) are reset as well." so it makes sense to me to reset the 
return_value and side_effect of children. But as mentioned in the PR it's a 
behaviour change that someone might be dependent on and can go on 3.9 . If we 
are not going ahead with the change then we can clarify the same in the docs 
and ask the user to reset mock recursively on their own so that it avoids 
confusion.

--
nosy: +cjw296, lisroach, mariocj89, michael.foord
versions: +Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38930] Subprocess failed to kill child process after timeout when using with statement

2019-11-27 Thread Xuan Hu



Xuan Hu  added the comment:

Seems it is a false negative report. Close it temporarily.

--
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38934] Dictionaries of dictionaries behave incorrectly when created from dict.fromkeys()

2019-11-27 Thread Josh Rosenberg


Josh Rosenberg  added the comment:

That's the expected behavior, and it's clearly documented here: 
https://docs.python.org/3/library/stdtypes.html#dict.fromkeys

Quote: "All of the values refer to just a single instance, so it generally 
doesn’t make sense for value to be a mutable object such as an empty list. To 
get distinct values, use a dict comprehension instead."

--
nosy: +josh.r
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38934] Dictionaries of dictionaries behave incorrectly when created from dict.fromkeys()

2019-11-27 Thread sourya varenya



sourya varenya  added the comment:

Here's a sample run for reproducibility:
---
Python 3.6.9(Ubuntu 18.04) & 3.7.4(Windows)
---
>>> a = {1:{5:8},2:{5:8}}

>>> b = dict.fromkeys([1,2],{5:8})

>>> a
{1: {5: 8}, 2: {5: 8}}

>>> b
{1: {5: 8}, 2: {5: 8}}

>>> a[1].update({6:9})
>>> b[1].update({6:9})

>>> a
{1: {5: 8, 6: 9}, 2: {5: 8}}

>>> b
{1: {5: 8, 6: 9}, 2: {5: 8, 6: 9}}

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38934] Dictionaries of dictionaries behave incorrectly when created from dict.fromkeys()

2019-11-27 Thread sourya varenya



New submission from sourya varenya :

Here's a sample run for reproducibility:
---
Python 3.6.9(Ubuntu 18.04) & 3.7.4(Windows)
---

 >>> a = {1:{5:8},2:{5:8}} 

 >>> b = dict.fromkeys([1,2],{5:8})   

  >>> a 
 {1: {5: 8}, 2: {5: 8}}  

   >>> b
  {1: {5: 8}, 2: {5: 8}}   

  >>> a[1].update({6:9})   

  >>> b[1].update({6:9})  

   >>> a
  {1: {5: 8, 6: 9}, 2: {5: 
8}} 

  >>> b 
 {1: {5: 8, 6: 9}, 2: {5: 8, 6: 9}}

--
components: Interpreter Core
messages: 357589
nosy: sourya varenya
priority: normal
severity: normal
status: open
title: Dictionaries of dictionaries behave incorrectly when created from 
dict.fromkeys()
type: behavior
versions: Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children



Change by Karthikeyan Singaravelan :


--
nosy: +xtreak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38928] EnvBuilder.upgrade_dependencies() does not exist on 3.8



Change by Tzu-ping Chung :


--
pull_requests: +16890
pull_request: https://github.com/python/cpython/pull/17410

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38817] Immutable types inplace operations work incorrect in async

2019-11-27 Thread Ayush Mahajan



Ayush Mahajan  added the comment:

Can I work on this issue?

--
nosy: +ay2306

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38933] unusual behaviour on list of dependable lambdas

2019-11-27 Thread Alexey Burdin



Alexey Burdin  added the comment:

x=[2,3]
[f(x) for f in [(lambda a:a[i]) for i in [0,1]]]
#the expected output is [2,3] but actual is [3,3]
[f(x) for f in [lambda a:a[0],lambda a:a[1]]]
#results [2,3] normally

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38933] unusual behaviour on list of dependable lambdas

2019-11-27 Thread Alexey Burdin



New submission from Alexey Burdin :

>>> x=[2,3]
>>> [f(x) for f in [(lambda a:a[i]) for i in [0,1]]]
[3, 3]
>>> [f(x) for f in [lambda a:a[0],lambda a:a[1]]]
[2, 3]

--
components: Interpreter Core
messages: 357586
nosy: Alexey Burdin
priority: normal
severity: normal
status: open
title: unusual behaviour on list of dependable lambdas
type: behavior
versions: Python 2.7, Python 3.6, Python 3.7, Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children



Change by Vegard Stikbakke :


--
keywords: +patch
pull_requests: +16889
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17409

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children



Change by Vegard Stikbakke :


--
versions:  -Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38927] venv --upgrade_deps fails on Windows



Change by Vinay Sajip :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38927] venv --upgrade_deps fails on Windows



Vinay Sajip  added the comment:


New changeset d9aa216d49423d58e192cd7a25016f90fe771ce7 by Vinay Sajip (Tzu-ping 
Chung) in branch 'master':
bpo-38927: Use python -m pip to upgrade venv deps (GH-17403)
https://github.com/python/cpython/commit/d9aa216d49423d58e192cd7a25016f90fe771ce7


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38928] EnvBuilder.upgrade_dependencies() does not exist on 3.8



Vinay Sajip  added the comment:


New changeset 045d4e243d042638bbbc9479d4f85f6f579ac3ca by Vinay Sajip (Tzu-ping 
Chung) in branch 'master':
bpo-38928: Fix versionadded for venv's upgrade_deps function (GH-17404)
https://github.com/python/cpython/commit/045d4e243d042638bbbc9479d4f85f6f579ac3ca


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35003] Provide an option to venv to put files in a bin/ directory on Windows



Vinay Sajip  added the comment:

The problem of bin over Scripts is that IIRC Scripts is baked-in in Windows, 
not just for venvs (e.g. a standard Python installation puts stuff in Scripts). 
So venv just sticks with the platform convention.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children



Vegard Stikbakke  added the comment:

I said MagicMock, but I meant Mock.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38932] unittest.mock.Mock.reset_mocks does not pass all arguments to its children



Change by Vegard Stikbakke :


--
title: MagicMock.reset_mocks does not pass all arguments to its children -> 
unittest.mock.Mock.reset_mocks does not pass all arguments to its children

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38932] MagicMock.reset_mocks does not pass all arguments to its children



New submission from Vegard Stikbakke :

MagicMock, from unittest.mock, has a method reset_mock, which takes optional 
arguments return_value and side_effect, both with default values False.

In the body of reset_mock, reset_mock is again called on all the _mock_children 
of of the MagicMock object. However, here the arguments are not passed. This 
means that if you have a MagicMock object with children that are also mocked, 
and methods on these have been directly mocked, then it is not enough to call 
reset_mock on the parent object. A code example that demonstrates this follows 
below. Here, we could expect m to have been completely reset. But the final 
print statement shows that m.a() still returns 1.

```
from unittest.mock import MagicMock

m = MagicMock(a=MagicMock())
m.a.return_value = 1
m.reset_mock(return_value=True)
print(m.a())
```

Pertinent line in Github 
https://github.com/python/cpython/blob/dadff6f6610e03a9363c52ba9c49aa923984640a/Lib/unittest/mock.py#L601

--
components: Library (Lib)
messages: 357581
nosy: vegarsti
priority: normal
severity: normal
status: open
title: MagicMock.reset_mocks does not pass all arguments to its children
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38462] Typo (nam ing) in import system docs

2019-11-27 Thread Roy Smith



Roy Smith  added the comment:

Just for the archives:

https://bugs.chromium.org/p/chromium/issues/detail?id=1022011

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38079] _PyObject_VAR_SIZE should avoid arithmetic overflow



Change by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue16079] list duplicate test names with patchcheck



Change by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue11664] Add patch method to unittest.TestCase



Change by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue7980] time.strptime not thread safe



Brett Cannon  added the comment:

As per Paul's suggestion, closing as "won't fix" as this only pertains to 
Python 2.7 and it will not be changing.

--
resolution:  -> wont fix
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue34309] Trouble when reloading extension modules.



Change by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38569] Unknown distribution option: 'license_files'



Change by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38593] Python 3.7 does not catch infinite recursion for some values of sys.getrecursionlimit()



Change by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38649] tkinter messagebox is sloppy



Change by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue32856] Optimize the `for y in [x]` idiom in comprehensions



Change by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38021] pep425 tag for AIX is inadequate



Change by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38021] pep425 tag for AIX is inadequate

2019-11-27 Thread Michael Felt



Michael Felt  added the comment:

On 26/11/2019 20:10, Paul Moore wrote:
> Paul Moore  added the comment:
>
>> replacement platform_tag, not compatibility tag.
> Ah, I see, sorry. In that case, this should be fine, it's purely a CPython 
> question. There's obviously a follow-on discussion about how that platform 
> tag is *incorporated* into the compatibility tags, but as you say, that's a 
> separate point.
Still an excellent question - as it clarified at least one vital point!
Thanks for the feedback and question.
> --
>
> ___
> Python tracker 
> 
> ___
>

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38931] pathlib.Path on Windows - parser issue

2019-11-27 Thread Zachary Ware



Zachary Ware  added the comment:

Note that you're using backslashes in a non-raw string; in particular, you're 
naming your file `\x09est.eps`.  Try `Path(r'C:\Temp\MyProj.wc\test.eps')` and 
see if that works for you.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38916] Remove array.fromstring



Brett Cannon  added the comment:

> there's no harm to keeping it (it's not broken)

... for now. :) There's always the risk that will change if we keep the code 
around.

> The other deprecation in the array module says, "Deprecated since version 
> 3.3, will be removed in version 4.0".  Perhaps this one should have had the 
> same qualifier.

If the function is left then I agree it should probably be updated to match the 
rest of the module.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35003] Provide an option to venv to put files in a bin/ directory on Windows



Change by Brett Cannon :


--
nosy: +vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue35003] Provide an option to venv to put files in a bin/ directory on Windows



Change by Brett Cannon :


--
versions: +Python 3.9 -Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38931] pathlib.Path on Windows - parser issue



Change by Brett Cannon :


--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38928] EnvBuilder.upgrade_dependencies() does not exist on 3.8



Change by Brett Cannon :


--
nosy: +vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38927] venv --upgrade_deps fails on Windows



Change by Brett Cannon :


--
nosy: +vinay.sajip

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38924] pathlib paths .normalize()



Brett Cannon  added the comment:

Do note that Path inherits from PurePath, so providing a normalize() method on 
the latter means it will end up on the former.

--
nosy: +brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38931] pathlib.Path on Windows - parser issue

2019-11-27 Thread tempest



New submission from tempest :

the Path parser from pathlib seems to give incorrect paths if a folder 
(subdirectory) name includes a period. (This issue does not manifest with Unix 
paths.) 

Please see a demonstration below: "Out[2]" is not the same as "Out[3]" and 
"Out[4]"; the "\" separator following the folder name with the period is not 
converted to the forward slash ("/") in the WindowsPath() when the full path is 
given as a Windows path string. This issue manifests with pathlib.WindowsPath() 
as well. This is Python 3.7.4 from the Anaconda distribution.

Jupyter QtConsole 4.6.0
Python 3.7.4 (default, Aug  9 2019, 18:34:13) [MSC v.1915 64 bit (AMD64)]
Type 'copyright', 'credits' or 'license' for more information
IPython 7.9.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: from pathlib import Path

In [2]: Path('C:\Temp\MyProj.wc\test.eps')
Out[2]: WindowsPath('C:/Temp/MyProj.wc\test.eps')

In [3]: Path('C:\Temp\MyProj.wc').joinpath('test.eps')
Out[3]: WindowsPath('C:/Temp/MyProj.wc/test.eps')

In [4]: Path('C:/Temp/MyProj.wc/test.eps')
Out[4]: WindowsPath('C:/Temp/MyProj.wc/test.eps')

--
components: Windows
messages: 357574
nosy: paul.moore, steve.dower, tempest, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: pathlib.Path on Windows - parser issue
type: behavior
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38918] Add module entry for function type in inspect docs table.

2019-11-27 Thread Roundup Robot



Change by Roundup Robot :


--
keywords: +patch
pull_requests: +16888
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/17408

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue37883] threading.Lock.locked is not documented

2019-11-27 Thread Ido Michael



Ido Michael  added the comment:

Thanks, Tal, I think this one can be closed, I don't think I have permissions 
to close it

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38906] copy2 doesn't copy metadata on Windows and MacOS

2019-11-27 Thread Eryk Sun

Eryk Sun added the comment:

> copystat() and copymode() should be able to copy the same
> metadata/security-bits/etc as CopyFileExW.

Regarding metadata, CopyFileExW copies the basic file info (i.e.
FileAttributes, LastAccessTime, LastWriteTime, and ChangeTime). This metadata
can be copied separately as the FileBasicInfo, via GetFileInformationByHandleEx
and SetFileInformationByHandle. (Zero the CreationTime field to skip setting
it.) Note that this includes the change time (i.e. Unix st_ctime) in file
systems that support it, such as NTFS and ReFS. It also includes all settable
file attributes, including readonly, hidden, system, archive, temporary, and
not-content-indexed. Currently we only copy the readonly attribute.

Regarding security bits, CopyFileExW copies security resource attributes (i.e.
ATTRIBUTE_SECURITY_INFORMATION), which in Windows 8+ can be referenced by
arbitrarily complex expressions in conditional ACEs. See "[MS-DTYP] 2.4.4.17
Conditional ACEs" [1] for details. Security resource attributes can be queried
and set by handle via GetSecurityInfo and SetSecurityInfo. This information is
set in the system access control list (SACL), but it does not require the
privileged ACCESS_SYSTEM_SECURITY right. It only requires READ_CONTROL and
WRITE_DAC access.

CopyFileExW also copies extended attributes. These are commonly set on system
files, but in this case they're usually "$Kernel." attributes [2], which cannot
be set from user mode. IIRC, WSL also uses them. Otherwise extended attributes
are not used much at all because the Windows API provides no way to query and
set them separately. (They're supported in the NT API via NtQueryEaFile and
NtSetEaFile.) When creating a new file via CreateFileW, we can pass it a handle
to a template file from which to copy extended attributes. But that doesn't
help with copystat(), which requires copying extended attributes onto an
existing file.

Regarding data, CopyFileExW copies all $DATA streams [3] in a file, not just
the anonymous $DATA stream. The stream names and sizes can be read via
GetFileInformationByHandleEx: FileStreamInfo. Just loop over the stream names
to try copying them individually.

For complete consistency, copytree should copy named data streams in
directories. (A directory can't have an anonymous data stream, but it can have
named streams, and it's not uncommon to store metadata about a directory like
this. Ignoring this data is inconsistent, but it's a matter of opinion whether
complete consistency is worthwhile.) This can be implemented at a high level
via CreateDirectoryExW by passing the source directory path as the
lpTemplateDirectory parameter. However, CreateDirectoryExW also preserves
whether the directory is compressed or encrypted. I don't know whether copytree
should preserve those attributes.

[1]
https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-dtyp/10dc22eb-788d-4343-b556-0b6969fe58ca
[2]
https://docs.microsoft.com/en-us/windows-hardware/drivers/ifs/kernel-extended-attributes
[3] https://docs.microsoft.com/en-us/windows/win32/fileio/file-streams

___
Python tracker

___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38270] Tests: Avoid MD5 or check for MD5 availablity

2019-11-27 Thread Petr Viktorin



Petr Viktorin  added the comment:

The change silently disables 2 tests, see comment here:
https://github.com/python/cpython/commit/66cd041df8dfadd001ae298292e16f0271c0d139#diff-ba7d7a4a1a0050e1f497b71b5cd50afcR365

(I think it's better to reopen this bug, than to open a new one, so all the 
fixes are in one place. Do you agree?)

--
nosy: +petr.viktorin
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26730] SpooledTemporaryFile rollover corrupts data silently when Unicode characters are written



Change by Inada Naoki :


--
pull_requests: +16887
pull_request: https://github.com/python/cpython/pull/17407

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38524] functools.cached_property is not supported for setattr



Change by Tal Einat :


--
pull_requests: +16886
pull_request: https://github.com/python/cpython/pull/17406

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26730] SpooledTemporaryFile rollover corrupts data silently when Unicode characters are written



Inada Naoki  added the comment:


New changeset ea9835c5d154ab6a54eed627958473b6768b28cc by Inada Naoki in branch 
'master':
bpo-26730: Fix SpooledTemporaryFile data corruption (GH-17400)
https://github.com/python/cpython/commit/ea9835c5d154ab6a54eed627958473b6768b28cc


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26730] SpooledTemporaryFile rollover corrupts data silently when Unicode characters are written



Change by miss-islington :


--
pull_requests: +16885
pull_request: https://github.com/python/cpython/pull/17405

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38929] Float // Integer doesn't give best result.

2019-11-27 Thread Steven D'Aprano



Steven D'Aprano  added the comment:

Although it often gets called "integer division", that's not actually what // 
does, it is actually *floor* division, as documented here:

https://docs.python.org/3/library/stdtypes.html#numeric-types-int-float-complex

So the behaviour as given is correct: it returns the floor of the quotient. 
Arguments are coerced to a common type in the normal fashion, so float//int 
performs the floor  division in floating point, which may not give the same 
result as integer floor division due to floating point rounding:

py> 10**17 // 7
14285714285714285
py> 1e17 // 7
1.4285714285714284e+16

If you don't want floating point rounding, don't use floats.

If you want "true division", use / not the floor division operator.

This isn't a bug, it is working as designed.

Even if the behaviour you are asking for was possible, practical and desirable, 
it would break backwards compatibility. There's no way to do a "floor division 
that returns an int" for all float arguments, since there are no int NANs.

py> float('inf')//7
nan

--
nosy: +steven.daprano
resolution:  -> not a bug
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38930] Subprocess failed to kill child process after timeout when using with statement

2019-11-27 Thread Xuan Hu



New submission from Xuan Hu :

The original issue is that the `timeout` in `subprocess.run()` does not work 
properly, so I try to use `subprocess.Popen()` instead. There are two 
references I found, [1] is the implementation of `subprocess.run()` and [2] is 
the example for `Popen.communicate()`. Surprisingly, [2] works for me, and 
seems the `with` statement is the cause of the issue.

I created a snippet [3] to reproduce the bug, note that `ffmpeg` is needed to 
run the script. Ideally, all the time should be less than 0.1 or just a little 
bit greater than 0.1, but when using the `with` statement, the result would be 
much larger than that.

[1] 
https://github.com/python/cpython/blob/0f9c9d53283420a570850aa92869d032b40d4fba/Lib/subprocess.py#L489
[2] 
https://docs.python.org/3/library/subprocess.html#subprocess.Popen.communicate
[3] https://gist.github.com/huxuan/d58a5899be9b42e0936c71dd7884442a

--
components: Library (Lib)
messages: 357568
nosy: Xuan Hu
priority: normal
severity: normal
status: open
title: Subprocess failed to kill child process after timeout when using with 
statement
type: behavior
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38929] Float // Integer doesn't give best result.



Serhiy Storchaka  added the comment:

To get 20.45 use the true division operator /.

If float // int would return int, 1e300 // 2 would return a 300-digit integer. 
It takee more memory and its creation is slower than 5e299. In addition it does 
not make sense to provide such precision.

--
nosy: +mark.dickinson, serhiy.storchaka, tim.peters

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38929] Float // Integer doesn't give best result.

2019-11-27 Thread Douglas Feather



New submission from Douglas Feather :

40.9//2 give 20.0 as a result.  I would have expected one of: 20.45 or 20.  If 
it is going to give an FP answer then it should do the division as FP and get 
the right answer.  If it is going to do an integer division then it should give 
the division as an integer.

--
components: ctypes
messages: 357566
nosy: def
priority: normal
severity: normal
status: open
title: Float // Integer doesn't give best result.
versions: Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38861] zipfile: Corrupts filenames containing non-UTF8 characters



Serhiy Storchaka  added the comment:

The standard requires interpreting filename encoding as cp470 or utf8. But for 
practical reasons it would be handy to allow to specify other encoding (which 
is not necessary equal ti the local filesystem encoding)
. This is issue28080. But i left this issue open so that we will not forget to 
ensure that it will be the option of using extractall() with the encoding that 
matches the encoding of the local zip tool. There may be percularities on 
Windows and macOS. Lso there should be an option for CLI.

--
components: +Library (Lib)
dependencies: +Allow reading member names with bogus encodings in zipfile
nosy: +serhiy.storchaka

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38906] copy2 doesn't copy metadata on Windows and MacOS

2019-11-27 Thread Giampaolo Rodola'



Giampaolo Rodola'  added the comment:

If we use CopyFileExW in copy2(), then also copystat() and copymode() should be 
able to copy the same metadata/security-bits/etc as CopyFileExW. I don't know 
which Windows APIs should be used though.

I sort of agree with Steven that CopyFileExW could be used everywhere (meaning 
copyfile()), but that basically means breaking backward compatibility re. what 
is promised in the doc, and am not sure how to deal with that. For that reason 
it's probably it's better to leave copyfile() alone. 

On macOS it seems we can use fcopyfile(3) syscall (which is already exposed) 
and its flag argument (COPYFILE_METADATA, COPYFILE_DATA. COPYFILE_XATTR, etc,) 
to implement both copy2() and copystat() / copymode().

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38928] EnvBuilder.upgrade_dependencies() does not exist on 3.8



Change by Tzu-ping Chung :


--
keywords: +patch
pull_requests: +16884
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17404

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38927] venv --upgrade_deps fails on Windows



Change by Tzu-ping Chung :


--
keywords: +patch
pull_requests: +16883
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/17403

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38928] EnvBuilder.upgrade_dependencies() does not exist on 3.8



New submission from Tzu-ping Chung :

The documentation says it is new in 3.8, but in reality it is not present until 
3.9.

https://docs.python.org/3/library/venv.html#venv.EnvBuilder.upgrade_dependencies

--
assignee: docs@python
components: Documentation
messages: 357563
nosy: docs@python, uranusjr
priority: normal
severity: normal
status: open
title: EnvBuilder.upgrade_dependencies() does not exist on 3.8
versions: Python 3.8

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38927] venv --upgrade_deps fails on Windows



New submission from Tzu-ping Chung :

https://github.com/python/cpython/commit/4acdbf11b1fae1af24c47413a6caa593010d1b6f

EnvBuilder.upgrade_dependencies() uses `pip.exe install -U` to upgrade pip, 
which fails on Windows with `[WinError 5] Access is denied`.

--
components: Library (Lib), Windows
messages: 357562
nosy: paul.moore, steve.dower, tim.golden, uranusjr, zach.ware
priority: normal
severity: normal
status: open
title: venv --upgrade_deps fails on Windows
versions: Python 3.9

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38524] functools.cached_property is not supported for setattr



miss-islington  added the comment:


New changeset 0f9c9d53283420a570850aa92869d032b40d4fba by Miss Islington (bot) 
in branch '3.8':
bpo-38524: document implicit and explicit calling of descriptors' __set_name__ 
(GH-17364)
https://github.com/python/cpython/commit/0f9c9d53283420a570850aa92869d032b40d4fba


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38524] functools.cached_property is not supported for setattr



miss-islington  added the comment:


New changeset cd27d22ac90a869dc740004597246f24246348a6 by Miss Islington (bot) 
in branch '3.7':
bpo-38524: document implicit and explicit calling of descriptors' __set_name__ 
(GH-17364)
https://github.com/python/cpython/commit/cd27d22ac90a869dc740004597246f24246348a6


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38524] functools.cached_property is not supported for setattr



Change by miss-islington :


--
pull_requests: +16882
pull_request: https://github.com/python/cpython/pull/17402

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38524] functools.cached_property is not supported for setattr



Change by miss-islington :


--
pull_requests: +16881
pull_request: https://github.com/python/cpython/pull/17401

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue38524] functools.cached_property is not supported for setattr