[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

2020-11-20 Thread Adrian Vladu


Adrian Vladu  added the comment:

Thank you for the suggestion, I will update the PR accordingly to change the 
__msvccompiler.py. I just need to find a good candidate that uses that 
implementation to check if the compilation gets fixed.

--

___
Python tracker 
<https://bugs.python.org/issue42405>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

2020-11-19 Thread Adrian Vladu


Adrian Vladu  added the comment:

This fix is __required__ to build a lot of important packages in the python 
ecosystem, like numpy, pandas, pywin32 and probably a lot more, as most of 
these important packages have not migrated to setuptools and usually maintain 
support for multiple python versions.

I know that there is a way to change all the packages to use the canonical 
approach to compile things, but most of them have a tweaked compiler on top of 
the msvc9compiler.py compiler. I do not see a change in all the python packages 
to happen as fast as a small backwards compatible commit in the main cpython 
code. I see this commit as a fix for the win-arm64 package build and not an 
"extra" feature.

As I can see it, not adding this fix here will require a split of trees that 
are going to be used just for this reason.

I will add the fix to setuptools too, but that will not change the above 
(maintaining separate branches for people who want to use those packages).

--

___
Python tracker 
<https://bugs.python.org/issue42405>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

2020-11-19 Thread Adrian Vladu


Change by Adrian Vladu :


--
keywords: +patch
pull_requests: +22291
stage:  -> patch review
pull_request: https://github.com/python/cpython/pull/23399

___
Python tracker 
<https://bugs.python.org/issue42405>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue42405] Add distutils mvsccompiler support for Windows ARM64 build

2020-11-19 Thread Adrian Vladu


New submission from Adrian Vladu :

To add support for building packages that have C extensions on Windows ARM64, 
some fixes are required in the integrated distutils wrapper for Visual Studio 
compiler (Lib/distutils/msvc9compiler.py)

This is a hardcoded fix that needs to be improved so that it applies only on 
windows arm64:
https://github.com/ader1990/cpython/commit/b8c59c9b96a7ad11094224b5631aae3b89323f7a

Any suggestions are welcome.

--
components: Windows
messages: 381407
nosy: avladu, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
status: open
title: Add distutils mvsccompiler support for Windows ARM64 build
type: compile error
versions: Python 3.10

___
Python tracker 
<https://bugs.python.org/issue42405>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com