[issue19500] Add client-side SSL session resumption
Changes by Alex Warhawk : -- nosy: -Alex Warhawk ___ Python tracker <http://bugs.python.org/issue19500> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19500] Error when connecting to FTPS servers not supporting SSL session resuming
Alex Warhawk added the comment: Even after enabling client cache one still has to call SSL_set_session. See documentation of SSL_CTX_set_session_cache_mode point SSL_SESS_CACHE_CLIENT. I started thinking about not exposing a SSL_SESSION object to the user but rather extending wrap_socket to take an already established socket as argument and use that socket's session object. This way I can ensure that both sockets share the same SSL context I am not really convinced by this idea myself, what do you think about this? Any better ideas? -- ___ Python tracker <http://bugs.python.org/issue19500> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19500] Error when connecting to FTPS servers not supporting SSL session resuming
Alex Warhawk added the comment: Thanks for the heads up Christian I'll try enabling client session caching. If this does not work I'll try to adapt the patch to only allow session reusing within the same context. -- ___ Python tracker <http://bugs.python.org/issue19500> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19500] Error when connecting to FTPS servers not supporting SSL session resuming
Alex Warhawk added the comment: I have re-targeted the patch for 3.6. It is not a 1 to 1 port of the prior one, but quite similar. -- Added file: http://bugs.python.org/file40716/implement_ssl_session_reuse_3.6.patch ___ Python tracker <http://bugs.python.org/issue19500> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19500] Error when connecting to FTPS servers not supporting SSL session resuming
Alex Warhawk added the comment: Based on the proof-of-concept patch I submitted a few days ago I have built a more sophisticated patch. Please review it and let me know about necessary changes. -- Added file: http://bugs.python.org/file40708/implement_ssl_session_reuse.patch ___ Python tracker <http://bugs.python.org/issue19500> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19500] Error when connecting to FTPS servers not supporting SSL session resuming
Alex Warhawk added the comment: I encountered this problem recently and could not find a fix, so i tried fixing it myself. Note that the patch attached is my first contribution to cpython as well as the first time I used the C extension mechanism. Therefore I do not consider the patch polished enough to be just merged upstream. Maybe it helps in solving this issue. The attached patch is based on: changeset: 79113:ec373d762213 branch: 2.7 -- keywords: +patch nosy: +Alex Warhawk Added file: http://bugs.python.org/file40666/reuse_session.diff ___ Python tracker <http://bugs.python.org/issue19500> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com