[issue17048] calendar should understand full- vs. half-width characters

2018-01-28 Thread Chason Chaffin

Change by Chason Chaffin <cha...@gmail.com>:


--
nosy: +chason.chaffin

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue17048>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32673] update tutorial dict part to reflect dict is ordered

2018-01-25 Thread Chason Chaffin

Change by Chason Chaffin <cha...@gmail.com>:


--
nosy: +chason

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32673>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32657] Mutable Objects in SMTP send_message Signature

2018-01-25 Thread Chason Chaffin

Chason Chaffin <cha...@gmail.com> added the comment:

> It's probably enough to fix it.  I fear that if we also change them in 
> sendmail we'll break someone's code, but maybe we should do that anyway, for 
> 3.7 only.

Should I make a separate issue for that, or attach it to this PR?

--

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32657>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32657] Mutable Objects in SMTP send_message Signature

2018-01-25 Thread Chason Chaffin

Change by Chason Chaffin <cha...@gmail.com>:


--
keywords: +patch
pull_requests: +5180
stage:  -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32657>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32657] Mutable Objects in SMTP send_message Signature

2018-01-25 Thread Chason Chaffin

Chason Chaffin <cha...@gmail.com> added the comment:

I'm writing a PR for this right now. Is it worth it to write a test to make 
sure that mail_options isn't being mutated or is it enough just to update the 
code to use non-mutable defaults? Interesting side effect of looking into this 
is #32663 where I found the tests for the UTF8 code weren't being run.

--

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32657>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31972] Inherited docstrings for pathlib classes are confusing

2018-01-25 Thread Chason Chaffin

Change by Chason Chaffin <cha...@gmail.com>:


--
nosy: +chason

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31972>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32663] SMTPUTF8SimTests are not actually being run

2018-01-25 Thread Chason Chaffin

Change by Chason Chaffin <cha...@gmail.com>:


--
keywords: +patch
pull_requests: +5160
stage:  -> patch review

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32663>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32663] SMTPUTF8SimTests are not actually being run

2018-01-25 Thread Chason Chaffin

New submission from Chason Chaffin <cha...@gmail.com>:

In the tests for smtplib, the suite of tests for SMTPUTF8SimTests (added by 
issue 24218)  are not actually being run. This is troublesome in particular, 
because the test test_send_message_error_on_non_ascii_addrs_if_no_smtputf8 
calls assertRaises incorrectly and thus fails.

--
components: Tests
messages: 310664
nosy: chason
priority: normal
severity: normal
status: open
title: SMTPUTF8SimTests are not actually being run
type: behavior

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32663>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue32657] Mutable Objects in SMTP send_message Signature

2018-01-24 Thread Chason Chaffin

Chason Chaffin <cha...@gmail.com> added the comment:

Hi Steven,

I have nothing to do with the original submitter but this bug did catch my eye. 
Does using mutable variables in the SMTP library serve a purpose? Looking 
through the code, I wasn't able to spot anything obvious, and I did spot a 
place with a potential bug:

https://github.com/python/cpython/blob/master/Lib/smtplib.py#L960

Here mail_options is mutated in the case of a non-ASCII email address. 
Subsequent calls to send_message, even to a different SMTP server (if I'm not 
mistaken) would also send these headers along.

--
nosy: +chason

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue32657>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue31972] Inherited docstrings for pathlib classes are confusing

2018-01-24 Thread Chason Chaffin

Change by Chason Chaffin <cha...@gmail.com>:


--
pull_requests: +5157

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue31972>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com