[issue18983] Specify time unit for timeit CLI
Julian Gindi added the comment: Anything else need to be done on this patch? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21720] TypeError: Item in ``from list'' not a string message
Julian Gindi added the comment: I'm trying to replicate this issue. I do not get an error when I run ``` __import__('datetime', fromlist=[u'datetime']) ``` any more information you could provide to help move this issue forward? -- nosy: +Julian.Gindi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21720 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue21720] TypeError: Item in ``from list'' not a string message
Julian Gindi added the comment: Interesting...I'll try to dig in and see what's going on. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21720 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue22189] collections.UserString missing some str methods
Julian Gindi added the comment: Good catch. I'm gonna look into this. Seems like you should be able to access these from UserString as well. -- nosy: +Julian.Gindi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22189 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18983] Specify time unit for timeit CLI
Julian Gindi added the comment: What needs to be done to close this one out? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19683] test_minidom has many empty tests
Julian Gindi added the comment: Modernizing these tests will be a decent undertaking but seems important. I'll go a head and try to fix these up further. Thanks for the guidance and motivation on this one :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError
Julian Gindi added the comment: Looks like this issue has been resolved. Can we close it? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError
Julian Gindi added the comment: Sorry. I meant, merged. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue20068] collections.Counter documentation leaves out interesting usecase
New submission from Julian Gindi: I think the documentation for collections.Counter can be updated slightly to include an example showing the initialization of a counter object from a list. For example, it explains how to manually iterate through a list and increment the values... for word in ['red', 'blue', 'red', 'green', 'blue', 'blue']: ... cnt[word] += 1 I think it is more useful and powerful to do something like this: cnt = Counter(['red', 'blue', 'red', 'green', 'blue', 'blue']) where the result would be: Counter({'blue': 3, 'red': 2, 'green': 1}) Just a thought. I'm curious to see what other people think. -- assignee: docs@python components: Documentation messages: 206935 nosy: Julian.Gindi, docs@python, rhettinger priority: normal severity: normal status: open title: collections.Counter documentation leaves out interesting usecase type: enhancement versions: Python 2.7, Python 3.1, Python 3.2, Python 3.3, Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20068 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19683] test_minidom has many empty tests
Julian Gindi added the comment: So, it seems that there are many seemingly redundant tests and many tests whose intentions are unclear. I think this might be better suited for someone who has more experience with the xml minidom module. I have uploaded the work I have done but it is not complete. -- Added file: http://bugs.python.org/file33258/issue19683.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18983] Specify time unit for timeit CLI
Julian Gindi added the comment: Just wanted to check in and see if the documentation change I made is sufficient. I tried to copy the other entries for the command line arguments. Let me know if I can improve it in any way. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19683] test_minidom has many empty tests
Julian Gindi added the comment: I have not started yet, wasn't completely sure of the status of this. I'll get going filling in those tests to the best of my ability. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1100942] Add datetime.time.strptime and datetime.date.strptime
Julian Gindi added the comment: Maciej, cool! I just wanted to move this patch forward because A) it seemed inactive and B) I would love to see this feature make it in :) I guess that means there is nothing that I need to do. Looking forward to this one, good work! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1100942 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue1100942] Add datetime.time.strptime and datetime.date.strptime
Julian Gindi added the comment: I'm interested in taking over and finishing whatever needs to be completed to move this forward. What else needs to be done? It looks like improved tests are needed, but are there any changes needed to the implementation code? -- nosy: +Julian.Gindi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue1100942 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18983] Specify time unit for timeit CLI
Julian Gindi added the comment: Re-uploaded the patch to remove duplication. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18983] Specify time unit for timeit CLI
Julian Gindi added the comment: Updated documentation and fixed a few lines that were too long. -- Added file: http://bugs.python.org/file33095/issue18983_v6.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18983] Specify time unit for timeit CLI
Julian Gindi added the comment: Implemented proposed changes to patch. Simplified for-loop and implemented invalid input test. -- Added file: http://bugs.python.org/file33058/issue18983_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18983] Specify time unit for timeit CLI
Julian Gindi added the comment: Incorporated updates suggested by serhiy.storchaka -- Added file: http://bugs.python.org/file33064/issue18983_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18983] Specify time unit for timeit CLI
Julian Gindi added the comment: Updated patch to log to stderr. -- Added file: http://bugs.python.org/file33066/issue18983_v4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18983] Specify time unit for timeit CLI
Julian Gindi added the comment: Added newline after error message. -- Added file: http://bugs.python.org/file33067/issue18983_v5.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18983] Specify time unit for timeit CLI
Julian Gindi added the comment: Whoops. Sorry about that. Super embarrassing. -- Added file: http://bugs.python.org/file33068/issue18983_v5.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18983] Specify time unit for timeit CLI
Julian Gindi added the comment: Just wanted to check to see if there was anything else I should do regarding this issue. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19683] test_minidom has many empty tests
Julian Gindi added the comment: I agree that they should be implemented. I'll fill them in and submit a patch in a day or so. -- nosy: +Julian.Gindi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19683 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18983] Specify time unit for timeit CLI
Julian Gindi added the comment: Updated patch to include unit tests. -- Added file: http://bugs.python.org/file32874/issue18983.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19588] Silently skipped test in test_random
Julian Gindi added the comment: Just wanted to see if there was anything else I needed to do to get this patch rolling :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19588 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18983] Specify time unit for timeit CLI
Julian Gindi added the comment: I created a patch that allows users to specify a time unit output using the -u flag. Example usage: python -m timeit -u msec '-.join(str(n) for n in range(100))' 1 loops, best of 3: 0.156 msec per loop python -m timeit -u sec '-.join(str(n) for n in range(100))' 1 loops, best of 3: 0.000159 sec per loop You can specify msec, sec, or usec. I am also interested in having a JSON option as mentioned by Antoine. Any thoughts? -- keywords: +patch nosy: +Julian.Gindi Added file: http://bugs.python.org/file32862/issue18983.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18983 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17951] TypeError during gdb backtracing
Julian Gindi added the comment: Could you provide some more details on how to reproduce this issue? If I am able to reproduce the issue, I'll write a few unit tests and get this patch rolling again. -- nosy: +Julian.Gindi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17951 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19588] Silently skipped test in test_random
Julian Gindi added the comment: Awesome! I signed the contributor agreement today via E-sign. I look forward to making more significant contributions soon :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19588 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19588] Silently skipped test in test_random
Julian Gindi added the comment: That makes perfect sense :) Here is an updated patch. I also made the change to the other test of the same name in MersenneTwister_TestBasicOps -- Added file: http://bugs.python.org/file32747/issue19588_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19588 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue19588] Silently skipped test in test_random
Julian Gindi added the comment: Maybe some documentation could help express the purpose of this test, but I was able to make the changes mentioned below and the test seems to work better than it used to. The test no longer returns if a value is 'skipped'. This is my first attempt at a patch so apologies if this is not perfect. -- keywords: +patch nosy: +Julian.Gindi Added file: http://bugs.python.org/file32711/issue19588.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19588 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError
Julian Gindi added the comment: I did some further testing and it seems that you are right, testcase.SkipTest() never causes an error in setUp or tearDown but raise AssertionError does (even in setUp or tearDown). I went ahead and made relevant documentation changes, let me know what you think. -- keywords: +patch nosy: +Julian.Gindi Added file: http://bugs.python.org/file32716/issue18566.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue18566 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com