[issue16874] setup.py upload option repeated in docs
Marek Šuppa added the comment: So what do you think should be done here? Just removing the or --repository= part? -- nosy: +mrshu ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16874 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15948] Unchecked return value of I/O functions
Marek Šuppa added the comment: Thanks for the review. Do you think I should split it into multiple patches to make it easier to look through? It might be that some changes are completely wrong. This is the first time I did something with cpython core code. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15948 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15948] Unchecked return value of I/O functions
Marek Šuppa added the comment: That is probably right. I was way too foolish to start with this but won't stop now. I'll try to iterate on your feedback. Thanks! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15948 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15948] Unchecked return value of I/O functions
Marek Šuppa added the comment: Any update on this? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15948 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15948] Unchecked return value of I/O functions
Marek Šuppa added the comment: Hi, Sorry for the long delay. The attached patch should fix all the relevant occurrences of I/O functions I was able to find. Please review. Thanks! -- Added file: http://bugs.python.org/file28253/unchecked_return_values.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15948 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15948] Unchecked return value of I/O functions
Marek Šuppa added the comment: Since there is probably a lot to work on here I'd also like to participate. I've got one question though. In case these function don't return 0 and the test fails what should happen then? What kind of error should be thrown for let's say fseek() ? -- nosy: +mrshu ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15948 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15948] Unchecked return value of I/O functions
Marek Šuppa added the comment: Thanks for a quick response. Should we also test this somewhere? Christian Heimes rep...@bugs.python.org wrote: Christian Heimes added the comment: The functions should set an appropriate errno so it's PyErr_SetFromErrno(PyExc_IOError). You should use the PyErr_SetFromErrnoWithFilename*() variants when a file name (PyObject*, char*, unicode) is available. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15948 ___ Marek, http://marek.suppa.co -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15948 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue15948] Unchecked return value of I/O functions
Marek Šuppa added the comment: Appended is the patch for _cursesmodule.c Let me know if it's OK. -- keywords: +patch Added file: http://bugs.python.org/file27692/issue15948__cursesmodule.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15948 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue16241] -X faulthandler is not documented in -X option docs
Marek Šuppa added the comment: I already filled and signed the PSF Contributor Agreement thanks to Petri at the PyCon Finland sprint. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16241 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
