[issue9682] socket.create_connection error message for domain subpart with invalid length is very confusing
Mike Milkin added the comment: Moved the conditional logic out of the method. There are no tests for ToASCII function and I was not comfortable making changes to it without adding tests. -- Added file: http://bugs.python.org/file30139/Issue9682-5513.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9682 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9682] socket.create_connection error message for domain subpart with invalid length is very confusing
Mike Milkin added the comment: Dave, let me know what you think of the tests, ill fix the rest of your comments. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9682 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9682] socket.create_connection error message for domain subpart with invalid length is very confusing
Mike Milkin added the comment: There are a few of interesting parts. 1.) I noticed that the ToASCII class is not tested. 2.) I had some unreachable branches due to concatenation of constant variable ace_prefix. 3) I also found it weird that we only check the max of labels[-1], but decided to perserve the original functionality. -- Added file: http://bugs.python.org/file29984/Issue9682.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9682 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9682] socket.create_connection error message for domain subpart with invalid length is very confusing
Changes by Mike Milkin mmil...@gmail.com: Removed file: http://bugs.python.org/file29850/Issue9682-full.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9682 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9682] socket.create_connection error message for domain subpart with invalid length is very confusing
Changes by Mike Milkin mmil...@gmail.com: Removed file: http://bugs.python.org/file29984/Issue9682.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9682 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9682] socket.create_connection error message for domain subpart with invalid length is very confusing
Changes by Mike Milkin mmil...@gmail.com: Added file: http://bugs.python.org/file29985/Issue9682-42213.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9682 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9682] socket.create_connection error message for domain subpart with invalid length is very confusing
Mike Milkin added the comment: Sure ill modify the patch, thanks for the feedback. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9682 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17353] Plistlib outputs empty data tags when deeply nested
Mike Milkin added the comment: Adding tests. -- Added file: http://bugs.python.org/file29894/issue-17357-tests.txt ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17353 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9682] socket.create_connection error message for domain subpart with invalid length is very confusing
Mike Milkin added the comment: I did not mean to take the decode out of the previos patch. Sorry for the spam. -- Added file: http://bugs.python.org/file29850/Issue9682-full.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9682 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9682] socket.create_connection error message for domain subpart with invalid length is very confusing
Changes by Mike Milkin mmil...@gmail.com: Removed file: http://bugs.python.org/file29834/Issue9682-full.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9682 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17353] Plistlib outputs empty data tags when deeply nested
Mike Milkin added the comment: Looks like plistlib.writePlistToString is no loger in the plistlib. -- nosy: +mmilkin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17353 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue17353] Plistlib outputs empty data tags when deeply nested
Mike Milkin added the comment:
Yep you are correct.
plistlib.readPlistFromBytes(plistlib.writePlistToBytes({'test':
plistlib.Data(b'aa')}))
{'test': Data(b'aa')}
plistlib.readPlistFromBytes(plistlib.writePlistToBytes([{'test':
plistlib.Data(b'aa')}]))
[{'test': Data(b'')}]
I presume we want to raise a ValueError if the indentation is more than the
maximal line length.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue17353
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9682] socket.create_connection error message for domain subpart with invalid length is very confusing
Mike Milkin added the comment: This patch adds better exception messages. If any label other then the last is empty or is too long the request is added to the exception message. If the last label is over 64, the label is added to the exception message -- keywords: +patch nosy: +mmilkin Added file: http://bugs.python.org/file29809/Issue9682.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9682 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11957] re.sub confusion between count and flags args
Mike Milkin added the comment: I like option #2, and I was thinking of working on it today, poke me if anyone has a problem with this. -- nosy: +mmilkin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11957 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11957] re.sub confusion between count and flags args
Mike Milkin added the comment: There is no sane way to issue a warning without changing the signature and we don't want to change the signature without issuing a deprecation warning for the function, so sadly option 3 is the only way for this to work, (Im going to not touch this till ENUMS are merged in.) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11957 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue11957] re.sub confusion between count and flags args
Mike Milkin added the comment: We could do that but we would be changing the signature before adding the warning -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11957 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue9682] socket.create_connection error message for domain subpart with invalid length is very confusing
Mike Milkin added the comment: Made changes to to the tests and made changes to the error messages. I think decode() is valid since the input is already ascii encoded. -- Added file: http://bugs.python.org/file29834/Issue9682-full.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue9682 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
