Morgan Ramsay <morgan.ram...@gmail.com> added the comment:

The encoding test in ZipFile.open() is highly opinionated and has no purpose 
beyond itself. Testing for encoding issues should be done outside this library 
in the user's own code.

Using the 3.7.2 version of ZipFile, this is my proposal:

https://gist.github.com/MorganRamsay/696e89450e0f172c16ac8dfc016eb79f/revisions?diff=unified

Currently, I'm subclassing ZipFile with this patch and I've had no issues with 
extracting thousands of different ZIP files on Windows. I can't attest to this 
solution's applicability on other platforms.

----------
nosy: +MorganRamsay
versions: +Python 3.6, Python 3.7

_______________________________________
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue6839>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to